129465 2014-02-27 20:33:48 -0800 :active style is not cleared when its display property is set to none before mouse released. 2014-03-03 22:32:07 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sh53.lee webkit-unassigned commit-queue esprehn+autocc gyuyoung.kim jinwoo7.song kangil.han kling ryuan.choi oldest_to_newest 985439 0 sh53.lee 2014-02-27 20:33:48 -0800 We currently clearing the :active style when element has a renderer. This patch makes elements active style without renderer cleared. 985440 1 225433 sh53.lee 2014-02-27 20:35:05 -0800 Created attachment 225433 Patch 985504 2 225433 kling 2014-02-28 01:49:01 -0800 Comment on attachment 225433 Patch It's great that you are fixing this bug, but we should add a layout test so it doesn't regress again. http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree 985895 3 225542 sh53.lee 2014-02-28 23:52:21 -0800 Created attachment 225542 Patch 986009 4 225542 darin 2014-03-01 16:11:43 -0800 Comment on attachment 225542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225542&action=review > Source/WebCore/dom/Document.cpp:5839 > + if (!oldActiveElement->renderer()) > + oldActiveElement->setActive(false); This code change seems like only a partial fix. Last time Document::updateHoverActiveState was called, we called setActive(true) on multiple elements. It seems that elements that were ancestors of the main active one will have the same bug as before. We should construct test cases that cover that and fix the whole problem instead of patching over the most obvious surface part of the problem. There’s no real need for the !oldActiveElement->renderer() check. It would be harmless and clearer to call oldActiveElement->setActive(false) unconditionally. It’s hard to understand why we would do this only for an element without a renderer. Slightly ugly to fetch the renderer twice, here and for the loop just below it. 986034 5 225580 sh53.lee 2014-03-01 19:18:08 -0800 Created attachment 225580 Patch 986076 6 225580 tonikitoo 2014-03-02 07:36:01 -0800 Comment on attachment 225580 Patch r=me 986677 7 225580 gyuyoung.kim 2014-03-03 22:01:30 -0800 Comment on attachment 225580 Patch cq=me. It looks latest patch is fixed according to Darin's comment. 986679 8 225580 commit-queue 2014-03-03 22:32:04 -0800 Comment on attachment 225580 Patch Clearing flags on attachment: 225580 Committed r165037: <http://trac.webkit.org/changeset/165037> 986680 9 commit-queue 2014-03-03 22:32:07 -0800 All reviewed patches have been landed. Closing bug. 225433 2014-02-27 20:35:05 -0800 2014-02-28 23:52:12 -0800 Patch bug-129465-20140228133505.patch text/plain 1687 sh53.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0ODQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDVmNGFjMjRhZWFlMjQ4 YjQ3ZTEyYWYyNjc3NjAxNGZjYzUzOTFkNC4uMGUxYmY0OWVlYjZiNTQ0NTNhMjFiYmE4MjMxNjYw Y2QwZjlkNmQxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAyLTI3ICBTYW5n aHl1cCBMZWUgIDxzaDUzLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICA6YWN0aXZlIHN0eWxl IGlzIG5vdCBjbGVhcmVkIHdoZW4gaXRzIGRpc3BsYXkgcHJvcGVydHkgaXMgc2V0IHRvIG5vbmUg YmVmb3JlIG1vdXNlIHJlbGVhc2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI5NDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2UgY3VycmVudGx5IGNsZWFyaW5nIHRoZSA6YWN0aXZlIHN0eWxlIHdo ZW4gZWxlbWVudCBoYXMgYSByZW5kZXJlci4KKyAgICAgICAgVGhpcyBwYXRjaCBtYWtlcyBlbGVt ZW50cyBhY3RpdmUgc3R5bGUgd2l0aG91dCByZW5kZXJlciBjbGVhcmVkLgorCisgICAgICAgICog ZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp1cGRhdGVIb3Zl ckFjdGl2ZVN0YXRlKToKKwogMjAxNC0wMi0xNyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4Zmll bGRAYXBwbGUuY29tPgogCiAgICAgICAgIHRleHQtZGVjb3JhdGlvbi1za2lwOiBpbmsgZG9lcyBu b3Qgc2tpcCBvdmVyIFNWRyBmb250cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggODRkMzdm NmE3MjcxYjRlNmJkYThiMmQzNjFjNjk1NmQ5OTVlZDcyZi4uZjVkYzI0YTM4MjY4M2FlMWU0YzAx MWE2NzQ2YTQxM2NiZDk2YmU5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3Vt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC01ODI2LDYg KzU4MjYsOCBAQCB2b2lkIERvY3VtZW50Ojp1cGRhdGVIb3ZlckFjdGl2ZVN0YXRlKGNvbnN0IEhp dFRlc3RSZXF1ZXN0JiByZXF1ZXN0LCBFbGVtZW50KiBpbgogICAgIEVsZW1lbnQqIG9sZEFjdGl2 ZUVsZW1lbnQgPSBtX2FjdGl2ZUVsZW1lbnQuZ2V0KCk7CiAgICAgaWYgKG9sZEFjdGl2ZUVsZW1l bnQgJiYgIXJlcXVlc3QuYWN0aXZlKCkpIHsKICAgICAgICAgLy8gV2UgYXJlIGNsZWFyaW5nIHRo ZSA6YWN0aXZlIGNoYWluIGJlY2F1c2UgdGhlIG1vdXNlIGhhcyBiZWVuIHJlbGVhc2VkLgorICAg ICAgICBpZiAoIW9sZEFjdGl2ZUVsZW1lbnQtPnJlbmRlcmVyKCkpCisgICAgICAgICAgICBvbGRB Y3RpdmVFbGVtZW50LT5zZXRBY3RpdmUoZmFsc2UpOwogICAgICAgICBmb3IgKFJlbmRlckVsZW1l bnQqIGN1cnIgPSBvbGRBY3RpdmVFbGVtZW50LT5yZW5kZXJlcigpOyBjdXJyOyBjdXJyID0gY3Vy ci0+cGFyZW50KCkpIHsKICAgICAgICAgICAgIEVsZW1lbnQqIGVsZW1lbnQgPSBjdXJyLT5lbGVt ZW50KCk7CiAgICAgICAgICAgICBpZiAoIWVsZW1lbnQpCg== 225542 2014-02-28 23:52:21 -0800 2014-03-01 19:18:00 -0800 Patch bug-129465-20140301165220.patch text/plain 3997 sh53.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0OTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDc4MTYyMTA5MDA4ZTBh OTZlMWEyOTk5YjgzMzA3NmRkY2JiYTBkYy4uNGFmMGI3N2Y2NDI5M2VkOTZkMzllOGE3ZjkxOGQz ZThiMDcwM2YxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTAyLTI4ICBTYW5n aHl1cCBMZWUgIDxzaDUzLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICA6YWN0aXZlIHN0eWxl IGlzIG5vdCBjbGVhcmVkIHdoZW4gaXRzIGRpc3BsYXkgcHJvcGVydHkgaXMgc2V0IHRvIG5vbmUg YmVmb3JlIG1vdXNlIHJlbGVhc2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI5NDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU291cmNlL1dlYkNvcmU6CisKKyAgICAgICAgV2UgY3VycmVudGx5IGNs ZWFyaW5nIHRoZSA6YWN0aXZlIHN0eWxlIHdoZW4gZWxlbWVudCBoYXMgYSByZW5kZXJlci4KKyAg ICAgICAgVGhpcyBwYXRjaCBtYWtlcyBlbGVtZW50cyBhY3RpdmUgc3R5bGUgd2l0aG91dCByZW5k ZXJlciBjbGVhcmVkLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkRvY3VtZW50Ojp1cGRhdGVIb3ZlckFjdGl2ZVN0YXRlKToKKworICAgICAgICBMYXlv dXRUZXN0czoKKworICAgICAgICAqIGZhc3QvY3NzL2FjdGl2ZS1kaXNwbGF5LW5vbmUtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9hY3RpdmUtZGlzcGxheS1ub25lLmh0 bWw6IEFkZGVkLgorCisKIDIwMTQtMDItMjggIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIENhbGxlciBzYXZlZCByZWdpc3RlcnMgY2FuIGJlIGFjY2lk ZW50YWxseSBkaXNjYXJkZWQgd2hlbiBjbGVhcmluZyB0aGUgbG9jYWwgc3RhY2sKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCmluZGV4IGE3MmE5MGI4OWNjYjVmY2ZjNTcwOGNmMmYzZjgwNDNmY2U4MGE0 ZjMuLjJmNTQxMjQ5ZDEyMGFhZTA3MGE4YzE3NWVmMzNkNWFiNGY1NGUyNWIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcApAQCAtNTgzNSw2ICs1ODM1LDggQEAgdm9pZCBEb2N1bWVudDo6dXBkYXRl SG92ZXJBY3RpdmVTdGF0ZShjb25zdCBIaXRUZXN0UmVxdWVzdCYgcmVxdWVzdCwgRWxlbWVudCog aW4KICAgICBFbGVtZW50KiBvbGRBY3RpdmVFbGVtZW50ID0gbV9hY3RpdmVFbGVtZW50LmdldCgp OwogICAgIGlmIChvbGRBY3RpdmVFbGVtZW50ICYmICFyZXF1ZXN0LmFjdGl2ZSgpKSB7CiAgICAg ICAgIC8vIFdlIGFyZSBjbGVhcmluZyB0aGUgOmFjdGl2ZSBjaGFpbiBiZWNhdXNlIHRoZSBtb3Vz ZSBoYXMgYmVlbiByZWxlYXNlZC4KKyAgICAgICAgaWYgKCFvbGRBY3RpdmVFbGVtZW50LT5yZW5k ZXJlcigpKQorICAgICAgICAgICAgb2xkQWN0aXZlRWxlbWVudC0+c2V0QWN0aXZlKGZhbHNlKTsK ICAgICAgICAgZm9yIChSZW5kZXJFbGVtZW50KiBjdXJyID0gb2xkQWN0aXZlRWxlbWVudC0+cmVu ZGVyZXIoKTsgY3VycjsgY3VyciA9IGN1cnItPnBhcmVudCgpKSB7CiAgICAgICAgICAgICBFbGVt ZW50KiBlbGVtZW50ID0gY3Vyci0+ZWxlbWVudCgpOwogICAgICAgICAgICAgaWYgKCFlbGVtZW50 KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvYWN0aXZlLWRpc3BsYXktbm9uZS1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9hY3RpdmUtZGlzcGxheS1ub25lLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jY2VkMmZmZmU5MWVlYzRkOGYzNWExZGI4MWJkMTBjNTcx OTNjZjk1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvYWN0aXZlLWRp c3BsYXktbm9uZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBAQAorOmFjdGl2ZSBzdHlsZSBz aG91bGQgYmUgY2xlYXJlZCBldmVuIGlmIGRpc3BsYXkgcHJvcGVydHkgaXMgc2V0IHRvIG5vbmUg YmVmb3JlIG1vdXNlIHJlbGVhc2VkLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKK1BB U1MgYmFja2dyb3VuZCBpcyAicmdiKDI1NSwgMCwgMCkiCitQQVNTIGJhY2tncm91bmQgaXMgInJn YigwLCAwLCAwKSIKKworCisKKworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9h Y3RpdmUtZGlzcGxheS1ub25lLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9hY3RpdmUtZGlz cGxheS1ub25lLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzhhNDc0ZDcyYmI0MDI5MmU3NDk2ZjI2OTAwNTRm NmYxYzI3MGU2NgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2FjdGl2 ZS1kaXNwbGF5LW5vbmUuaHRtbApAQCAtMCwwICsxLDQzIEBACis8IURPQ1RZUEUgaHRtbD4KKzxz dHlsZT4KKyAgZGl2OmFjdGl2ZSB7IGJhY2tncm91bmQ6IHJnYigyNTUsIDAsIDApOyB9CisgIGRp diB7CisgICAgd2lkdGg6IDEwMHB4OworICAgIGhlaWdodDogMTAwcHg7CisgICAgYm9yZGVyOiAy cHggc29saWQgcmdiKDAsIDAsIDI1NSk7CisgICAgYmFja2dyb3VuZDogcmdiKDAsIDAsIDApOwor ICB9Cis8L3N0eWxlPgorCis8Ym9keT4KKyAgPGRpdiBpZD0iYm94Ij48L2Rpdj4KKyAgPHByZSBp ZD0iZGVzY3JpcHRpb24iPjwvZGl2PgorICA8cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KKzwvYm9k eT4KKworPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3Jp cHQ+Cis8c2NyaXB0PgorICBmdW5jdGlvbiBzaG91bGRIYXZlQmFja2dyb3VuZChlbGVtZW50LCBi ZykgeworICAgIGJhY2tncm91bmQgPSBnZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQsIG51bGwpLmdl dFByb3BlcnR5VmFsdWUoImJhY2tncm91bmQtY29sb3IiKQorICAgIHNob3VsZEJlRXF1YWxUb1N0 cmluZygnYmFja2dyb3VuZCcsIGJnKQorICB9CisKKyAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7 CisgICAgZGVzY3JpcHRpb24oIjphY3RpdmUgc3R5bGUgc2hvdWxkIGJlIGNsZWFyZWQgZXZlbiBp ZiBkaXNwbGF5IHByb3BlcnR5IGlzIHNldCB0byBub25lIGJlZm9yZSBtb3VzZSByZWxlYXNlZC4i KQorICAgIHZhciBib3ggPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYm94JykKKyAgICB0ZXN0 UnVubmVyLmR1bXBBc1RleHQoKTsKKworICAgIC8vIE1vdmUgYW5kIGRvd24gaW50byB0aGUgYm94 LgorICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDUwLCA1MCkKKyAgICBldmVudFNlbmRlci5t b3VzZURvd24oKQorICAgIHNob3VsZEhhdmVCYWNrZ3JvdW5kKGJveCwgJ3JnYigyNTUsIDAsIDAp JykKKworICAgIC8vIFdpdGggdGhlIG1vdXNlIHN0aWxsIGRvd24sIHNldCBib3ggdG8gZGlzcGxh eTpub25lLgorICAgIGJveC5zdHlsZS5kaXNwbGF5ID0gIm5vbmUiOworCisgICAgLy8gTW91c2Ug dXAgdG8gY2xlYXIgYWN0aXZlIHN0eWxlLgorICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKQorICAg IGJveC5zdHlsZS5kaXNwbGF5ID0gImJsb2NrIjsKKyAgICBzaG91bGRIYXZlQmFja2dyb3VuZChi b3gsICdyZ2IoMCwgMCwgMCknKQorICB9Cis8L3NjcmlwdD4KXCBObyBuZXdsaW5lIGF0IGVuZCBv ZiBmaWxlCg== 225580 2014-03-01 19:18:08 -0800 2014-03-03 22:32:04 -0800 Patch bug-129465-20140302121807.patch text/plain 4609 sh53.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDhjZjQ0YjAzZTIwMGQ2 YmQ4NmQ5YzRhN2JmMmNiY2FiNmIwZmRkOS4uMzljNDZmMTIyM2U1YzMzNDg5YzI1ZGRmMGM2MWFj ZTUzYzQ2NTQyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTAzLTAxICBTYW5n aHl1cCBMZWUgIDxzaDUzLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICA6YWN0aXZlIHN0eWxl IGlzIG5vdCBjbGVhcmVkIHdoZW4gaXRzIGRpc3BsYXkgcHJvcGVydHkgaXMgc2V0IHRvIG5vbmUg YmVmb3JlIG1vdXNlIHJlbGVhc2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI5NDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU291cmNlL1dlYkNvcmU6CisKKyAgICAgICAgV2UgY3VycmVudGx5IGNs ZWFyaW5nIHRoZSA6YWN0aXZlIHN0eWxlIHdoZW4gZWxlbWVudCBoYXMgYSByZW5kZXJlci4KKyAg ICAgICAgVGhpcyBwYXRjaCBtYWtlcyBlbGVtZW50cyBjbGVhciBpdHMgYWN0aXZlIHN0eWxlIHJl Z2FyZGxlc3Mgb2YgcmVuZGVyZXIuIAorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp1cGRhdGVIb3ZlckFjdGl2ZVN0YXRlKToKKworICAg ICAgICBMYXlvdXRUZXN0czoKKworICAgICAgICAqIGZhc3QvY3NzL2FjdGl2ZS1kaXNwbGF5LW5v bmUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9hY3RpdmUtZGlzcGxh eS1ub25lLmh0bWw6IEFkZGVkLgorCisKIDIwMTQtMDMtMDEgIERhbiBCZXJuc3RlaW4gIDxtaXR6 QGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApp bmRleCBhNzJhOTBiODljY2I1ZmNmYzU3MDhjZjJmM2Y4MDQzZmNlODBhNGYzLi5hZmQ1MmE1OTVh MmIzYzhlZWE3Mjk1ZTRlMDE5ZmQyZDlhNTdlNDU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAK QEAgLTU4MzUsMTIgKzU4MzUsOSBAQCB2b2lkIERvY3VtZW50Ojp1cGRhdGVIb3ZlckFjdGl2ZVN0 YXRlKGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiByZXF1ZXN0LCBFbGVtZW50KiBpbgogICAgIEVsZW1l bnQqIG9sZEFjdGl2ZUVsZW1lbnQgPSBtX2FjdGl2ZUVsZW1lbnQuZ2V0KCk7CiAgICAgaWYgKG9s ZEFjdGl2ZUVsZW1lbnQgJiYgIXJlcXVlc3QuYWN0aXZlKCkpIHsKICAgICAgICAgLy8gV2UgYXJl IGNsZWFyaW5nIHRoZSA6YWN0aXZlIGNoYWluIGJlY2F1c2UgdGhlIG1vdXNlIGhhcyBiZWVuIHJl bGVhc2VkLgotICAgICAgICBmb3IgKFJlbmRlckVsZW1lbnQqIGN1cnIgPSBvbGRBY3RpdmVFbGVt ZW50LT5yZW5kZXJlcigpOyBjdXJyOyBjdXJyID0gY3Vyci0+cGFyZW50KCkpIHsKLSAgICAgICAg ICAgIEVsZW1lbnQqIGVsZW1lbnQgPSBjdXJyLT5lbGVtZW50KCk7Ci0gICAgICAgICAgICBpZiAo IWVsZW1lbnQpCi0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICBlbGVtZW50 LT5zZXRBY3RpdmUoZmFsc2UpOwotICAgICAgICAgICAgbV91c2VyQWN0aW9uRWxlbWVudHMuc2V0 SW5BY3RpdmVDaGFpbihlbGVtZW50LCBmYWxzZSk7CisgICAgICAgIGZvciAoRWxlbWVudCogY3Vy ciA9IG9sZEFjdGl2ZUVsZW1lbnQ7IGN1cnI7IGN1cnIgPSBjdXJyLT5wYXJlbnRFbGVtZW50KCkp IHsKKyAgICAgICAgICAgIGN1cnItPnNldEFjdGl2ZShmYWxzZSk7CisgICAgICAgICAgICBtX3Vz ZXJBY3Rpb25FbGVtZW50cy5zZXRJbkFjdGl2ZUNoYWluKGN1cnIsIGZhbHNlKTsKICAgICAgICAg fQogICAgICAgICBtX2FjdGl2ZUVsZW1lbnQuY2xlYXIoKTsKICAgICB9IGVsc2UgewpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvYWN0aXZlLWRpc3BsYXktbm9uZS1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9hY3RpdmUtZGlzcGxheS1ub25lLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi4zMjI0NmM5OGI0OTI1ODEzNGIwMDMxYmNiZDJhYjZjNDVmODgzMmNlCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvYWN0aXZlLWRpc3BsYXktbm9u ZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMyBAQAorOmFjdGl2ZSBzdHlsZSBzaG91bGQgYmUg Y2xlYXJlZCBldmVuIGlmIGRpc3BsYXkgcHJvcGVydHkgaXMgc2V0IHRvIG5vbmUgYmVmb3JlIG1v dXNlIHJlbGVhc2VkLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBB U1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKK1BBU1MgYmFja2dy b3VuZCBpcyAicmdiKDI1NSwgMCwgMCkiCitQQVNTIGJhY2tncm91bmQgaXMgInJnYigyNTUsIDAs IDApIgorUEFTUyBiYWNrZ3JvdW5kIGlzICJyZ2IoMCwgMCwgMCkiCitQQVNTIGJhY2tncm91bmQg aXMgInJnYigwLCAwLCAwKSIKKworCisKKworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9hY3RpdmUtZGlzcGxheS1ub25lLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9hY3Rp dmUtZGlzcGxheS1ub25lLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjc2OTc1OWY5NjNiNWZhNTUxYTIxNjBi YTg0ZmQyMjg3NDgxYTUxNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz L2FjdGl2ZS1kaXNwbGF5LW5vbmUuaHRtbApAQCAtMCwwICsxLDUzIEBACis8IURPQ1RZUEUgaHRt bD4KKzxzdHlsZT4KKyAgZGl2IHsgYmFja2dyb3VuZDogcmdiKDAsIDAsIDApOyB9CisgIGRpdjph Y3RpdmUgeyBiYWNrZ3JvdW5kOiByZ2IoMjU1LCAwLCAwKTsgfQorICAjcGFyZW50IHsKKyAgICB3 aWR0aDogMjAwcHg7CisgICAgaGVpZ2h0OiAyMDBweDsKKyAgICBib3JkZXI6IDJweCBzb2xpZCBy Z2IoMCwgMCwgMjU1KTsKKyAgfQorICAjY2hpbGQgeworICAgIHdpZHRoOiAxMDBweDsKKyAgICBo ZWlnaHQ6IDEwMHB4OworICAgIGJvcmRlcjogMnB4IHNvbGlkIHJnYigwLCAwLCAyNTUpOworICB9 Cis8L3N0eWxlPgorCis8Ym9keT4KKyAgPGRpdiBpZD0icGFyZW50Ij4KKyAgICA8ZGl2IGlkPSJj aGlsZCI+PC9kaXY+CisgIDwvZGl2PgorICA8cHJlIGlkPSJkZXNjcmlwdGlvbiI+PC9kaXY+Cisg IDxwcmUgaWQ9ImNvbnNvbGUiPjwvcHJlPgorPC9ib2R5PgorCis8c2NyaXB0IHNyYz0iLi4vLi4v cmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisgIGZ1bmN0aW9u IHNob3VsZEhhdmVCYWNrZ3JvdW5kKGVsZW1lbnQsIGJnKSB7CisgICAgYmFja2dyb3VuZCA9IGdl dENvbXB1dGVkU3R5bGUoZWxlbWVudCwgbnVsbCkuZ2V0UHJvcGVydHlWYWx1ZSgiYmFja2dyb3Vu ZC1jb2xvciIpCisgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdiYWNrZ3JvdW5kJywgYmcpCisg IH0KKworICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICBkZXNjcmlwdGlvbigiOmFjdGl2 ZSBzdHlsZSBzaG91bGQgYmUgY2xlYXJlZCBldmVuIGlmIGRpc3BsYXkgcHJvcGVydHkgaXMgc2V0 IHRvIG5vbmUgYmVmb3JlIG1vdXNlIHJlbGVhc2VkLiIpCisgICAgdmFyIGNoaWxkID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoJ2NoaWxkJykKKyAgICB2YXIgcGFyZW50ID0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ3BhcmVudCcpCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKKyAg ICAvLyBNb3ZlIGFuZCBkb3duIGludG8gdGhlIGNoaWxkIGJveC4KKyAgICBldmVudFNlbmRlci5t b3VzZU1vdmVUbyg1MCwgNTApCisgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCkKKyAgICBzaG91 bGRIYXZlQmFja2dyb3VuZChjaGlsZCwgJ3JnYigyNTUsIDAsIDApJykKKyAgICBzaG91bGRIYXZl QmFja2dyb3VuZChwYXJlbnQsICdyZ2IoMjU1LCAwLCAwKScpCisKKyAgICAvLyBXaXRoIHRoZSBt b3VzZSBzdGlsbCBkb3duLCBzZXQgcGFyZW50IGJveCB0byBkaXNwbGF5Om5vbmUuCisgICAgcGFy ZW50LnN0eWxlLmRpc3BsYXkgPSAibm9uZSI7CisKKyAgICAvLyBNb3VzZSB1cCB0byBjbGVhciBh Y3RpdmUgc3R5bGUuCisgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpCisgICAgcGFyZW50LnN0eWxl LmRpc3BsYXkgPSAiYmxvY2siOworICAgIHNob3VsZEhhdmVCYWNrZ3JvdW5kKGNoaWxkLCAncmdi KDAsIDAsIDApJykKKyAgICBzaG91bGRIYXZlQmFja2dyb3VuZChwYXJlbnQsICdyZ2IoMCwgMCwg MCknKQorICB9Cis8L3NjcmlwdD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==