129463 2014-02-27 16:35:56 -0800 Web Inspector: Use a RegExp when when using CodeMirror SearchCursor 2014-02-27 17:13:26 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 985411 0 timothy 2014-02-27 16:35:56 -0800 When passing a string to CodeMirror.getSearchCursor, and doing a case-insensitive search, CodeMirror will do toLowerString() on each line. That is expensive. Use a case-insensitive RegExp instead. 985412 1 webkit-bug-importer 2014-02-27 16:36:08 -0800 <rdar://problem/16190839> 985414 2 225429 timothy 2014-02-27 16:38:50 -0800 Created attachment 225429 Patch 985415 3 225429 joepeck 2014-02-27 16:39:53 -0800 Comment on attachment 225429 Patch r=me 985424 4 225429 commit-queue 2014-02-27 17:13:24 -0800 Comment on attachment 225429 Patch Clearing flags on attachment: 225429 Committed r164846: <http://trac.webkit.org/changeset/164846> 985425 5 commit-queue 2014-02-27 17:13:26 -0800 All reviewed patches have been landed. Closing bug. 225429 2014-02-27 16:38:50 -0800 2014-02-27 17:13:24 -0800 Patch bug-129463-20140227163849.patch text/plain 1888 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz ZmFiZGU1MTMyOTcwOWMyNTY3MTdmOWVjOWE2ZDdkNDM4YmY4MDBhLi5jMzY5OGVkNzdhYTEyOGU4 NGFhZjliN2Q0MGM4N2RhNTkwMDdlM2NmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOSBAQAogMjAxNC0wMi0yNyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgVXNlIGEgUmVnRXhwIHdoZW4gd2hlbiB1c2luZyBDb2RlTWlycm9yJ3Mg U2VhcmNoQ3Vyc29yLgorCisgICAgICAgIFRoaXMgYXZvaWRzIGRvaW5nIHRvTG93ZXJDYXNlKCkg b24gZXZlcnkgbGluZSBvZiB0aGUgVGV4dEVkaXRvci4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NDYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0 b3IuanM6CisgICAgICAgIChUZXh0RWRpdG9yLnByb3RvdHlwZS5wZXJmb3JtU2VhcmNoKTogVXNl IGEgUmVnRXhwIGZvciBxdWVyeS4gUGFzcyBmYWxzZSBmb3IgdGhlIGNhc2VGb2xkCisgICAgICAg IGFyZ3VtZW50LCBidXQgaXQgaXMgaWdub3JlZCBmb3IgUmVnRXhwIHNlYXJjaGVzIGFueXdheS4K KworMjAxNC0wMi0yNyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKICAg ICAgICAgRW5hYmxlIGJyZWFrcG9pbnRzIHdoZW4gYWRkaW5nIGEgbmV3IGJyZWFrcG9pbnQgb3Ig ZW5hYmxpbmcgYW4gZXhpc3RpbmcgYnJlYWtwb2ludC4KIAogICAgICAgICBUaGlzIGVsaW1pbmF0 ZXMgYSBtdWx0aS1zdGVwIHByb2Nlc3MgZm9yIHRoZSB1c2VyIHRoYXQgY2FuIGJlIGNvbmZ1c2lu Zy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UZXh0RWRpdG9yLmpzCmluZGV4IGEwNDUyNWM2NzEzN2E2M2VmNDJkM2ZlOWMwMzI2ODEyMjg3 NTVlZTUuLjM4ZTYwNmExZWEwNzc2Y2NhYWM5MzQ0ZjFmNmNlMTc0MjdmMjYxNjIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3Iu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVk aXRvci5qcwpAQCAtMzExLDcgKzMxMSw4IEBAIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3Rv dHlwZSA9IHsKICAgICAgICAgfQogCiAgICAgICAgIC8vIEdvIGRvd24gdGhlIHNsb3cgcGF0Y2gg Zm9yIGFsbCBvdGhlciB0ZXh0IGNvbnRlbnQuCi0gICAgICAgIHZhciBzZWFyY2hDdXJzb3IgPSB0 aGlzLl9jb2RlTWlycm9yLmdldFNlYXJjaEN1cnNvcihxdWVyeSwge2xpbmU6IDAsIGNoOiAwfSwg dHJ1ZSk7CisgICAgICAgIHZhciBxdWVyeVJlZ2V4ID0gbmV3IFJlZ0V4cChxdWVyeS5lc2NhcGVG b3JSZWdFeHAoKSwgImdpIik7CisgICAgICAgIHZhciBzZWFyY2hDdXJzb3IgPSB0aGlzLl9jb2Rl TWlycm9yLmdldFNlYXJjaEN1cnNvcihxdWVyeVJlZ2V4LCB7bGluZTogMCwgY2g6IDB9LCBmYWxz ZSk7CiAgICAgICAgIHZhciBib3VuZEJhdGNoU2VhcmNoID0gYmF0Y2hTZWFyY2guYmluZCh0aGlz KTsKICAgICAgICAgdmFyIG51bWJlck9mU2VhcmNoUmVzdWx0c0RpZENoYW5nZVRpbWVvdXQgPSBu dWxsOwogCg==