129460 2014-02-27 16:28:50 -0800 Web Inspector model tests load wrong inspector page under WebKitTestRunner 2014-03-02 19:37:05 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bburg bburg ap joepeck oldest_to_newest 985406 0 bburg 2014-02-27 16:28:50 -0800 From failure: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r164830%20(3577)/inspector/test-harness-trivially-works-pretty-diff.html Somehow WK2 is not pulling the right inspector page. 986235 1 225625 bburg 2014-03-02 18:54:36 -0800 Created attachment 225625 the patch 986239 2 225625 mitz 2014-03-02 19:07:57 -0800 Comment on attachment 225625 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=225625&action=review > Tools/WebKitTestRunner/TestInvocation.cpp:231 > + goto end; Extra whitespace here at the end. 986249 3 bburg 2014-03-02 19:37:05 -0800 Committed r164966: <http://trac.webkit.org/changeset/164966> 225625 2014-03-02 18:54:36 -0800 2014-03-02 19:07:56 -0800 the patch bug-129460-20140302185436.patch text/plain 3476 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0OTY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTY2MTkwMTk3ZDQ0OGUyYmM3Njc0MWRmZjk4NDcwYmM2 MjQ4ZTk5Yi4uM2NhZjA0M2MxNWQzOTZmZTZjZmJmNzU1YTBhNDNhNDY0YWUyMDk1OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE0LTAzLTAyICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAg IFdlYiBJbnNwZWN0b3IgbW9kZWwgdGVzdHMgbG9hZCB3cm9uZyBpbnNwZWN0b3IgcGFnZSB1bmRl ciBXZWJLaXRUZXN0UnVubmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjk0NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBEb24ndCB1bmNvbmRpdGlvbmFsbHkgb3BlbiB0aGUgaW5zcGVjdG9yIGJlZm9y ZSBydW5uaW5nIGFuIGluc3BlY3RvciB0ZXN0LgorICAgICAgICBJbnN0ZWFkLCB0aGUgdGVzdCBz aG91bGQgcmVxdWVzdCB0aGF0IHRoZSBpbnNwZWN0b3Igb3BlbiB3aGVuIGl0J3MgcmVhZHkuCisK KyAgICAgICAgVGhpcyBjaGFuZ2Ugd2FzIGxvc3QgZHVyaW5nIGEgcmViYXNlLCBidXQgaXMgdGhl IHNhbWUgY2hhbmdlIG1hZGUgdG8KKyAgICAgICAgRHVtcFJlbmRlclRyZWUuCisKKyAgICAgICAg KiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcDoKKyAgICAgICAgKFdUUjo6VGVz dEludm9jYXRpb246Omludm9rZSk6IAorCiAyMDE0LTAzLTAyICBEYXJpbiBBZGxlciAgPGRhcmlu QGFwcGxlLmNvbT4KIAogICAgICAgICBTcGxpdCBUZXh0SXRlcmF0b3JCZWhhdmlvciBpbnRvIGEg c2VwYXJhdGUgaGVhZGVyCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJ bnZvY2F0aW9uLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3Bw CmluZGV4IGY3NmJjODVhZmM1ZjExNzVhN2Y5MzgzNmZjMzYwODJmODY1ZDFlNDUuLjI1MjdkNmI1 Zjk3NmQ5Y2ZlODNmOTY0OWEzYmM0NDY3MTdiMTYzMWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvVGVzdEludm9jYXRpb24uY3BwCkBAIC0xMzksMTMgKzEzOSw2IEBAIHN0YXRpYyBib29sIHNo b3VsZExvZ0ZyYW1lTG9hZERlbGVnYXRlcyhjb25zdCBjaGFyKiBwYXRoT3JVUkwpCiAgICAgcmV0 dXJuIHN0cnN0cihwYXRoT3JVUkwsICJsb2FkaW5nLyIpOwogfQogCi0jaWYgRU5BQkxFKElOU1BF Q1RPUikgJiYgIVBMQVRGT1JNKElPUykKLXN0YXRpYyBib29sIHNob3VsZE9wZW5XZWJJbnNwZWN0 b3IoY29uc3QgY2hhciogcGF0aE9yVVJMKQotewotICAgIHJldHVybiBzdHJzdHIocGF0aE9yVVJM LCAiaW5zcGVjdG9yLyIpIHx8IHN0cnN0cihwYXRoT3JVUkwsICJpbnNwZWN0b3JcXCIpOwotfQot I2VuZGlmCi0KICNpZiBQTEFURk9STShDT0NPQSkKIHN0YXRpYyBib29sIHNob3VsZFVzZVRocmVh ZGVkU2Nyb2xsaW5nKGNvbnN0IGNoYXIqIHBhdGhPclVSTCkKIHsKQEAgLTIzNSwxMiArMjI4LDcg QEAgdm9pZCBUZXN0SW52b2NhdGlvbjo6aW52b2tlKCkKICAgICAgICAgZ290byBlbmQ7CiAgICAg fQogICAgIGlmIChtX2Vycm9yKQotICAgICAgICBnb3RvIGVuZDsKLQotI2lmIEVOQUJMRShJTlNQ RUNUT1IpICYmICFQTEFURk9STShJT1MpCi0gICAgaWYgKHNob3VsZE9wZW5XZWJJbnNwZWN0b3Io bV9wYXRoT3JVUkwuY19zdHIoKSkpCi0gICAgICAgIFdLSW5zcGVjdG9yU2hvdyhXS1BhZ2VHZXRJ bnNwZWN0b3IoVGVzdENvbnRyb2xsZXI6OnNoYXJlZCgpLm1haW5XZWJWaWV3KCktPnBhZ2UoKSkp OwotI2VuZGlmIC8vIEVOQUJMRShJTlNQRUNUT1IpICAgICAgICAKKyAgICAgICAgZ290byBlbmQ7 ICAgCiAKICAgICBXS1BhZ2VMb2FkVVJMKFRlc3RDb250cm9sbGVyOjpzaGFyZWQoKS5tYWluV2Vi VmlldygpLT5wYWdlKCksIG1fdXJsLmdldCgpKTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDRkOGFiZGVmMzJjZGFmNTAz OTc1MzE4ODJhOTkyNmQ2ZWJlYjhiNjkuLmEzZThjNTQ4MmM3NjNjZTM3YmUyMjk5YzYyYzljYjMz ODBmZjViMjcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNC0wMy0wMiAgQnJpYW4gQnVyZyAg PGJidXJnQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yIG1vZGVsIHRlc3RzIGxv YWQgd3JvbmcgaW5zcGVjdG9yIHBhZ2UgdW5kZXIgV2ViS2l0VGVzdFJ1bm5lcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NDYwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCBza2lwcGluZyBpbnNw ZWN0b3IvdGVzdC1oYXJuZXNzLXRyaXZpYWxseS13b3Jrcy5odG1sLgorCisgICAgICAgICogcGxh dGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTQtMDMtMDIgIERlYW4gSmFja3NvbiAg PGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBwcm90ZWN0ZWQgY2FzdGluZyB0byBGaWx0 ZXJPcGVyYXRpb24gY2xhc3Nlcy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dr Mi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3Rh dGlvbnMKaW5kZXggN2E1M2U0YThhOGFkYjgxZTg2NDhjZjExN2U1OTA5ZTBhMThjYWFiNy4uNzc3 MDYyYWQxM2FiMzg1NDJjZDVjYzliOWVhOTE3NzllNzAzYjQwMiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTI0Myw5ICsyNDMsNiBAQCB3ZWJraXQub3Jn L2IvMTA1OTUyIGZhc3QvbG9hZGVyL3N1Ym1pdC1mb3JtLXdoaWxlLXBhcnNpbmctMi5odG1sIFsg UGFzcyBGYWlsdXJlCiAKIHdlYmtpdC5vcmcvYi8xMjc2ODMgaHR0cC90ZXN0cy9uYXZpZ2F0aW9u L25ldy13aW5kb3ctcmVkaXJlY3QtaGlzdG9yeS5odG1sIFsgQ3Jhc2ggXQogCi0jIEFwcGFyZW50 IGZhbGxvdXQgZnJvbSBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNjQ4MzAKLXdl YmtpdC5vcmcvYi8xMjk0NjAgaW5zcGVjdG9yL3Rlc3QtaGFybmVzcy10cml2aWFsbHktd29ya3Mu aHRtbCBbIFNraXAgXQotCiAjIyMgRU5EIE9GICgxKSBDbGFzc2lmaWVkIGZhaWx1cmVzIHdpdGgg YnVnIHJlcG9ydHMKICMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMKIAo=