129459 2014-02-27 16:12:45 -0800 Build break when disabled CSS_GRID_LAYOUT 2014-02-27 19:26:14 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard oldest_to_newest 985400 0 ryuan.choi 2014-02-27 16:12:45 -0800 distcc[8236] ERROR: compile /home/ryuan/.ccache/tmp/CSSValue.tmp.ryuan-desktop2.8226.ii on localhost failed /workspace/project/webkit/efl-webkit/Source/WebCore/css/CSSValue.cpp: In member function ‘WTF::String WebCore::CSSValue::cssText() const’: /workspace/project/webkit/efl-webkit/Source/WebCore/css/CSSValue.cpp:250:12: error: enumeration value ‘GridTemplateAreasClass’ not handled in switch [-Werror=switch] switch (classType()) { ^ /workspace/project/webkit/efl-webkit/Source/WebCore/css/CSSValue.cpp: In member function ‘void WebCore::CSSValue::destroy()’: /workspace/project/webkit/efl-webkit/Source/WebCore/css/CSSValue.cpp:333:12: error: enumeration value ‘GridTemplateAreasClass’ not handled in switch [-Werror=switch] switch (classType()) { ^ 985403 1 225425 ryuan.choi 2014-02-27 16:18:07 -0800 Created attachment 225425 Patch 985405 2 commit-queue 2014-02-27 16:19:50 -0800 Attachment 225425 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 985426 3 225425 gyuyoung.kim 2014-02-27 17:23:36 -0800 Comment on attachment 225425 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225425&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Please remove this line before landing. 985427 4 225431 ryuan.choi 2014-02-27 17:24:59 -0800 Created attachment 225431 Patch 985437 5 ryuan.choi 2014-02-27 19:25:53 -0800 Committed r164849: <http://trac.webkit.org/changeset/164849> 985438 6 225431 ryuan.choi 2014-02-27 19:26:14 -0800 Comment on attachment 225431 Patch clearing flags. 225425 2014-02-27 16:18:07 -0800 2014-02-27 17:24:54 -0800 Patch bug-129459-20140228091806.patch text/plain 1874 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0ODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDBiOWU1ZjNjZmYyMTNl M2ZjMjE4ODU3Y2FmOTk1OWE5NDdjNmE0Zi4uZWRmYTQwNDY0YWZmNDNjZDgxZjk2MjkzMGY0YzBm YjJjZTM3ZjE2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAyLTI3ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBCdWlsZCBicmVhayB3 aGVuIGRpc2FibGVkIENTU19HUklEX0xBWU9VVAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NDU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBj c3MvQ1NTVmFsdWUuaDogQWRkZWQgZ3VhcmRzIG9mIENTU19HUklEX0xBWU9VVCBmb3IgR3JpZFRl bXBsYXRlQXJlYXNDbGFzcy4KKwogMjAxNC0wMi0yNyAgVGhpYWdvIGRlIEJhcnJvcyBMYWNlcmRh ICA8dGhpYWdvLmxhY2VyZGFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBbV2ViUlRDXSBSZW1v dmluZyBNZWRpYUNvbnN0cmFpbnRzIGFyZ3VtZW50IGZyb20gUlRDUGVlckNvbm5lY3Rpb24gYWRk U3RyZWFtLCB1cGRhdGVJY2UgbWV0aG9kcyBhbmQgY29uc3RydWN0b3IKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZS5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVl LmgKaW5kZXggYzAyNGRhYjFhZmVkYTA1ZmUyYzYyZWY5MmZmOWQ3ZTZiMjRjMzQ2My4uOGEwMDBk MDBmZjA5YWQxYmYyZDI5ZDdiMWZhMWUyMDI1MzJjYTViYiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1ZhbHVlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlLmgK QEAgLTk3LDcgKzk3LDkgQEAgcHVibGljOgogICAgIGJvb2wgaXNGaWx0ZXJJbWFnZVZhbHVlKCkg Y29uc3QgeyByZXR1cm4gbV9jbGFzc1R5cGUgPT0gRmlsdGVySW1hZ2VDbGFzczsgfQogICAgIGJv b2wgaXNXZWJLaXRDU1NGaWx0ZXJWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIG1fY2xhc3NUeXBlID09 IFdlYktpdENTU0ZpbHRlckNsYXNzOyB9CiAjZW5kaWYgLy8gRU5BQkxFKENTU19GSUxURVJTKQor I2lmIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQpCiAgICAgYm9vbCBpc0dyaWRUZW1wbGF0ZUFyZWFz VmFsdWUoKSBjb25zdCB7IHJldHVybiBtX2NsYXNzVHlwZSA9PSBHcmlkVGVtcGxhdGVBcmVhc0Ns YXNzOyB9CisjZW5kaWYKICAgICBib29sIGlzU1ZHQ29sb3IoKSBjb25zdCB7IHJldHVybiBtX2Ns YXNzVHlwZSA9PSBTVkdDb2xvckNsYXNzIHx8IG1fY2xhc3NUeXBlID09IFNWR1BhaW50Q2xhc3M7 IH0KICAgICBib29sIGlzU1ZHUGFpbnQoKSBjb25zdCB7IHJldHVybiBtX2NsYXNzVHlwZSA9PSBT VkdQYWludENsYXNzOyB9CiAgICAgYm9vbCBpc1VuaWNvZGVSYW5nZVZhbHVlKCkgY29uc3QgeyBy ZXR1cm4gbV9jbGFzc1R5cGUgPT0gVW5pY29kZVJhbmdlQ2xhc3M7IH0KQEAgLTE1Nyw3ICsxNTks OSBAQCBwcm90ZWN0ZWQ6CiAgICAgICAgIFVuaWNvZGVSYW5nZUNsYXNzLAogICAgICAgICBMaW5l Qm94Q29udGFpbkNsYXNzLAogICAgICAgICBDYWxjdWxhdGlvbkNsYXNzLAorI2lmIEVOQUJMRShD U1NfR1JJRF9MQVlPVVQpCiAgICAgICAgIEdyaWRUZW1wbGF0ZUFyZWFzQ2xhc3MsCisjZW5kaWYK ICAgICAgICAgU1ZHQ29sb3JDbGFzcywKICAgICAgICAgU1ZHUGFpbnRDbGFzcywKIAo= 225431 2014-02-27 17:24:59 -0800 2014-02-27 19:26:13 -0800 Patch bug-129459-20140228102457.patch text/plain 1841 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0ODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDBiOWU1ZjNjZmYyMTNl M2ZjMjE4ODU3Y2FmOTk1OWE5NDdjNmE0Zi4uZmQ5MWUyYTBlOGVkMTU3ZTg0OGViMzBlYzgwZmJl MTM3OGFkZWRhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAyLTI3ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBCdWlsZCBicmVhayB3 aGVuIGRpc2FibGVkIENTU19HUklEX0xBWU9VVAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NDU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBjc3MvQ1NTVmFsdWUuaDogQWRkZWQgZ3VhcmRzIG9mIENT U19HUklEX0xBWU9VVCBmb3IgR3JpZFRlbXBsYXRlQXJlYXNDbGFzcy4KKwogMjAxNC0wMi0yNyAg VGhpYWdvIGRlIEJhcnJvcyBMYWNlcmRhICA8dGhpYWdvLmxhY2VyZGFAb3BlbmJvc3NhLm9yZz4K IAogICAgICAgICBbV2ViUlRDXSBSZW1vdmluZyBNZWRpYUNvbnN0cmFpbnRzIGFyZ3VtZW50IGZy b20gUlRDUGVlckNvbm5lY3Rpb24gYWRkU3RyZWFtLCB1cGRhdGVJY2UgbWV0aG9kcyBhbmQgY29u c3RydWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZS5oIGIvU291 cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlLmgKaW5kZXggYzAyNGRhYjFhZmVkYTA1ZmUyYzYyZWY5 MmZmOWQ3ZTZiMjRjMzQ2My4uOGEwMDBkMDBmZjA5YWQxYmYyZDI5ZDdiMWZhMWUyMDI1MzJjYTVi YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlLmgKKysrIGIvU291cmNl L1dlYkNvcmUvY3NzL0NTU1ZhbHVlLmgKQEAgLTk3LDcgKzk3LDkgQEAgcHVibGljOgogICAgIGJv b2wgaXNGaWx0ZXJJbWFnZVZhbHVlKCkgY29uc3QgeyByZXR1cm4gbV9jbGFzc1R5cGUgPT0gRmls dGVySW1hZ2VDbGFzczsgfQogICAgIGJvb2wgaXNXZWJLaXRDU1NGaWx0ZXJWYWx1ZSgpIGNvbnN0 IHsgcmV0dXJuIG1fY2xhc3NUeXBlID09IFdlYktpdENTU0ZpbHRlckNsYXNzOyB9CiAjZW5kaWYg Ly8gRU5BQkxFKENTU19GSUxURVJTKQorI2lmIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQpCiAgICAg Ym9vbCBpc0dyaWRUZW1wbGF0ZUFyZWFzVmFsdWUoKSBjb25zdCB7IHJldHVybiBtX2NsYXNzVHlw ZSA9PSBHcmlkVGVtcGxhdGVBcmVhc0NsYXNzOyB9CisjZW5kaWYKICAgICBib29sIGlzU1ZHQ29s b3IoKSBjb25zdCB7IHJldHVybiBtX2NsYXNzVHlwZSA9PSBTVkdDb2xvckNsYXNzIHx8IG1fY2xh c3NUeXBlID09IFNWR1BhaW50Q2xhc3M7IH0KICAgICBib29sIGlzU1ZHUGFpbnQoKSBjb25zdCB7 IHJldHVybiBtX2NsYXNzVHlwZSA9PSBTVkdQYWludENsYXNzOyB9CiAgICAgYm9vbCBpc1VuaWNv ZGVSYW5nZVZhbHVlKCkgY29uc3QgeyByZXR1cm4gbV9jbGFzc1R5cGUgPT0gVW5pY29kZVJhbmdl Q2xhc3M7IH0KQEAgLTE1Nyw3ICsxNTksOSBAQCBwcm90ZWN0ZWQ6CiAgICAgICAgIFVuaWNvZGVS YW5nZUNsYXNzLAogICAgICAgICBMaW5lQm94Q29udGFpbkNsYXNzLAogICAgICAgICBDYWxjdWxh dGlvbkNsYXNzLAorI2lmIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQpCiAgICAgICAgIEdyaWRUZW1w bGF0ZUFyZWFzQ2xhc3MsCisjZW5kaWYKICAgICAgICAgU1ZHQ29sb3JDbGFzcywKICAgICAgICAg U1ZHUGFpbnRDbGFzcywKIAo=