129455 2014-02-27 15:49:39 -0800 [Mac] Stop using some deprecated functions in WKView.mm 2014-03-07 02:48:52 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap andersca mrowe sam thorton oldest_to_newest 985382 0 ap 2014-02-27 15:49:39 -0800 Stop using some deprecated functions in WKView.mm. 985396 1 225423 ap 2014-02-27 15:58:05 -0800 Created attachment 225423 proposed patch 985417 2 225423 andersca 2014-02-27 16:42:40 -0800 Comment on attachment 225423 proposed patch Please use dot syntax wherever possible (Except for [NSApp currentEvent] of course) 985430 3 ap 2014-02-27 18:00:06 -0800 Committed <http://trac.webkit.org/r164847>. 988089 4 thorton 2014-03-07 02:48:52 -0800 This caused a odd regression: https://bugs.webkit.org/show_bug.cgi?id=129872 225423 2014-02-27 15:58:05 -0800 2014-02-27 16:42:40 -0800 proposed patch Deprecation.txt text/plain 3568 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDgzOSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAyLTI3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFN0b3AgdXNpbmcg c29tZSBkZXByZWNhdGVkIGZ1bmN0aW9ucyBpbiBXS1ZpZXcubW0KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTQ1NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3 Lm1tOgorICAgICAgICAoLVtXS1ZpZXcgZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2U6YWN0dWFs UmFuZ2U6XSk6IFVzZSBjb252ZXJ0UmVjdFRvU2NyZWVuLAorICAgICAgICB3aGljaCBpcyBhIHJl cGxhY2VtZW50IGZvciBjb252ZXJ0QmFzZVRvU2NyZWVuLiBEb24ndCBjaGVjayBmb3Igd2luZG93 IGJlaW5nIG51bGwsCisgICAgICAgIGJlY2F1c2UgaXNuJ3QgdGhhdCBjcmF6eSB0YWxrPworICAg ICAgICAoLVtXS1ZpZXcgX3Bvc3RGYWtlTW91c2VNb3ZlZEV2ZW50Rm9yRmxhZ3NDaGFuZ2VkRXZl bnQ6XSk6IFVzZSBldmVudCdzIGxvY2F0aW9uCisgICAgICAgIGluIHdpbmRvdyBpbnN0ZWFkIG9m IGN1cnJlbnQgbW91c2UgbG9jYXRpb24uIFVzaW5nIGxvY2F0aW9uIHRoYXQgaXMgbm90IHN5bmNl ZCB0bworICAgICAgICBldmVudCBzdHJlYW0gcmFyZWx5IG1ha2VzIHNlbnNlLCBhbmQgaXQgZG9l c24ndCBsb29rIGxpa2UgdGhpcyBpcyBvbmUgb2YgdGhvc2UgY2FzZXMuCisgICAgICAgICgtW1dL VmlldyBwZXJmb3JtRGljdGlvbmFyeUxvb2t1cEF0Q3VycmVudE1vdXNlTG9jYXRpb25dKTogRGl0 dG8uCisKIDIwMTQtMDItMjcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4K IAogICAgICAgICBTaW1wbGlmeSBXZWJQcm9jZXNzUHJveHkgc3RhdGUgYWNjZXNzb3JzCkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCShyZXZpc2lvbiAx NjQ4MzApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdv cmtpbmcgY29weSkKQEAgLTE2NzEsMTMgKzE2NzEsNyBAQCAtIChOU1JlY3QpZmlyc3RSZWN0Rm9y Q2hhcmFjdGVyUmFuZ2U6KE5TCiAgICAgCiAgICAgTlNSZWN0IHJlc3VsdFJlY3QgPSBfZGF0YS0+ X3BhZ2UtPmZpcnN0UmVjdEZvckNoYXJhY3RlclJhbmdlKHRoZVJhbmdlLmxvY2F0aW9uLCB0aGVS YW5nZS5sZW5ndGgpOwogICAgIHJlc3VsdFJlY3QgPSBbc2VsZiBjb252ZXJ0UmVjdDpyZXN1bHRS ZWN0IHRvVmlldzpuaWxdOwotICAgIAotICAgIE5TV2luZG93ICp3aW5kb3cgPSBbc2VsZiB3aW5k b3ddOwotI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHB1c2gKLSNwcmFnbWEgY2xhbmcgZGlhZ25v c3RpYyBpZ25vcmVkICItV2RlcHJlY2F0ZWQtZGVjbGFyYXRpb25zIgotICAgIGlmICh3aW5kb3cp Ci0gICAgICAgIHJlc3VsdFJlY3Qub3JpZ2luID0gW3dpbmRvdyBjb252ZXJ0QmFzZVRvU2NyZWVu OnJlc3VsdFJlY3Qub3JpZ2luXTsKLSNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKKyAgICBy ZXN1bHRSZWN0ID0gW1tzZWxmIHdpbmRvd10gY29udmVydFJlY3RUb1NjcmVlbjpyZXN1bHRSZWN0 XTsKIAogICAgIGlmIChhY3R1YWxSYW5nZSkgewogICAgICAgICAvLyBGSVhNRTogVXBkYXRlIGFj dHVhbFJhbmdlIHRvIG1hdGNoIHRoZSByYW5nZSBvZiBmaXJzdCByZWN0LgpAQCAtMjE1MSwxMiAr MjE0NSw5IEBAIC0gKE5TVmlldyAqKWhpdFRlc3Q6KE5TUG9pbnQpcG9pbnQKIAogLSAodm9pZClf cG9zdEZha2VNb3VzZU1vdmVkRXZlbnRGb3JGbGFnc0NoYW5nZWRFdmVudDooTlNFdmVudCAqKWZs YWdzQ2hhbmdlZEV2ZW50CiB7Ci0jcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcHVzaAotI3ByYWdt YSBjbGFuZyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnMiCi0g ICAgTlNFdmVudCAqZmFrZUV2ZW50ID0gW05TRXZlbnQgbW91c2VFdmVudFdpdGhUeXBlOk5TTW91 c2VNb3ZlZCBsb2NhdGlvbjpbW2ZsYWdzQ2hhbmdlZEV2ZW50IHdpbmRvd10gY29udmVydFNjcmVl blRvQmFzZTpbTlNFdmVudCBtb3VzZUxvY2F0aW9uXV0KKyAgICBOU0V2ZW50ICpmYWtlRXZlbnQg PSBbTlNFdmVudCBtb3VzZUV2ZW50V2l0aFR5cGU6TlNNb3VzZU1vdmVkIGxvY2F0aW9uOltmbGFn c0NoYW5nZWRFdmVudCBsb2NhdGlvbkluV2luZG93XQogICAgICAgICBtb2RpZmllckZsYWdzOltm bGFnc0NoYW5nZWRFdmVudCBtb2RpZmllckZsYWdzXSB0aW1lc3RhbXA6W2ZsYWdzQ2hhbmdlZEV2 ZW50IHRpbWVzdGFtcF0gd2luZG93TnVtYmVyOltmbGFnc0NoYW5nZWRFdmVudCB3aW5kb3dOdW1i ZXJdCiAgICAgICAgIGNvbnRleHQ6W2ZsYWdzQ2hhbmdlZEV2ZW50IGNvbnRleHRdIGV2ZW50TnVt YmVyOjAgY2xpY2tDb3VudDowIHByZXNzdXJlOjBdOwotI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGlj IHBvcAogICAgIE5hdGl2ZVdlYk1vdXNlRXZlbnQgd2ViRXZlbnQoZmFrZUV2ZW50LCBzZWxmKTsK ICAgICBfZGF0YS0+X3BhZ2UtPmhhbmRsZU1vdXNlRXZlbnQod2ViRXZlbnQpOwogfQpAQCAtMzA5 MywxNCArMzA4NCw3IEBAIC0gKEJPT0wpZnJhbWVTaXplVXBkYXRlc0Rpc2FibGVkCiAKIC0gKHZv aWQpcGVyZm9ybURpY3Rpb25hcnlMb29rdXBBdEN1cnJlbnRNb3VzZUxvY2F0aW9uCiB7Ci0gICAg TlNQb2ludCB0aGVQb2ludCA9IFtOU0V2ZW50IG1vdXNlTG9jYXRpb25dOwotI3ByYWdtYSBjbGFu ZyBkaWFnbm9zdGljIHB1c2gKLSNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVkICItV2Rl cHJlY2F0ZWQtZGVjbGFyYXRpb25zIgotICAgIHRoZVBvaW50ID0gW1tzZWxmIHdpbmRvd10gY29u dmVydFNjcmVlblRvQmFzZTp0aGVQb2ludF07Ci0jcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcG9w Ci0gICAgdGhlUG9pbnQgPSBbc2VsZiBjb252ZXJ0UG9pbnQ6dGhlUG9pbnQgZnJvbVZpZXc6bmls XTsKLQotICAgIF9kYXRhLT5fcGFnZS0+cGVyZm9ybURpY3Rpb25hcnlMb29rdXBBdExvY2F0aW9u KEZsb2F0UG9pbnQodGhlUG9pbnQueCwgdGhlUG9pbnQueSkpOworICAgIF9kYXRhLT5fcGFnZS0+ cGVyZm9ybURpY3Rpb25hcnlMb29rdXBBdExvY2F0aW9uKFtzZWxmIGNvbnZlcnRQb2ludDpbW05T QXBwIGN1cnJlbnRFdmVudF0gbG9jYXRpb25JbldpbmRvd10gZnJvbVZpZXc6bmlsXSk7CiB9CiAK ICsgKHZvaWQpaGlkZVdvcmREZWZpbml0aW9uV2luZG93Cg==