129448 2014-02-27 14:10:15 -0800 lldb_webkit.py throws exception when generating summary of null StringImpl 2014-08-04 16:06:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bburg webkit-unassigned commit-queue jer.noble joepeck mattbaker oldest_to_newest 985340 0 bburg 2014-02-27 14:10:15 -0800 frame #3: 0x0000000100a89e40 JavaScriptCore`WTF::StringImpl::reallocate(originalString=0x00007fff5fbf6020, length=268435456, data=0x00007fff5fbf6950) + 128 at StringImpl.cpp:240 (lldb) frame variable Traceback (most recent call last): File "/Users/bburg/repos/webkit/OpenSource/Tools/lldb/lldb_webkit.py", line 55, in WTFStringImpl_SummaryProvider return "{ length = %d, is8bit = %d, contents = '%s' }" % (provider.get_length(), provider.is_8bit(), provider.to_string()) File "/Users/bburg/repos/webkit/OpenSource/Tools/lldb/lldb_webkit.py", line 175, in to_string return ustring_to_string(self.get_data16(), error, self.get_length()) File "/Users/bburg/repos/webkit/OpenSource/Tools/lldb/lldb_webkit.py", line 131, in ustring_to_string contents = valobj.GetProcess().ReadMemory(pointer, length * 2, lldb.SBError()) File "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Versions/A/Resources/Python/lldb/__init__.py", line 5709, in ReadMemory return _lldb.SBProcess_ReadMemory(self, *args) ValueError: Positive integer expected (WTF::PassRefPtr<WTF::StringImpl> &) originalString = 0x00007fff5fbf6020: { m_ptr = 0x0000000000000000 } (unsigned int) length = 268435456 (LChar *&) data = 0x00007fff5fbf6950: { &data = 0x000000012ff97024 } 985586 1 jer.noble 2014-02-28 09:11:58 -0800 Good catch! I'll look into this. 1026076 2 mattbaker 2014-07-31 14:53:39 -0700 I have a fix, will patch soon. 1026081 3 235849 mattbaker 2014-07-31 15:09:58 -0700 Created attachment 235849 Proposed fix 1026082 4 commit-queue 2014-07-31 15:11:53 -0700 Attachment 235849 did not pass style-queue: ERROR: Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1026086 5 235851 mattbaker 2014-07-31 15:21:51 -0700 Created attachment 235851 Patch 1026107 6 235851 jer.noble 2014-07-31 16:27:32 -0700 Comment on attachment 235851 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235851&action=review r=me, with nit. > Tools/lldb/lldb_webkit.py:58 > + return "" Nit: it might be nice to return "{ null }" here. 1026116 7 235851 joepeck 2014-07-31 16:45:25 -0700 Comment on attachment 235851 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235851&action=review >> Tools/lldb/lldb_webkit.py:58 >> + return "" > > Nit: it might be nice to return "{ null }" here. Oh nice! I like that idea. 1026120 8 235851 mattbaker 2014-07-31 16:56:05 -0700 Comment on attachment 235851 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235851&action=review >> Tools/lldb/lldb_webkit.py:58 >> + return "" > > Nit: it might be nice to return "{ null }" here. Xcode auto-appends "NULL" in the variables window in this case, so it might just add clutter. 1026715 9 235851 commit-queue 2014-08-04 16:06:28 -0700 Comment on attachment 235851 Patch Clearing flags on attachment: 235851 Committed r172012: <http://trac.webkit.org/changeset/172012> 1026716 10 commit-queue 2014-08-04 16:06:32 -0700 All reviewed patches have been landed. Closing bug. 235849 2014-07-31 15:09:58 -0700 2014-07-31 15:21:47 -0700 Proposed fix bug129448-lldb-script-patch.txt text/plain 2534 mattbaker ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3MjQw MmE5Li4xNGU3N2U5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQtMDctMzEgIE1hdHQgQmFrZXIgIDxtYXR0YmFr ZXJAYXBwbGUuY29tPgorCisgICAgICAgIGxsZGJfd2Via2l0LnB5IHRocm93cyBleGNlcHRpb24g d2hlbiBnZW5lcmF0aW5nIHN1bW1hcnkgb2YgbnVsbCBTdHJpbmdJbXBsCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk0NDgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCUFkZGVkIGNoZWNrcyBmb3IgbnVsbCBTdHJpbmdJ bXBsIGFuZCAwIGJ5dGUgUmVhZE1lbW9yeSBjYWxscy4KKworICAgICAgICAqIGxsZGIvbGxkYl93 ZWJraXQucHk6CisgICAgICAgIChXVEZTdHJpbmdJbXBsX1N1bW1hcnlQcm92aWRlcik6CisgICAg ICAgICh1c3RyaW5nX3RvX3N0cmluZyk6CisgICAgICAgIChsc3RyaW5nX3RvX3N0cmluZyk6Cisg ICAgICAgIChXVEZTdHJpbmdJbXBsUHJvdmlkZXIudG9fc3RyaW5nKToKKyAgICAgICAgKFdURlN0 cmluZ0ltcGxQcm92aWRlci5pc19pbml0aWFsaXplZCk6CisKIDIwMTQtMDctMjggIFJlbmF0byBO YWd5ICA8bmFneS5yZW5hdG9Ac3R1ZC51LXN6ZWdlZC5odT4KIAogICAgICAgICBGb2xsb3d1cCBm aXggYWZ0ZXIgcjE3MTU5NApkaWZmIC0tZ2l0IGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weSBi L1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkKaW5kZXggNmIyYjlhOS4uMjI2N2YxZiAxMDA2NDQK LS0tIGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weQorKysgYi9Ub29scy9sbGRiL2xsZGJfd2Vi a2l0LnB5CkBAIC01NCw2ICs1NCw4IEBAIGRlZiBXVEZTdHJpbmdfU3VtbWFyeVByb3ZpZGVyKHZh bG9iaiwgZGljdCk6CiAKIGRlZiBXVEZTdHJpbmdJbXBsX1N1bW1hcnlQcm92aWRlcih2YWxvYmos IGRpY3QpOgogICAgIHByb3ZpZGVyID0gV1RGU3RyaW5nSW1wbFByb3ZpZGVyKHZhbG9iaiwgZGlj dCkKKyAgICBpZiBub3QgcHJvdmlkZXIuaXNfaW5pdGlhbGl6ZWQoKToKKyAgICAgICAgcmV0dXJu ICIiCiAgICAgcmV0dXJuICJ7IGxlbmd0aCA9ICVkLCBpczhiaXQgPSAlZCwgY29udGVudHMgPSAn JXMnIH0iICUgKHByb3ZpZGVyLmdldF9sZW5ndGgoKSwgcHJvdmlkZXIuaXNfOGJpdCgpLCBwcm92 aWRlci50b19zdHJpbmcoKSkKIAogCkBAIC0xNjYsNiArMTY4LDkgQEAgZGVmIHVzdHJpbmdfdG9f c3RyaW5nKHZhbG9iaiwgZXJyb3IsIGxlbmd0aD1Ob25lKToKICAgICBlbHNlOgogICAgICAgICBs ZW5ndGggPSBpbnQobGVuZ3RoKQogCisgICAgaWYgbGVuZ3RoID09IDA6CisgICAgICAgIHJldHVy biAiIgorCiAgICAgcG9pbnRlciA9IHZhbG9iai5HZXRWYWx1ZUFzVW5zaWduZWQoKQogICAgIGNv bnRlbnRzID0gdmFsb2JqLkdldFByb2Nlc3MoKS5SZWFkTWVtb3J5KHBvaW50ZXIsIGxlbmd0aCAq IDIsIGxsZGIuU0JFcnJvcigpKQogCkBAIC0xODMsNiArMTg4LDkgQEAgZGVmIGxzdHJpbmdfdG9f c3RyaW5nKHZhbG9iaiwgZXJyb3IsIGxlbmd0aD1Ob25lKToKICAgICBlbHNlOgogICAgICAgICBs ZW5ndGggPSBpbnQobGVuZ3RoKQogCisgICAgaWYgbGVuZ3RoID09IDA6CisgICAgICAgIHJldHVy biAiIgorCiAgICAgcG9pbnRlciA9IHZhbG9iai5HZXRWYWx1ZUFzVW5zaWduZWQoKQogICAgIGNv bnRlbnRzID0gdmFsb2JqLkdldFByb2Nlc3MoKS5SZWFkTWVtb3J5KHBvaW50ZXIsIGxlbmd0aCwg bGxkYi5TQkVycm9yKCkpCiAKQEAgLTIwOSw2ICsyMTcsMTAgQEAgY2xhc3MgV1RGU3RyaW5nSW1w bFByb3ZpZGVyOgogCiAgICAgZGVmIHRvX3N0cmluZyhzZWxmKToKICAgICAgICAgZXJyb3IgPSBs bGRiLlNCRXJyb3IoKQorCisgICAgICAgIGlmIG5vdCBzZWxmLmlzX2luaXRpYWxpemVkKCk6Cisg ICAgICAgICAgICByZXR1cm4gdSIiCisKICAgICAgICAgaWYgc2VsZi5pc184Yml0KCk6CiAgICAg ICAgICAgICByZXR1cm4gbHN0cmluZ190b19zdHJpbmcoc2VsZi5nZXRfZGF0YTgoKSwgZXJyb3Is IHNlbGYuZ2V0X2xlbmd0aCgpKQogICAgICAgICByZXR1cm4gdXN0cmluZ190b19zdHJpbmcoc2Vs Zi5nZXRfZGF0YTE2KCksIGVycm9yLCBzZWxmLmdldF9sZW5ndGgoKSkKQEAgLTIxOCw2ICsyMzAs OSBAQCBjbGFzcyBXVEZTdHJpbmdJbXBsUHJvdmlkZXI6CiAgICAgICAgIHJldHVybiBib29sKHNl bGYudmFsb2JqLkdldENoaWxkTWVtYmVyV2l0aE5hbWUoJ21faGFzaEFuZEZsYWdzJykuR2V0VmFs dWVBc1Vuc2lnbmVkKDApIFwKICAgICAgICAgICAgICYgMSA8PCA1KQogCisgICAgZGVmIGlzX2lu aXRpYWxpemVkKHNlbGYpOgorICAgICAgICByZXR1cm4gc2VsZi52YWxvYmouR2V0VmFsdWVBc1Vu c2lnbmVkKCkgIT0gMAorCiAKIGNsYXNzIFdURlN0cmluZ1Byb3ZpZGVyOgogICAgIGRlZiBfX2lu aXRfXyhzZWxmLCB2YWxvYmosIGRpY3QpOgo= 235851 2014-07-31 15:21:51 -0700 2014-08-04 16:06:28 -0700 Patch bug-129448-20140731152138.patch text/plain 2701 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNjgwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzI0MDJhOWY3MjlkZTM1MWEwNWQxZDA2MWZiZTkxZmY0 YzQzOWY2OC4uOTI4OWI3YmViZGNiMjAxZjBmNTRkYWQwYWY2MzcwYmIyZDcyYmQzZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE0LTA3LTMxICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KKworICAg ICAgICBsbGRiX3dlYmtpdC5weSB0aHJvd3MgZXhjZXB0aW9uIHdoZW4gZ2VuZXJhdGluZyBzdW1t YXJ5IG9mIG51bGwgU3RyaW5nSW1wbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI5NDQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkZWQgY2hlY2tzIGZvciBudWxsIFN0cmluZ0ltcGwgYW5kIDAgYnl0 ZSBSZWFkTWVtb3J5IGNhbGxzLgorCisgICAgICAgICogbGxkYi9sbGRiX3dlYmtpdC5weToKKyAg ICAgICAgKFdURlN0cmluZ0ltcGxfU3VtbWFyeVByb3ZpZGVyKToKKyAgICAgICAgKHVzdHJpbmdf dG9fc3RyaW5nKToKKyAgICAgICAgKGxzdHJpbmdfdG9fc3RyaW5nKToKKyAgICAgICAgKFdURlN0 cmluZ0ltcGxQcm92aWRlci50b19zdHJpbmcpOgorICAgICAgICAoV1RGU3RyaW5nSW1wbFByb3Zp ZGVyLmlzX2luaXRpYWxpemVkKToKKwogMjAxNC0wNy0yOCAgUmVuYXRvIE5hZ3kgIDxuYWd5LnJl bmF0b0BzdHVkLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIEZvbGxvd3VwIGZpeCBhZnRlciByMTcx NTk0CmRpZmYgLS1naXQgYS9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5IGIvVG9vbHMvbGxkYi9s bGRiX3dlYmtpdC5weQppbmRleCA2YjJiOWE5Y2JmYjJjMTUzMGJmOWJhYjQ4MTNmMTMxMDQyOTIx NmQ5Li4yMjY3ZjFmZmQ3YjZiYTg4ZTRkZTBlMmE5OWFmY2RlZjY5OTU4M2ViIDEwMDY0NAotLS0g YS9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5CisrKyBiL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQu cHkKQEAgLTU0LDYgKzU0LDggQEAgZGVmIFdURlN0cmluZ19TdW1tYXJ5UHJvdmlkZXIodmFsb2Jq LCBkaWN0KToKIAogZGVmIFdURlN0cmluZ0ltcGxfU3VtbWFyeVByb3ZpZGVyKHZhbG9iaiwgZGlj dCk6CiAgICAgcHJvdmlkZXIgPSBXVEZTdHJpbmdJbXBsUHJvdmlkZXIodmFsb2JqLCBkaWN0KQor ICAgIGlmIG5vdCBwcm92aWRlci5pc19pbml0aWFsaXplZCgpOgorICAgICAgICByZXR1cm4gIiIK ICAgICByZXR1cm4gInsgbGVuZ3RoID0gJWQsIGlzOGJpdCA9ICVkLCBjb250ZW50cyA9ICclcycg fSIgJSAocHJvdmlkZXIuZ2V0X2xlbmd0aCgpLCBwcm92aWRlci5pc184Yml0KCksIHByb3ZpZGVy LnRvX3N0cmluZygpKQogCiAKQEAgLTE2Niw2ICsxNjgsOSBAQCBkZWYgdXN0cmluZ190b19zdHJp bmcodmFsb2JqLCBlcnJvciwgbGVuZ3RoPU5vbmUpOgogICAgIGVsc2U6CiAgICAgICAgIGxlbmd0 aCA9IGludChsZW5ndGgpCiAKKyAgICBpZiBsZW5ndGggPT0gMDoKKyAgICAgICAgcmV0dXJuICIi CisKICAgICBwb2ludGVyID0gdmFsb2JqLkdldFZhbHVlQXNVbnNpZ25lZCgpCiAgICAgY29udGVu dHMgPSB2YWxvYmouR2V0UHJvY2VzcygpLlJlYWRNZW1vcnkocG9pbnRlciwgbGVuZ3RoICogMiwg bGxkYi5TQkVycm9yKCkpCiAKQEAgLTE4Myw2ICsxODgsOSBAQCBkZWYgbHN0cmluZ190b19zdHJp bmcodmFsb2JqLCBlcnJvciwgbGVuZ3RoPU5vbmUpOgogICAgIGVsc2U6CiAgICAgICAgIGxlbmd0 aCA9IGludChsZW5ndGgpCiAKKyAgICBpZiBsZW5ndGggPT0gMDoKKyAgICAgICAgcmV0dXJuICIi CisKICAgICBwb2ludGVyID0gdmFsb2JqLkdldFZhbHVlQXNVbnNpZ25lZCgpCiAgICAgY29udGVu dHMgPSB2YWxvYmouR2V0UHJvY2VzcygpLlJlYWRNZW1vcnkocG9pbnRlciwgbGVuZ3RoLCBsbGRi LlNCRXJyb3IoKSkKIApAQCAtMjA5LDYgKzIxNywxMCBAQCBjbGFzcyBXVEZTdHJpbmdJbXBsUHJv dmlkZXI6CiAKICAgICBkZWYgdG9fc3RyaW5nKHNlbGYpOgogICAgICAgICBlcnJvciA9IGxsZGIu U0JFcnJvcigpCisKKyAgICAgICAgaWYgbm90IHNlbGYuaXNfaW5pdGlhbGl6ZWQoKToKKyAgICAg ICAgICAgIHJldHVybiB1IiIKKwogICAgICAgICBpZiBzZWxmLmlzXzhiaXQoKToKICAgICAgICAg ICAgIHJldHVybiBsc3RyaW5nX3RvX3N0cmluZyhzZWxmLmdldF9kYXRhOCgpLCBlcnJvciwgc2Vs Zi5nZXRfbGVuZ3RoKCkpCiAgICAgICAgIHJldHVybiB1c3RyaW5nX3RvX3N0cmluZyhzZWxmLmdl dF9kYXRhMTYoKSwgZXJyb3IsIHNlbGYuZ2V0X2xlbmd0aCgpKQpAQCAtMjE4LDYgKzIzMCw5IEBA IGNsYXNzIFdURlN0cmluZ0ltcGxQcm92aWRlcjoKICAgICAgICAgcmV0dXJuIGJvb2woc2VsZi52 YWxvYmouR2V0Q2hpbGRNZW1iZXJXaXRoTmFtZSgnbV9oYXNoQW5kRmxhZ3MnKS5HZXRWYWx1ZUFz VW5zaWduZWQoMCkgXAogICAgICAgICAgICAgJiAxIDw8IDUpCiAKKyAgICBkZWYgaXNfaW5pdGlh bGl6ZWQoc2VsZik6CisgICAgICAgIHJldHVybiBzZWxmLnZhbG9iai5HZXRWYWx1ZUFzVW5zaWdu ZWQoKSAhPSAwCisKIAogY2xhc3MgV1RGU3RyaW5nUHJvdmlkZXI6CiAgICAgZGVmIF9faW5pdF9f KHNlbGYsIHZhbG9iaiwgZGljdCk6Cg==