129436 2014-02-27 10:11:22 -0800 [Mac][WK2] Remove hardcoded Cmd+B and Cmd+I from WKView.mm 2025-12-15 16:02:31 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=304117 P2 Normal --- 1 ap ap commit-queue darin enrica rniwa oldest_to_newest 985224 0 ap 2014-02-27 10:11:22 -0800 We hardcode Cmd+B and Cmd+I in WebKit1 for historic reasons, but it doesn't look like there is any need to do this in WebKit2. I tested GMail and iCloud e-mail, and these shortcuts work there even without this code (presumably because both implemented them in JS for Firefox on Mac). Mail.app has these shortcuts in menu, so again, hardcoding is unnecessary. The reason I want to remove this is that _handleStyleKeyEquivalent looks at EditorState, which is not going to be supported in the future. 985227 1 225387 ap 2014-02-27 10:13:11 -0800 Created attachment 225387 proposed patch 985267 2 225387 commit-queue 2014-02-27 11:14:37 -0800 Comment on attachment 225387 proposed patch Clearing flags on attachment: 225387 Committed r164818: <http://trac.webkit.org/changeset/164818> 985268 3 commit-queue 2014-02-27 11:14:39 -0800 All reviewed patches have been landed. Closing bug. 225387 2014-02-27 10:13:11 -0800 2014-02-27 11:14:37 -0800 proposed patch CmdB.txt text/plain 2387 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDgxMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAyLTI3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdW1dLMl0gUmVtb3Zl IGhhcmRjb2RlZCBDbWQrQiBhbmQgQ21kK0kgZnJvbSBXS1ZpZXcubW0KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTQzNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tW aWV3Lm1tOiBSZW1vdmVkIGEgaGlzdG9yaWMgV2ViS2l0MSBiZWhhdmlvciB0aGF0IHdlIGRvbid0 CisgICAgICAgIG5lZWQgdG8gcHJlc2VydmUgaW4gV2ViS2l0Mi4KKwogMjAxNC0wMi0yNyAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIExvb2sgdXAgYWxy ZWFkeSBleGlzdGluZyBWaXNpdGVkTGlua1RhYmxlQ29udHJvbGxlciBvYmplY3RzIGJ5IGlkZW50 aWZpZXIKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0J KHJldmlzaW9uIDE2NDQ4OCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dL Vmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTMxMCwzMiArMTMxMCw2IEBAIC0gKHZvaWQpaW5z ZXJ0VGV4dDooaWQpc3RyaW5nIHJlcGxhY2VtZW4KICAgICAgICAgcGFyYW1ldGVycy0+ZXZlbnRJ bnRlcnByZXRhdGlvbkhhZFNpZGVFZmZlY3RzIHw9IGV2ZW50SGFuZGxlZDsKIH0KIAotLSAoQk9P TClfaGFuZGxlU3R5bGVLZXlFcXVpdmFsZW50OihOU0V2ZW50ICopZXZlbnQKLXsKLSAgICBpZiAo IV9kYXRhLT5fcGFnZS0+ZWRpdG9yU3RhdGUoKS5pc0NvbnRlbnRFZGl0YWJsZSkKLSAgICAgICAg cmV0dXJuIE5POwotCi0gICAgaWYgKChbZXZlbnQgbW9kaWZpZXJGbGFnc10gJiBOU0RldmljZUlu ZGVwZW5kZW50TW9kaWZpZXJGbGFnc01hc2spICE9IE5TQ29tbWFuZEtleU1hc2spCi0gICAgICAg IHJldHVybiBOTzsKLSAgICAKLSAgICAvLyBIZXJlIHdlIHNwZWNpYWwgY2FzZSBjbWQrYiBhbmQg Y21kK2kgYnV0IG5vdCBjbWQrdSwgZm9yIGhpc3RvcmljIHJlYXNvbi4KLSAgICAvLyBUaGlzIHNo b3VsZCBub3QgYmUgY2hhbmdlZCwgc2luY2UgaXQgY291bGQgYnJlYWsgc29tZSBNYWMgYXBwbGlj YXRpb25zIHRoYXQKLSAgICAvLyByZWx5IG9uIHRoaXMgaW5oZXJlbnQgYmVoYXZpb3IuCi0gICAg Ly8gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDk0MwotICAg IAotICAgIE5TU3RyaW5nICpzdHJpbmcgPSBbZXZlbnQgY2hhcmFjdGVyc107Ci0gICAgaWYgKFtz dHJpbmcgY2FzZUluc2Vuc2l0aXZlQ29tcGFyZTpAImIiXSA9PSBOU09yZGVyZWRTYW1lKSB7Ci0g ICAgICAgIF9kYXRhLT5fcGFnZS0+ZXhlY3V0ZUVkaXRDb21tYW5kKCJUb2dnbGVCb2xkIik7Ci0g ICAgICAgIHJldHVybiBZRVM7Ci0gICAgfQotICAgIGlmIChbc3RyaW5nIGNhc2VJbnNlbnNpdGl2 ZUNvbXBhcmU6QCJpIl0gPT0gTlNPcmRlcmVkU2FtZSkgewotICAgICAgICBfZGF0YS0+X3BhZ2Ut PmV4ZWN1dGVFZGl0Q29tbWFuZCgiVG9nZ2xlSXRhbGljIik7Ci0gICAgICAgIHJldHVybiBZRVM7 Ci0gICAgfQotICAgIAotICAgIHJldHVybiBOTzsKLX0KLQogLSAoQk9PTClwZXJmb3JtS2V5RXF1 aXZhbGVudDooTlNFdmVudCAqKWV2ZW50CiB7CiAgICAgLy8gVGhlcmUncyBhIGNoYW5jZSB0aGF0 IHJlc3BvbmRpbmcgdG8gdGhpcyBldmVudCB3aWxsIHJ1biBhIG5lc3RlZCBldmVudCBsb29wLCBh bmQKQEAgLTEzNTcsNyArMTMzMSw3IEBAIC0gKEJPT0wpcGVyZm9ybUtleUVxdWl2YWxlbnQ6KE5T RXZlbnQgKikKICAgICAgICAgcmV0dXJuIFlFUzsKICAgICB9CiAgICAgCi0gICAgcmV0dXJuIFtz ZWxmIF9oYW5kbGVTdHlsZUtleUVxdWl2YWxlbnQ6ZXZlbnRdIHx8IFtzdXBlciBwZXJmb3JtS2V5 RXF1aXZhbGVudDpldmVudF07CisgICAgcmV0dXJuIFtzdXBlciBwZXJmb3JtS2V5RXF1aXZhbGVu dDpldmVudF07CiB9CiAKIC0gKHZvaWQpa2V5VXA6KE5TRXZlbnQgKil0aGVFdmVudAo=