129432 2014-02-27 09:33:32 -0800 [GTK] Finetune captions menu as per design team 2014-02-28 02:01:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 calvaris calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble macpherson menard philipj sergio oldest_to_newest 985207 0 calvaris 2014-02-27 09:33:32 -0800 [GTK] Finetune captions menu as per design team 985208 1 225381 calvaris 2014-02-27 09:37:32 -0800 Created attachment 225381 Patch 985379 2 calvaris 2014-02-27 15:35:42 -0800 Small explanation: http://imgur.com/kPxvS6G,JVhRQjf#0 In the first image, you can see that the dialog is centered (as usual) con the menu button but as it is too close to right side, a part of it is being shown out of the panel space and the effect is weird. Apart from that, designers asked to do some tweaking to the header file. 985509 3 225381 commit-queue 2014-02-28 02:00:57 -0800 Comment on attachment 225381 Patch Clearing flags on attachment: 225381 Committed r164857: <http://trac.webkit.org/changeset/164857> 985510 4 commit-queue 2014-02-28 02:01:00 -0800 All reviewed patches have been landed. Closing bug. 225381 2014-02-27 09:37:32 -0800 2014-02-28 02:00:57 -0800 Patch bug-129432-20140227183731.patch text/plain 4213 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0Nzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkxNTY4Yjg0MThmZTYz YmMwNGFkMTgxYzRiYzI3OTdkN2EzMTRhYi4uN2U3MzQyYmJkN2ViYTI5MTU5ZDFjZjI2ZjI2Y2Ni ZDI1ZDhjOTE1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE0LTAyLTI3ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dU S10gRmluZXR1bmUgY2FwdGlvbnMgbWVudSBhcyBwZXIgZGVzaWduIHRlYW0KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTQzMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWUgZGVzaWduIGZpbmUgdHVu aW5nIG9mIHRoZSBjYXB0aW9ucyBkaWFsb2cgd2FzIHJlcXVpcmVkLgorICAgICAgICAKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCBjdXJyZW50IHN1ZmZpY2UuCisKKyAgICAgICAgKiBNb2R1bGVzL21l ZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzOgorICAgICAgICBBZGRlZCBvdXQgY2xh c3MuCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNHdGsuanM6 CisgICAgICAgIChDb250cm9sbGVyR3RrLnByb3RvdHlwZS5idWlsZENhcHRpb25NZW51KTogU2V0 dGluZyBvdXQgY2xhc3Mgd2hlbgorICAgICAgICBtZW51IGlzIGdvaW5nIHRvIHNob3cgb3Zlcmxh cCB0aGUgcGFuZWwgcmlnaHQgYm9yZGVyLgorICAgICAgICAqIGNzcy9tZWRpYUNvbnRyb2xzR3Rr LmNzczoKKyAgICAgICAgKHZpZGVvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWNsb3NlZC1jYXB0 aW9ucy1jb250YWluZXIub3V0KToKKyAgICAgICAgU2V0dGluZyBhbGwgYm9yZGVycyB0byA1cHg7 CisgICAgICAgICh2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1jbG9zZWQtY2FwdGlvbnMt Y29udGFpbmVyIGgzKToKKyAgICAgICAgUmVkdWNlZCBmb250IHNpemUgYW5kIGluY3JlYXNpbmcg dG9wIHBhZGRpbmcuCisgICAgICAgICh2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1jbG9z ZWQtY2FwdGlvbnMtY29udGFpbmVyIHVsKToKKyAgICAgICAgSW5jcmVhc2VkIHRvcCBwYWRkaW5n LgorCiAyMDE0LTAyLTI3ICBSZW5hdGEgSG9kb3ZhbiAgPHJob2RvdmFuLnUtc3plZ2VkQHBhcnRu ZXIuc2Ftc3VuZy5jb20+CiAKICAgICAgICAgSW1wcm92aW5nIGNvbnRhaW5pbmcgY29sdW1uIGJs b2NrIGRldGVybWluYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCmluZGV4IDQ2ODljZjE2NDE2OGMy YjdhY2Y5Y2MxOGJjZDJlNTkwZjU3YzY1NGMuLmUwZDE4NDFjNzJiMGNjMDRjYjE2N2NhYTdhZDdl ZWY3MmVkNDcwZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250 cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcwpAQCAtODMsNiArODMsNyBAQCBDb250 cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgdm9sdW1lQm94OiAndm9sdW1lLWJveCcsCiAg ICAgICAgIG5vVmlkZW86ICduby12aWRlbycsCiAgICAgICAgIGRvd246ICdkb3duJywKKyAgICAg ICAgb3V0OiAnb3V0JywKICAgICB9LAogICAgIEtleUNvZGVzOiB7CiAgICAgICAgIGVudGVyOiAx MywKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRp YUNvbnRyb2xzR3RrLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNHdGsuanMKaW5kZXggMDMwMDVmZDVmOWQ3Yjk3NTlkNmRiN2Q1MTU2MTE4NWRm ZjRhZDc2MC4uMTUzNjhhY2ZkMDk0ZjY5NTdhZWQwNmZjNzkzODFhNDk3OGUwMGE0ZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNH dGsuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29u dHJvbHNHdGsuanMKQEAgLTE2MCw3ICsxNjAsMTAgQEAgQ29udHJvbGxlckd0ay5wcm90b3R5cGUg PSB7CiAgICAgICAgIC8vIENhcHRpb24gbWVudSBoYXMgdG8gYmUgY2VudGVyZWQgdG8gdGhlIGNh cHRpb24gYnV0dG9uLgogICAgICAgICB2YXIgY2FwdGlvbkJ1dHRvbkNlbnRlciA9ICB0aGlzLmNv bnRyb2xzLnBhbmVsLm9mZnNldExlZnQgKyB0aGlzLmNvbnRyb2xzLmNhcHRpb25CdXR0b24ub2Zm c2V0TGVmdCArCiAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLmNhcHRpb25CdXR0b24ub2Zmc2V0 V2lkdGggLyAyOwotICAgICAgICB0aGlzLmNhcHRpb25NZW51LnN0eWxlLmxlZnQgPSAoY2FwdGlv bkJ1dHRvbkNlbnRlciAtIHRoaXMuY2FwdGlvbk1lbnUub2Zmc2V0V2lkdGggLyAyKSArICdweCc7 CisgICAgICAgIHZhciBjYXB0aW9uTWVudUxlZnQgPSAoY2FwdGlvbkJ1dHRvbkNlbnRlciAtIHRo aXMuY2FwdGlvbk1lbnUub2Zmc2V0V2lkdGggLyAyKTsKKyAgICAgICAgaWYgKGNhcHRpb25NZW51 TGVmdCArIHRoaXMuY2FwdGlvbk1lbnUub2Zmc2V0V2lkdGggPiB0aGlzLmNvbnRyb2xzLnBhbmVs Lm9mZnNldExlZnQgKyB0aGlzLmNvbnRyb2xzLnBhbmVsLm9mZnNldFdpZHRoKQorICAgICAgICAg ICAgdGhpcy5jYXB0aW9uTWVudS5jbGFzc0xpc3QuYWRkKHRoaXMuQ2xhc3NOYW1lcy5vdXQpOwor ICAgICAgICB0aGlzLmNhcHRpb25NZW51LnN0eWxlLmxlZnQgPSBjYXB0aW9uTWVudUxlZnQgKyAn cHgnOwogICAgICAgICAvLyBBcyBoZWlnaHQgaXMgbm90IGluIHRoZSBjc3MsIGl0IG5lZWRzIHRv IGJlIHNwZWNpZmllZCB0byBhbmltYXRlIGl0LgogICAgICAgICB0aGlzLmNhcHRpb25NZW51Lmhl aWdodCA9IHRoaXMuY2FwdGlvbk1lbnUub2Zmc2V0SGVpZ2h0OwogICAgICAgICB0aGlzLmNhcHRp b25NZW51LnN0eWxlLmhlaWdodCA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv bWVkaWFDb250cm9sc0d0ay5jc3MgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9sc0d0 ay5jc3MKaW5kZXggYTUyNjY5ZmJjYjg3NDJmYWQyMzliMjA5MmU1MWZkZDVlNzM3NzYwNS4uYzM4 YWVjNDdlZTg0ZjViM2YzYjFhOWYyZmRkMzViMjc3MmIyMGFhYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvY3NzL21lZGlhQ29udHJvbHNHdGsuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9tZWRpYUNvbnRyb2xzR3RrLmNzcwpAQCAtMzA4LDE1ICszMDgsMjQgQEAgdmlkZW86Oi13ZWJr aXQtbWVkaWEtY29udHJvbHMtY2xvc2VkLWNhcHRpb25zLWNvbnRhaW5lciB7CiAgICAgdHJhbnNp dGlvbjogaGVpZ2h0IDAuMTBzIGxpbmVhcjsKIH0KIAordmlkZW86Oi13ZWJraXQtbWVkaWEtY29u dHJvbHMtY2xvc2VkLWNhcHRpb25zLWNvbnRhaW5lci5vdXQgeworICAgIGJvcmRlci1yYWRpdXM6 IDVweDsKK30KKwogdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtY2xvc2VkLWNhcHRpb25z LWNvbnRhaW5lciBoMyB7Ci0gICAgbWFyZ2luOiAxcHggMTBweDsKLSAgICBwYWRkaW5nLXRvcDog NHB4OworICAgIHBhZGRpbmctdG9wOiA4cHg7CisgICAgbWFyZ2luOiAwOworICAgIHBhZGRpbmct bGVmdDogMTdweDsKKyAgICBwYWRkaW5nLXJpZ2h0OiAxNXB4OworICAgIGZvbnQtc2l6ZTogMTBw dDsKKyAgICBmb250LXdlaWdodDogYm9sZDsKKyAgICBmb250LXN0eWxlOiBub3JtYWw7CiB9CiAK IHZpZGVvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWNsb3NlZC1jYXB0aW9ucy1jb250YWluZXIg dWwgewogICAgIGxpc3Qtc3R5bGUtdHlwZTogbm9uZTsKICAgICBtYXJnaW46IDAgMCA0cHggMDsK LSAgICBwYWRkaW5nOiAwOworICAgIHBhZGRpbmc6IDRweCAwIDAgMDsKIH0KIAogdmlkZW86Oi13 ZWJraXQtbWVkaWEtY29udHJvbHMtY2xvc2VkLWNhcHRpb25zLWNvbnRhaW5lciBsaSB7Cg==