129427 2014-02-27 08:59:11 -0800 Some small modernizing tweaks to the coding style guide 2014-03-03 14:48:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin andersca sam oldest_to_newest 985190 0 darin 2014-02-27 08:59:11 -0800 Change coding style guide to specify nullptr instead of 0, and other small modernizing tweaks 985191 1 225374 darin 2014-02-27 09:03:42 -0800 Created attachment 225374 Patch 985616 2 225374 ap 2014-02-28 10:05:56 -0800 Comment on attachment 225374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225374&action=review > Websites/webkit.org/ChangeLog:14 > + without non-WebKit-style abbreviations and such. Use auto& instead of const auto& in for loop > + example, since that's normally preferred. Changed section title to say "zero" instead of "0". This is one part I'm not sure of. We have a lot of "const auto&" loop variables currently in the tree, and I personally like those. 985677 3 darin 2014-02-28 12:39:11 -0800 (In reply to comment #2) > This is one part I'm not sure of. We have a lot of "const auto&" loop variables currently in the tree, and I personally like those. The compiler will automatically propagate the const from the collection if begin/end are overloaded suitably. How critical is it to narrow the reference to read-only in cases where the access to the collection is not already read-only? Is it worth an extra keyword on every one of these for loops? 985998 4 225374 darin 2014-03-01 15:24:49 -0800 Comment on attachment 225374 Patch For now I will land with "auto&". We can change back later if we confirm that "const auto&" is preferred. 985999 5 darin 2014-03-01 15:25:21 -0800 Committed r164930: <http://trac.webkit.org/changeset/164930> 986498 6 225374 joepeck 2014-03-03 14:48:14 -0800 Comment on attachment 225374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225374&action=review > Websites/webkit.org/ChangeLog:17 > + over index iteration in vector iteration example and also showed use of unsigned rather than > + size_t since that is almost always what we want. Eliminated the use of PassOwnPtr in the "return Why is "unsigned rather than size_t" preferred? Shouldn't we match the type that the method / object produces? 225374 2014-02-27 09:03:42 -0800 2014-03-03 14:48:14 -0800 Patch bug-129427-20140227090341.patch text/plain 5836 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0ODA2CmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDk2NDlh YThiMDI2OGQzODgxZGI3NTI1ZGU3MzBjNGFjODhkMTcwMTkuLjdhMThhOGExZTE0MjA5MmJjYjAw OTdjZTRkMjBlMjk4MGIwZDQ5MDcgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTQtMDItMjcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAg IFNvbWUgc21hbGwgbW9kZXJuaXppbmcgdHdlYWtzIHRvIHRoZSBjb2Rpbmcgc3R5bGUgZ3VpZGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTQyNwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE15IGludGVu dCBoZXJlIHdhcyBvcmlnaW5hbGx5IHRvIGRvIHRoZSBudWxscHRyIHN0eWxlIGd1aWRlIHVwZGF0 ZSwgYnV0IHRoYXQgd2FzIGFscmVhZHkgZG9uZS4KKyAgICAgICAgSSBkaWQgc29tZSBvdGhlciBp bXByb3ZlbWVudHMuIFRoZXJlJ3Mgc3RpbGwgcXVpdGUgYSBiaXQgdG8gZG8gLS0gdGhlIGd1aWRl IGlzIG91dCBvZiBkYXRlIGluCisgICAgICAgIGEgbnVtYmVyIG9mIHN1YnRsZSB3YXlzLgorCisg ICAgICAgICogY29kaW5nL2NvZGluZy1zdHlsZS5odG1sOiBDaGFuZ2UgImxlZnQgc2lkZSBvcGVy YXRvciIgZXhhbXBsZSB0byBiZSBhIG1vcmUgbW9kZXJuIGV4YW1wbGUKKyAgICAgICAgd2l0aG91 dCBub24tV2ViS2l0LXN0eWxlIGFiYnJldmlhdGlvbnMgYW5kIHN1Y2guIFVzZSBhdXRvJiBpbnN0 ZWFkIG9mIGNvbnN0IGF1dG8mIGluIGZvciBsb29wCisgICAgICAgIGV4YW1wbGUsIHNpbmNlIHRo YXQncyBub3JtYWxseSBwcmVmZXJyZWQuIENoYW5nZWQgc2VjdGlvbiB0aXRsZSB0byBzYXkgInpl cm8iIGluc3RlYWQgb2YgIjAiLgorICAgICAgICBVc2Ugd29yZHMgaW5zdGVhZCBvZiBhYmJyZXZp YXRpb25zIGluIGNvZGUgZXhhbXBsZXMuIFNob3cgdGhhdCBhIG1vZGVybiBDKysgZm9yIGxvb3Ag aXMgcHJlZmVycmVkCisgICAgICAgIG92ZXIgaW5kZXggaXRlcmF0aW9uIGluIHZlY3RvciBpdGVy YXRpb24gZXhhbXBsZSBhbmQgYWxzbyBzaG93ZWQgdXNlIG9mIHVuc2lnbmVkIHJhdGhlciB0aGFu CisgICAgICAgIHNpemVfdCBzaW5jZSB0aGF0IGlzIGFsbW9zdCBhbHdheXMgd2hhdCB3ZSB3YW50 LiBFbGltaW5hdGVkIHRoZSB1c2Ugb2YgUGFzc093blB0ciBpbiB0aGUgInJldHVybgorICAgICAg ICBhIG5ld2x5IGNyZWF0ZWQgb2JqZWN0IiBleGFtcGxlLiBVc2UgcmVmZXJlbmNlcyBpbnN0ZWFk IG9mIHBvaW50ZXJzIGluIG9uZSBleGFtcGxlLgorCiAyMDE0LTAyLTI2ICBKdWxpZW4gQnJpYW5j ZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgogCiAgICAgICAgIEFkZCBDaXNjbyB0byB0ZWFtLmh0 bWwKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvY29kaW5nL2NvZGluZy1zdHlsZS5o dG1sIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKaW5kZXgg ZDI5ZjFlM2ExNmU2ZDBkYzc2MWIzNDIzNWY0YjUxNmQyMjQ3ZThlYS4uMTY5NGIyYjQ5N2IzNjA4 YjAyYjMzNjhiNTk0NGQ1ZDBlNGE5YTdiMSAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvd2Via2l0Lm9y Zy9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKKysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2Rp bmcvY29kaW5nLXN0eWxlLmh0bWwKQEAgLTEzOSwxOCArMTM5LDE2IEBAIGhhdmUgdGhlaXIgb3Bl cmF0b3JzIG9uIHRoZSBsZWZ0IHNpZGUgb2YgdGhlIGxpbmUgaW5zdGVhZCBvZiB0aGUgcmlnaHQg c2lkZS4KIAogPGg0IGNsYXNzPSJyaWdodCI+UmlnaHQ6PC9oND4KIDxwcmUgY2xhc3M9ImNvZGUi PgotaWYgKGF0dHItPm5hbWUoKSA9PSBzcmNBdHRyCi0gICAgfHwgYXR0ci0+bmFtZSgpID09IGxv d3NyY0F0dHIKLSAgICB8fCAoYXR0ci0+bmFtZSgpID09IHVzZW1hcEF0dHIgJiYgYXR0ci0+dmFs dWUoKS5kb21TdHJpbmcoKVswXSAhPSAnIycpKQotICAgIHJldHVybjsKK3JldHVybiBhdHRyaWJ1 dGUubmFtZSgpID09IHNyY0F0dHIKKyAgICB8fCBhdHRyaWJ1dGUubmFtZSgpID09IGxvd3NyY0F0 dHIKKyAgICB8fCAoYXR0cmlidXRlLm5hbWUoKSA9PSB1c2VtYXBBdHRyICZhbXA7JmFtcDsgYXR0 cmlidXRlLnZhbHVlKCkuc3RyaW5nKClbMF0gIT0gJyMnKTsKIDwvcHJlPgogCiA8aDQgY2xhc3M9 Indyb25nIj5Xcm9uZzo8L2g0PgogPHByZSBjbGFzcz0iY29kZSI+Ci1pZiAoYXR0ci0+bmFtZSgp ID09IHNyY0F0dHIgfHwKLSAgICBhdHRyLT5uYW1lKCkgPT0gbG93c3JjQXR0ciB8fAotICAgIChh dHRyLT5uYW1lKCkgPT0gdXNlbWFwQXR0ciAmJiBhdHRyLT52YWx1ZSgpLmRvbVN0cmluZygpWzBd ICE9ICcjJykpCi0gICAgcmV0dXJuOworcmV0dXJuIGF0dHJpYnV0ZS5uYW1lKCkgPT0gc3JjQXR0 ciB8fAorICAgIGF0dHJpYnV0ZS5uYW1lKCkgPT0gbG93c3JjQXR0ciB8fAorICAgIChhdHRyaWJ1 dGUubmFtZSgpID09IHVzZW1hcEF0dHIgJmFtcDsmYW1wOyBhdHRyLT52YWx1ZSgpLnN0cmluZygp WzBdICE9ICcjJyk7CiA8L3ByZT4KIDwvbGk+CiAKQEAgLTE5MiwxNCArMTkwLDE0IEBAIHJldHVy biBjb25kaXRpb24gPyAxOjA7CiA8aDQgY2xhc3M9InJpZ2h0Ij5SaWdodDo8L2g0PgogPHByZSBj bGFzcz0iY29kZSI+CiBWZWN0b3ImbHQ7UGx1Z2luTW9kdWxlSW5mbz4gcGx1Z2luczsKLWZvciAo Y29uc3QgYXV0byZhbXA7IHBsdWdpbiA6IHBsdWdpbnMpCitmb3IgKGF1dG8mYW1wOyBwbHVnaW4g OiBwbHVnaW5zKQogICAgIHJlZ2lzdGVyUGx1Z2luKHBsdWdpbik7CiA8L3ByZT4KIAogPGg0IGNs YXNzPSJ3cm9uZyI+V3Jvbmc6PC9oND4KIDxwcmUgY2xhc3M9ImNvZGUiPgogVmVjdG9yJmx0O1Bs dWdpbk1vZHVsZUluZm8+IHBsdWdpbnM7Ci1mb3IgKGNvbnN0IGF1dG8mYW1wOyBwbHVnaW46IHBs dWdpbnMpCitmb3IgKGF1dG8mYW1wOyBwbHVnaW46IHBsdWdpbnMpCiAgICAgcmVnaXN0ZXJQbHVn aW4ocGx1Z2luKTsKIDwvcHJlPgogPC9saT4KQEAgLTQyMSw3ICs0MTksNyBAQCBmb3IgKCA7IGN1 cnJlbnQ7IGN1cnJlbnQgPSBjdXJyZW50LT5uZXh0KTsKIDwvbGk+CiA8L29sPgogCi08aDMgaWQ9 Inplcm8iPk51bGwsIGZhbHNlIGFuZCAwPC9oMz4KKzxoMyBpZD0iemVybyI+TnVsbCwgZmFsc2Ug YW5kIHplcm88L2gzPgogPG9sPgogPGxpIGlkPSJ6ZXJvLW51bGwiPkluIEMrKywgdGhlIG51bGwg cG9pbnRlciB2YWx1ZSBzaG91bGQgYmUgd3JpdHRlbiBhcyA8Y29kZT5udWxscHRyPC9jb2RlPi4g SW4gQywgaXQgc2hvdWxkIGJlIHdyaXR0ZW4gYXMgPGNvZGU+TlVMTDwvY29kZT4uIEluIE9iamVj dGl2ZS1DIGFuZCBPYmplY3RpdmUtQysrLCBmb2xsb3cgdGhlIGd1aWRlbGluZSBmb3IgQyBvciBD KyssIHJlc3BlY3RpdmVseSwgYnV0IHVzZSA8Y29kZT5uaWw8L2NvZGU+IHRvIHJlcHJlc2VudCBh IG51bGwgT2JqZWN0aXZlLUMgb2JqZWN0LjwvbGk+CiAKQEAgLTcxNiwxMCArNzE0LDEwIEBAIGxp bmUsIHdpdGggdGhlIGNvbG9uIG9yIGNvbW1hIHByZWNlZGluZyB0aGUgbWVtYmVyIG9uIHRoYXQg bGluZS4KIAogPGg0IGNsYXNzPSJyaWdodCI+UmlnaHQ6PC9oND4KIDxwcmUgY2xhc3M9ImNvZGUi PgotTXlDbGFzczo6TXlDbGFzcyhEb2N1bWVudCogZG9jKQorTXlDbGFzczo6TXlDbGFzcyhEb2N1 bWVudCogZG9jdW1lbnQpCiAgICAgOiBNeVN1cGVyQ2xhc3MoKQogICAgICwgbV9teU1lbWJlcigw KQotICAgICwgbV9kb2MoZG9jKQorICAgICwgbV9kb2N1bWVudChkb2N1bWVudCkKIHsKIH0KIApA QCAtNzMxLDIxICs3MjksMjcgQEAgTXlPdGhlckNsYXNzOjpNeU90aGVyQ2xhc3MoKQogCiA8aDQg Y2xhc3M9Indyb25nIj5Xcm9uZzo8L2g0PgogPHByZSBjbGFzcz0iY29kZSI+Ci1NeUNsYXNzOjpN eUNsYXNzKERvY3VtZW50KiBkb2MpIDogTXlTdXBlckNsYXNzKCkKK015Q2xhc3M6Ok15Q2xhc3Mo RG9jdW1lbnQqIGRvY3VtZW50KSA6IE15U3VwZXJDbGFzcygpCiB7CiAgICAgbV9teU1lbWJlciA9 IDA7Ci0gICAgbV9kb2MgPSBkb2M7CisgICAgbV9kb2N1bWVudCA9IGRvY3VtZW50OwogfQogCiBN eU90aGVyQ2xhc3M6Ok15T3RoZXJDbGFzcygpIDogTXlTdXBlckNsYXNzKCkge30KIDwvcHJlPgog Ci08bGkgaWQ9InB1bmN0dWF0aW9uLXZlY3Rvci1pbmRleCI+UHJlZmVyIGluZGV4IG92ZXIgaXRl cmF0b3IgaW4gVmVjdG9yIGl0ZXJhdGlvbnMgZm9yIGEgdGVyc2UsIGVhc2llci10by1yZWFkIGNv ZGUuCis8bGkgaWQ9InB1bmN0dWF0aW9uLXZlY3Rvci1pbmRleCI+UHJlZmVyIGluZGV4IG92ZXIg aXRlcmF0b3IgaW4gVmVjdG9yIGl0ZXJhdGlvbnMgZm9yIHRlcnNlLCBlYXNpZXItdG8tcmVhZCBj b2RlLgogCiA8aDQgY2xhc3M9InJpZ2h0Ij5SaWdodDo8L2g0PgogPHByZSBjbGFzcz0iY29kZSI+ Ci1zaXplX3QgZnJhbWVWaWV3c0NvdW50ID0gZnJhbWVWaWV3cy5zaXplKCk7Ci1mb3IgKHNpemVf dCBpID0gMDsgaSAmbHQ7IGZyYW1lVmlld3NDb3VudDsgKytpKQorZm9yIChhdXRvJmFtcDsgZnJh bWVWaWV3IDogZnJhbWVWaWV3cykKKyAgICBmcmFtZVZpZXctPnVwZGF0ZUxheW91dEFuZFN0eWxl SWZOZWVkZWRSZWN1cnNpdmUoKTsKKzwvcHJlPgorCis8aDQgY2xhc3M9InJpZ2h0Ij5PSzo8L2g0 PgorPHByZSBjbGFzcz0iY29kZSI+Cit1bnNpZ25lZCBmcmFtZVZpZXdzQ291bnQgPSBmcmFtZVZp ZXdzLnNpemUoKTsKK2ZvciAodW5zaWduZWQgaSA9IDA7IGkgJmx0OyBmcmFtZVZpZXdzQ291bnQ7 ICsraSkKICAgICBmcmFtZVZpZXdzW2ldLT51cGRhdGVMYXlvdXRBbmRTdHlsZUlmTmVlZGVkUmVj dXJzaXZlKCk7CiA8L3ByZT4KIApAQCAtODU1LDcgKzg1OSw2IEBAIERvbid0IGJvdGhlciB0byBv cmdhbml6ZSB0aGVtIGluIGEgbG9naWNhbCBvcmRlci4KICNpbmNsdWRlICJBdHRyaWJ1dGUuaCIK ICNpbmNsdWRlICJIVE1MRWxlbWVudC5oIgogI2luY2x1ZGUgIlF1YWxpZmllZE5hbWUuaCIKLQog PC9wcmU+CiAKIDxoNCBjbGFzcz0id3JvbmciPldyb25nOjwvaDQ+CkBAIC0xMDk5LDcgKzExMDIs NyBAQCBwdWJsaWM6CiBjbGFzcyBWZWN0b3IgewogcHVibGljOgogICAgIGV4cGxpY2l0IFZlY3Rv cihpbnQgc2l6ZSk7IC8vIE5vdCBhIHR5cGUgY29udmVyc2lvbi4KLSAgICBQYXNzT3duUHRyJmx0 O1ZlY3RvciZndDsgY3JlYXRlKEFycmF5KTsgLy8gQ29zdGx5IGNvbnZlcnNpb24uCisgICAgVmVj dG9yIGNyZWF0ZShBcnJheSk7IC8vIENvc3RseSBjb252ZXJzaW9uLgogLi4uCiAKIDwvcHJlPgpA QCAtMTEwOCw5ICsxMTExLDkgQEAgcHVibGljOgogPHByZSBjbGFzcz0iY29kZSI+CiBjbGFzcyBU YXNrIHsKIHB1YmxpYzoKLSAgICBUYXNrKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqKTsgLy8gTm90 IGEgdHlwZSBjb252ZXJzaW9uLgorICAgIFRhc2soU2NyaXB0RXhlY3V0aW9uQ29udGV4dCZhbXA7 KTsgLy8gTm90IGEgdHlwZSBjb252ZXJzaW9uLgogICAgIGV4cGxpY2l0IFRhc2soKTsgLy8gTm8g YXJndW1lbnRzLgotICAgIGV4cGxpY2l0IFRhc2soU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIE90 aGVyKTsgLy8gTW9yZSB0aGFuIG9uZSBhcmd1bWVudC4KKyAgICBleHBsaWNpdCBUYXNrKFNjcmlw dEV4ZWN1dGlvbkNvbnRleHQmYW1wOywgT3RoZXIpOyAvLyBNb3JlIHRoYW4gb25lIGFyZ3VtZW50 LgogLi4uCiA8L3ByZT4KIDwvbGk+Cg==