129426 2014-02-27 08:50:33 -0800 Web Inspector: Enable breakpoints when adding or enabling a breakpoint 2014-02-28 14:48:50 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 985183 0 timothy 2014-02-27 08:50:33 -0800 Make adding a new breakpoint or enabling an existing breakpoint enable all breakpoints. <rdar://problem/15605961> 985184 1 225372 timothy 2014-02-27 08:52:36 -0800 Created attachment 225372 Patch 985713 2 225372 joepeck 2014-02-28 14:35:21 -0800 Comment on attachment 225372 Patch r=me 985719 3 225372 commit-queue 2014-02-28 14:48:48 -0800 Comment on attachment 225372 Patch Clearing flags on attachment: 225372 Committed r164885: <http://trac.webkit.org/changeset/164885> 985720 4 commit-queue 2014-02-28 14:48:50 -0800 All reviewed patches have been landed. Closing bug. 225372 2014-02-27 08:52:36 -0800 2014-02-28 14:48:48 -0800 Patch bug-129426-20140227085236.patch text/plain 5830 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl YTM3NmRkYmM0YTYzMTg4NTEyMDg3ZmUyNjg2OGY4Y2RmM2NhMWI0Li4zZmFiZGU1MTMyOTcwOWMy NTY3MTdmOWVjOWE2ZDdkNDM4YmY4MDBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNC0wMi0yNyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgRW5hYmxlIGJyZWFrcG9pbnRzIHdoZW4gYWRkaW5nIGEgbmV3IGJyZWFr cG9pbnQgb3IgZW5hYmxpbmcgYW4gZXhpc3RpbmcgYnJlYWtwb2ludC4KKworICAgICAgICBUaGlz IGVsaW1pbmF0ZXMgYSBtdWx0aS1zdGVwIHByb2Nlc3MgZm9yIHRoZSB1c2VyIHRoYXQgY2FuIGJl IGNvbmZ1c2luZy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI5NDI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RlYnVnZ2VyTWFuYWdlci5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5EZWJ1Z2dlck1hbmFnZXIucHJvdG90eXBlLnNldCBicmVha3Bv aW50c0VuYWJsZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdlci5wcm90 b3R5cGUuX2JyZWFrcG9pbnREaXNhYmxlZFN0YXRlRGlkQ2hhbmdlKToKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkRlYnVnZ2VyU2lkZWJhclBhbmVsKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EZWJ1 Z2dlclNpZGViYXJQYW5lbC5wcm90b3R5cGUuX2JyZWFrcG9pbnRzRW5hYmxlZERpZENoYW5nZSk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9i cmVha3BvaW50c1RvZ2dsZUJ1dHRvbkNsaWNrZWQpOgorCiAyMDE0LTAyLTI2ICBUaW1vdGh5IEhh dGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggYW4gaXNzdWUgd2hlcmUg dGhlIFRpbWVsaW5lIGZpbHRlciBzY29wZSBiYXJzIHdlcmUgbm90IGFwcGx5aW5nLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRGVi dWdnZXJNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29u dHJvbGxlcnMvRGVidWdnZXJNYW5hZ2VyLmpzCmluZGV4IDJjZmE0N2M3MjA2OWJhNGMzNTc0MjA4 MjU4Mjc0ODI1ZWQyZTgzY2QuLmFkZTc1ODIyZmQ4YmM5YTMxMzliNWQxODQ4YzZhYjdhMzdmM2Zh ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRy b2xsZXJzL0RlYnVnZ2VyTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9EZWJ1Z2dlck1hbmFnZXIuanMKQEAgLTg1LDcgKzg1LDgg QEAgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdlci5FdmVudCA9IHsKICAgICBDYWxsRnJhbWVz RGlkQ2hhbmdlOiAiZGVidWdnZXItbWFuYWdlci1jYWxsLWZyYW1lcy1kaWQtY2hhbmdlIiwKICAg ICBBY3RpdmVDYWxsRnJhbWVEaWRDaGFuZ2U6ICJkZWJ1Z2dlci1tYW5hZ2VyLWFjdGl2ZS1jYWxs LWZyYW1lLWRpZC1jaGFuZ2UiLAogICAgIFNjcmlwdEFkZGVkOiAiZGVidWdnZXItbWFuYWdlci1z Y3JpcHQtYWRkZWQiLAotICAgIFNjcmlwdHNDbGVhcmVkOiAiZGVidWdnZXItbWFuYWdlci1zY3Jp cHRzLWNsZWFyZWQiCisgICAgU2NyaXB0c0NsZWFyZWQ6ICJkZWJ1Z2dlci1tYW5hZ2VyLXNjcmlw dHMtY2xlYXJlZCIsCisgICAgQnJlYWtwb2ludHNFbmFibGVkRGlkQ2hhbmdlOiAiZGVidWdnZXIt bWFuYWdlci1icmVha3BvaW50cy1lbmFibGVkLWRpZC1jaGFuZ2UiCiB9OwogCiBXZWJJbnNwZWN0 b3IuRGVidWdnZXJNYW5hZ2VyLnByb3RvdHlwZSA9IHsKQEAgLTEwNSw2ICsxMDYsOCBAQCBXZWJJ bnNwZWN0b3IuRGVidWdnZXJNYW5hZ2VyLnByb3RvdHlwZSA9IHsKIAogICAgICAgICB0aGlzLl9i cmVha3BvaW50c0VuYWJsZWRTZXR0aW5nLnZhbHVlID0gZW5hYmxlZDsKIAorICAgICAgICB0aGlz LmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuRGVidWdnZXJNYW5hZ2VyLkV2 ZW50LkJyZWFrcG9pbnRzRW5hYmxlZERpZENoYW5nZSk7CisKICAgICAgICAgdGhpcy5fYWxsRXhj ZXB0aW9uc0JyZWFrcG9pbnQuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5C cmVha3BvaW50LkV2ZW50LlJlc29sdmVkU3RhdGVEaWRDaGFuZ2UpOwogICAgICAgICB0aGlzLl9h bGxVbmNhdWdodEV4Y2VwdGlvbnNCcmVha3BvaW50LmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhX ZWJJbnNwZWN0b3IuQnJlYWtwb2ludC5FdmVudC5SZXNvbHZlZFN0YXRlRGlkQ2hhbmdlKTsKIApA QCAtNTE3LDYgKzUyMCwxMCBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJNYW5hZ2VyLnByb3RvdHlw ZSA9IHsKICAgICAgICAgaWYgKGJyZWFrcG9pbnQuaWRlbnRpZmllciB8fCBicmVha3BvaW50LmRp c2FibGVkKQogICAgICAgICAgICAgcmV0dXJuOwogCisgICAgICAgIC8vIEVuYWJsZSBicmVha3Bv aW50cyBzaW5jZSBhIGJyZWFrcG9pbnQgaXMgYmVpbmcgc2V0LiBUaGlzIGVsaW1pbmF0ZXMKKyAg ICAgICAgLy8gYSBtdWx0aS1zdGVwIHByb2Nlc3MgZm9yIHRoZSB1c2VyIHRoYXQgY2FuIGJlIGNv bmZ1c2luZy4KKyAgICAgICAgdGhpcy5icmVha3BvaW50c0VuYWJsZWQgPSB0cnVlOworCiAgICAg ICAgIGZ1bmN0aW9uIGRpZFNldEJyZWFrcG9pbnQoZXJyb3IsIGJyZWFrcG9pbnRJZGVudGlmaWVy KQogICAgICAgICB7CiAgICAgICAgICAgICBpZiAoZXJyb3IpCkBAIC02MTYsMTIgKzYyMywxNiBA QCBXZWJJbnNwZWN0b3IuRGVidWdnZXJNYW5hZ2VyLnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFy IGJyZWFrcG9pbnQgPSBldmVudC50YXJnZXQ7CiAKICAgICAgICAgaWYgKGJyZWFrcG9pbnQgPT09 IHRoaXMuX2FsbEV4Y2VwdGlvbnNCcmVha3BvaW50KSB7CisgICAgICAgICAgICBpZiAoIWJyZWFr cG9pbnQuZGlzYWJsZWQpCisgICAgICAgICAgICAgICAgdGhpcy5icmVha3BvaW50c0VuYWJsZWQg PSB0cnVlOwogICAgICAgICAgICAgdGhpcy5fYWxsRXhjZXB0aW9uc0JyZWFrcG9pbnRFbmFibGVk U2V0dGluZy52YWx1ZSA9ICFicmVha3BvaW50LmRpc2FibGVkOwogICAgICAgICAgICAgdGhpcy5f dXBkYXRlQnJlYWtPbkV4Y2VwdGlvbnNTdGF0ZSgpOwogICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICB9CiAKICAgICAgICAgaWYgKGJyZWFrcG9pbnQgPT09IHRoaXMuX2FsbFVuY2F1Z2h0RXhj ZXB0aW9uc0JyZWFrcG9pbnQpIHsKKyAgICAgICAgICAgIGlmICghYnJlYWtwb2ludC5kaXNhYmxl ZCkKKyAgICAgICAgICAgICAgICB0aGlzLmJyZWFrcG9pbnRzRW5hYmxlZCA9IHRydWU7CiAgICAg ICAgICAgICB0aGlzLl9hbGxVbmNhdWdodEV4Y2VwdGlvbnNCcmVha3BvaW50RW5hYmxlZFNldHRp bmcudmFsdWUgPSAhYnJlYWtwb2ludC5kaXNhYmxlZDsKICAgICAgICAgICAgIHRoaXMuX3VwZGF0 ZUJyZWFrT25FeGNlcHRpb25zU3RhdGUoKTsKICAgICAgICAgICAgIHJldHVybjsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lk ZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv RGVidWdnZXJTaWRlYmFyUGFuZWwuanMKaW5kZXggYTQ1ODkxNDU0ZTcyYzBmNGUzZDVkNzllYjY5 ZTZiNTUwZTA0MjcxYS4uMmQ1OGFiZTk1ZTQ4MmEzNjlmNjY5NmI1YjEwNjg5OGMzODY2ZmMxYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGVi dWdnZXJTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanMKQEAgLTMwLDYgKzMwLDcgQEAgV2Vi SW5zcGVjdG9yLkRlYnVnZ2VyU2lkZWJhclBhbmVsID0gZnVuY3Rpb24oKQogICAgIFdlYkluc3Bl Y3Rvci5GcmFtZS5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5GcmFtZS5FdmVudC5NYWlu UmVzb3VyY2VEaWRDaGFuZ2UsIHRoaXMuX21haW5SZXNvdXJjZUNoYW5nZWQsIHRoaXMpOwogICAg IFdlYkluc3BlY3Rvci5GcmFtZS5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5GcmFtZS5F dmVudC5SZXNvdXJjZVdhc0FkZGVkLCB0aGlzLl9yZXNvdXJjZUFkZGVkLCB0aGlzKTsKIAorICAg IFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFnZXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0 b3IuRGVidWdnZXJNYW5hZ2VyLkV2ZW50LkJyZWFrcG9pbnRzRW5hYmxlZERpZENoYW5nZSwgdGhp cy5fYnJlYWtwb2ludHNFbmFibGVkRGlkQ2hhbmdlLCB0aGlzKTsKICAgICBXZWJJbnNwZWN0b3Iu ZGVidWdnZXJNYW5hZ2VyLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFu YWdlci5FdmVudC5DYWxsRnJhbWVzRGlkQ2hhbmdlLCB0aGlzLl9kZWJ1Z2dlckNhbGxGcmFtZXNE aWRDaGFuZ2UsIHRoaXMpOwogICAgIFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFnZXIuYWRkRXZl bnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRGVidWdnZXJNYW5hZ2VyLkV2ZW50LkJyZWFrcG9pbnRB ZGRlZCwgdGhpcy5fYnJlYWtwb2ludEFkZGVkLCB0aGlzKTsKICAgICBXZWJJbnNwZWN0b3IuZGVi dWdnZXJNYW5hZ2VyLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdl ci5FdmVudC5CcmVha3BvaW50UmVtb3ZlZCwgdGhpcy5fYnJlYWtwb2ludFJlbW92ZWQsIHRoaXMp OwpAQCAtMjE5LDEwICsyMjAsMTQgQEAgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyU2lkZWJhclBhbmVs LnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5fZGVidWdnZXJTdGVwT3V0QnV0dG9uSXRlbS5l bmFibGVkID0gZmFsc2U7CiAgICAgfSwKIAorICAgIF9icmVha3BvaW50c0VuYWJsZWREaWRDaGFu Z2U6IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgdGhpcy5fZGVidWdnZXJCcmVha3Bv aW50c0J1dHRvbkl0ZW0uYWN0aXZhdGVkID0gV2ViSW5zcGVjdG9yLmRlYnVnZ2VyTWFuYWdlci5i cmVha3BvaW50c0VuYWJsZWQ7CisgICAgfSwKKwogICAgIF9icmVha3BvaW50c1RvZ2dsZUJ1dHRv bkNsaWNrZWQ6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKLSAgICAgICAgdGhpcy5fZGVidWdnZXJC cmVha3BvaW50c0J1dHRvbkl0ZW0uYWN0aXZhdGVkID0gIXRoaXMuX2RlYnVnZ2VyQnJlYWtwb2lu dHNCdXR0b25JdGVtLmFjdGl2YXRlZDsKLSAgICAgICAgV2ViSW5zcGVjdG9yLmRlYnVnZ2VyTWFu YWdlci5icmVha3BvaW50c0VuYWJsZWQgPSB0aGlzLl9kZWJ1Z2dlckJyZWFrcG9pbnRzQnV0dG9u SXRlbS5hY3RpdmF0ZWQ7CisgICAgICAgIFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFnZXIuYnJl YWtwb2ludHNFbmFibGVkID0gIXRoaXMuX2RlYnVnZ2VyQnJlYWtwb2ludHNCdXR0b25JdGVtLmFj dGl2YXRlZDsKICAgICB9LAogCiAgICAgX2FkZEJyZWFrcG9pbnQ6IGZ1bmN0aW9uKGJyZWFrcG9p bnQsIHNvdXJjZUNvZGUpCg==