129421 2014-02-27 05:12:35 -0800 [ATK] Fix style errors in enum members 2014-02-27 06:16:47 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Linux RESOLVED FIXED InRadar P2 Normal --- 1 k.czech webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 985108 0 k.czech 2014-02-27 05:12:35 -0800 enum members should use InterCaps with an initial capital letter 985109 1 webkit-bug-importer 2014-02-27 05:13:09 -0800 <rdar://problem/16183788> 985111 2 225358 k.czech 2014-02-27 05:16:01 -0800 Created attachment 225358 patch 985113 3 225358 mario 2014-02-27 05:21:49 -0800 Comment on attachment 225358 patch This is a no-brainer :). Thanks! 985138 4 225358 commit-queue 2014-02-27 06:16:43 -0800 Comment on attachment 225358 patch Clearing flags on attachment: 225358 Committed r164802: <http://trac.webkit.org/changeset/164802> 985139 5 commit-queue 2014-02-27 06:16:47 -0800 All reviewed patches have been landed. Closing bug. 225358 2014-02-27 05:16:01 -0800 2014-02-27 06:16:43 -0800 patch a11y-fixstyleerrors.patch text/plain 6048 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2YTkwNDA5Li5lM2M4MTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTQtMDItMjcgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CiAK KyAgICAgICAgW0FUS10gRml4IHN0eWxlIGVycm9ycyBpbiBlbnVtIG1lbWJlcnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTQyMQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8g bmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgRW51bSBtZW1iZXJzIHNob3VsZCB1c2UgSW50 ZXJDYXBzIHdpdGggYW4gaW5pdGlhbCBjYXBpdGFsIGxldHRlci4KKworICAgICAgICAqIGFjY2Vz c2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcDoKKyAgICAgICAgKGdl dEludGVyZmFjZU1hc2tGcm9tT2JqZWN0KToKKworMjAxNC0wMi0yNyAgS3J6eXN6dG9mIEN6ZWNo ICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KKwogICAgICAgICBbQVRLXSBVdGlsaXplIEF0a1RhYmxl Q2VsbCB0byBleHBvc2UgZGlyZWN0bHkgQWNjZXNzaWJpbGl0eVRhYmxlQ2VsbCB0byBBVAogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MjUwCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2li bGVXcmFwcGVyQXRrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktp dEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcAppbmRleCA5ZWQ1Yzc4Li4wYzM4YWEzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3Jh cHBlckF0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0 QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwCkBAIC0xMDY0LDUwICsxMDY0LDUwIEBAIHN0YXRpYyBj b25zdCBHSW50ZXJmYWNlSW5mbyBBdGtJbnRlcmZhY2VzSW5pdEZ1bmN0aW9uc1tdID0gewogfTsK IAogZW51bSBXQUlUeXBlIHsKLSAgICBXQUlfQUNUSU9OLAotICAgIFdBSV9TRUxFQ1RJT04sCi0g ICAgV0FJX0VESVRBQkxFX1RFWFQsCi0gICAgV0FJX1RFWFQsCi0gICAgV0FJX0NPTVBPTkVOVCwK LSAgICBXQUlfSU1BR0UsCi0gICAgV0FJX1RBQkxFLAorICAgIFdBSUFjdGlvbiwKKyAgICBXQUlT ZWxlY3Rpb24sCisgICAgV0FJRWRpdGFibGVUZXh0LAorICAgIFdBSVRleHQsCisgICAgV0FJQ29t cG9uZW50LAorICAgIFdBSUltYWdlLAorICAgIFdBSVRhYmxlLAogI2lmIEFUS19DSEVDS19WRVJT SU9OKDIsMTEsOTApCi0gICAgV0FJX1RBQkxFX0NFTEwsCisgICAgV0FJVGFibGVDZWxsLAogI2Vu ZGlmCi0gICAgV0FJX0hZUEVSVEVYVCwKLSAgICBXQUlfSFlQRVJMSU5LLAotICAgIFdBSV9ET0NV TUVOVCwKLSAgICBXQUlfVkFMVUUsCisgICAgV0FJSHlwZXJ0ZXh0LAorICAgIFdBSUh5cGVybGlu aywKKyAgICBXQUlEb2N1bWVudCwKKyAgICBXQUlWYWx1ZSwKIH07CiAKIHN0YXRpYyBHVHlwZSBH ZXRBdGtJbnRlcmZhY2VUeXBlRnJvbVdBSVR5cGUoV0FJVHlwZSB0eXBlKQogewogICAgIHN3aXRj aCAodHlwZSkgewotICAgIGNhc2UgV0FJX0FDVElPTjoKKyAgICBjYXNlIFdBSUFjdGlvbjoKICAg ICAgICAgcmV0dXJuIEFUS19UWVBFX0FDVElPTjsKLSAgICBjYXNlIFdBSV9TRUxFQ1RJT046Cisg ICAgY2FzZSBXQUlTZWxlY3Rpb246CiAgICAgICAgIHJldHVybiBBVEtfVFlQRV9TRUxFQ1RJT047 Ci0gICAgY2FzZSBXQUlfRURJVEFCTEVfVEVYVDoKKyAgICBjYXNlIFdBSUVkaXRhYmxlVGV4dDoK ICAgICAgICAgcmV0dXJuIEFUS19UWVBFX0VESVRBQkxFX1RFWFQ7Ci0gICAgY2FzZSBXQUlfVEVY VDoKKyAgICBjYXNlIFdBSVRleHQ6CiAgICAgICAgIHJldHVybiBBVEtfVFlQRV9URVhUOwotICAg IGNhc2UgV0FJX0NPTVBPTkVOVDoKKyAgICBjYXNlIFdBSUNvbXBvbmVudDoKICAgICAgICAgcmV0 dXJuIEFUS19UWVBFX0NPTVBPTkVOVDsKLSAgICBjYXNlIFdBSV9JTUFHRToKKyAgICBjYXNlIFdB SUltYWdlOgogICAgICAgICByZXR1cm4gQVRLX1RZUEVfSU1BR0U7Ci0gICAgY2FzZSBXQUlfVEFC TEU6CisgICAgY2FzZSBXQUlUYWJsZToKICAgICAgICAgcmV0dXJuIEFUS19UWVBFX1RBQkxFOwog I2lmIEFUS19DSEVDS19WRVJTSU9OKDIsMTEsOTApCi0gICAgY2FzZSBXQUlfVEFCTEVfQ0VMTDoK KyAgICBjYXNlIFdBSVRhYmxlQ2VsbDoKICAgICAgICAgcmV0dXJuIEFUS19UWVBFX1RBQkxFX0NF TEw7CiAjZW5kaWYKLSAgICBjYXNlIFdBSV9IWVBFUlRFWFQ6CisgICAgY2FzZSBXQUlIeXBlcnRl eHQ6CiAgICAgICAgIHJldHVybiBBVEtfVFlQRV9IWVBFUlRFWFQ7Ci0gICAgY2FzZSBXQUlfSFlQ RVJMSU5LOgorICAgIGNhc2UgV0FJSHlwZXJsaW5rOgogICAgICAgICByZXR1cm4gQVRLX1RZUEVf SFlQRVJMSU5LX0lNUEw7Ci0gICAgY2FzZSBXQUlfRE9DVU1FTlQ6CisgICAgY2FzZSBXQUlEb2N1 bWVudDoKICAgICAgICAgcmV0dXJuIEFUS19UWVBFX0RPQ1VNRU5UOwotICAgIGNhc2UgV0FJX1ZB TFVFOgorICAgIGNhc2UgV0FJVmFsdWU6CiAgICAgICAgIHJldHVybiBBVEtfVFlQRV9WQUxVRTsK ICAgICB9CiAKQEAgLTExMjQsNyArMTEyNCw3IEBAIHN0YXRpYyBndWludDE2IGdldEludGVyZmFj ZU1hc2tGcm9tT2JqZWN0KEFjY2Vzc2liaWxpdHlPYmplY3QqIGNvcmVPYmplY3QpCiAgICAgZ3Vp bnQxNiBpbnRlcmZhY2VNYXNrID0gMDsKIAogICAgIC8vIENvbXBvbmVudCBpbnRlcmZhY2UgaXMg YWx3YXlzIHN1cHBvcnRlZAotICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlfQ09NUE9ORU5U OworICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlDb21wb25lbnQ7CiAKICAgICBBY2Nlc3Np YmlsaXR5Um9sZSByb2xlID0gY29yZU9iamVjdC0+cm9sZVZhbHVlKCk7CiAKQEAgLTExMzQsMTEg KzExMzQsMTEgQEAgc3RhdGljIGd1aW50MTYgZ2V0SW50ZXJmYWNlTWFza0Zyb21PYmplY3QoQWNj ZXNzaWJpbGl0eU9iamVjdCogY29yZU9iamVjdCkKICAgICAvLyBvYmplY3QsIGFuZCBvbmx5IHN1 cHBvcnRzIGhhdmluZyBvbmUgYWN0aW9uIHBlciBvYmplY3QpLCBpdCBpcwogICAgIC8vIGJldHRl ciBqdXN0IHRvIGltcGxlbWVudCB0aGlzIGludGVyZmFjZSBmb3IgZXZlcnkgaW5zdGFuY2Ugb2YK ICAgICAvLyB0aGUgV2ViS2l0QWNjZXNzaWJsZSBjbGFzcyBhbmQgbGV0IFdlYkNvcmUgZGVjaWRl IHdoYXQgdG8gZG8uCi0gICAgaW50ZXJmYWNlTWFzayB8PSAxIDw8IFdBSV9BQ1RJT047CisgICAg aW50ZXJmYWNlTWFzayB8PSAxIDw8IFdBSUFjdGlvbjsKIAogICAgIC8vIFNlbGVjdGlvbgogICAg IGlmIChjb3JlT2JqZWN0LT5pc0xpc3RCb3goKSB8fCBjb3JlT2JqZWN0LT5pc01lbnVMaXN0KCkp Ci0gICAgICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlfU0VMRUNUSU9OOworICAgICAgICBp bnRlcmZhY2VNYXNrIHw9IDEgPDwgV0FJU2VsZWN0aW9uOwogCiAgICAgLy8gR2V0IHJlbmRlcmVy IGlmIGF2YWlsYWJsZS4KICAgICBSZW5kZXJPYmplY3QqIHJlbmRlcmVyID0gMDsKQEAgLTExNDcs MjEgKzExNDcsMjEgQEAgc3RhdGljIGd1aW50MTYgZ2V0SW50ZXJmYWNlTWFza0Zyb21PYmplY3Qo QWNjZXNzaWJpbGl0eU9iamVjdCogY29yZU9iamVjdCkKIAogICAgIC8vIEh5cGVybGluayAobGlu a3MgYW5kIGVtYmVkZGVkIG9iamVjdHMpLgogICAgIGlmIChjb3JlT2JqZWN0LT5pc0xpbmsoKSB8 fCAocmVuZGVyZXIgJiYgcmVuZGVyZXItPmlzUmVwbGFjZWQoKSkpCi0gICAgICAgIGludGVyZmFj ZU1hc2sgfD0gMSA8PCBXQUlfSFlQRVJMSU5LOworICAgICAgICBpbnRlcmZhY2VNYXNrIHw9IDEg PDwgV0FJSHlwZXJsaW5rOwogCiAgICAgLy8gVGV4dCAmIEVkaXRhYmxlIFRleHQKICAgICBpZiAo cm9sZSA9PSBTdGF0aWNUZXh0Um9sZSB8fCBjb3JlT2JqZWN0LT5pc01lbnVMaXN0T3B0aW9uKCkp Ci0gICAgICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlfVEVYVDsKKyAgICAgICAgaW50ZXJm YWNlTWFzayB8PSAxIDw8IFdBSVRleHQ7CiAgICAgZWxzZSB7CiAgICAgICAgIGlmIChjb3JlT2Jq ZWN0LT5pc1RleHRDb250cm9sKCkpIHsKLSAgICAgICAgICAgIGludGVyZmFjZU1hc2sgfD0gMSA8 PCBXQUlfVEVYVDsKKyAgICAgICAgICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlUZXh0Owog ICAgICAgICAgICAgaWYgKCFjb3JlT2JqZWN0LT5pc1JlYWRPbmx5KCkpCi0gICAgICAgICAgICAg ICAgaW50ZXJmYWNlTWFzayB8PSAxIDw8IFdBSV9FRElUQUJMRV9URVhUOworICAgICAgICAgICAg ICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlFZGl0YWJsZVRleHQ7CiAgICAgICAgIH0gZWxz ZSB7CiAgICAgICAgICAgICBpZiAocm9sZSAhPSBUYWJsZVJvbGUpIHsKLSAgICAgICAgICAgICAg ICBpbnRlcmZhY2VNYXNrIHw9IDEgPDwgV0FJX0hZUEVSVEVYVDsKKyAgICAgICAgICAgICAgICBp bnRlcmZhY2VNYXNrIHw9IDEgPDwgV0FJSHlwZXJ0ZXh0OwogICAgICAgICAgICAgICAgIGlmICgo cmVuZGVyZXIgJiYgcmVuZGVyZXItPmNoaWxkcmVuSW5saW5lKCkpIHx8IHJvbGVJc1RleHRUeXBl KHJvbGUpKQotICAgICAgICAgICAgICAgICAgICBpbnRlcmZhY2VNYXNrIHw9IDEgPDwgV0FJX1RF WFQ7CisgICAgICAgICAgICAgICAgICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlUZXh0Owog ICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAvLyBBZGQgdGhlIFRFWFQgaW50ZXJmYWNlIGZv ciBsaXN0IGl0ZW1zIHdob3NlCkBAIC0xMTc4LDI5ICsxMTc4LDI5IEBAIHN0YXRpYyBndWludDE2 IGdldEludGVyZmFjZU1hc2tGcm9tT2JqZWN0KEFjY2Vzc2liaWxpdHlPYmplY3QqIGNvcmVPYmpl Y3QpCiAKICAgICAvLyBJbWFnZQogICAgIGlmIChjb3JlT2JqZWN0LT5pc0ltYWdlKCkpCi0gICAg ICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlfSU1BR0U7CisgICAgICAgIGludGVyZmFjZU1h c2sgfD0gMSA8PCBXQUlJbWFnZTsKIAogICAgIC8vIFRhYmxlCiAgICAgaWYgKHJvbGUgPT0gVGFi bGVSb2xlKQotICAgICAgICBpbnRlcmZhY2VNYXNrIHw9IDEgPDwgV0FJX1RBQkxFOworICAgICAg ICBpbnRlcmZhY2VNYXNrIHw9IDEgPDwgV0FJVGFibGU7CiAKICNpZiBBVEtfQ0hFQ0tfVkVSU0lP TigyLDExLDkwKQogICAgIGlmIChyb2xlID09IENlbGxSb2xlKQotICAgICAgICBpbnRlcmZhY2VN YXNrIHw9IDEgPDwgV0FJX1RBQkxFX0NFTEw7CisgICAgICAgIGludGVyZmFjZU1hc2sgfD0gMSA8 PCBXQUlUYWJsZUNlbGw7CiAjZW5kaWYKIAogICAgIC8vIERvY3VtZW50CiAgICAgaWYgKHJvbGUg PT0gV2ViQXJlYVJvbGUpCi0gICAgICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlfRE9DVU1F TlQ7CisgICAgICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlEb2N1bWVudDsKIAogICAgIC8v IFZhbHVlCiAgICAgaWYgKHJvbGUgPT0gU2xpZGVyUm9sZSB8fCByb2xlID09IFNwaW5CdXR0b25S b2xlIHx8IHJvbGUgPT0gU2Nyb2xsQmFyUm9sZSB8fCByb2xlID09IFByb2dyZXNzSW5kaWNhdG9y Um9sZSkKLSAgICAgICAgaW50ZXJmYWNlTWFzayB8PSAxIDw8IFdBSV9WQUxVRTsKKyAgICAgICAg aW50ZXJmYWNlTWFzayB8PSAxIDw8IFdBSVZhbHVlOwogCiAjaWYgRU5BQkxFKElOUFVUX1RZUEVf Q09MT1IpCiAgICAgLy8gQ29sb3IgdHlwZS4KICAgICBpZiAocm9sZSA9PSBDb2xvcldlbGxSb2xl KQotICAgICAgICBpbnRlcmZhY2VNYXNrIHw9IDEgPDwgV0FJX1RFWFQ7CisgICAgICAgIGludGVy ZmFjZU1hc2sgfD0gMSA8PCBXQUlUZXh0OwogI2VuZGlmCiAKICAgICByZXR1cm4gaW50ZXJmYWNl TWFzazsK