129420 2014-02-27 05:03:12 -0800 Incorrect V_JITOperation_EJ call implementation in DFG for 32-bit ports. 2014-02-27 10:42:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 jbriance webkit-unassigned commit-queue ggaren mark.lam ossy rgabor yong.li.webkit zherczeg oldest_to_newest 985103 0 jbriance 2014-02-27 05:03:12 -0800 r162652 (http://trac.webkit.org/changeset/162652) introduced V_JITOperation_EJ prototype. Its implementation seems to be incorrect for 32-bit ports. 985105 1 225357 jbriance 2014-02-27 05:09:15 -0800 Created attachment 225357 Fix V_JITOperation_EJ call implementation in DFG for 32-bit ports. 985114 2 zherczeg 2014-02-27 05:23:03 -0800 Was this a speculative fix? 985116 3 jbriance 2014-02-27 05:26:05 -0800 (In reply to comment #2) > Was this a speculative fix? Yes, I only checked compilation. I'm going to retrieve my env to launch run-layout-jsc tests on my arm traditional board. 985123 4 jbriance 2014-02-27 05:48:50 -0800 (In reply to comment #3) > Yes, I only checked compilation. I'm going to retrieve my env to launch run-layout-jsc tests on my arm traditional board. run-layout-jsc reports the same results on my board with and without this patch: not better, not worse. 985130 5 zherczeg 2014-02-27 06:02:29 -0800 > run-layout-jsc reports the same results on my board with and without this patch: not better, not worse. Interesting. So this patch is needed or not? I suspect this code is not triggered. 985133 6 jbriance 2014-02-27 06:08:08 -0800 (In reply to comment #5) > > run-layout-jsc reports the same results on my board with and without this patch: not better, not worse. > > Interesting. So this patch is needed or not? I suspect this code is not triggered. You're right. If I remove this function, compilation is still ok so it's not even compiled actually :) What's the best choice, removing it or fixing it in case we'd need it later? 985137 7 zherczeg 2014-02-27 06:16:06 -0800 I think we should trigger it somehow, otherwise we don't know whether the fix is correct :( 985154 8 jbriance 2014-02-27 07:40:42 -0800 (In reply to comment #7) > I think we should trigger it somehow, otherwise we don't know whether the fix is correct :( As it's like http://trac.webkit.org/changeset/157797 for the tag/payload swap, I'm pretty sure the fix is correct. However if the code is not compiled, I won't be opposed to just remove it. 985171 9 225357 yong.li.webkit 2014-02-27 08:05:58 -0800 Comment on attachment 225357 Fix V_JITOperation_EJ call implementation in DFG for 32-bit ports. Looks right to me 985172 10 225357 yong.li.webkit 2014-02-27 08:08:46 -0800 Comment on attachment 225357 Fix V_JITOperation_EJ call implementation in DFG for 32-bit ports. Withdraw r+. A test case should have helped to find this problem. 985223 11 225357 ggaren 2014-02-27 10:11:20 -0800 Comment on attachment 225357 Fix V_JITOperation_EJ call implementation in DFG for 32-bit ports. r=me 985240 12 225357 commit-queue 2014-02-27 10:42:23 -0800 Comment on attachment 225357 Fix V_JITOperation_EJ call implementation in DFG for 32-bit ports. Clearing flags on attachment: 225357 Committed r164813: <http://trac.webkit.org/changeset/164813> 985241 13 commit-queue 2014-02-27 10:42:26 -0800 All reviewed patches have been landed. Closing bug. 225357 2014-02-27 05:09:15 -0800 2014-02-27 10:42:23 -0800 Fix V_JITOperation_EJ call implementation in DFG for 32-bit ports. bug-129420.patch text/plain 1352 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0Nzk0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTAyLTI3ICBKdWxpZW4gQnJpYW5jZWF1ICAgPGpicmlhbmNlQGNpc2NvLmNvbT4KKwor ICAgICAgICBGaXggMzItYml0IFZfSklUT3BlcmF0aW9uX0VKIGNhbGxPcGVyYXRpb24gaW50cm9k dWNlZCBpbiByMTYyNjUyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI5NDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuaDoKKyAgICAgICAgKEpTQzo6REZHOjpT cGVjdWxhdGl2ZUpJVDo6Y2FsbE9wZXJhdGlvbik6IFBheWxvYWQgYW5kIHRhZyBhcmUgc3dhcHBl ZC4KKyAgICAgICAgQWxzbywgRUFCSV8zMkJJVF9EVU1NWV9BUkcgaXMgbWlzc2luZyBmb3IgYXJt IEVBQkkgYW5kIG1pcHMuCisKIDIwMTQtMDItMjcgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5i ZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICByMTY0NzY0IGJyb2tlIHRoZSBBUk0gYnVpbGQKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgJKHJl dmlzaW9uIDE2NDc5MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRp dmVKSVQuaAkod29ya2luZyBjb3B5KQpAQCAtMTY0MCw3ICsxNjQwLDcgQEAgcHVibGljOgogCiAg ICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbE9wZXJhdGlvbihWX0pJVE9wZXJhdGlvbl9FSiBvcGVy YXRpb24sIEdQUlJlZyBhcmcxVGFnLCBHUFJSZWcgYXJnMVBheWxvYWQpCiAgICAgewotICAgICAg ICBtX2ppdC5zZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoYXJnMVRhZywgYXJnMVBheWxvYWQp OworICAgICAgICBtX2ppdC5zZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoRUFCSV8zMkJJVF9E VU1NWV9BUkcgYXJnMVBheWxvYWQsIGFyZzFUYWcpOwogICAgICAgICByZXR1cm4gYXBwZW5kQ2Fs bFdpdGhFeGNlcHRpb25DaGVjayhvcGVyYXRpb24pOwogICAgIH0KIAo=