129415 2014-02-26 18:17:44 -0800 r164764 broke the ARM build 2014-02-27 05:56:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 mhahnenberg mhahnenberg commit-queue ossy rgabor zherczeg oldest_to_newest 985027 0 mhahnenberg 2014-02-26 18:17:44 -0800 Potential fix coming. 985029 1 225335 mhahnenberg 2014-02-26 18:19:27 -0800 Created attachment 225335 Patch 985030 2 mhahnenberg 2014-02-26 18:20:00 -0800 (In reply to comment #1) > Created an attachment (id=225335) [details] > Patch Potential fix. I don't have a way to test this patch. 985045 3 225335 ggaren 2014-02-26 19:04:54 -0800 Comment on attachment 225335 Patch Is this just a copy of branchPtrWithPatch? I guess I'll r=me to get the build going -- but testing is for great good. 985050 4 225335 commit-queue 2014-02-26 19:35:59 -0800 Comment on attachment 225335 Patch Clearing flags on attachment: 225335 Committed r164774: <http://trac.webkit.org/changeset/164774> 985051 5 commit-queue 2014-02-26 19:36:02 -0800 All reviewed patches have been landed. Closing bug. 985064 6 mhahnenberg 2014-02-26 22:35:47 -0800 Reopening to attach new patch. 985065 7 225345 mhahnenberg 2014-02-26 22:35:49 -0800 Created attachment 225345 Patch 985066 8 mhahnenberg 2014-02-26 22:36:20 -0800 (In reply to comment #7) > Created an attachment (id=225345) [details] > Patch Another fix for ARM traditional build. 985068 9 225345 ggaren 2014-02-27 00:09:10 -0800 Comment on attachment 225345 Patch r=me 985069 10 225345 commit-queue 2014-02-27 00:40:27 -0800 Comment on attachment 225345 Patch Clearing flags on attachment: 225345 Committed r164781: <http://trac.webkit.org/changeset/164781> 985070 11 commit-queue 2014-02-27 00:40:29 -0800 All reviewed patches have been landed. Closing bug. 985081 12 ossy 2014-02-27 01:44:37 -0800 Reopen, because the ARM traditional build is still broken. /home/webkitbuildbot/slaves/efl-ARMv7-traditional-official-build/buildslave/efl-linux-armv7-traditional-release/build/Source/JavaScriptCore/assembler/MacroAssemblerARM.h: In member function 'JSC::AbstractMacroAssembler<JSC::ARMAssembler>::DataLabel32 JSC::MacroAssemblerARM::moveWithPatch(JSC::AbstractMacroAssembler<JSC::ARMAssembler>::TrustedImm32, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID)': /home/webkitbuildbot/slaves/efl-ARMv7-traditional-official-build/buildslave/efl-linux-armv7-traditional-release/build/Source/JavaScriptCore/assembler/MacroAssemblerARM.h:1034:92: error: invalid cast from type 'int32_t {aka int}' to type 'JSC::ARMWord {aka unsigned int}' 985097 13 225354 rgabor 2014-02-27 04:19:53 -0800 Created attachment 225354 proposed fix Change reinterpret_cast to static_cast in MacroAssemblerARM::moveWithPatch() and add some missing function. 985115 14 225354 zherczeg 2014-02-27 05:23:34 -0800 Comment on attachment 225354 proposed fix r=me 985127 15 225354 commit-queue 2014-02-27 05:56:15 -0800 Comment on attachment 225354 proposed fix Clearing flags on attachment: 225354 Committed r164799: <http://trac.webkit.org/changeset/164799> 985128 16 commit-queue 2014-02-27 05:56:17 -0800 All reviewed patches have been landed. Closing bug. 225335 2014-02-26 18:19:27 -0800 2014-02-26 22:35:43 -0800 Patch bug-129415-20140226181926.patch text/plain 1567 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0NzcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTAyLTI2ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgcjE2NDc2NCBicm9rZSB0aGUgQVJNIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk0MTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFS TS5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTo6YnJhbmNoMzJXaXRoUGF0Y2gp OiBNaXNzaW5nIHRoaXMgZnVuY3Rpb24uCisKIDIwMTQtMDItMjYgIE1hcmsgSGFobmVuYmVyZyAg PG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBFRkwgYnVpbGQgZml4CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFS TS5oCShyZXZpc2lvbiAxNjQ3NjgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyQVJNLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNDUsNiArMTA0NSwxNSBA QCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBqdW1wOwogICAgIH0KIAorICAgIEp1bXAgYnJhbmNo MzJXaXRoUGF0Y2goUmVsYXRpb25hbENvbmRpdGlvbiBjb25kLCBBZGRyZXNzIGxlZnQsIERhdGFM YWJlbDMyJiBkYXRhTGFiZWwsIFRydXN0ZWRJbW0zMiBpbml0aWFsUmlnaHRWYWx1ZSA9IFRydXN0 ZWRJbW0zMigwKSkKKyAgICB7CisgICAgICAgIGxvYWQzMihsZWZ0LCBBUk1SZWdpc3RlcnM6OlMx KTsKKyAgICAgICAgZW5zdXJlU3BhY2UoMyAqIHNpemVvZihBUk1Xb3JkKSwgMiAqIHNpemVvZihB Uk1Xb3JkKSk7CisgICAgICAgIGRhdGFMYWJlbCA9IG1vdmVXaXRoUGF0Y2goaW5pdGlhbFJpZ2h0 VmFsdWUsIEFSTVJlZ2lzdGVyczo6UzApOworICAgICAgICBKdW1wIGp1bXAgPSBicmFuY2gzMihj b25kLCBBUk1SZWdpc3RlcnM6OlMwLCBBUk1SZWdpc3RlcnM6OlMxLCB0cnVlKTsKKyAgICAgICAg cmV0dXJuIGp1bXA7CisgICAgfQorCiAgICAgRGF0YUxhYmVsUHRyIHN0b3JlUHRyV2l0aFBhdGNo KFRydXN0ZWRJbW1QdHIgaW5pdGlhbFZhbHVlLCBJbXBsaWNpdEFkZHJlc3MgYWRkcmVzcykKICAg ICB7CiAgICAgICAgIERhdGFMYWJlbFB0ciBkYXRhTGFiZWwgPSBtb3ZlV2l0aFBhdGNoKGluaXRp YWxWYWx1ZSwgQVJNUmVnaXN0ZXJzOjpTMSk7Cg== 225345 2014-02-26 22:35:49 -0800 2014-02-27 00:40:26 -0800 Patch bug-129415-20140226223548.patch text/plain 1417 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0Nzc1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTAyLTI2ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgcjE2NDc2NCBicm9rZSB0aGUgQVJNIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk0MTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFS TS5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTo6bW92ZVdpdGhQYXRjaCk6CisK IDIwMTQtMDItMjYgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAog ICAgICAgICByMTY0NzY0IGJyb2tlIHRoZSBBUk0gYnVpbGQKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgJKHJldmlzaW9u IDE2NDc3NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJBUk0uaAkod29ya2luZyBjb3B5KQpAQCAtMTAyOCw2ICsxMDI4LDEzIEBAIHB1YmxpYzoKICAg ICAgICAgcmV0dXJuIGRhdGFMYWJlbDsKICAgICB9CiAKKyAgICBEYXRhTGFiZWwzMiBtb3ZlV2l0 aFBhdGNoKFRydXN0ZWRJbW0zMiBpbml0aWFsVmFsdWUsIFJlZ2lzdGVySUQgZGVzdCkKKyAgICB7 CisgICAgICAgIERhdGFMYWJlbDMyIGRhdGFMYWJlbCh0aGlzKTsKKyAgICAgICAgbV9hc3NlbWJs ZXIubGRyVW5pcXVlSW1tZWRpYXRlKGRlc3QsIHJlaW50ZXJwcmV0X2Nhc3Q8QVJNV29yZD4oaW5p dGlhbFZhbHVlLm1fdmFsdWUpKTsKKyAgICAgICAgcmV0dXJuIGRhdGFMYWJlbDsKKyAgICB9CisK ICAgICBKdW1wIGJyYW5jaFB0cldpdGhQYXRjaChSZWxhdGlvbmFsQ29uZGl0aW9uIGNvbmQsIFJl Z2lzdGVySUQgbGVmdCwgRGF0YUxhYmVsUHRyJiBkYXRhTGFiZWwsIFRydXN0ZWRJbW1QdHIgaW5p dGlhbFJpZ2h0VmFsdWUgPSBUcnVzdGVkSW1tUHRyKDApKQogICAgIHsKICAgICAgICAgZW5zdXJl U3BhY2UoMyAqIHNpemVvZihBUk1Xb3JkKSwgMiAqIHNpemVvZihBUk1Xb3JkKSk7Cg== 225354 2014-02-27 04:19:53 -0800 2014-02-27 05:56:15 -0800 proposed fix arm_buildfix.patch text/plain 2572 rgabor SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0NzkyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAyLTI3ICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAg ICAgICByMTY0NzY0IGJyb2tlIHRoZSBBUk0gYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTQxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6 CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjptb3ZlV2l0aFBhdGNoKTogQ2hhbmdl IHJlaW50ZXJwcmV0X2Nhc3QgdG8gc3RhdGljX2Nhc3QuCisgICAgICAgIChKU0M6Ok1hY3JvQXNz ZW1ibGVyQVJNOjpjYW5KdW1wUmVwbGFjZVBhdGNoYWJsZUJyYW5jaDMyV2l0aFBhdGNoKTogQWRk IG1pc3NpbmcgZnVuY3Rpb24uCisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpzdGFy dE9mUGF0Y2hhYmxlQnJhbmNoMzJXaXRoUGF0Y2hPbkFkZHJlc3MpOiBBZGQgbWlzc2luZyBmdW5j dGlvbi4KKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06OnJldmVydEp1bXBSZXBsYWNl bWVudFRvUGF0Y2hhYmxlQnJhbmNoMzJXaXRoUGF0Y2gpOiBBZGQgbWlzc2luZyBmdW5jdGlvbi4K KwogMjAxNC0wMi0yNyAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgog CiAgICAgICAgIHIxNjQ3NjQgYnJva2UgdGhlIEFSTSBidWlsZApJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAkocmV2aXNp b24gMTY0NzgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2Vt YmxlckFSTS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDMxLDcgKzEwMzEsNyBAQCBwdWJsaWM6CiAg ICAgRGF0YUxhYmVsMzIgbW92ZVdpdGhQYXRjaChUcnVzdGVkSW1tMzIgaW5pdGlhbFZhbHVlLCBS ZWdpc3RlcklEIGRlc3QpCiAgICAgewogICAgICAgICBEYXRhTGFiZWwzMiBkYXRhTGFiZWwodGhp cyk7Ci0gICAgICAgIG1fYXNzZW1ibGVyLmxkclVuaXF1ZUltbWVkaWF0ZShkZXN0LCByZWludGVy cHJldF9jYXN0PEFSTVdvcmQ+KGluaXRpYWxWYWx1ZS5tX3ZhbHVlKSk7CisgICAgICAgIG1fYXNz ZW1ibGVyLmxkclVuaXF1ZUltbWVkaWF0ZShkZXN0LCBzdGF0aWNfY2FzdDxBUk1Xb3JkPihpbml0 aWFsVmFsdWUubV92YWx1ZSkpOwogICAgICAgICByZXR1cm4gZGF0YUxhYmVsOwogICAgIH0KIApA QCAtMTM3MCw2ICsxMzcwLDEzIEBAIHB1YmxpYzoKICAgICB9CiAKICAgICBzdGF0aWMgYm9vbCBj YW5KdW1wUmVwbGFjZVBhdGNoYWJsZUJyYW5jaFB0cldpdGhQYXRjaCgpIHsgcmV0dXJuIGZhbHNl OyB9CisgICAgc3RhdGljIGJvb2wgY2FuSnVtcFJlcGxhY2VQYXRjaGFibGVCcmFuY2gzMldpdGhQ YXRjaCgpIHsgcmV0dXJuIGZhbHNlOyB9CisKKyAgICBzdGF0aWMgQ29kZUxvY2F0aW9uTGFiZWwg c3RhcnRPZlBhdGNoYWJsZUJyYW5jaDMyV2l0aFBhdGNoT25BZGRyZXNzKENvZGVMb2NhdGlvbkRh dGFMYWJlbDMyKQorICAgIHsKKyAgICAgICAgVU5SRUFDSEFCTEVfRk9SX1BMQVRGT1JNKCk7Cisg ICAgICAgIHJldHVybiBDb2RlTG9jYXRpb25MYWJlbCgpOworICAgIH0KIAogICAgIHN0YXRpYyBD b2RlTG9jYXRpb25MYWJlbCBzdGFydE9mUGF0Y2hhYmxlQnJhbmNoUHRyV2l0aFBhdGNoT25BZGRy ZXNzKENvZGVMb2NhdGlvbkRhdGFMYWJlbFB0cikKICAgICB7CkBAIC0xMzg3LDYgKzEzOTQsMTEg QEAgcHVibGljOgogICAgICAgICBBUk1Bc3NlbWJsZXI6OnJldmVydEJyYW5jaFB0cldpdGhQYXRj aChpbnN0cnVjdGlvblN0YXJ0LmRhdGFMb2NhdGlvbigpLCByZWcsIHJlaW50ZXJwcmV0X2Nhc3Q8 dWludHB0cl90Pihpbml0aWFsVmFsdWUpICYgMHhmZmZmKTsKICAgICB9CiAKKyAgICBzdGF0aWMg dm9pZCByZXZlcnRKdW1wUmVwbGFjZW1lbnRUb1BhdGNoYWJsZUJyYW5jaDMyV2l0aFBhdGNoKENv ZGVMb2NhdGlvbkxhYmVsLCBBZGRyZXNzLCBpbnQzMl90KQorICAgIHsKKyAgICAgICAgVU5SRUFD SEFCTEVfRk9SX1BMQVRGT1JNKCk7CisgICAgfQorCiAgICAgc3RhdGljIHZvaWQgcmV2ZXJ0SnVt cFJlcGxhY2VtZW50VG9QYXRjaGFibGVCcmFuY2hQdHJXaXRoUGF0Y2goQ29kZUxvY2F0aW9uTGFi ZWwsIEFkZHJlc3MsIHZvaWQqKQogICAgIHsKICAgICAgICAgVU5SRUFDSEFCTEVfRk9SX1BMQVRG T1JNKCk7Cg==