129408 2014-02-26 16:18:06 -0800 Ranges given to createMarkupInternal might not be canonicalized 2014-02-26 17:21:29 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield dino rniwa sam simon.fraser thorton oldest_to_newest 984976 0 mmaxfield 2014-02-26 16:18:06 -0800 Ranges given to createMarkupInternal might not be canonicalized 984977 1 225317 mmaxfield 2014-02-26 16:20:42 -0800 Created attachment 225317 Patch 984994 2 225317 rniwa 2014-02-26 17:00:22 -0800 Comment on attachment 225317 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225317&action=review > Source/WebCore/ChangeLog:9 > + No new tests because this codepath will only be reached via SPI. > + We need to describe why we're making this change. > Source/WebCore/editing/markup.cpp:575 > - if (body && areRangesEqual(VisibleSelection::selectionFromContentsOfNode(body).toNormalizedRange().get(), &range)) > + if (body && areRangesEqual(VisibleSelection::selectionFromContentsOfNode(body).toNormalizedRange().get(), > + VisibleSelection(range.startPosition(), range.endPosition()).toNormalizedRange().get())) This is very inefficient way of checking this condition anyways. It's probably better to do VisiblePosition(firstPositionInNode(body)) == VisiblePosition(range.startPosition()) and the similar for the end. 985007 3 225326 mmaxfield 2014-02-26 17:17:04 -0800 Created attachment 225326 Patch 985008 4 mmaxfield 2014-02-26 17:21:29 -0800 http://trac.webkit.org/changeset/164763 225317 2014-02-26 16:20:42 -0800 2014-02-26 17:17:02 -0800 Patch bug-129408-20140226162041.patch text/plain 1794 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQyODY3OTIzMzUxMzY2 NzEzZTU0YzdmZDA3MDcwZDdlMjllNjA4OS4uYzA5MDIzNjZlMDI2NDBlNjM1NWRjZmEwMjhkOTZj OTFjMTQ4Njk2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTI2ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgUmFuZ2VzIGdp dmVuIHRvIGNyZWF0ZU1hcmt1cEludGVybmFsIG1pZ2h0IG5vdCBiZSBjYW5vbmljYWxpemVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk0MDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMgYmVjYXVzZSB0aGlzIGNvZGVwYXRoIHdpbGwgb25seSBiZSByZWFjaGVkIHZpYSBTUEkuCisK KyAgICAgICAgKiBlZGl0aW5nL21hcmt1cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVN YXJrdXBJbnRlcm5hbCk6CisKIDIwMTQtMDItMjYgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5j b20+CiAKICAgICAgICAgV2ViIFJlcGxheTogcm91dGUgdGhyb3VnaCBVc2VySW5wdXRCcmlkZ2Ug d2hlbiBkZWxpdmVyaW5nIHVzZXIgaW5wdXRzIHRvIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFy a3VwLmNwcAppbmRleCAxZGQzNDQ3ODdiNGNjZGQyZGM4ZDE5YTI3YTZhNjZmNjBlOTIzYTA3Li5j YzhjNmIwOGY3NzMyNGY4ZTYwMzcyZDhkMGI2NWFmZjI1ZjNmYzJlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9tYXJrdXAuY3BwCkBAIC01NzEsNyArNTcxLDggQEAgc3RhdGljIFN0cmluZyBjcmVhdGVNYXJr dXBJbnRlcm5hbChEb2N1bWVudCYgZG9jdW1lbnQsIGNvbnN0IFJhbmdlJiByYW5nZSwgY29uc3QK ICAgICBOb2RlKiBib2R5ID0gZW5jbG9zaW5nTm9kZVdpdGhUYWcoZmlyc3RQb3NpdGlvbkluTm9k ZShjb21tb25BbmNlc3RvciksIGJvZHlUYWcpOwogICAgIE5vZGUqIGZ1bGx5U2VsZWN0ZWRSb290 ID0gMDsKICAgICAvLyBGSVhNRTogRG8gdGhpcyBmb3IgYWxsIGZ1bGx5IHNlbGVjdGVkIGJsb2Nr cywgbm90IGp1c3QgdGhlIGJvZHkuCi0gICAgaWYgKGJvZHkgJiYgYXJlUmFuZ2VzRXF1YWwoVmlz aWJsZVNlbGVjdGlvbjo6c2VsZWN0aW9uRnJvbUNvbnRlbnRzT2ZOb2RlKGJvZHkpLnRvTm9ybWFs aXplZFJhbmdlKCkuZ2V0KCksICZyYW5nZSkpCisgICAgaWYgKGJvZHkgJiYgYXJlUmFuZ2VzRXF1 YWwoVmlzaWJsZVNlbGVjdGlvbjo6c2VsZWN0aW9uRnJvbUNvbnRlbnRzT2ZOb2RlKGJvZHkpLnRv Tm9ybWFsaXplZFJhbmdlKCkuZ2V0KCksCisgICAgICAgIFZpc2libGVTZWxlY3Rpb24ocmFuZ2Uu c3RhcnRQb3NpdGlvbigpLCByYW5nZS5lbmRQb3NpdGlvbigpKS50b05vcm1hbGl6ZWRSYW5nZSgp LmdldCgpKSkKICAgICAgICAgZnVsbHlTZWxlY3RlZFJvb3QgPSBib2R5OwogICAgIE5vZGUqIHNw ZWNpYWxDb21tb25BbmNlc3RvciA9IGhpZ2hlc3RBbmNlc3RvclRvV3JhcE1hcmt1cCgmdXBkYXRl ZFJhbmdlLCBzaG91bGRBbm5vdGF0ZSk7CiAK 225326 2014-02-26 17:17:04 -0800 2014-02-26 17:17:51 -0800 Patch bug-129408-20140226171703.patch text/plain 2093 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQyODY3OTIzMzUxMzY2 NzEzZTU0YzdmZDA3MDcwZDdlMjllNjA4OS4uMzA4OTgzODUxODU2YzRiNmZiMGI0NGEwZDE2NDE0 NzMwYzhkNDQ5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAyLTI2ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgUmFuZ2VzIGdp dmVuIHRvIGNyZWF0ZU1hcmt1cEludGVybmFsIG1pZ2h0IG5vdCBiZSBjYW5vbmljYWxpemVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk0MDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIFdlYktp dCBjbGllbnRzIChzdWNoIGFzIE1haWwpIGNhbGwgV0tXZWJBcmNoaXZlQ3JlYXRlRnJvbVJhbmdl KCkgd2l0aCBhIHJhbmdlLAorICAgICAgICB0aGF0IHJhbmdlIGlzIG5vdCBuZWNlc3NhcmlseSBj YW5vbmljYWxpemVkLiBUaGVyZWZvcmUsIGNvbXBhcmluZyBpdCBmb3IgZXF1YWxpdHkKKyAgICAg ICAgd2l0aCBhIGNhbm9uaWNhbGl6ZWQgcmFuZ2UgbWlnaHQgcmV0dXJuIGEgZmFsc2UgbmVnYXRp dmUuIEluc3RlYWQsIHdlIHNob3VsZCBjb21wYXJlCisgICAgICAgIGNhbm9uaWNhbGl6ZWQgcmFu Z2VzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoaXMgY29kZXBhdGggd2lsbCBv bmx5IGJlIHJlYWNoZWQgdmlhIFNQSS4KKworICAgICAgICAqIGVkaXRpbmcvbWFya3VwLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZU1hcmt1cEludGVybmFsKToKKwogMjAxNC0wMi0yNiAg QnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgUmVwbGF5OiByb3V0 ZSB0aHJvdWdoIFVzZXJJbnB1dEJyaWRnZSB3aGVuIGRlbGl2ZXJpbmcgdXNlciBpbnB1dHMgdG8g V2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYXJrdXAuY3BwIGIv U291cmNlL1dlYkNvcmUvZWRpdGluZy9tYXJrdXAuY3BwCmluZGV4IDFkZDM0NDc4N2I0Y2NkZDJk YzhkMTlhMjdhNmE2NmY2MGU5MjNhMDcuLmY0YjM0ZTMxZjY1NTlkYjQ5YWJiZjJiZGMxYmVlYmRm NDVjYjEwMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAKQEAgLTU3MSw3ICs1NzEsOCBA QCBzdGF0aWMgU3RyaW5nIGNyZWF0ZU1hcmt1cEludGVybmFsKERvY3VtZW50JiBkb2N1bWVudCwg Y29uc3QgUmFuZ2UmIHJhbmdlLCBjb25zdAogICAgIE5vZGUqIGJvZHkgPSBlbmNsb3NpbmdOb2Rl V2l0aFRhZyhmaXJzdFBvc2l0aW9uSW5Ob2RlKGNvbW1vbkFuY2VzdG9yKSwgYm9keVRhZyk7CiAg ICAgTm9kZSogZnVsbHlTZWxlY3RlZFJvb3QgPSAwOwogICAgIC8vIEZJWE1FOiBEbyB0aGlzIGZv ciBhbGwgZnVsbHkgc2VsZWN0ZWQgYmxvY2tzLCBub3QganVzdCB0aGUgYm9keS4KLSAgICBpZiAo Ym9keSAmJiBhcmVSYW5nZXNFcXVhbChWaXNpYmxlU2VsZWN0aW9uOjpzZWxlY3Rpb25Gcm9tQ29u dGVudHNPZk5vZGUoYm9keSkudG9Ob3JtYWxpemVkUmFuZ2UoKS5nZXQoKSwgJnJhbmdlKSkKKyAg ICBpZiAoYm9keSAmJiBWaXNpYmxlUG9zaXRpb24oZmlyc3RQb3NpdGlvbkluTm9kZShib2R5KSkg PT0gVmlzaWJsZVBvc2l0aW9uKHJhbmdlLnN0YXJ0UG9zaXRpb24oKSkKKyAgICAgICAgJiYgVmlz aWJsZVBvc2l0aW9uKGxhc3RQb3NpdGlvbkluTm9kZShib2R5KSkgPT0gVmlzaWJsZVBvc2l0aW9u KHJhbmdlLmVuZFBvc2l0aW9uKCkpKQogICAgICAgICBmdWxseVNlbGVjdGVkUm9vdCA9IGJvZHk7 CiAgICAgTm9kZSogc3BlY2lhbENvbW1vbkFuY2VzdG9yID0gaGlnaGVzdEFuY2VzdG9yVG9XcmFw TWFya3VwKCZ1cGRhdGVkUmFuZ2UsIHNob3VsZEFubm90YXRlKTsKIAo=