129403 2014-02-26 16:01:51 -0800 speechSynthesis.speak of a zero length utterance kills future speech 2014-02-27 12:18:09 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach commit-queue mario webkit-bug-importer oldest_to_newest 984963 0 cfleizach 2014-02-26 16:01:51 -0800 Steps to Reproduce: <script> speechSynthesis.speak( new SpeechSynthesisUtterance("")); speechSynthesis.speak( new SpeechSynthesisUtterance("hello")) </script> Expected Results: It should say hello. Actual Results: speechSynthesis.speak is hung until I call speechSynthesis.cancel() <rdar://problem/16168664> 984990 1 225322 cfleizach 2014-02-26 16:51:04 -0800 Created attachment 225322 patch 985088 2 225322 mario 2014-02-27 02:21:44 -0800 Comment on attachment 225322 patch Looks good to me, hence the r+. Still, I wonder that the problem this is fixing happens only for empty (zero-length) strings, or for anything that should not spoken at all, such as a string containing only blanks or unpronounceable characters. If that's the case, maybe it would make sense to check that in advance and early return if needed. What do you think? 985195 3 cfleizach 2014-02-27 09:11:50 -0800 (In reply to comment #2) > (From update of attachment 225322 [details]) > Looks good to me, hence the r+. Still, I wonder that the problem this is fixing happens only for empty (zero-length) strings, or for anything that should not spoken at all, such as a string containing only blanks or unpronounceable characters. If that's the case, maybe it would make sense to check that in advance and early return if needed. > > What do you think? This a bit of an unknown unfortunately. I don't think an empty string would cause every synthesizer to choke for example. It just happens that it does so on Mac. This is the first case I've heard of it happening, so I'm happy to be conservative about what we strip out. Likewise, it's not always clear what a synthesizer can speak or not. Not all of them have API that allows you to know if a character is speakable or not. And even if something was not speakable, the synth may use that for pausing. Likewise, it may be able to normalize a character like é to e, even though it can't speak é. 985217 4 225322 commit-queue 2014-02-27 09:44:14 -0800 Comment on attachment 225322 patch Clearing flags on attachment: 225322 Committed r164807: <http://trac.webkit.org/changeset/164807> 985218 5 commit-queue 2014-02-27 09:44:16 -0800 All reviewed patches have been landed. Closing bug. 985299 6 225322 darin 2014-02-27 12:15:14 -0800 Comment on attachment 225322 patch View in context: https://bugs.webkit.org/attachment.cgi?id=225322&action=review > Source/WebCore/Modules/speech/SpeechSynthesis.cpp:115 > + // Zero lengthed strings should immediately notify that the event is complete. > + if (utterance->text().isEmpty()) { > + handleSpeakingCompleted(utterance, false); > + return; > + } Are there any other strings that don’t work right? I guess that putting this check here relieves all the platforms of the need to handle empty strings, but what about strings with just spaces in them? Do those cause the same problems? 985301 7 cfleizach 2014-02-27 12:18:09 -0800 (In reply to comment #6) > (From update of attachment 225322 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225322&action=review > > > Source/WebCore/Modules/speech/SpeechSynthesis.cpp:115 > > + // Zero lengthed strings should immediately notify that the event is complete. > > + if (utterance->text().isEmpty()) { > > + handleSpeakingCompleted(utterance, false); > > + return; > > + } > > Are there any other strings that don’t work right? I guess that putting this check here relieves all the platforms of the need to handle empty strings, but what about strings with just spaces in them? Do those cause the same problems? I haven't noticed issues with any strings with content in them. It's always possible there are such sequences, but I'm not aware of them. It's possible that synthesizers use such strings to help with prosity perhaps. 225322 2014-02-26 16:51:04 -0800 2014-02-27 12:15:14 -0800 patch patch text/plain 4795 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDc1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAyLTI2ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgc3BlZWNoU3ludGhlc2lz LnNwZWFrIG9mIGEgemVybyBsZW5ndGggdXR0ZXJhbmNlIGtpbGxzIGZ1dHVyZSBzcGVlY2gKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTQwMworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVtcHR5IGxlbmd0 aCBzdHJpbmdzIG1heSBjaG9rZSBhIHN5bnRoZXNpemVyIGFuZCByZXN1bHQgaW4gZGlkRmluaXNo U3BlYWtpbmcgbm90IGJlaW5nIGNhbGxlZC4gCisgICAgICAgIFRoZSBXZWJLaXQgY29kZSBzaG91 bGQgYmUgcHJvYWN0aXZlIGFib3V0IHNjcmVlbmluZyBvdXQgZW1wdHkgbGVuZ3RoIHN0cmluZ3Mu CisKKyAgICAgICAgVGVzdDogcGxhdGZvcm0vbWFjL2Zhc3Qvc3BlZWNoc3ludGhlc2lzL3NwZWVj aC1zeW50aGVzaXMtc3BlYWstZW1wdHktc3RyaW5nLmh0bWwKKworICAgICAgICAqIE1vZHVsZXMv c3BlZWNoL1NwZWVjaFN5bnRoZXNpcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTcGVlY2hTeW50 aGVzaXM6OnN0YXJ0U3BlYWtpbmdJbW1lZGlhdGVseSk6CisKIDIwMTQtMDItMjYgIEFuZHkgRXN0 ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFN1cHBvcnQgbmV0d29yayBz dGF0ZSBub3RpZmljYXRpb24gdXNpbmcgQ1BOZXR3b3JrT2JzZXJ2ZXIKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL01vZHVsZXMvc3BlZWNoL1NwZWVjaFN5bnRoZXNpcy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvTW9kdWxlcy9zcGVlY2gvU3BlZWNoU3ludGhlc2lzLmNwcAkocmV2aXNp b24gMTY0NzMzKQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zcGVlY2gvU3BlZWNoU3ludGhl c2lzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA3LDYgKzEwNywxMyBAQAogICAgIHV0dGVyYW5j ZS0+c2V0U3RhcnRUaW1lKG1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpKTsKICAgICBtX2N1 cnJlbnRTcGVlY2hVdHRlcmFuY2UgPSB1dHRlcmFuY2U7CiAgICAgbV9pc1BhdXNlZCA9IGZhbHNl OworICAgIAorICAgIC8vIFplcm8gbGVuZ3RoZWQgc3RyaW5ncyBzaG91bGQgaW1tZWRpYXRlbHkg bm90aWZ5IHRoYXQgdGhlIGV2ZW50IGlzIGNvbXBsZXRlLgorICAgIGlmICh1dHRlcmFuY2UtPnRl eHQoKS5pc0VtcHR5KCkpIHsKKyAgICAgICAgaGFuZGxlU3BlYWtpbmdDb21wbGV0ZWQodXR0ZXJh bmNlLCBmYWxzZSk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisgICAgCiAgICAgaWYgKCFtX3Bs YXRmb3JtU3BlZWNoU3ludGhlc2l6ZXIpCiAgICAgICAgIG1fcGxhdGZvcm1TcGVlY2hTeW50aGVz aXplciA9IFBsYXRmb3JtU3BlZWNoU3ludGhlc2l6ZXI6OmNyZWF0ZSh0aGlzKTsKICAgICBtX3Bs YXRmb3JtU3BlZWNoU3ludGhlc2l6ZXItPnNwZWFrKHV0dGVyYW5jZS0+cGxhdGZvcm1VdHRlcmFu Y2UoKSk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjQ3NTgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0wMi0yNiAgQ2hyaXMgRmxl aXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgorCisgICAgICAgIHNwZWVjaFN5bnRoZXNpcy5z cGVhayBvZiBhIHplcm8gbGVuZ3RoIHV0dGVyYW5jZSBraWxscyBmdXR1cmUgc3BlZWNoCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk0MDMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21h Yy9mYXN0L3NwZWVjaHN5bnRoZXNpcy9zcGVlY2gtc3ludGhlc2lzLXNwZWFrLWVtcHR5LXN0cmlu Zy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L3NwZWVj aHN5bnRoZXNpcy9zcGVlY2gtc3ludGhlc2lzLXNwZWFrLWVtcHR5LXN0cmluZy5odG1sOiBBZGRl ZC4KKwogMjAxNC0wMi0yNiAgQmVtIEpvbmVzLUJleSAgPGJqb25lc2JlQGFkb2JlLmNvbT4KIAog ICAgICAgICBbQ1NTIFNoYXBlc10gaW5zZXQgYW5kIGluc2V0LXJlY3RhbmdsZSB0cmlnZ2VyIGFz c2VydCB3aXRoIHJlcGxhY2VkIGVsZW1lbnQgYW5kIGxhcmdlIHBlcmNlbnRhZ2UgZGltZW5zaW9u CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9zcGVlY2hzeW50aGVzaXMvc3Bl ZWNoLXN5bnRoZXNpcy1zcGVhay1lbXB0eS1zdHJpbmctZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3NwZWVjaHN5bnRoZXNpcy9zcGVlY2gt c3ludGhlc2lzLXNwZWFrLWVtcHR5LXN0cmluZy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9zcGVlY2hzeW50aGVzaXMvc3BlZWNoLXN5 bnRoZXNpcy1zcGVhay1lbXB0eS1zdHJpbmctZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBA IC0wLDAgKzEsMTIgQEAKK1RoaXMgdGVzdHMgdGhhdCBhbiBlbXB0eSBzdHJpbmcgc2VudCB0byB0 aGUgc3ludGhlc2l6ZXIgc3RpbGwgZ2VuZXJhdGVzIGEgY2FsbGJhY2suCisKK09uIHN1Y2Nlc3Ms IHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJU RVNUIENPTVBMRVRFIi4KKworCitQQVNTIHNwZWVjaFN5bnRoZXNpcy5zcGVha2luZyBpcyBmYWxz ZQorUEFTUyBldmVudC5lbGFwc2VkVGltZSA+IDAgaXMgdHJ1ZQorUEFTUyBzcGVlY2hTeW50aGVz aXMuc3BlYWtpbmcgaXMgZmFsc2UKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKwor VEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9zcGVl Y2hzeW50aGVzaXMvc3BlZWNoLXN5bnRoZXNpcy1zcGVhay1lbXB0eS1zdHJpbmcuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9zcGVlY2hzeW50aGVzaXMv c3BlZWNoLXN5bnRoZXNpcy1zcGVhay1lbXB0eS1zdHJpbmcuaHRtbAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3NwZWVjaHN5bnRoZXNpcy9zcGVlY2gtc3lu dGhlc2lzLXNwZWFrLWVtcHR5LXN0cmluZy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs NDIgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxo dG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3Qt cHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPGRpdiBpZD0i Y29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisKKyAgICBpZiAod2luZG93LmludGVybmFscykK KyAgICAgICAgd2luZG93LmludGVybmFscy5lbmFibGVNb2NrU3BlZWNoU3ludGhlc2l6ZXIoKTsK KworICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgYW4gZW1wdHkgc3RyaW5nIHNlbnQg dG8gdGhlIHN5bnRoZXNpemVyIHN0aWxsIGdlbmVyYXRlcyBhIGNhbGxiYWNrLiIpOworCisgICAg aWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUo KTsKKworICAgIHdpbmRvdy5qc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKworICAgIC8vIFN0YXJ0IGEg dmVyeSBzaG9ydCBzcGVha2luZyBqb2IgdGhhdCB3aWxsIGZpbmlzaCBxdWlja2x5LgorICAgIHZh ciB1ID0gbmV3IFNwZWVjaFN5bnRoZXNpc1V0dGVyYW5jZSgiIik7CisKKyAgICB1Lm9uc3RhcnQg PSBmdW5jdGlvbihldmVudCkgeworICAgICAgIHNob3VsZEJlVHJ1ZSgiZXZlbnQuZWxhcHNlZFRp bWUgPiAwIik7CisgICAgICAgc2hvdWxkQmVUcnVlKCJzcGVlY2hTeW50aGVzaXMuc3BlYWtpbmci KTsKKyAgICB9CisgICAgdS5vbmVuZCA9IGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgICAgc2hvdWxk QmVUcnVlKCJldmVudC5lbGFwc2VkVGltZSA+IDAiKTsKKyAgICAgICBzaG91bGRCZUZhbHNlKCJz cGVlY2hTeW50aGVzaXMuc3BlYWtpbmciKTsKKyAgICAgICBmaW5pc2hKU1Rlc3QoKTsKKyAgICB9 CisKKyAgICBzaG91bGRCZUZhbHNlKCJzcGVlY2hTeW50aGVzaXMuc3BlYWtpbmciKTsKKyAgICBz cGVlY2hTeW50aGVzaXMuc3BlYWsodSk7CisKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNyYz0iLi4v Li4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8 L2h0bWw+Cg==