129399 2014-02-26 15:22:09 -0800 Create symlink to /usr/local/bin/jsc during installation 2014-04-23 02:53:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 132053 1 ddkilzer ddkilzer commit-queue ggaren joepeck mhahnenberg mitz mrowe oliver ossy webkit-bug-importer oldest_to_newest 984934 0 ddkilzer 2014-02-26 15:22:09 -0800 When iOS changes were upstreamed to JavaScriptCore, we lost the creation of a symlink from /usr/local/bin/jsc to /S/L/F/JavaScriptCore.framework/Resources/jsc. This bug is to track adding that back. 984936 1 ddkilzer 2014-02-26 15:22:28 -0800 <rdar://problem/16168734> 984937 2 225306 ddkilzer 2014-02-26 15:24:27 -0800 Created attachment 225306 Patch v1 984958 3 225306 mitz 2014-02-26 15:49:39 -0800 Comment on attachment 225306 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=225306&action=review > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:5925 > + shellScript = "if [[ \"${SKIP_INSTALL}\" == \"NO\" ]]; then\n mkdir -p \"${DSTROOT}/usr/local/bin\"\n cd \"${DSTROOT}/usr/local/bin\"\n ln -s \"../../..${INSTALL_PATH}/jsc\" jsc\n exit\nfi\n"; Unless I’m missing something, when building for the iOS Simulator, this will create the usr directory alongside the Applications directory (which contains Xcode.app/Developer/…) in DSTROOT, which is not desirable in production builds. 984960 4 mitz 2014-02-26 15:50:16 -0800 s/Developer/Contents\/Developer/ 985253 5 225394 ddkilzer 2014-02-27 10:48:44 -0800 Created attachment 225394 Patch v2 Fixed install paths for iOS Simulator. 985308 6 225394 commit-queue 2014-02-27 12:32:20 -0800 Comment on attachment 225394 Patch v2 Clearing flags on attachment: 225394 Committed r164823: <http://trac.webkit.org/changeset/164823> 985309 7 commit-queue 2014-02-27 12:32:22 -0800 All reviewed patches have been landed. Closing bug. 985322 8 joepeck 2014-02-27 13:12:43 -0800 I'm seeing build failures on the bots: <http://build.webkit.org/builders/Apple%20Mavericks%20LLINT%20CLoop%20%28BuildAndTest%29/builds/2260/steps/compile-webkit/logs/stdio> > The following build commands failed: > PhaseScriptExecution Create\ /usr/local/bin/jsc\ symlink I'm guessing this is because if there is no iOS SDK then: DebugRelease.xcconfig line 23: Unable to find included file "../../../../Internal/Configurations/UseInternalSDK.xcconfig" iOS.xcconfig line 1: Unable to find included file "<DEVELOPER_DIR>/AppleInternal/XcodeConfig/AspenFamily.xcconfig" And $(INSTALL_PATH_PREFIX) may be undefined? Just a wild guess at this time. 985324 9 joepeck 2014-02-27 13:14:04 -0800 Or rather, INSTALL_PATH_ACTUAL would be the important thing here. 985328 10 ddkilzer 2014-02-27 13:36:55 -0800 (In reply to comment #9) > Or rather, INSTALL_PATH_ACTUAL would be the important thing here. Actually, the build failed because the buildbot was trying to create a symlink where a symlink already existed (in a non-clean build). Fixed in r164828: <http://trac.webkit.org/changeset/r164828> 999498 11 ossy 2014-04-10 04:31:43 -0700 After this change build-jsc unconditionally tries to create a symlink to /tmp/JavaScriptCore.dst/usr/local/bin: jsc -> ../../../System/Library/Frameworks/JavaScriptCore.framework/Versions/A/Resources/jsc But if there are more user work on a Mac, the second user won't be able to remove and recreate this symlink and build-jsc will fail. Could you possibly give us some hint how can we solve this problem? 1003239 12 ossy 2014-04-23 02:53:22 -0700 (In reply to comment #11) > After this change build-jsc unconditionally tries to create > a symlink to /tmp/JavaScriptCore.dst/usr/local/bin: > jsc -> ../../../System/Library/Frameworks/JavaScriptCore.framework/Versions/A/Resources/jsc > > But if there are more user work on a Mac, the second user won't be > able to remove and recreate this symlink and build-jsc will fail. > > Could you possibly give us some hint how can we solve this problem? Unfortunately I didn't get answer for this serious regression in 2 weeks. :( I filed a new bug report to fix - https://bugs.webkit.org/show_bug.cgi?id=132053 225306 2014-02-26 15:24:27 -0800 2014-02-27 10:48:42 -0800 Patch v1 bug-129399-20140226152427.patch text/plain 2555 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz Y2Q2ODQ0ZGFkMGY2NzY5MjdjMGUwY2Y3MDdjNTQzZTM5N2QwYmQyLi40YzJhNjI5ODNkNTE1Yjg5 YmU1MmU1NjhiODljYzliODQyZDhlYzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMi0yNiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIENyZWF0ZSBzeW1saW5rIHRvIC91c3IvbG9jYWwvYmluL2pzYyBkdXJpbmcg aW5zdGFsbGF0aW9uCisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEyOTM5OT4KKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE2MTY4NzM0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvajoKKyAgICAgICAgLSBBZGQgIkNyZWF0ZSAvdXNyL2xvY2FsL2Jpbi9qc2Mgc3ltbGlu ayIgYnVpbGQgcGhhc2Ugc2NyaXB0IHRvCisgICAgICAgICAgY3JlYXRlIHRoZSBzeW1saW5rIGR1 cmluZyBpbnN0YWxsYXRpb24uCisKIDIwMTQtMDItMjYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBw bGUuY29tPgogCiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6IG1faGVhcC0+dm0oKS0+Y3VycmVu dFRocmVhZElzSG9sZGluZ0FQSUxvY2soKSBpbiBpbnNwZWN0b3ItcHJvdG9jb2wvKi4KZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJv amVjdC5wYnhwcm9qIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnhjb2Rl cHJvai9wcm9qZWN0LnBieHByb2oKaW5kZXggMjkzYmQwMTc3Y2U2MjI0MzE0Y2FlYjA4ZDgxMGVj ZGM3NTI2YWQzZS4uZjM3ZTFmNDk3NjRkMWEzOTA0MWQzNzEwZjhiNjNmM2I1NTVlZTI0OCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnhjb2RlcHJvai9w cm9qZWN0LnBieHByb2oKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3Jl Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKQEAgLTU3NDMsNiArNTc0Myw3IEBACiAJCQlidWls ZFBoYXNlcyA9ICgKIAkJCQk5MzJGNUJEQzA4MjJBMUM3MDA3MzY5NzUgLyogU291cmNlcyAqLywK IAkJCQk5MzJGNUJERTA4MjJBMUM3MDA3MzY5NzUgLyogRnJhbWV3b3JrcyAqLywKKwkJCQk1RDVE OEFCRjBFMEQwQjAzMDBGOUM2OTIgLyogQ3JlYXRlIC91c3IvbG9jYWwvYmluL2pzYyBzeW1saW5r ICovLAogCQkJKTsKIAkJCWJ1aWxkUnVsZXMgPSAoCiAJCQkpOwpAQCAtNTkwNyw2ICs1OTA4LDIy IEBACiAJCQlzaGVsbFBhdGggPSAvYmluL3NoOwogCQkJc2hlbGxTY3JpcHQgPSAic2V0IC1lXG5c blRSQUNJTkdfRD1cIiRTUkNST09UL3J1bnRpbWUvVHJhY2luZy5kXCI7XG5UUkFDSU5HX0g9XCIk QlVJTFRfUFJPRFVDVFNfRElSL0Rlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL1RyYWNpbmdE dHJhY2UuaFwiO1xuXG5pZiBbWyBcIiRIQVZFX0RUUkFDRVwiID0gXCIxXCIgJiYgXCIkVFJBQ0lO R19EXCIgLW50IFwiJFRSQUNJTkdfSFwiIF1dO1xudGhlblxuXHRkdHJhY2UgLWggLW8gXCIkVFJB Q0lOR19IXCIgLXMgXCIkVFJBQ0lOR19EXCI7XG5maTtcbiI7CiAJCX07CisJCTVENUQ4QUJGMEUw RDBCMDMwMEY5QzY5MiAvKiBDcmVhdGUgL3Vzci9sb2NhbC9iaW4vanNjIHN5bWxpbmsgKi8gPSB7 CisJCQlpc2EgPSBQQlhTaGVsbFNjcmlwdEJ1aWxkUGhhc2U7CisJCQlidWlsZEFjdGlvbk1hc2sg PSAyMTQ3NDgzNjQ3OworCQkJZmlsZXMgPSAoCisJCQkpOworCQkJaW5wdXRQYXRocyA9ICgKKwkJ CQkiJChEU1RST09UKSQoSU5TVEFMTF9QQVRIKS9qc2MiLAorCQkJKTsKKwkJCW5hbWUgPSAiQ3Jl YXRlIC91c3IvbG9jYWwvYmluL2pzYyBzeW1saW5rIjsKKwkJCW91dHB1dFBhdGhzID0gKAorCQkJ CSIkKERTVFJPT1QpL3Vzci9sb2NhbC9iaW4vanNjIiwKKwkJCSk7CisJCQlydW5Pbmx5Rm9yRGVw bG95bWVudFBvc3Rwcm9jZXNzaW5nID0gMDsKKwkJCXNoZWxsUGF0aCA9IC9iaW4vc2g7CisJCQlz aGVsbFNjcmlwdCA9ICJpZiBbWyBcIiR7U0tJUF9JTlNUQUxMfVwiID09IFwiTk9cIiBdXTsgdGhl blxuICAgIG1rZGlyIC1wIFwiJHtEU1RST09UfS91c3IvbG9jYWwvYmluXCJcbiAgICBjZCBcIiR7 RFNUUk9PVH0vdXNyL2xvY2FsL2JpblwiXG4gICAgbG4gLXMgXCIuLi8uLi8uLiR7SU5TVEFMTF9Q QVRIfS9qc2NcIiBqc2NcbiAgICBleGl0XG5maVxuIjsKKwkJfTsKIAkJNURBRkQ2Q0QxNDZCNkI2 RTAwRkJFRkI0IC8qIEluc3RhbGwgU3VwcG9ydCBTY3JpcHQgKi8gPSB7CiAJCQlpc2EgPSBQQlhT aGVsbFNjcmlwdEJ1aWxkUGhhc2U7CiAJCQlidWlsZEFjdGlvbk1hc2sgPSA4Owo= 225394 2014-02-27 10:48:44 -0800 2014-02-27 12:32:20 -0800 Patch v2 bug-129399-20140227104843.patch text/plain 2628 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz Y2Q2ODQ0ZGFkMGY2NzY5MjdjMGUwY2Y3MDdjNTQzZTM5N2QwYmQyLi40YzJhNjI5ODNkNTE1Yjg5 YmU1MmU1NjhiODljYzliODQyZDhlYzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMi0yNiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIENyZWF0ZSBzeW1saW5rIHRvIC91c3IvbG9jYWwvYmluL2pzYyBkdXJpbmcg aW5zdGFsbGF0aW9uCisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEyOTM5OT4KKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE2MTY4NzM0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvajoKKyAgICAgICAgLSBBZGQgIkNyZWF0ZSAvdXNyL2xvY2FsL2Jpbi9qc2Mgc3ltbGlu ayIgYnVpbGQgcGhhc2Ugc2NyaXB0IHRvCisgICAgICAgICAgY3JlYXRlIHRoZSBzeW1saW5rIGR1 cmluZyBpbnN0YWxsYXRpb24uCisKIDIwMTQtMDItMjYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBw bGUuY29tPgogCiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6IG1faGVhcC0+dm0oKS0+Y3VycmVu dFRocmVhZElzSG9sZGluZ0FQSUxvY2soKSBpbiBpbnNwZWN0b3ItcHJvdG9jb2wvKi4KZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJv amVjdC5wYnhwcm9qIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnhjb2Rl cHJvai9wcm9qZWN0LnBieHByb2oKaW5kZXggMjkzYmQwMTc3Y2U2MjI0MzE0Y2FlYjA4ZDgxMGVj ZGM3NTI2YWQzZS4uNzc3ZDZmN2ExM2I0MTEyY2U0MDcwZWMyYTJlNWY4Y2FjNWRiNjNlMiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnhjb2RlcHJvai9w cm9qZWN0LnBieHByb2oKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3Jl Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKQEAgLTU3NDMsNiArNTc0Myw3IEBACiAJCQlidWls ZFBoYXNlcyA9ICgKIAkJCQk5MzJGNUJEQzA4MjJBMUM3MDA3MzY5NzUgLyogU291cmNlcyAqLywK IAkJCQk5MzJGNUJERTA4MjJBMUM3MDA3MzY5NzUgLyogRnJhbWV3b3JrcyAqLywKKwkJCQk1RDVE OEFCRjBFMEQwQjAzMDBGOUM2OTIgLyogQ3JlYXRlIC91c3IvbG9jYWwvYmluL2pzYyBzeW1saW5r ICovLAogCQkJKTsKIAkJCWJ1aWxkUnVsZXMgPSAoCiAJCQkpOwpAQCAtNTkwNyw2ICs1OTA4LDIy IEBACiAJCQlzaGVsbFBhdGggPSAvYmluL3NoOwogCQkJc2hlbGxTY3JpcHQgPSAic2V0IC1lXG5c blRSQUNJTkdfRD1cIiRTUkNST09UL3J1bnRpbWUvVHJhY2luZy5kXCI7XG5UUkFDSU5HX0g9XCIk QlVJTFRfUFJPRFVDVFNfRElSL0Rlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL1RyYWNpbmdE dHJhY2UuaFwiO1xuXG5pZiBbWyBcIiRIQVZFX0RUUkFDRVwiID0gXCIxXCIgJiYgXCIkVFJBQ0lO R19EXCIgLW50IFwiJFRSQUNJTkdfSFwiIF1dO1xudGhlblxuXHRkdHJhY2UgLWggLW8gXCIkVFJB Q0lOR19IXCIgLXMgXCIkVFJBQ0lOR19EXCI7XG5maTtcbiI7CiAJCX07CisJCTVENUQ4QUJGMEUw RDBCMDMwMEY5QzY5MiAvKiBDcmVhdGUgL3Vzci9sb2NhbC9iaW4vanNjIHN5bWxpbmsgKi8gPSB7 CisJCQlpc2EgPSBQQlhTaGVsbFNjcmlwdEJ1aWxkUGhhc2U7CisJCQlidWlsZEFjdGlvbk1hc2sg PSAyMTQ3NDgzNjQ3OworCQkJZmlsZXMgPSAoCisJCQkpOworCQkJaW5wdXRQYXRocyA9ICgKKwkJ CQkiJChEU1RST09UKSQoSU5TVEFMTF9QQVRIKS9qc2MiLAorCQkJKTsKKwkJCW5hbWUgPSAiQ3Jl YXRlIC91c3IvbG9jYWwvYmluL2pzYyBzeW1saW5rIjsKKwkJCW91dHB1dFBhdGhzID0gKAorCQkJ CSIkKERTVFJPT1QpJChJTlNUQUxMX1BBVEhfUFJFRklYKS91c3IvbG9jYWwvYmluL2pzYyIsCisJ CQkpOworCQkJcnVuT25seUZvckRlcGxveW1lbnRQb3N0cHJvY2Vzc2luZyA9IDA7CisJCQlzaGVs bFBhdGggPSAvYmluL3NoOworCQkJc2hlbGxTY3JpcHQgPSAiaWYgW1sgXCIke1NLSVBfSU5TVEFM TH1cIiA9PSBcIk5PXCIgXV07IHRoZW5cbiAgICBta2RpciAtcCBcIiR7RFNUUk9PVH0ke0lOU1RB TExfUEFUSF9QUkVGSVh9L3Vzci9sb2NhbC9iaW5cIlxuICAgIGNkIFwiJHtEU1RST09UfSR7SU5T VEFMTF9QQVRIX1BSRUZJWH0vdXNyL2xvY2FsL2JpblwiXG4gICAgbG4gLXMgXCIuLi8uLi8uLiR7 SU5TVEFMTF9QQVRIX0FDVFVBTH0vanNjXCIganNjXG4gICAgZXhpdFxuZmlcbiI7CisJCX07CiAJ CTVEQUZENkNEMTQ2QjZCNkUwMEZCRUZCNCAvKiBJbnN0YWxsIFN1cHBvcnQgU2NyaXB0ICovID0g ewogCQkJaXNhID0gUEJYU2hlbGxTY3JpcHRCdWlsZFBoYXNlOwogCQkJYnVpbGRBY3Rpb25NYXNr ID0gODsK