129386 2014-02-26 13:11:20 -0800 [WebGL] Protect more WebGL entry points for pending contexts 2014-02-26 13:26:44 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino commit-queue esprehn+autocc gyuyoung.kim kondapallykalyan roger_fong webkit-bug-importer oldest_to_newest 984869 0 dino 2014-02-26 13:11:20 -0800 There are more entry points into WebGL than the public API. For example, drawing a WebGL canvas into another canvas. 984870 1 webkit-bug-importer 2014-02-26 13:12:02 -0800 <rdar://problem/16176389> 984872 2 225287 dino 2014-02-26 13:13:05 -0800 Created attachment 225287 Patch 984873 3 225287 jonlee 2014-02-26 13:16:12 -0800 Comment on attachment 225287 Patch Provisional r=me! 984874 4 225287 thorton 2014-02-26 13:17:56 -0800 Comment on attachment 225287 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225287&action=review > Source/WebCore/html/canvas/WebGLRenderingContext.cpp:811 > + return 0; nullptr 984878 5 dino 2014-02-26 13:26:44 -0800 Committed r164744: <http://trac.webkit.org/changeset/164744> 225287 2014-02-26 13:13:05 -0800 2014-02-26 13:17:56 -0800 Patch bug-129386-20140227081304.patch text/plain 2976 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjI1N2UyNWU4NmIxMTkx NDRlZDY1OWEwMDQ0ZTdmYjhmZjNmMzY1ZS4uM2FjMGYwYjJmMDIxYjE2OWMzYjAzYzRjZDE2NmVk YmY3OWNiOTNjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTAyLTI2ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViR0xdIFByb3RlY3QgbW9y ZSBXZWJHTCBlbnRyeSBwb2ludHMgZm9yIHBlbmRpbmcgY29udGV4dHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTM4NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSBlbnRyeSBwb2ludHMg aW50byBhIFdlYkdMUmVuZGVyaW5nQ29udGV4dCB0aGF0IGRvbid0CisgICAgICAgIGNvbWUgZnJv bSB0aGUgd2ViLWV4cG9zZWQgQVBJIGRpcmVjdGx5LCBzdWNoIGFzIGRyYXdJbWFnZSB3aXRoCisg ICAgICAgIHRoZSBXZWJHTCBjYW52YXMuIFByb3RlY3QgdGhlc2UgYnkgcmV0dXJuaW5nIGVhcmx5 IGlmIHdlJ3JlCisgICAgICAgIGEgcGVuZGluZyBjb250ZXh0LgorCisgICAgICAgICogaHRtbC9j YW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdM UmVuZGVyaW5nQ29udGV4dDo6bWFya0xheWVyQ29tcG9zaXRlZCk6CisgICAgICAgIChXZWJDb3Jl OjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnBhaW50UmVuZGVyaW5nUmVzdWx0c1RvQ2FudmFzKToK KyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6cGFpbnRSZW5kZXJpbmdS ZXN1bHRzVG9JbWFnZURhdGEpOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250 ZXh0OjpyZXNoYXBlKToKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6 Z2V0RXJyb3IpOgorCiAyMDE0LTAyLTI2ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNv bT4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIEluc3BlY3RvckNvdW50ZXJzLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKaW5k ZXggZDU5N2FmOWNhN2YwMzQxMzg0NjZiOGU0NDgwNDRjNDAxY2Q1ODRkNi4uNTUyZDA0OGRmZjIx MGUzYjMyYjUwN2M1YWU5NjhkOWQ4NzY2NzdmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC03NjQsMTEgKzc2NCwx NiBAQCB2b2lkIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6cmVzdG9yZVN0YXRlQWZ0ZXJDbGVhcigp CiAKIHZvaWQgV2ViR0xSZW5kZXJpbmdDb250ZXh0OjptYXJrTGF5ZXJDb21wb3NpdGVkKCkKIHsK KyAgICBpZiAoaXNDb250ZXh0TG9zdE9yUGVuZGluZygpKQorICAgICAgICByZXR1cm47CiAgICAg bV9jb250ZXh0LT5tYXJrTGF5ZXJDb21wb3NpdGVkKCk7CiB9CiAKIHZvaWQgV2ViR0xSZW5kZXJp bmdDb250ZXh0OjpwYWludFJlbmRlcmluZ1Jlc3VsdHNUb0NhbnZhcygpCiB7CisgICAgaWYgKGlz Q29udGV4dExvc3RPclBlbmRpbmcoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgaWYgKGNhbnZh cygpLT5kb2N1bWVudCgpLnByaW50aW5nKCkpCiAgICAgICAgIGNhbnZhcygpLT5jbGVhclByZXNl bnRhdGlvbkNvcHkoKTsKIApAQCAtODAyLDYgKzgwNyw4IEBAIHZvaWQgV2ViR0xSZW5kZXJpbmdD b250ZXh0OjpwYWludFJlbmRlcmluZ1Jlc3VsdHNUb0NhbnZhcygpCiAKIFBhc3NSZWZQdHI8SW1h Z2VEYXRhPiBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnBhaW50UmVuZGVyaW5nUmVzdWx0c1RvSW1h Z2VEYXRhKCkKIHsKKyAgICBpZiAoaXNDb250ZXh0TG9zdE9yUGVuZGluZygpKQorICAgICAgICBy ZXR1cm4gMDsKICAgICBjbGVhcklmQ29tcG9zaXRlZCgpOwogICAgIGlmIChtX2RyYXdpbmdCdWZm ZXIpCiAgICAgICAgIG1fZHJhd2luZ0J1ZmZlci0+Y29tbWl0KCk7CkBAIC04MTksNiArODI2LDkg QEAgUGFzc1JlZlB0cjxJbWFnZURhdGE+IFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6cGFpbnRSZW5k ZXJpbmdSZXN1bHRzVG9JbWFnZURhdGEoKQogCiB2b2lkIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6 cmVzaGFwZShpbnQgd2lkdGgsIGludCBoZWlnaHQpCiB7CisgICAgaWYgKGlzQ29udGV4dExvc3RP clBlbmRpbmcoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgLy8gVGhpcyBpcyBhbiBhcHByb3hp bWF0aW9uIGJlY2F1c2UgYXQgV2ViR0xSZW5kZXJpbmdDb250ZXh0IGxldmVsIHdlIGRvbid0CiAg ICAgLy8ga25vdyBpZiB0aGUgdW5kZXJseWluZyBGQk8gdXNlcyB0ZXh0dXJlcyBvciByZW5kZXJi dWZmZXJzLgogICAgIEdDM0RpbnQgbWF4U2l6ZSA9IHN0ZDo6bWluKG1fbWF4VGV4dHVyZVNpemUs IG1fbWF4UmVuZGVyYnVmZmVyU2l6ZSk7CkBAIC0yMzc2LDYgKzIzODYsOCBAQCBQYXNzUmVmUHRy PFdlYkdMQ29udGV4dEF0dHJpYnV0ZXM+IFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0Q29udGV4 dEF0dHJpYnV0ZXMoKQogCiBHQzNEZW51bSBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldEVycm9y KCkKIHsKKyAgICBpZiAoaXNDb250ZXh0TG9zdE9yUGVuZGluZygpKQorICAgICAgICByZXR1cm4g R3JhcGhpY3NDb250ZXh0M0Q6Ok5PX0VSUk9SOwogICAgIHJldHVybiBtX2NvbnRleHQtPmdldEVy cm9yKCk7CiB9CiAK