129364 2014-02-25 22:49:53 -0800 ASSERTION FAILED: m_heap->vm()->currentThreadIsHoldingAPILock() in inspector-protocol/* 2014-02-26 08:36:40 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap mark.lam commit-queue graouts joepeck mark.lam timothy webkit-bug-importer oldest_to_newest 984638 0 ap 2014-02-25 22:49:53 -0800 http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r164696%20(2899)/inspector-protocol/page/deny-X-FrameOption-crash-log.txt ASSERTION FAILED: m_heap->vm()->currentThreadIsHoldingAPILock() /Volumes/Data/slave/mavericks-debug/build/Source/JavaScriptCore/heap/MarkedAllocator.cpp(149) : void *JSC::MarkedAllocator::allocateSlowCase(size_t) 1 0x1106508d0 WTFCrash 2 0x110474955 JSC::MarkedAllocator::allocateSlowCase(unsigned long) 3 0x11189f7af JSC::MarkedAllocator::allocate(unsigned long) 4 0x11189f649 JSC::MarkedSpace::allocateWithImmortalStructureDestructor(unsigned long) 5 0x11189f5b6 JSC::Heap::allocateWithImmortalStructureDestructor(unsigned long) 6 0x11189f487 void* JSC::allocateCell<JSC::Structure>(JSC::Heap&, unsigned long) 7 0x11189f05f void* JSC::allocateCell<JSC::Structure>(JSC::Heap&) 8 0x11189eddf JSC::Structure::create(JSC::VM&, JSC::JSGlobalObject*, JSC::JSValue, JSC::TypeInfo const&, JSC::ClassInfo const*, unsigned char, unsigned int) 9 0x1124cc810 WebCore::JSCommandLineAPIHostPrototype::createStructure(JSC::VM&, JSC::JSGlobalObject*, JSC::JSValue) 10 0x1124cb769 WebCore::JSCommandLineAPIHost::createPrototype(JSC::VM&, JSC::JSGlobalObject*) ... 984642 1 webkit-bug-importer 2014-02-25 22:50:56 -0800 <rdar://problem/16170264> 984643 2 ap 2014-02-25 22:53:52 -0800 Actually, there are lots of inspector tests failing with this assertion, probably should file a bug about each one. Also: inspector-protocol/debugger/nested-inspectors.html inspector-protocol/dom-debugger/node-removed.html 984644 3 mark.lam 2014-02-25 22:54:49 -0800 (In reply to comment #2) > Actually, there are lots of inspector tests failing with this assertion, probably should file a bug about each one. > > Also: > > inspector-protocol/debugger/nested-inspectors.html > inspector-protocol/dom-debugger/node-removed.html They are probably due to the same root cause though. I'm investigating. 984671 4 mark.lam 2014-02-26 00:32:25 -0800 *** Bug 129360 has been marked as a duplicate of this bug. *** 984672 5 mark.lam 2014-02-26 00:38:42 -0800 The test failure is intermittent because it depends on an GC / allocation activity happening at exactly the right moment. That is why I don't see the failures when I run it on my machine. However, there is an easy way to get an equivalent reproduction case i.e. by adding the following assertion to JSC::Structure::create(): ASSERT(vm.currentThreadIsHoldingAPILock()); With that I can get the inspector-protocol tests to fail all the time. The failure is because InjectedScriptModule::ensureInjected() isn't using an APIEntryShim before it started calling functions that enter the VM. The fix is to use the shim here. Patch coming soon. 984676 6 225235 mark.lam 2014-02-26 00:47:59 -0800 Created attachment 225235 the patch. 984679 7 225237 mark.lam 2014-02-26 00:52:00 -0800 Created attachment 225237 patch 2: added a comment. 984750 8 225237 commit-queue 2014-02-26 08:36:37 -0800 Comment on attachment 225237 patch 2: added a comment. Clearing flags on attachment: 225237 Committed r164717: <http://trac.webkit.org/changeset/164717> 984751 9 commit-queue 2014-02-26 08:36:40 -0800 All reviewed patches have been landed. Closing bug. 225235 2014-02-26 00:47:59 -0800 2014-02-26 00:52:00 -0800 the patch. bug-129364.patch text/plain 1663 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0NzA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTAyLTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB U1NFUlRJT04gRkFJTEVEOiBtX2hlYXAtPnZtKCktPmN1cnJlbnRUaHJlYWRJc0hvbGRpbmdBUElM b2NrKCkgaW4gaW5zcGVjdG9yLXByb3RvY29sLyouCisgICAgICAgIDxodHRwczovL3dlYmtpdC5v cmcvYi8xMjkzNjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRNb2R1bGUuY3BwOgorICAgICAgICAoSW5z cGVjdG9yOjpJbmplY3RlZFNjcmlwdE1vZHVsZTo6ZW5zdXJlSW5qZWN0ZWQpOgorICAgICAgICAt IEFkZGVkIHRoZSBuZWVkZWQgYnV0IG1pc3NpbmcgQVBJRW50cnlTaGltLiAKKwogMjAxNC0wMi0y NSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogQ1JBU0ggd2hlbiBldmFsdWF0aW5nIGluIGNvbnNvbGUgb2YgSlNDb250ZXh0IFJXSSB3aXRo IGRpc2FibGVkIGJyZWFrcG9pbnRzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9JbmplY3RlZFNjcmlwdE1vZHVsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdE1vZHVsZS5jcHAJKHJldmlzaW9uIDE2 NDY5NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRN b2R1bGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCw3IEBACiAKICNpZiBFTkFCTEUo SU5TUEVDVE9SKQogCisjaW5jbHVkZSAiQVBJU2hpbXMuaCIKICNpbmNsdWRlICJJbmplY3RlZFNj cmlwdC5oIgogI2luY2x1ZGUgIkluamVjdGVkU2NyaXB0TWFuYWdlci5oIgogI2luY2x1ZGUgIlNj cmlwdEZ1bmN0aW9uQ2FsbC5oIgpAQCAtNjMsNiArNjQsNyBAQCB2b2lkIEluamVjdGVkU2NyaXB0 TW9kdWxlOjplbnN1cmVJbmplY3RlCiAgICAgICAgIHJldHVybjsKIAogICAgIC8vIEZJWE1FOiBN YWtlIHRoZSBJbmplY3RlZFNjcmlwdCBhIG1vZHVsZSBpdHNlbGYuCisgICAgSlNDOjpBUElFbnRy eVNoaW0gZW50cnlTaGltKGluamVjdGVkU2NyaXB0LnNjcmlwdFN0YXRlKCkpOwogICAgIERlcHJl Y2F0ZWQ6OlNjcmlwdEZ1bmN0aW9uQ2FsbCBmdW5jdGlvbihpbmplY3RlZFNjcmlwdC5pbmplY3Rl ZFNjcmlwdE9iamVjdCgpLCBBU0NJSUxpdGVyYWwoIm1vZHVsZSIpLCBpbmplY3RlZFNjcmlwdE1h bmFnZXItPmluc3BlY3RvckVudmlyb25tZW50KCkuZnVuY3Rpb25DYWxsSGFuZGxlcigpKTsKICAg ICBmdW5jdGlvbi5hcHBlbmRBcmd1bWVudChuYW1lKCkpOwogICAgIGJvb2wgaGFkRXhjZXB0aW9u ID0gZmFsc2U7Cg== 225237 2014-02-26 00:52:00 -0800 2014-02-26 08:36:37 -0800 patch 2: added a comment. bug-129364.patch text/plain 1736 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0NzA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAyLTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB U1NFUlRJT04gRkFJTEVEOiBtX2hlYXAtPnZtKCktPmN1cnJlbnRUaHJlYWRJc0hvbGRpbmdBUElM b2NrKCkgaW4gaW5zcGVjdG9yLXByb3RvY29sLyouCisgICAgICAgIDxodHRwczovL3dlYmtpdC5v cmcvYi8xMjkzNjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW5qZWN0ZWRTY3JpcHRNb2R1bGU6OmVuc3VyZUluamVjdGVkKCkgbmVlZHMgYW4gQVBJ RW50cnlTaGltLgorCisgICAgICAgICogaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0TW9kdWxlLmNw cDoKKyAgICAgICAgKEluc3BlY3Rvcjo6SW5qZWN0ZWRTY3JpcHRNb2R1bGU6OmVuc3VyZUluamVj dGVkKToKKyAgICAgICAgLSBBZGRlZCB0aGUgbmVlZGVkIGJ1dCBtaXNzaW5nIEFQSUVudHJ5U2hp bS4gCisKIDIwMTQtMDItMjUgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IENSQVNIIHdoZW4gZXZhbHVhdGluZyBpbiBjb25zb2xlIG9mIEpT Q29udGV4dCBSV0kgd2l0aCBkaXNhYmxlZCBicmVha3BvaW50cy4KSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRNb2R1bGUuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRNb2R1bGUu Y3BwCShyZXZpc2lvbiAxNjQ2OTcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9y L0luamVjdGVkU2NyaXB0TW9kdWxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQsNiArMzQsNyBA QAogCiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKIAorI2luY2x1ZGUgIkFQSVNoaW1zLmgiCiAjaW5j bHVkZSAiSW5qZWN0ZWRTY3JpcHQuaCIKICNpbmNsdWRlICJJbmplY3RlZFNjcmlwdE1hbmFnZXIu aCIKICNpbmNsdWRlICJTY3JpcHRGdW5jdGlvbkNhbGwuaCIKQEAgLTYzLDYgKzY0LDcgQEAgdm9p ZCBJbmplY3RlZFNjcmlwdE1vZHVsZTo6ZW5zdXJlSW5qZWN0ZQogICAgICAgICByZXR1cm47CiAK ICAgICAvLyBGSVhNRTogTWFrZSB0aGUgSW5qZWN0ZWRTY3JpcHQgYSBtb2R1bGUgaXRzZWxmLgor ICAgIEpTQzo6QVBJRW50cnlTaGltIGVudHJ5U2hpbShpbmplY3RlZFNjcmlwdC5zY3JpcHRTdGF0 ZSgpKTsKICAgICBEZXByZWNhdGVkOjpTY3JpcHRGdW5jdGlvbkNhbGwgZnVuY3Rpb24oaW5qZWN0 ZWRTY3JpcHQuaW5qZWN0ZWRTY3JpcHRPYmplY3QoKSwgQVNDSUlMaXRlcmFsKCJtb2R1bGUiKSwg aW5qZWN0ZWRTY3JpcHRNYW5hZ2VyLT5pbnNwZWN0b3JFbnZpcm9ubWVudCgpLmZ1bmN0aW9uQ2Fs bEhhbmRsZXIoKSk7CiAgICAgZnVuY3Rpb24uYXBwZW5kQXJndW1lbnQobmFtZSgpKTsKICAgICBi b29sIGhhZEV4Y2VwdGlvbiA9IGZhbHNlOwo=