129342 2014-02-25 15:48:57 -0800 [iOS] Exiting full screen immediately after entering full screen leaves full screen in a broken state 2014-02-28 09:51:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 jer.noble jer.noble oldest_to_newest 984518 0 jer.noble 2014-02-25 15:48:57 -0800 [iOS] Exiting full screen immediately after entering full screen leaves full screen in a broken state 985613 1 225474 jer.noble 2014-02-28 09:51:57 -0800 Created attachment 225474 Work in progress Uploading work-in-progress patch. The view controller presentViewController:animated:completion: method is non-cancellable, so we should probably look into adding a delegate which can exit full screen only once the animation into full screen completes. 225474 2014-02-28 09:51:57 -0800 2014-02-28 09:51:57 -0800 Work in progress bug-129342-20140228095204.patch text/plain 5354 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjMwZDY5NzU2MDI3ZmQ1 MTk3MzlmMjQ4MTdkYTY0MGYzODE4NzhlMy4uZjJjM2RmNDY2ZWMwNmVkMTRiMDNlMDFmM2NlMGI2 NGE0ZGNkYTA4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE0LTAyLTI1ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIFtpT1NdIEV4aXRpbmcgZnVs bCBzY3JlZW4gaW1tZWRpYXRlbHkgYWZ0ZXIgZW50ZXJpbmcgZnVsbCBzY3JlZW4gbGVhdmVzIGZ1 bGwgc2NyZWVuIGluIGEgYnJva2VuIHN0YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjkzNDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXaGVuIGVudGVyaW5nIGludG8gZnVsbCBzY3JlZW4sIGlmIGZ1 bGwgc2NyZWVuIGlzIGV4aXRpZWQgKGUuZy4gdGhyb3VnaCBKUykgYmVmb3JlIHRoZSAKKyAgICAg ICAgZW50ZXIgcmVxdWVzdCBpcyBhY3RlZCB1cG9uLCBtX21lZGlhRWxlbWVudCB3aWxsIGJlIG51 bGwgd2hlbiB0aG9zZSByZXF1ZXN0cyBhcmUgaGFuZGxlZC4KKyAgICAgICAgQ2hlY2sgZm9yIG51 bGxpdHkgb2YgbV9tZWRpYUVsZW1lbnQsIGFuZCBpbiB0aGUgY2FzZSBvZiByZXF1ZXN0RXhpdEZ1 bGxzY3JlZW4sIGp1c3QgY2xvc2UKKyAgICAgICAgdGhlIGZ1bGwgc2NyZWVuIHZpZXcgaWYgbm8g bV9tZWRpYUVsZW1lbnQgaXMgcHJlc2VudC4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9XZWJW aWRlb0Z1bGxzY3JlZW5Nb2RlbE1lZGlhRWxlbWVudC5tbToKKyAgICAgICAgKFdlYlZpZGVvRnVs bHNjcmVlbk1vZGVsTWVkaWFFbGVtZW50OjpyZXF1ZXN0RXhpdEZ1bGxTY3JlZW4pOgorICAgICAg ICAoV2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxNZWRpYUVsZW1lbnQ6OnBsYXkpOgorICAgICAgICAo V2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxNZWRpYUVsZW1lbnQ6OnBhdXNlKToKKyAgICAgICAgKFdl YlZpZGVvRnVsbHNjcmVlbk1vZGVsTWVkaWFFbGVtZW50Ojp0b2dnbGVQbGF5U3RhdGUpOgorICAg ICAgICAoV2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxNZWRpYUVsZW1lbnQ6OnNlZWtUb1RpbWUpOgor CisyMDE0LTAyLTI1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCiAgICAgICAg IFtFTUVdW01hY10gRml4IGEgZmV3IGlzc3VlcyBpbiBDRE1TZXNzaW9uTWVkaWFTb3VyY2VBVkZP YmpDLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5 MzEwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1 bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9X ZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQppbmRleCBjOGVhOTQyNjZmYzIyZTA4 NDRiODFjZWJkYTYwNmQ5ZmM0ZDJiNDVmLi42MWNmNGYyYjY3YmVjMDhlMmYxODdhYjNkNGZiOTYz Njk1ZDAwZjViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlk ZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCkBAIC0zNDUsNyArMzQ1 LDcgQEAgdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6ZXhpdEZ1bGxzY3Jl ZW5XaXRoQ29tcGxldGlvbkhhbmRsZXIoc3RkOjoKICAgICBSZWZQdHI8V2ViVmlkZW9GdWxsc2Ny ZWVuSW50ZXJmYWNlQVZLaXQ+IHN0cm9uZ1RoaXModGhpcyk7CiAgICAgCiAgICAgZGlzcGF0Y2hf YXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgW3N0cm9uZ1RoaXMsIGNvbXBsZXRpb25d ewotICAgICAgICBbc3Ryb25nVGhpcy0+bV92aWV3Q29udHJvbGxlciBkaXNtaXNzVmlld0NvbnRy b2xsZXJBbmltYXRlZDpZRVMgY29tcGxldGlvbjpbc3Ryb25nVGhpcywgY29tcGxldGlvbl17Cisg ICAgICAgIGF1dG8gaW5uZXJDb21wbGV0aW9uID0gW3N0cm9uZ1RoaXMsIGNvbXBsZXRpb25dewog ICAgICAgICAgICAgc3Ryb25nVGhpcy0+bV93aW5kb3cuZ2V0KCkuaGlkZGVuID0gWUVTOwogICAg ICAgICAgICAgc3Ryb25nVGhpcy0+bV93aW5kb3cuZ2V0KCkucm9vdFZpZXdDb250cm9sbGVyID0g bmlsOwogICAgICAgICAgICAgc3Ryb25nVGhpcy0+bV9wbGF5ZXJWaWV3Q29udHJvbGxlciA9IG5p bDsKQEAgLTM1NSw3ICszNTUsMTQgQEAgdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VB VktpdDo6ZXhpdEZ1bGxzY3JlZW5XaXRoQ29tcGxldGlvbkhhbmRsZXIoc3RkOjoKICAgICAgICAg ICAgICAgICBzdHJvbmdUaGlzLT5tX3ZpZGVvRnVsbHNjcmVlbk1vZGVsLT5kaWRFeGl0RnVsbHNj cmVlbigpOwogICAgICAgICAgICAgaWYgKGNvbXBsZXRpb24pCiAgICAgICAgICAgICAgICAgY29t cGxldGlvbigpOwotICAgICAgICB9XTsKKyAgICAgICAgfTsKKyAgICAgICAgaWYgKFtzdHJvbmdU aGlzLT5tX3BsYXllclZpZXdDb250cm9sbGVyIGlzQmVpbmdQcmVzZW50ZWRdKSB7CisgICAgICAg ICAgICAvLyBkaXNtaXNzVmlld0NvbnRyb2xsZXJBbmltYXRlZDpjb21wbGV0aW9uOiB3aWxsIHJl dHVybiB3aXRob3V0IGNhbGxpbmcgaXRzIGNvbXBsZXRpb24gYmxvY2sKKyAgICAgICAgICAgIC8v IGlmIGNhbGxlZCB3aGlsZSBhIHZpZXcgY29udHJvbGxlciBpcyBzdGlsbCBiZWluZyBwcmVzZW50 ZWQuCisgICAgICAgICAgICBpbm5lckNvbXBsZXRpb24oKTsKKyAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgfQorICAgICAgICBbc3Ryb25nVGhpcy0+bV92aWV3Q29udHJvbGxlciBkaXNtaXNz Vmlld0NvbnRyb2xsZXJBbmltYXRlZDpZRVMgY29tcGxldGlvbjppbm5lckNvbXBsZXRpb25dOwog ICAgIH0pOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2Vi VmlkZW9GdWxsc2NyZWVuTW9kZWxNZWRpYUVsZW1lbnQubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxNZWRpYUVsZW1lbnQubW0KaW5kZXggNWFi ZGU1NzE5NjlkMmY1MTA3NzQ3YmIyZWI4ZWY1MzUxMmNhZjQ5ZC4uZjZlNTZiMDMxNzRlZDE0ZmI1 YTVmZTBhNmI5ZGU5ZWVjMWYyNjdmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbk1vZGVsTWVkaWFFbGVtZW50Lm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbE1lZGlhRWxlbWVu dC5tbQpAQCAtMTI3LDYgKzEyNywxMSBAQCB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbk1vZGVsTWVk aWFFbGVtZW50OjpyZXF1ZXN0RXhpdEZ1bGxTY3JlZW4oKQogewogICAgIF9fYmxvY2sgUmVmUHRy PFdlYlZpZGVvRnVsbHNjcmVlbk1vZGVsTWVkaWFFbGVtZW50PiBwcm90ZWN0KHRoaXMpOwogICAg IFdlYlRocmVhZFJ1biheeworICAgICAgICBpZiAoIW1fbWVkaWFFbGVtZW50KSB7CisgICAgICAg ICAgICBtX3ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZS0+ZXhpdEZ1bGxzY3JlZW4oKTsKKyAgICAg ICAgICAgIHByb3RlY3QuY2xlYXIoKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQog ICAgICAgICBtX21lZGlhRWxlbWVudC0+cGF1c2UoKTsKICAgICAgICAgbV9tZWRpYUVsZW1lbnQt PmV4aXRGdWxsc2NyZWVuKCk7CiAgICAgICAgIHByb3RlY3QuY2xlYXIoKTsKQEAgLTEzNiw2ICsx NDEsMTAgQEAgdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbE1lZGlhRWxlbWVudDo6cmVxdWVz dEV4aXRGdWxsU2NyZWVuKCkKIHZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxNZWRpYUVsZW1l bnQ6OnBsYXkoKSB7CiAgICAgX19ibG9jayBSZWZQdHI8V2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxN ZWRpYUVsZW1lbnQ+IHByb3RlY3QodGhpcyk7CiAgICAgV2ViVGhyZWFkUnVuKF57CisgICAgICAg IGlmICghbV9tZWRpYUVsZW1lbnQpIHsKKyAgICAgICAgICAgIHByb3RlY3QuY2xlYXIoKTsKKyAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQogICAgICAgICBtX21lZGlhRWxlbWVudC0+cGxh eSgpOwogICAgICAgICBwcm90ZWN0LmNsZWFyKCk7CiAgICAgfSk7CkBAIC0xNDUsNiArMTU0LDEw IEBAIHZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxNZWRpYUVsZW1lbnQ6OnBhdXNlKCkKIHsK ICAgICBfX2Jsb2NrIFJlZlB0cjxXZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbE1lZGlhRWxlbWVudD4g cHJvdGVjdCh0aGlzKTsKICAgICBXZWJUaHJlYWRSdW4oXnsKKyAgICAgICAgaWYgKCFtX21lZGlh RWxlbWVudCkgeworICAgICAgICAgICAgcHJvdGVjdC5jbGVhcigpOworICAgICAgICAgICAgcmV0 dXJuOworICAgICAgICB9CiAgICAgICAgIG1fbWVkaWFFbGVtZW50LT5wYXVzZSgpOwogICAgICAg ICBwcm90ZWN0LmNsZWFyKCk7CiAgICAgfSk7CkBAIC0xNTQsNiArMTY3LDEwIEBAIHZvaWQgV2Vi VmlkZW9GdWxsc2NyZWVuTW9kZWxNZWRpYUVsZW1lbnQ6OnRvZ2dsZVBsYXlTdGF0ZSgpCiB7CiAg ICAgX19ibG9jayBSZWZQdHI8V2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxNZWRpYUVsZW1lbnQ+IHBy b3RlY3QodGhpcyk7CiAgICAgV2ViVGhyZWFkUnVuKF57CisgICAgICAgIGlmICghbV9tZWRpYUVs ZW1lbnQpIHsKKyAgICAgICAgICAgIHByb3RlY3QuY2xlYXIoKTsKKyAgICAgICAgICAgIHJldHVy bjsKKyAgICAgICAgfQogICAgICAgICBtX21lZGlhRWxlbWVudC0+dG9nZ2xlUGxheVN0YXRlKCk7 CiAgICAgICAgIHByb3RlY3QuY2xlYXIoKTsKICAgICB9KTsKQEAgLTE2Myw2ICsxODAsMTAgQEAg dm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbE1lZGlhRWxlbWVudDo6c2Vla1RvVGltZShkb3Vi bGUgdGltZSkKIHsKICAgICBfX2Jsb2NrIFJlZlB0cjxXZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbE1l ZGlhRWxlbWVudD4gcHJvdGVjdCh0aGlzKTsKICAgICBXZWJUaHJlYWRSdW4oXnsKKyAgICAgICAg aWYgKCFtX21lZGlhRWxlbWVudCkgeworICAgICAgICAgICAgcHJvdGVjdC5jbGVhcigpOworICAg ICAgICAgICAgcmV0dXJuOworICAgICAgICB9CiAgICAgICAgIG1fbWVkaWFFbGVtZW50LT5zZXRD dXJyZW50VGltZSh0aW1lKTsKICAgICAgICAgcHJvdGVjdC5jbGVhcigpOwogICAgIH0pOwo=