129341 2014-02-25 15:23:12 -0800 JSDOMPromise methods should acquire VM lock before calling into JS 2014-04-24 16:46:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 129265 1 mark.lam mark.lam ap ggaren sam oldest_to_newest 984514 0 mark.lam 2014-02-25 15:23:12 -0800 Some crypto tests were failing after r164627: <http://trac.webkit.org/r164627> because the resolve() and reject() methods were calling into JS VM without using an entry shim. r164627 added assertions that caught this issue. Patch coming. 984515 1 225191 mark.lam 2014-02-25 15:26:33 -0800 Created attachment 225191 the patch. 984516 2 225191 ggaren 2014-02-25 15:43:29 -0800 Comment on attachment 225191 the patch. r=me 984517 3 mark.lam 2014-02-25 15:48:51 -0800 Thanks. Landed in r164679: <http://trac.webkit.org/r164679>. 1003877 4 darin 2014-04-24 16:46:02 -0700 Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. 225191 2014-02-25 15:26:33 -0800 2014-02-25 15:43:29 -0800 the patch. bug-129341.patch text/plain 3244 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDY3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAyLTI1ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBKU0RPTVByb21pc2UgbWV0aG9kcyBz aG91bGQgYWNxdWlyZSBWTSBsb2NrIGJlZm9yZSBjYWxsaW5nIGludG8gSlMuCisgICAgICAgIDxo dHRwczovL3dlYmtpdC5vcmcvYi8xMjkzNDE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogYmluZGluZ3Mv anMvSlNET01Qcm9taXNlLmg6CisgICAgICAgIChXZWJDb3JlOjpEZWZlcnJlZFdyYXBwZXI6OnJl c29sdmUpOgorICAgICAgICAoV2ViQ29yZTo6RGVmZXJyZWRXcmFwcGVyOjpyZWplY3QpOgorICAg ICAgICAoV2ViQ29yZTo6RGVmZXJyZWRXcmFwcGVyOjpyZXNvbHZlPFN0cmluZz4pOgorICAgICAg ICAoV2ViQ29yZTo6RGVmZXJyZWRXcmFwcGVyOjpyZXNvbHZlPGJvb2w+KToKKyAgICAgICAgKFdl YkNvcmU6OmNoYXI+Pik6CisgICAgICAgIChXZWJDb3JlOjpEZWZlcnJlZFdyYXBwZXI6OnJlamVj dDxTdHJpbmc+KToKKwogMjAxNC0wMi0yNSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBUaHJlYWRTcGVjaWZpY0luc3BlY3RvckNvdW50 ZXJzLgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Qcm9taXNlLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Qcm9taXNlLmgJKHJl dmlzaW9uIDE2NDY1OSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NUHJvbWlz ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSAiSlNDcnlwdG9L ZXkuaCIKICNpbmNsdWRlICJKU0NyeXB0b0tleVBhaXIuaCIKICNpbmNsdWRlICJKU0RPTUJpbmRp bmcuaCIKKyNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9BUElTaGltcy5oPgogI2luY2x1ZGUgPGhl YXAvU3Ryb25nSW5saW5lcy5oPgogI2luY2x1ZGUgPHJ1bnRpbWUvSlNQcm9taXNlRGVmZXJyZWQu aD4KIApAQCAtNTgsNiArNTksNyBAQCB0ZW1wbGF0ZTxjbGFzcyBSZXNvbHZlUmVzdWx0VHlwZT4K IGlubGluZSB2b2lkIERlZmVycmVkV3JhcHBlcjo6cmVzb2x2ZShjb25zdCBSZXNvbHZlUmVzdWx0 VHlwZSYgcmVzdWx0KQogewogICAgIEpTQzo6RXhlY1N0YXRlKiBleGVjID0gbV9nbG9iYWxPYmpl Y3QtPmdsb2JhbEV4ZWMoKTsKKyAgICBKU0M6OkFQSUVudHJ5U2hpbSBlbnRyeVNoaW0oZXhlYyk7 CiAgICAgcmVzb2x2ZShleGVjLCB0b0pTKGV4ZWMsIG1fZ2xvYmFsT2JqZWN0LmdldCgpLCByZXN1 bHQpKTsKIH0KIApAQCAtNjUsNiArNjcsNyBAQCB0ZW1wbGF0ZTxjbGFzcyBSZWplY3RSZXN1bHRU eXBlPgogaW5saW5lIHZvaWQgRGVmZXJyZWRXcmFwcGVyOjpyZWplY3QoY29uc3QgUmVqZWN0UmVz dWx0VHlwZSYgcmVzdWx0KQogewogICAgIEpTQzo6RXhlY1N0YXRlKiBleGVjID0gbV9nbG9iYWxP YmplY3QtPmdsb2JhbEV4ZWMoKTsKKyAgICBKU0M6OkFQSUVudHJ5U2hpbSBlbnRyeVNoaW0oZXhl Yyk7CiAgICAgcmVqZWN0KGV4ZWMsIHRvSlMoZXhlYywgbV9nbG9iYWxPYmplY3QuZ2V0KCksIHJl c3VsdCkpOwogfQogCkBAIC03Miw2ICs3NSw3IEBAIHRlbXBsYXRlPD4KIGlubGluZSB2b2lkIERl ZmVycmVkV3JhcHBlcjo6cmVqZWN0KGNvbnN0IHN0ZDo6bnVsbHB0cl90JikKIHsKICAgICBKU0M6 OkV4ZWNTdGF0ZSogZXhlYyA9IG1fZ2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCk7CisgICAgSlND OjpBUElFbnRyeVNoaW0gZW50cnlTaGltKGV4ZWMpOwogICAgIHJlamVjdChleGVjLCBKU0M6Ompz TnVsbCgpKTsKIH0KIApAQCAtNzksNiArODMsNyBAQCB0ZW1wbGF0ZTw+CiBpbmxpbmUgdm9pZCBE ZWZlcnJlZFdyYXBwZXI6OnJlc29sdmU8U3RyaW5nPihjb25zdCBTdHJpbmcmIHJlc3VsdCkKIHsK ICAgICBKU0M6OkV4ZWNTdGF0ZSogZXhlYyA9IG1fZ2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCk7 CisgICAgSlNDOjpBUElFbnRyeVNoaW0gZW50cnlTaGltKGV4ZWMpOwogICAgIHJlc29sdmUoZXhl YywganNTdHJpbmcoZXhlYywgcmVzdWx0KSk7CiB9CiAKQEAgLTg2LDYgKzkxLDcgQEAgdGVtcGxh dGU8PgogaW5saW5lIHZvaWQgRGVmZXJyZWRXcmFwcGVyOjpyZXNvbHZlPGJvb2w+KGNvbnN0IGJv b2wmIHJlc3VsdCkKIHsKICAgICBKU0M6OkV4ZWNTdGF0ZSogZXhlYyA9IG1fZ2xvYmFsT2JqZWN0 LT5nbG9iYWxFeGVjKCk7CisgICAgSlNDOjpBUElFbnRyeVNoaW0gZW50cnlTaGltKGV4ZWMpOwog ICAgIHJlc29sdmUoZXhlYywgSlNDOjpqc0Jvb2xlYW4ocmVzdWx0KSk7CiB9CiAKQEAgLTkzLDYg Kzk5LDcgQEAgdGVtcGxhdGU8PgogaW5saW5lIHZvaWQgRGVmZXJyZWRXcmFwcGVyOjpyZXNvbHZl PFZlY3Rvcjx1bnNpZ25lZCBjaGFyPj4oY29uc3QgVmVjdG9yPHVuc2lnbmVkIGNoYXI+JiByZXN1 bHQpCiB7CiAgICAgSlNDOjpFeGVjU3RhdGUqIGV4ZWMgPSBtX2dsb2JhbE9iamVjdC0+Z2xvYmFs RXhlYygpOworICAgIEpTQzo6QVBJRW50cnlTaGltIGVudHJ5U2hpbShleGVjKTsKICAgICBSZWZQ dHI8QXJyYXlCdWZmZXI+IGJ1ZmZlciA9IEFycmF5QnVmZmVyOjpjcmVhdGUocmVzdWx0LmRhdGEo KSwgcmVzdWx0LnNpemUoKSk7CiAgICAgcmVzb2x2ZShleGVjLCB0b0pTKGV4ZWMsIG1fZ2xvYmFs T2JqZWN0LmdldCgpLCBidWZmZXIuZ2V0KCkpKTsKIH0KQEAgLTEwMSw2ICsxMDgsNyBAQCB0ZW1w bGF0ZTw+CiBpbmxpbmUgdm9pZCBEZWZlcnJlZFdyYXBwZXI6OnJlamVjdDxTdHJpbmc+KGNvbnN0 IFN0cmluZyYgcmVzdWx0KQogewogICAgIEpTQzo6RXhlY1N0YXRlKiBleGVjID0gbV9nbG9iYWxP YmplY3QtPmdsb2JhbEV4ZWMoKTsKKyAgICBKU0M6OkFQSUVudHJ5U2hpbSBlbnRyeVNoaW0oZXhl Yyk7CiAgICAgcmVqZWN0KGV4ZWMsIGpzU3RyaW5nKGV4ZWMsIHJlc3VsdCkpOwogfQogCg==