129304 2014-02-25 06:13:57 -0800 Inspector server should be enabled only when the web sockets is enabled too. 2014-02-26 05:34:59 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 gbalogh.u-szeged webkit-unassigned commit-queue graouts joepeck ossy timothy webkit-bug-importer oldest_to_newest 984293 0 gbalogh.u-szeged 2014-02-25 06:13:57 -0800 The inspector won't work when the web sockets is disabled. 984294 1 webkit-bug-importer 2014-02-25 06:14:17 -0800 <rdar://problem/16159582> 984295 2 225144 gbalogh.u-szeged 2014-02-25 06:18:43 -0800 Created attachment 225144 patch 984307 3 225144 ossy 2014-02-25 06:48:39 -0800 Comment on attachment 225144 patch View in context: https://bugs.webkit.org/attachment.cgi?id=225144&action=review The fix LGTM, but please fix the changelog. > Source/WebKit2/ChangeLog:3 > + Inspector should be enabled only when the web sockets is enabled too. You meant "Inspector _server_ should be enabled only when the web sockets is enabled too." 984657 4 225229 gbalogh.u-szeged 2014-02-25 23:42:04 -0800 Created attachment 225229 changelog typo fix 984714 5 225229 commit-queue 2014-02-26 05:34:57 -0800 Comment on attachment 225229 changelog typo fix Clearing flags on attachment: 225229 Committed r164714: <http://trac.webkit.org/changeset/164714> 984715 6 commit-queue 2014-02-26 05:34:59 -0800 All reviewed patches have been landed. Closing bug. 225144 2014-02-25 06:18:43 -0800 2014-02-25 23:42:04 -0800 patch bug129304.diff text/plain 1112 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkNWFlMTNiLi5mMGM2NjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTQtMDItMjUgIEdlcmdvIEJhbG9naCAgPGdiYWxvZ2gudS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KKworICAgICAgICBJbnNwZWN0b3Igc2hvdWxkIGJlIGVuYWJsZWQgb25seSB3 aGVuIHRoZSB3ZWIgc29ja2V0cyBpcyBlbmFibGVkIHRvby4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTMwNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY29uZmlnLmg6CisKIDIwMTQtMDItMjAgIFph bGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgcmVkdW5kYW50 IGRldmljZVNjYWxlRmFjdG9yKCkgZnVuY3Rpb25zIGFuZCBtYWtlIGNhbGxlcnMgdXNlIERvY3Vt ZW50OjpkZXZpY2VTY2FsZUZhY3RvcigpIHdoZW4gYWNjZXNzaWJsZS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL2NvbmZpZy5oIGIvU291cmNlL1dlYktpdDIvY29uZmlnLmgKaW5kZXggMTll YWY5ZC4uMWY4NWZkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvY29uZmlnLmgKKysrIGIv U291cmNlL1dlYktpdDIvY29uZmlnLmgKQEAgLTcxLDcgKzcxLDcgQEAKICNkZWZpbmUgUExVR0lO X0FSQ0hJVEVDVFVSRShBUkNIKSAoZGVmaW5lZCBQTFVHSU5fQVJDSElURUNUVVJFXyMjQVJDSCAm JiBQTFVHSU5fQVJDSElURUNUVVJFXyMjQVJDSCkKIAogI2lmbmRlZiBFTkFCTEVfSU5TUEVDVE9S X1NFUlZFUgotI2lmIEVOQUJMRShJTlNQRUNUT1IpICYmIChQTEFURk9STShHVEspIHx8IFBMQVRG T1JNKEVGTCkpCisjaWYgRU5BQkxFKElOU1BFQ1RPUikgJiYgRU5BQkxFKFdFQl9TT0NLRVRTKSAm JiAoUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShFRkwpKQogI2RlZmluZSBFTkFCTEVfSU5TUEVD VE9SX1NFUlZFUiAxCiAjZW5kaWYKICNlbmRpZgo= 225229 2014-02-25 23:42:04 -0800 2014-02-26 05:34:57 -0800 changelog typo fix bug129304.diff text/plain 1119 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkNWFlMTNiLi5mMGM2NjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTQtMDItMjUgIEdlcmdvIEJhbG9naCAgPGdiYWxvZ2gudS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KKworICAgICAgICBJbnNwZWN0b3Igc2VydmVyIHNob3VsZCBiZSBlbmFibGVk IG9ubHkgd2hlbiB0aGUgd2ViIHNvY2tldHMgaXMgZW5hYmxlZCB0b28uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjkzMDQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNvbmZpZy5oOgorCiAyMDE0LTAy LTIwICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHJl ZHVuZGFudCBkZXZpY2VTY2FsZUZhY3RvcigpIGZ1bmN0aW9ucyBhbmQgbWFrZSBjYWxsZXJzIHVz ZSBEb2N1bWVudDo6ZGV2aWNlU2NhbGVGYWN0b3IoKSB3aGVuIGFjY2Vzc2libGUuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9jb25maWcuaCBiL1NvdXJjZS9XZWJLaXQyL2NvbmZpZy5oCmlu ZGV4IDE5ZWFmOWQuLjFmODVmZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL2NvbmZpZy5o CisrKyBiL1NvdXJjZS9XZWJLaXQyL2NvbmZpZy5oCkBAIC03MSw3ICs3MSw3IEBACiAjZGVmaW5l IFBMVUdJTl9BUkNISVRFQ1RVUkUoQVJDSCkgKGRlZmluZWQgUExVR0lOX0FSQ0hJVEVDVFVSRV8j I0FSQ0ggJiYgUExVR0lOX0FSQ0hJVEVDVFVSRV8jI0FSQ0gpCiAKICNpZm5kZWYgRU5BQkxFX0lO U1BFQ1RPUl9TRVJWRVIKLSNpZiBFTkFCTEUoSU5TUEVDVE9SKSAmJiAoUExBVEZPUk0oR1RLKSB8 fCBQTEFURk9STShFRkwpKQorI2lmIEVOQUJMRShJTlNQRUNUT1IpICYmIEVOQUJMRShXRUJfU09D S0VUUykgJiYgKFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oRUZMKSkKICNkZWZpbmUgRU5BQkxF X0lOU1BFQ1RPUl9TRVJWRVIgMQogI2VuZGlmCiAjZW5kaWYK