129272 2014-02-24 13:41:06 -0800 JSC regressions after r164494 2014-02-24 18:13:37 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac (Intel) Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned commit-queue mark.lam mhahnenberg msaboff oldest_to_newest 984048 0 peavo 2014-02-24 13:41:06 -0800 The patch in bug 129155 caused many JSC test failures for 32-bit Mac and GTK. 984060 1 225095 peavo 2014-02-24 14:05:42 -0800 Created attachment 225095 Patch 984061 2 225095 ggaren 2014-02-24 14:11:24 -0800 Comment on attachment 225095 Patch r=me 984063 3 225096 peavo 2014-02-24 14:13:40 -0800 Created attachment 225096 Patch 984064 4 225096 mark.lam 2014-02-24 14:22:02 -0800 Comment on attachment 225096 Patch I don't know the x87 instructions, but In the original patch <http://trac.webkit.org/changeset/164494>, you modified all 3 cases in that if else statement blob. Do the other 2 cases need to be conditional on isIntelSyntax as well? Please comment. Thanks. 984068 5 peavo 2014-02-24 14:25:39 -0800 (In reply to comment #4) > (From update of attachment 225096 [details]) > I don't know the x87 instructions, but In the original patch <http://trac.webkit.org/changeset/164494>, you modified all 3 cases in that if else statement blob. Do the other 2 cases need to be conditional on isIntelSyntax as well? Please comment. Thanks. No, I believe I only added the orderOperands function there, which will do nothing for !isIntelSyntax. 984071 6 225096 mark.lam 2014-02-24 14:31:06 -0800 Comment on attachment 225096 Patch r=me 984080 7 225096 commit-queue 2014-02-24 14:53:17 -0800 Comment on attachment 225096 Patch Clearing flags on attachment: 225096 Committed r164612: <http://trac.webkit.org/changeset/164612> 984081 8 commit-queue 2014-02-24 14:53:19 -0800 All reviewed patches have been landed. Closing bug. 984083 9 peavo 2014-02-24 14:55:26 -0800 (In reply to comment #6) > (From update of attachment 225096 [details]) > r=me Thanks, sorry for the fuzz ... 984132 10 mhahnenberg 2014-02-24 18:13:37 -0800 *** Bug 129281 has been marked as a duplicate of this bug. *** 225095 2014-02-24 14:05:42 -0800 2014-02-24 14:13:30 -0800 Patch bug-129272-20140224230539.patch text/plain 1644 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0NjA2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDE0LTAyLTI0ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisg ICAgICAgIEpTQyByZWdyZXNzaW9ucyBhZnRlciByMTY0NDk0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjkyNzIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG9mZmxpbmVhc20veDg2LnJiOiBPbmx5IGF2 b2lkIHJldmVyc2Ugb3Bjb2RlIChmZGl2cikgZm9yIFdpbmRvd3MuCisKIDIwMTQtMDItMjQgIFRh bWFzIEdlcmdlbHkgIDx0Z2VyZ2VseS51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAg ICAgICAgIENvZGUgY2xlYW51cDogcmVtb3ZlIGxlZnRvdmVyIEVOQUJMRShXT1JLRVJTKSBtYWNy b3MgYW5kIHN1cHBvcnQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94 ODYucmIKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20veDg2 LnJiCShyZXZpc2lvbiAxNjQ2MDUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFz bS94ODYucmIJKHdvcmtpbmcgY29weSkKQEAgLTgwOCw3ICs4MDgsMTEgQEAgY2xhc3MgSW5zdHJ1 Y3Rpb24KICAgICAgICAgaWYgKG9wZXJhbmRzWzFdLng4N0RlZmF1bHRTdGFja1Bvc2l0aW9uID09 IDApCiAgICAgICAgICAgICAkYXNtLnB1dHMgIiN7b3Bjb2RlfSAje29yZGVyT3BlcmFuZHMob3Bl cmFuZHNbMF0ueDg3T3BlcmFuZCgwKSwgcmVnaXN0ZXIoInN0IikpfSIKICAgICAgICAgZWxzaWYg KG9wZXJhbmRzWzBdLng4N0RlZmF1bHRTdGFja1Bvc2l0aW9uID09IDApCi0gICAgICAgICAgICAk YXNtLnB1dHMgIiN7b3Bjb2RlfSAje29yZGVyT3BlcmFuZHMocmVnaXN0ZXIoInN0IiksIG9wZXJh bmRzWzFdLng4N09wZXJhbmQoMCkpfSIKKyAgICAgICAgICAgIGlmICFpc0ludGVsU3ludGF4Cisg ICAgICAgICAgICAgICAgJGFzbS5wdXRzICIje29wY29kZXJldmVyc2V9ICN7cmVnaXN0ZXIoInN0 Iil9LCAje29wZXJhbmRzWzFdLng4N09wZXJhbmQoMCl9IgorICAgICAgICAgICAgZWxzZQorICAg ICAgICAgICAgICAgICRhc20ucHV0cyAiI3tvcGNvZGV9ICN7b3BlcmFuZHNbMV0ueDg3T3BlcmFu ZCgwKSl9LCAje3JlZ2lzdGVyKCJzdCIpfSIKKyAgICAgICAgICAgIGVuZAogICAgICAgICBlbHNl CiAgICAgICAgICAgICAkYXNtLnB1dHMgImZsZCAje29wZXJhbmRzWzBdLng4N09wZXJhbmQoMCl9 IgogICAgICAgICAgICAgJGFzbS5wdXRzICIje29wY29kZXJldmVyc2V9cCAje29yZGVyT3BlcmFu ZHMocmVnaXN0ZXIoInN0IiksIG9wZXJhbmRzWzFdLng4N09wZXJhbmQoMSkpfSIK 225096 2014-02-24 14:13:40 -0800 2014-02-24 14:53:17 -0800 Patch bug-129272-20140224231338.patch text/plain 1643 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0NjA2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDE0LTAyLTI0ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisg ICAgICAgIEpTQyByZWdyZXNzaW9ucyBhZnRlciByMTY0NDk0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjkyNzIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG9mZmxpbmVhc20veDg2LnJiOiBPbmx5IGF2 b2lkIHJldmVyc2Ugb3Bjb2RlIChmZGl2cikgZm9yIFdpbmRvd3MuCisKIDIwMTQtMDItMjQgIFRh bWFzIEdlcmdlbHkgIDx0Z2VyZ2VseS51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAg ICAgICAgIENvZGUgY2xlYW51cDogcmVtb3ZlIGxlZnRvdmVyIEVOQUJMRShXT1JLRVJTKSBtYWNy b3MgYW5kIHN1cHBvcnQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94 ODYucmIKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20veDg2 LnJiCShyZXZpc2lvbiAxNjQ2MDUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFz bS94ODYucmIJKHdvcmtpbmcgY29weSkKQEAgLTgwOCw3ICs4MDgsMTEgQEAgY2xhc3MgSW5zdHJ1 Y3Rpb24KICAgICAgICAgaWYgKG9wZXJhbmRzWzFdLng4N0RlZmF1bHRTdGFja1Bvc2l0aW9uID09 IDApCiAgICAgICAgICAgICAkYXNtLnB1dHMgIiN7b3Bjb2RlfSAje29yZGVyT3BlcmFuZHMob3Bl cmFuZHNbMF0ueDg3T3BlcmFuZCgwKSwgcmVnaXN0ZXIoInN0IikpfSIKICAgICAgICAgZWxzaWYg KG9wZXJhbmRzWzBdLng4N0RlZmF1bHRTdGFja1Bvc2l0aW9uID09IDApCi0gICAgICAgICAgICAk YXNtLnB1dHMgIiN7b3Bjb2RlfSAje29yZGVyT3BlcmFuZHMocmVnaXN0ZXIoInN0IiksIG9wZXJh bmRzWzFdLng4N09wZXJhbmQoMCkpfSIKKyAgICAgICAgICAgIGlmICFpc0ludGVsU3ludGF4Cisg ICAgICAgICAgICAgICAgJGFzbS5wdXRzICIje29wY29kZXJldmVyc2V9ICN7cmVnaXN0ZXIoInN0 Iil9LCAje29wZXJhbmRzWzFdLng4N09wZXJhbmQoMCl9IgorICAgICAgICAgICAgZWxzZQorICAg ICAgICAgICAgICAgICRhc20ucHV0cyAiI3tvcGNvZGV9ICN7b3BlcmFuZHNbMV0ueDg3T3BlcmFu ZCgwKX0sICN7cmVnaXN0ZXIoInN0Iil9IgorICAgICAgICAgICAgZW5kCiAgICAgICAgIGVsc2UK ICAgICAgICAgICAgICRhc20ucHV0cyAiZmxkICN7b3BlcmFuZHNbMF0ueDg3T3BlcmFuZCgwKX0i CiAgICAgICAgICAgICAkYXNtLnB1dHMgIiN7b3Bjb2RlcmV2ZXJzZX1wICN7b3JkZXJPcGVyYW5k cyhyZWdpc3Rlcigic3QiKSwgb3BlcmFuZHNbMV0ueDg3T3BlcmFuZCgxKSl9Igo=