129260 2014-02-24 11:12:53 -0800 Web Inspector: Toolbar is all white on non-Mac platforms 2014-02-24 19:50:06 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy graouts joepeck timothy webkit-bug-importer oldest_to_newest 983959 0 timothy 2014-02-24 11:12:53 -0800 The toolbar is all white on Windows and Linux. We should give those platforms a default toolbar background. 983962 1 225076 timothy 2014-02-24 11:16:01 -0800 Created attachment 225076 Patch 983963 2 webkit-bug-importer 2014-02-24 11:16:27 -0800 <rdar://problem/16149805> 983987 3 225076 joepeck 2014-02-24 11:45:45 -0800 Comment on attachment 225076 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Main.js:203 > + } else if (navigator.platform.contains("Win")) > + document.body.classList.add("windows-platform"); > + else if (navigator.platform.contains("Linux")) > + document.body.classList.add("linux-platform"); > + else > + document.body.classList.add("other-platform"); Should we use InspectorFrontendHost.platform instead? It would simplify things a bit. 984032 4 timothy 2014-02-24 13:24:40 -0800 https://trac.webkit.org/changeset/164604 984092 5 225076 graouts 2014-02-24 15:23:00 -0800 Comment on attachment 225076 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review > Source/WebInspectorUI/UserInterface/Views/Toolbar.css:58 > + background-image: -webkit-linear-gradient(top, rgb(233, 233, 233), rgb(229, 229, 229)); You could have used the W3C syntax as follows, with the default value for the orientation: linear-gradient(rgb(229, 229, 229), rgb(233, 233, 233)); 984163 6 225076 timothy 2014-02-24 19:50:06 -0800 Comment on attachment 225076 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review >> Source/WebInspectorUI/UserInterface/Views/Toolbar.css:58 >> + background-image: -webkit-linear-gradient(top, rgb(233, 233, 233), rgb(229, 229, 229)); > > You could have used the W3C syntax as follows, with the default value for the orientation: linear-gradient(rgb(229, 229, 229), rgb(233, 233, 233)); I fixed all our gradients to use the in prefixed version in a follow up. 225076 2014-02-24 11:16:01 -0800 2014-02-24 19:50:06 -0800 Patch bug-129260-20140224111600.patch text/plain 4739 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk ZjhiYmQ5MjAxNTVhNzhmOWNjOWQ4YzFiYWEwMjdlMGRhNDJjOWMyLi5hOWUyYjY0MmY3MjZhZjNk ZGMzNDlhMDZjOWE2MzYyY2VhZThhNjcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNC0wMi0yNCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgR2l2ZSBub24tTWFjIHBsYXRmb3JtcyBhIGRlZmF1bHQgdG9vbGJhciBi YWNrZ3JvdW5kIHNvIGl0IGlzbid0IGp1c3Qgd2hpdGUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTI2MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCk6IFN0eWxlIHRoZSBib2J5IHdp dGggcGxhdGZvcm0gY2xhc3Nlcy4KKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvVXRpbGl0 aWVzLmpzOgorICAgICAgICAoU3RyaW5nLnByb3RvdHlwZS5jb250YWlucyk6IEFkZGVkLgorICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVG9vbGJhci5jc3M6CisgICAgICAgIChib2R5LmRv Y2tlZCAudG9vbGJhciwgYm9keTpub3QoLm1hYy1wbGF0Zm9ybSkgLnRvb2xiYXIpOiBBZGRlZC4g RGVmYXVsdCB0b29sYmFyIGJhY2tncm91bmQuCisgICAgICAgIChib2R5LmRvY2tlZC5tYWMtcGxh dGZvcm0ubWF2ZXJpY2tzIC50b29sYmFyLCBib2R5LmRvY2tlZC5tYWMtcGxhdGZvcm0ubW91bnRh aW4tbGlvbik6IEFkZGVkLgorICAgICAgICAoYm9keS5tYWMtcGxhdGZvcm06bm90KC5kb2NrZWQp IC50b29sYmFyIC5pdGVtLmJ1dHRvbiA+IC5sYWJlbCk6IE9ubHkgYXBwbHkgdG8gTWFjLgorCiAy MDE0LTAyLTIyICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUkVH UkVTU0lPTiAocjE2NDUwNyk6IENyYXNoIGJlbmVhdGggSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JD b250cm9sbGVyOjpyZXBvcnRBUElFeGNlcHRpb24gYXQgZmFjZWJvb2suY29tLCB0d2l0dGVyLmNv bSwgeW91dHViZS5jb20KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvTWFpbi5qcwppbmRleCBlYmI3MDY1MWZlNTkwNDEyYjBkY2M1Mjc1YzIyNWUwYWNiYjc1 ODBkLi5kNzcwNjRkOGY1ZTNhODQ3OGQ0OTVlMmFhOWEwYjE3ZjE3MTI2NzU2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0xODYs NiArMTg2LDIyIEBAIFdlYkluc3BlY3Rvci5jb250ZW50TG9hZGVkID0gZnVuY3Rpb24oKQogICAg IGlmICh2ZXJzaW9uTWF0Y2ggJiYgdmVyc2lvbk1hdGNoWzFdLmluZGV4T2YoIisiKSAhPT0gLTEg JiYgZG9jdW1lbnQuc3R5bGVTaGVldHMubGVuZ3RoIDwgMTApCiAgICAgICAgIGRvY3VtZW50LmJv ZHkuY2xhc3NMaXN0LmFkZCgibmlnaHRseS1idWlsZCIpOwogCisgICAgLy8gQWRkIHBsYXRmb3Jt IHN0eWxlIGNsYXNzZXMgc28gdGhlIFVJIGNhbiBiZSB0d2Vha2VkIHBlci1wbGF0Zm9ybS4KKyAg ICBpZiAobmF2aWdhdG9yLnBsYXRmb3JtLmNvbnRhaW5zKCJNYWMiKSkgeworICAgICAgICBkb2N1 bWVudC5ib2R5LmNsYXNzTGlzdC5hZGQoIm1hYy1wbGF0Zm9ybSIpOworCisgICAgICAgIHZhciB2 ZXJzaW9uTWF0Y2ggPSAvIE1hYyBPUyBYIChcZCspXyhcZCspLy5leGVjKG5hdmlnYXRvci5hcHBW ZXJzaW9uKTsKKyAgICAgICAgaWYgKHZlcnNpb25NYXRjaCAmJiB2ZXJzaW9uTWF0Y2hbMV0gPT0g MTAgJiYgdmVyc2lvbk1hdGNoWzJdID09IDgpCisgICAgICAgICAgICBkb2N1bWVudC5ib2R5LmNs YXNzTGlzdC5hZGQoIm1vdW50YWluLWxpb24iKTsKKyAgICAgICAgZWxzZSBpZiAodmVyc2lvbk1h dGNoICYmIHZlcnNpb25NYXRjaFsxXSA9PSAxMCAmJiB2ZXJzaW9uTWF0Y2hbMl0gPT0gOSkKKyAg ICAgICAgICAgIGRvY3VtZW50LmJvZHkuY2xhc3NMaXN0LmFkZCgibWF2ZXJpY2tzIik7CisgICAg fSBlbHNlIGlmIChuYXZpZ2F0b3IucGxhdGZvcm0uY29udGFpbnMoIldpbiIpKQorICAgICAgICBk b2N1bWVudC5ib2R5LmNsYXNzTGlzdC5hZGQoIndpbmRvd3MtcGxhdGZvcm0iKTsKKyAgICBlbHNl IGlmIChuYXZpZ2F0b3IucGxhdGZvcm0uY29udGFpbnMoIkxpbnV4IikpCisgICAgICAgIGRvY3Vt ZW50LmJvZHkuY2xhc3NMaXN0LmFkZCgibGludXgtcGxhdGZvcm0iKTsKKyAgICBlbHNlCisgICAg ICAgIGRvY3VtZW50LmJvZHkuY2xhc3NMaXN0LmFkZCgib3RoZXItcGxhdGZvcm0iKTsKKwogICAg IHRoaXMuZGVidWdnYWJsZVR5cGUgPSBJbnNwZWN0b3JGcm9udGVuZEhvc3QuZGVidWdnYWJsZVR5 cGUoKSA9PT0gIndlYiIgPyBXZWJJbnNwZWN0b3IuRGVidWdnYWJsZVR5cGUuV2ViIDogV2ViSW5z cGVjdG9yLkRlYnVnZ2FibGVUeXBlLkphdmFTY3JpcHQ7CiAgICAgZG9jdW1lbnQuYm9keS5jbGFz c0xpc3QuYWRkKHRoaXMuZGVidWdnYWJsZVR5cGUpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzCmluZGV4IDZhNDA3MTc5 MWE2YmYyOTcwYjRkZDA0NzRjMGM0YzUxYmM2MzNlZGYuLjIyOGMzZWRiOWVjM2Y0NTIyODlkYTIx NGI1MDc4Mzc3M2Y5NTQ3NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzCkBAIC0zODMsNiArMzgzLDE0IEBAIE9iamVj dC5kZWZpbmVQcm9wZXJ0eShEb2N1bWVudEZyYWdtZW50LnByb3RvdHlwZSwgImNyZWF0ZUNoaWxk IiwKICAgICB2YWx1ZTogRWxlbWVudC5wcm90b3R5cGUuY3JlYXRlQ2hpbGQKIH0pOwogCitPYmpl Y3QuZGVmaW5lUHJvcGVydHkoU3RyaW5nLnByb3RvdHlwZSwgImNvbnRhaW5zIiwKK3sKKyAgICB2 YWx1ZTogZnVuY3Rpb24odmFsdWUpCisgICAgeworICAgICAgICByZXR1cm4gdGhpcy5pbmRleE9m KHZhbHVlKSAhPT0gLTE7CisgICAgfQorfSk7CisKIE9iamVjdC5kZWZpbmVQcm9wZXJ0eShBcnJh eS5wcm90b3R5cGUsICJjb250YWlucyIsCiB7CiAgICAgdmFsdWU6IGZ1bmN0aW9uKHZhbHVlKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVG9v bGJhci5jc3MgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Ub29s YmFyLmNzcwppbmRleCBmM2Y2NTY3NGQ4NmZhMTYyNGRlZTgyMDZmYTA5ZDQ5MzRlMGQyZTQxLi42 MGUzMzBkMDlkY2U5NWZjOWM5NTg5ZThiZjA2YzcxZjM4M2QxMDI1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Ub29sYmFyLmNzcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Ub29sYmFyLmNzcwpAQCAt NTMsMTIgKzUzLDE5IEBACiAgICAgaGVpZ2h0OiAzMnB4OwogfQogCi1ib2R5LmRvY2tlZCAudG9v bGJhciB7Citib2R5LmRvY2tlZCAudG9vbGJhciwKK2JvZHk6bm90KC5tYWMtcGxhdGZvcm0pIC50 b29sYmFyIHsKKyAgICBiYWNrZ3JvdW5kLWltYWdlOiAtd2Via2l0LWxpbmVhci1ncmFkaWVudCh0 b3AsIHJnYigyMzMsIDIzMywgMjMzKSwgcmdiKDIyOSwgMjI5LCAyMjkpKTsKKyAgICBib3gtc2hh ZG93OiBpbnNldCByZ2IoMjUyLCAyNTIsIDI1MikgMCAxcHggMDsKK30KKworYm9keS5kb2NrZWQu bWFjLXBsYXRmb3JtLm1vdW50YWluLWxpb24gLnRvb2xiYXIsCitib2R5LmRvY2tlZC5tYWMtcGxh dGZvcm0ubWF2ZXJpY2tzIC50b29sYmFyIHsKICAgICBiYWNrZ3JvdW5kLWltYWdlOiAtd2Via2l0 LWxpbmVhci1ncmFkaWVudCh0b3AsIHJnYigyMTYsIDIxNiwgMjE2KSwgcmdiKDE5MCwgMTkwLCAx OTApKTsKICAgICBib3gtc2hhZG93OiBpbnNldCByZ2JhKDI1NSwgMjU1LCAyNTUsIDAuMSkgMCAx cHggMCwgaW5zZXQgcmdiYSgwLCAwLCAwLCAwLjAyKSAwIC0xcHggMDsKIH0KIAotYm9keTpub3Qo LmRvY2tlZCkgLnRvb2xiYXIgLml0ZW0uYnV0dG9uID4gLmxhYmVsIHsKK2JvZHkubWFjLXBsYXRm b3JtOm5vdCguZG9ja2VkKSAudG9vbGJhciAuaXRlbS5idXR0b24gPiAubGFiZWwgewogIC8qIFdl IG5lZWQgdG8gZGlzYWJsZSBzdWItcGl4ZWwgYW50aWFsaWFzaW5nIGluIHRoZSB0b29sYmFyIHdo ZW4gbm90IGRvY2tlZCBiZWNhdXNlIHRoZQogICAgIHRvb2xiYXIgaXMgdHJhbnNwYXJlbnQgYW5k IHNvIGlzIHRoZSBXZWJWaWV3LiAqLwogICAgIC13ZWJraXQtZm9udC1zbW9vdGhpbmc6IGFudGlh bGlhc2VkOwo=