129253 2014-02-24 04:33:24 -0800 Web Inspector: Remove single quote characters from Web Inspector JavaScript files 2014-02-24 09:00:10 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Trivial --- 1 dpino webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 983867 0 dpino 2014-02-24 04:33:24 -0800 Single-quote characters are not allowed in Web Inspector JavaScript files. Now Tools/Scripts/check-webkit-style checks Web Inspector JavaScript files don't contain single-quote characters (r164487). However, there are currently some files which contain single-quote characters. 983868 1 webkit-bug-importer 2014-02-24 04:33:32 -0800 <rdar://problem/16146713> 983869 2 225050 dpino 2014-02-24 04:35:58 -0800 Created attachment 225050 Patch 983923 3 225050 commit-queue 2014-02-24 09:00:08 -0800 Comment on attachment 225050 Patch Clearing flags on attachment: 225050 Committed r164588: <http://trac.webkit.org/changeset/164588> 983924 4 commit-queue 2014-02-24 09:00:10 -0800 All reviewed patches have been landed. Closing bug. 225050 2014-02-24 04:35:58 -0800 2014-02-24 09:00:08 -0800 Patch bug-129253-20140224133556.patch text/plain 7040 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj ODQ2NTU3YjU1MzY5MDg2NGYwY2M2M2M1M2Y5OGI3ZjQxN2JlZDViLi42MWFjMzIzOTkxZWI2YTQx MTViZmNjNDQxMDM1ZDg3ZGEwNmM1MjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxNC0wMi0yNCAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlbW92ZSBzaW5nbGUgcXVvdGUgY2hhcmFj dGVycyBmcm9tIFdlYiBJbnNwZWN0b3IgSmF2YVNjcmlwdCBmaWxlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MjUzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFp bi5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5vcGVuVVJMKToKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL0Nvb2tpZVN0b3JhZ2VDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5jb29raWVEb21haW5NYXRjaGVzUmVzb3VyY2VEb21haW4pOgorICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuRE9NVHJlZUVsZW1lbnQucHJvdG90eXBlLl9pbnNlcnRJbkxhc3RBdHRyaWJ1dGVQb3NpdGlv bik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJlZUVsZW1lbnQucHJvdG90eXBlLl9zdGFy dEVkaXRpbmdUYWdOYW1lLmVkaXRpbmdDb21pdHRlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu RE9NVHJlZUVsZW1lbnQucHJvdG90eXBlLl9zdGFydEVkaXRpbmdUYWdOYW1lLmVkaXRpbmdDYW5j ZWxsZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5f c3RhcnRFZGl0aW5nVGFnTmFtZSk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9ET01U cmVlT3V0bGluZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlT3V0bGluZS5wcm90 b3R5cGUuX29uZHJhZ292ZXIpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdy aWQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YUdyaWQucHJvdG90eXBlLmFkZFBsYWNl aG9sZGVyTm9kZSk6CisKIDIwMTQtMDItMjMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KIAogICAgICAgICBSZW1vdmVkIC1Xbm8tZm9ybWF0LXkyayBmcm9tIFdBUk5JTkdfQ0ZMQUdT CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01h aW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMK aW5kZXggZWJiNzA2NTFmZTU5MDQxMmIwZGNjNTI3NWMyMjVlMGFjYmI3NTgwZC4uMDllMzJiMzk4 ZTFiZDcyZmViNzhlYjg0MWQwYzBhOTc0ZjU5ZGI3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtNDkxLDcgKzQ5MSw3IEBAIFdl Ykluc3BlY3Rvci5vcGVuVVJMID0gZnVuY3Rpb24odXJsLCBmcmFtZSwgYWx3YXlzT3BlbkV4dGVy bmFsbHksIGxpbmVOdW1iZXIpCiAKICAgICAgICAgLy8gVGhlIHBhdGggb2Ygb2YgdGhlIHByb2Zp bGUgVVJMIHN0YXJ0cyB3aXRoIGEgc2xhc2gsIHJlbW92ZSBpdCwgc28KICAgICAgICAgLy8gd2Ug Y2FuIGdldCB0aGUgYWN0dWFsIHRpdGxlLgotICAgICAgICBjb25zb2xlLmFzc2VydChwcm9maWxl VGl0bGVbMF0gPT09ICcvJyk7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHByb2ZpbGVUaXRsZVsw XSA9PT0gIi8iKTsKICAgICAgICAgcHJvZmlsZVRpdGxlID0gcHJvZmlsZVRpdGxlLnN1YnN0cmlu ZygxKTsKIAogICAgICAgICB0aGlzLnRpbWVsaW5lU2lkZWJhclBhbmVsLnNob3dQcm9maWxlKHBy b2ZpbGVUeXBlLCBwcm9maWxlVGl0bGUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29va2llU3RvcmFnZUNvbnRlbnRWaWV3LmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29va2llU3RvcmFnZUNvbnRl bnRWaWV3LmpzCmluZGV4IGYzNzhkZDY0MTZhNjcwMWNhNmUwOWJjMWVhMWE2YmQ0NzZkOTIwZDEu Ljg0M2U2YzkzMDBmODU5ODcxNTIwNzI3ZjRjYTBlNzIzN2YwOWQ3ZGEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nvb2tpZVN0b3JhZ2VDb250 ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9Db29raWVTdG9yYWdlQ29udGVudFZpZXcuanMKQEAgLTI1MSw3ICsyNTEsNyBAQCBXZWJJbnNw ZWN0b3IuY29va2llTWF0Y2hlc1Jlc291cmNlVVJMID0gZnVuY3Rpb24oY29va2llLCByZXNvdXJj ZVVSTCkKIAogV2ViSW5zcGVjdG9yLmNvb2tpZURvbWFpbk1hdGNoZXNSZXNvdXJjZURvbWFpbiA9 IGZ1bmN0aW9uKGNvb2tpZURvbWFpbiwgcmVzb3VyY2VEb21haW4pCiB7Ci0gICAgaWYgKGNvb2tp ZURvbWFpbi5jaGFyQXQoMCkgIT09ICcuJykKKyAgICBpZiAoY29va2llRG9tYWluLmNoYXJBdCgw KSAhPT0gIi4iKQogICAgICAgICByZXR1cm4gcmVzb3VyY2VEb21haW4gPT09IGNvb2tpZURvbWFp bjsKICAgICByZXR1cm4gISFyZXNvdXJjZURvbWFpbi5tYXRjaChuZXcgUmVnRXhwKCJeKFteXFwu XStcXC4pPyIgKyBjb29raWVEb21haW4uc3Vic3RyaW5nKDEpLmVzY2FwZUZvclJlZ0V4cCgpICsg IiQiKSwgImkiKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMKaW5kZXggMDdiZDg5ZTMxNjg4ZGMx ODdkMGNmZDVhZjY2NWRjYmFmZTU3MTNiMy4uMzdjMDYzYjc2NmU4ZjIwZjY2NWVkOWM1OGQyMGQw N2Y2ODE1NDhiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMKQEAgLTUzNiwxMCArNTM2LDEwIEBA IFdlYkluc3BlY3Rvci5ET01UcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB0 YWcuaW5zZXJ0QmVmb3JlKG5vZGUsIHRhZy5sYXN0Q2hpbGQpOwogICAgICAgICBlbHNlIHsKICAg ICAgICAgICAgIHZhciBub2RlTmFtZSA9IHRhZy50ZXh0Q29udGVudC5tYXRjaCgvXjwoLio/KT4k LylbMV07Ci0gICAgICAgICAgICB0YWcudGV4dENvbnRlbnQgPSAnJzsKLSAgICAgICAgICAgIHRh Zy5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgnPCcrbm9kZU5hbWUpKTsKKyAg ICAgICAgICAgIHRhZy50ZXh0Q29udGVudCA9ICIiOworICAgICAgICAgICAgdGFnLmFwcGVuZENo aWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCI8Iitub2RlTmFtZSkpOwogICAgICAgICAgICAg dGFnLmFwcGVuZENoaWxkKG5vZGUpOwotICAgICAgICAgICAgdGFnLmFwcGVuZENoaWxkKGRvY3Vt ZW50LmNyZWF0ZVRleHROb2RlKCc+JykpOworICAgICAgICAgICAgdGFnLmFwcGVuZENoaWxkKGRv Y3VtZW50LmNyZWF0ZVRleHROb2RlKCI+IikpOwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy51 cGRhdGVTZWxlY3Rpb24oKTsKQEAgLTc0OSwxNyArNzQ5LDE3IEBAIFdlYkluc3BlY3Rvci5ET01U cmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgZnVuY3Rpb24gZWRpdGluZ0NvbWl0 dGVkKGVsZW1lbnQsIG5ld1RhZ05hbWUpCiAgICAgICAgIHsKLSAgICAgICAgICAgIHRhZ05hbWVF bGVtZW50LnJlbW92ZUV2ZW50TGlzdGVuZXIoJ2tleXVwJywga2V5dXBMaXN0ZW5lciwgZmFsc2Up OworICAgICAgICAgICAgdGFnTmFtZUVsZW1lbnQucmVtb3ZlRXZlbnRMaXN0ZW5lcigia2V5dXAi LCBrZXl1cExpc3RlbmVyLCBmYWxzZSk7CiAgICAgICAgICAgICB0aGlzLl90YWdOYW1lRWRpdGlu Z0NvbW1pdHRlZC5hcHBseSh0aGlzLCBhcmd1bWVudHMpOwogICAgICAgICB9CiAKICAgICAgICAg ZnVuY3Rpb24gZWRpdGluZ0NhbmNlbGxlZCgpCiAgICAgICAgIHsKLSAgICAgICAgICAgIHRhZ05h bWVFbGVtZW50LnJlbW92ZUV2ZW50TGlzdGVuZXIoJ2tleXVwJywga2V5dXBMaXN0ZW5lciwgZmFs c2UpOworICAgICAgICAgICAgdGFnTmFtZUVsZW1lbnQucmVtb3ZlRXZlbnRMaXN0ZW5lcigia2V5 dXAiLCBrZXl1cExpc3RlbmVyLCBmYWxzZSk7CiAgICAgICAgICAgICB0aGlzLl9lZGl0aW5nQ2Fu Y2VsbGVkLmFwcGx5KHRoaXMsIGFyZ3VtZW50cyk7CiAgICAgICAgIH0KIAotICAgICAgICB0YWdO YW1lRWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCdrZXl1cCcsIGtleXVwTGlzdGVuZXIsIGZhbHNl KTsKKyAgICAgICAgdGFnTmFtZUVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigia2V5dXAiLCBrZXl1 cExpc3RlbmVyLCBmYWxzZSk7CiAKICAgICAgICAgdmFyIGNvbmZpZyA9IG5ldyBXZWJJbnNwZWN0 b3IuRWRpdGluZ0NvbmZpZyhlZGl0aW5nQ29taXR0ZWQuYmluZCh0aGlzKSwgZWRpdGluZ0NhbmNl bGxlZC5iaW5kKHRoaXMpLCB0YWdOYW1lKTsKICAgICAgICAgdGhpcy5fZWRpdGluZyA9IFdlYklu c3BlY3Rvci5zdGFydEVkaXRpbmcodGFnTmFtZUVsZW1lbnQsIGNvbmZpZyk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlT3V0bGlu ZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVP dXRsaW5lLmpzCmluZGV4IDE3ZmE1ZjNjY2NjM2RiOGNlZDA0MjkyODkzM2Y4OTJmZjZkZTRhOGMu LjE0NzUxYjliMDJjOWYyMWViNzZhYmY5NDBlNzE2NWI0ZTM3ZGY1NzIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVP dXRsaW5lLmpzCkBAIC0zNzcsNyArMzc3LDcgQEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVPdXRsaW5l LnByb3RvdHlwZSA9IHsKICAgICAgICAgdHJlZUVsZW1lbnQubGlzdEl0ZW1FbGVtZW50LmNsYXNz TGlzdC5hZGQoImVsZW1lbnRzLWRyYWctb3ZlciIpOwogICAgICAgICB0aGlzLl9kcmFnT3ZlclRy ZWVFbGVtZW50ID0gdHJlZUVsZW1lbnQ7CiAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7 Ci0gICAgICAgIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0ID0gJ21vdmUnOworICAgICAg ICBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCA9ICJtb3ZlIjsKICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgIH0sCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKaW5kZXggODI3OGMyM2NmM2NmNThhZjc3NjZhYjMx NWZkMWY4YzE0MTU4NTgzOS4uYjdjNzk5NzIzNDNmNTVmNDM3MjMxNDkzOGI3NWFjZTVmZmFhMjA2 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv RGF0YUdyaWQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvRGF0YUdyaWQuanMKQEAgLTY1Nyw3ICs2NTcsNyBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWQu cHJvdG90eXBlID0gewogCiAgICAgICAgIHZhciBlbXB0eURhdGEgPSB7fTsKICAgICAgICAgZm9y ICh2YXIgaWRlbnRpZmllciBvZiB0aGlzLmNvbHVtbnMua2V5cygpKQotICAgICAgICAgICAgZW1w dHlEYXRhW2lkZW50aWZpZXJdID0gJyc7CisgICAgICAgICAgICBlbXB0eURhdGFbaWRlbnRpZmll cl0gPSAiIjsKICAgICAgICAgdGhpcy5wbGFjZWhvbGRlck5vZGUgPSBuZXcgV2ViSW5zcGVjdG9y LlBsYWNlaG9sZGVyRGF0YUdyaWROb2RlKGVtcHR5RGF0YSk7CiAgICAgICAgIHRoaXMuYXBwZW5k Q2hpbGQodGhpcy5wbGFjZWhvbGRlck5vZGUpOwogICAgIH0sCkBAIC0xMTA4LDcgKzExMDgsNyBA QCBXZWJJbnNwZWN0b3IuRGF0YUdyaWQucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIGVs c2UgewogICAgICAgICAgICAgICAgICAgICB2YXIgZWxlbWVudCA9IGV2ZW50LnRhcmdldC5lbmNs b3NpbmdOb2RlT3JTZWxmV2l0aE5vZGVOYW1lKCJ0ZCIpOwogICAgICAgICAgICAgICAgICAgICB2 YXIgY29sdW1uSWRlbnRpZmllciA9IGVsZW1lbnQuX19jb2x1bW5JZGVudGlmaWVyOwotICAgICAg ICAgICAgICAgICAgICB2YXIgY29sdW1uVGl0bGUgPSB0aGlzLmRhdGFHcmlkLmNvbHVtbnMuZ2V0 KGNvbHVtbklkZW50aWZpZXIpLmdldCgndGl0bGUnKTsKKyAgICAgICAgICAgICAgICAgICAgdmFy IGNvbHVtblRpdGxlID0gdGhpcy5kYXRhR3JpZC5jb2x1bW5zLmdldChjb2x1bW5JZGVudGlmaWVy KS5nZXQoInRpdGxlIik7CiAgICAgICAgICAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0 ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJFZGl0IOKAnCVz4oCdIikuZm9ybWF0KGNvbHVtblRp dGxlKSwgdGhpcy5fc3RhcnRFZGl0aW5nLmJpbmQodGhpcywgZXZlbnQudGFyZ2V0KSk7CiAgICAg ICAgICAgICAgICAgfQogICAgICAgICAgICAgfQo=