129252 2014-02-24 02:14:58 -0800 REGRESSION(r164438): [GTK] Tests /webkit2/WebKitWebView/tls-errors-policy and /webkit2/WebKitWebContext/uri-scheme fail 2014-02-24 11:37:57 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue eocanha gustavo mrobinson oldest_to_newest 983853 0 cgarcia 2014-02-24 02:14:58 -0800 /webkit2/WebKitWebContext/uri-scheme: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:225:void testWebContextURIScheme(URISchemeTest*, gconstpointer): assertion failed (test->m_error.get() == (test, 10)): Error message. (test, 399) /webkit2/WebKitWebView/tls-errors-policy: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:45:virtual void SSLTest::provisionalLoadFailed(const gchar*, GError*): assertion failed (error == (soup_http_error_quark, 6)): Unacceptable TLS certificate (soup_http_error_quark, 399) This is because we are assuming all error codes come from WebCore. I think in the case of errors we should not use the conversion functions or at least we should not assert in default: and return the passed in error code instead of falling back to network error. 983875 1 225056 eocanha 2014-02-24 05:50:54 -0800 Created attachment 225056 Patch 983876 2 commit-queue 2014-02-24 05:53:18 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 983894 3 eocanha 2014-02-24 07:06:08 -0800 The root cause of this bug is related to the root cause of #129256, but this time in WK2. 983980 4 225056 commit-queue 2014-02-24 11:37:54 -0800 Comment on attachment 225056 Patch Clearing flags on attachment: 225056 Committed r164597: <http://trac.webkit.org/changeset/164597> 983981 5 commit-queue 2014-02-24 11:37:57 -0800 All reviewed patches have been landed. Closing bug. 225056 2014-02-24 05:50:54 -0800 2014-02-24 11:37:54 -0800 Patch bug-129252-20140224135052.patch text/plain 1999 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDVhZTEzYjE1MjJhMjc4 ZjdiZDQ0NzJlNjA3ZWU5YmE0MmY5YjE5NS4uMmQ0NGUzZDdiMjFlMDJiN2M0ZWFiOTUwZjhmNzc2 NzhhZDhiNjEyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAyLTI0ICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVH UkVTU0lPTihyMTY0NDM4KTogW0dUS10gVGVzdHMgL3dlYmtpdDIvV2ViS2l0V2ViVmlldy90bHMt ZXJyb3JzLXBvbGljeSBhbmQgL3dlYmtpdDIvV2ViS2l0V2ViQ29udGV4dC91cmktc2NoZW1lIGZh aWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTI1 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0UHJpdmF0ZS5jcHA6IE1hbmFnZSBlcnJvciB2YWx1ZXMgZ2Vu ZXJhdGVkIGJ5IHRoZSB1c2VyIGFwcGxpY2F0aW9uIGFuZCBub3QgcHJlc2VudCBpbiBXZWJDb3Jl CisgICAgICAgICh0b1dlYktpdEVycm9yKToKKyAgICAgICAgKHRvV2ViQ29yZUVycm9yKToKKwog MjAxNC0wMi0yMCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJl bW92ZSByZWR1bmRhbnQgZGV2aWNlU2NhbGVGYWN0b3IoKSBmdW5jdGlvbnMgYW5kIG1ha2UgY2Fs bGVycyB1c2UgRG9jdW1lbnQ6OmRldmljZVNjYWxlRmFjdG9yKCkgd2hlbiBhY2Nlc3NpYmxlLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0UHJpdmF0 ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRQcml2YXRlLmNw cAppbmRleCA2YTZkOTJhNGJkOTliYmI4YzI0OTAzNDI5OTVlOGZmZDNhNmM2NGRiLi41ZThmOWM1 ZDc2OWQyNzljNDk3YjY3YzFhZTUxYTViZDkwZGUzY2MyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRQcml2YXRlLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRQcml2YXRlLmNwcApAQCAtMTAyLDggKzEwMiw4 IEBAIHVuc2lnbmVkIHRvV2ViS2l0RXJyb3IodW5zaWduZWQgd2ViQ29yZUVycm9yKQogICAgIGNh c2UgV2ViQ29yZTo6UHJpbnRFcnJvckludmFsaWRQYWdlUmFuZ2U6CiAgICAgICAgIHJldHVybiBX RUJLSVRfUFJJTlRfRVJST1JfSU5WQUxJRF9QQUdFX1JBTkdFOwogICAgIGRlZmF1bHQ6Ci0gICAg ICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgICAgICByZXR1cm4gV0VCS0lUX05FVFdPUktf RVJST1JfRkFJTEVEOworICAgICAgICAvLyBUaGlzIG1heSBiZSBhIHVzZXIgYXBwIGRlZmluZWQg ZXJyb3IsIHdoaWNoIG5lZWRzIHRvIGJlIHBhc3NlZCBhcy1pcy4KKyAgICAgICAgcmV0dXJuIHdl YkNvcmVFcnJvcjsKICAgICB9CiB9CiAKQEAgLTE1NSw3ICsxNTUsNyBAQCB1bnNpZ25lZCB0b1dl YkNvcmVFcnJvcih1bnNpZ25lZCB3ZWJLaXRFcnJvcikKICAgICBjYXNlIFdFQktJVF9QUklOVF9F UlJPUl9JTlZBTElEX1BBR0VfUkFOR0U6CiAgICAgICAgIHJldHVybiBXZWJDb3JlOjpQcmludEVy cm9ySW52YWxpZFBhZ2VSYW5nZTsKICAgICBkZWZhdWx0OgotICAgICAgICBBU1NFUlRfTk9UX1JF QUNIRUQoKTsKLSAgICAgICAgcmV0dXJuIFdlYkNvcmU6Ok5ldHdvcmtFcnJvckZhaWxlZDsKKyAg ICAgICAgLy8gVGhpcyBtYXkgYmUgYSB1c2VyIGFwcCBkZWZpbmVkIGVycm9yLCB3aGljaCBuZWVk cyB0byBiZSBwYXNzZWQgYXMtaXMuCisgICAgICAgIHJldHVybiB3ZWJLaXRFcnJvcjsKICAgICB9 CiB9Cg==