129245 2014-02-24 00:58:54 -0800 [GTK] Remove unneeded method webkitWebViewBaseRequestExitFullScreen 2014-02-24 01:26:03 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue gustavo mrobinson svillar oldest_to_newest 983812 0 cgarcia 2014-02-24 00:58:54 -0800 It's a semi-private method but that it's only used once in WebKitWebViewBase.cpp and it contains a single line. 983813 1 225032 cgarcia 2014-02-24 01:01:13 -0800 Created attachment 225032 Patch 983815 2 commit-queue 2014-02-24 01:02:45 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 983828 3 225032 svillar 2014-02-24 01:13:10 -0800 Comment on attachment 225032 Patch Let's do it. BTW what about also replacing the switch by an if statement in webkitWebViewBaseKeyPressEvent? Looks like abusing the syntax to me. 983836 4 cgarcia 2014-02-24 01:26:03 -0800 Committed r164578: <http://trac.webkit.org/changeset/164578> 225032 2014-02-24 01:01:13 -0800 2014-02-24 01:13:10 -0800 Patch wk2-request-exit-fullscreen.diff text/plain 2937 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4YTAzODQzLi5iMWI2Nzg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDItMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFJlbW92ZSB1bm5lZWRlZCBtZXRob2Qgd2Via2l0V2ViVmlld0Jh c2VSZXF1ZXN0RXhpdEZ1bGxTY3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyOTI0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3Bw OgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VLZXlQcmVzc0V2ZW50KTogQ2FsbCBGdWxsc2Ny ZWVuTWFuYWdlcjo6cmVxdWVzdEV4aXRGdWxsU2NyZWVuKCkgZGlyZWN0bHkuCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmg6CisKIDIwMTQtMDIt MjMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjovL3By b2JsZW0vMTYxNDQ1MDg+IFtpT1NdIFNvbWUgZGVmaW5pdGlvbnMgb2YgSU5TVEFMTF9QQVRIIGRv buKAmXQgYWNjb3VudCBmb3IgSU5TVEFMTF9QQVRIX1BSRUZJWApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCmluZGV4IGY3 MmExNGUuLjFhOWI0M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTYxOSw3ICs2MTksNyBAQCBzdGF0aWMg Z2Jvb2xlYW4gd2Via2l0V2ViVmlld0Jhc2VLZXlQcmVzc0V2ZW50KEd0a1dpZGdldCogd2lkZ2V0 LCBHZGtFdmVudEtleSogZQogICAgICAgICBjYXNlIEdES19LRVlfRXNjYXBlOgogICAgICAgICBj YXNlIEdES19LRVlfZjoKICAgICAgICAgY2FzZSBHREtfS0VZX0Y6Ci0gICAgICAgICAgICB3ZWJr aXRXZWJWaWV3QmFzZVJlcXVlc3RFeGl0RnVsbFNjcmVlbih3ZWJWaWV3QmFzZSk7CisgICAgICAg ICAgICBwcml2LT5wYWdlUHJveHktPmZ1bGxTY3JlZW5NYW5hZ2VyKCktPnJlcXVlc3RFeGl0RnVs bFNjcmVlbigpOwogICAgICAgICAgICAgcmV0dXJuIFRSVUU7CiAgICAgICAgIGRlZmF1bHQ6CiAg ICAgICAgICAgICBicmVhazsKQEAgLTEwODIsMTMgKzEwODIsNiBAQCB2b2lkIHdlYmtpdFdlYlZp ZXdCYXNlRXhpdEZ1bGxTY3JlZW4oV2ViS2l0V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNl KQogI2VuZGlmCiB9CiAKLXZvaWQgd2Via2l0V2ViVmlld0Jhc2VSZXF1ZXN0RXhpdEZ1bGxTY3Jl ZW4oV2ViS2l0V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNlKQotewotI2lmIEVOQUJMRShG VUxMU0NSRUVOX0FQSSkKLSAgICB3ZWJraXRXZWJWaWV3QmFzZS0+cHJpdi0+cGFnZVByb3h5LT5m dWxsU2NyZWVuTWFuYWdlcigpLT5yZXF1ZXN0RXhpdEZ1bGxTY3JlZW4oKTsKLSNlbmRpZgotfQot CiB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlSW5pdGlhbGl6ZUZ1bGxTY3JlZW5DbGllbnQoV2ViS2l0 V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNlLCBjb25zdCBXS0Z1bGxTY3JlZW5DbGllbnRH dGtCYXNlKiB3a0NsaWVudCkKIHsKICAgICB3ZWJraXRXZWJWaWV3QmFzZS0+cHJpdi0+ZnVsbFNj cmVlbkNsaWVudC5pbml0aWFsaXplKHdrQ2xpZW50KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZS5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmgKaW5k ZXggNTA5OWQwMy4uYjljMzhjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmgKQEAgLTQ1LDcgKzQ1 LDYgQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVN0YXJ0RHJhZyhXZWJLaXRXZWJWaWV3QmFzZSos IGNvbnN0IFdlYkNvcmU6OkRyYWdEYXRhJiwgUGEKIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VDaGls ZE1vdmVSZXNpemUoV2ViS2l0V2ViVmlld0Jhc2UqLCBHdGtXaWRnZXQqLCBjb25zdCBXZWJDb3Jl OjpJbnRSZWN0Jik7CiB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlRW50ZXJGdWxsU2NyZWVuKFdlYktp dFdlYlZpZXdCYXNlKik7CiB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlRXhpdEZ1bGxTY3JlZW4oV2Vi S2l0V2ViVmlld0Jhc2UqKTsKLXZvaWQgd2Via2l0V2ViVmlld0Jhc2VSZXF1ZXN0RXhpdEZ1bGxT Y3JlZW4oV2ViS2l0V2ViVmlld0Jhc2UqKTsKIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VJbml0aWFs aXplRnVsbFNjcmVlbkNsaWVudChXZWJLaXRXZWJWaWV3QmFzZSosIGNvbnN0IFdLRnVsbFNjcmVl bkNsaWVudEd0a0Jhc2UqKTsKIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VTZXRJbnNwZWN0b3JWaWV3 U2l6ZShXZWJLaXRXZWJWaWV3QmFzZSosIHVuc2lnbmVkIHNpemUpOwogdm9pZCB3ZWJraXRXZWJW aWV3QmFzZVNldEFjdGl2ZUNvbnRleHRNZW51UHJveHkoV2ViS2l0V2ViVmlld0Jhc2UqLCBXZWJL aXQ6OldlYkNvbnRleHRNZW51UHJveHlHdGsqKTsK