129244 2014-02-24 00:37:17 -0800 Wrong active context when destroying GL objects 2014-02-24 07:19:19 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 itoral webkit-unassigned commit-queue mrobinson oldest_to_newest 983806 0 itoral 2014-02-24 00:37:17 -0800 When we have multiple webviews, each with its own GL context, it is possible that destroying a view (for example closing a tab in the browser) triggers destruction of the underlying LayerTreeHost with the wrong active GL context. We should make sure that we set the right context as active before destroying GL objects in LayerTreeHostGtk::invalidate. I'll attach patch shortly. 983807 1 225031 itoral 2014-02-24 00:47:08 -0800 Created attachment 225031 Patch 983899 2 225031 commit-queue 2014-02-24 07:19:17 -0800 Comment on attachment 225031 Patch Clearing flags on attachment: 225031 Committed r164584: <http://trac.webkit.org/changeset/164584> 983900 3 commit-queue 2014-02-24 07:19:19 -0800 All reviewed patches have been landed. Closing bug. 225031 2014-02-24 00:47:08 -0800 2014-02-24 07:19:17 -0800 Patch 0001-GTK-Wrong-active-context-when-destroying-GL-objects.patch text/plain 2015 itoral RnJvbSA0MjlhOGE4Y2IzZWQzZTIyODFhNmQ2YjI0NDFmZWEyNGRlOGNmMjY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJYWdvIFRvcmFsIFF1aXJvZ2EgPGl0b3JhbEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDI0IEZlYiAyMDE0IDA5OjQ0OjUxICswMTAwClN1YmplY3Q6IFtQQVRDSF0g W0dUS10gV3JvbmcgYWN0aXZlIGNvbnRleHQgd2hlbiBkZXN0cm95aW5nIEdMIG9iamVjdHMuCiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MjQ0CgpSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiogV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9MYXllclRyZWVIb3N0 R3RrLmNwcDoKKFdlYktpdDo6TGF5ZXJUcmVlSG9zdEd0azo6aW52YWxpZGF0ZSk6IG1ha2UgY29u dGV4dCBjdXJyZW50IGJlZm9yZSBkZXN0cm95aW5nIEdMIG9iamVjdHMuCi0tLQogU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDEwICsr KysrKysrKysKIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvTGF5ZXJUcmVl SG9zdEd0ay5jcHAgfCAgNSArKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCsp CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCmluZGV4IDhhMDM4NDMuLjk4YzA4YTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx MyBAQAorMjAxNC0wMi0yNCAgSWFnbyBUb3JhbCBRdWlyb2dhICA8aXRvcmFsQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gV3JvbmcgYWN0aXZlIGNvbnRleHQgd2hlbiBkZXN0cm95aW5nIEdM IG9iamVjdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjkyNDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9ndGsvTGF5ZXJUcmVlSG9zdEd0ay5jcHA6CisgICAgICAg IChXZWJLaXQ6OkxheWVyVHJlZUhvc3RHdGs6OmludmFsaWRhdGUpOiBtYWtlIGNvbnRleHQgY3Vy cmVudCBiZWZvcmUgZGVzdHJveWluZyBHTCBvYmplY3RzLgorCiAyMDE0LTAyLTIzICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2MTQ0 NTA4PiBbaU9TXSBTb21lIGRlZmluaXRpb25zIG9mIElOU1RBTExfUEFUSCBkb27igJl0IGFjY291 bnQgZm9yIElOU1RBTExfUEFUSF9QUkVGSVgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9ndGsvTGF5ZXJUcmVlSG9zdEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL0xheWVyVHJlZUhvc3RHdGsuY3BwCmluZGV4IDBkOTMw ZmU0Li4zNGYwYzEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvZ3RrL0xheWVyVHJlZUhvc3RHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9ndGsvTGF5ZXJUcmVlSG9zdEd0ay5jcHAKQEAgLTE2OCw2ICsxNjgsMTEgQEAg dm9pZCBMYXllclRyZWVIb3N0R3RrOjppbnZhbGlkYXRlKCkKIHsKICAgICBBU1NFUlQobV9pc1Zh bGlkKTsKIAorICAgIC8vIFRoaXMgY2FuIHRyaWdnZXIgZGVzdHJ1Y3Rpb24gb2YgR0wgb2JqZWN0 cyBzbyBsZXQncyBtYWtlIHN1cmUgdGhhdAorICAgIC8vIHdlIGhhdmUgdGhlIHJpZ2h0IGFjdGl2 ZSBjb250ZXh0CisgICAgaWYgKG1fY29udGV4dCkKKyAgICAgICAgbV9jb250ZXh0LT5tYWtlQ29u dGV4dEN1cnJlbnQoKTsKKwogICAgIGNhbmNlbFBlbmRpbmdMYXllckZsdXNoKCk7CiAgICAgbV9y b290TGF5ZXIgPSBudWxscHRyOwogICAgIG1fbm9uQ29tcG9zaXRlZENvbnRlbnRMYXllciA9IG51 bGxwdHI7Ci0tIAoxLjguMy4yCgo=