129224 2014-02-22 20:47:04 -0800 Subpixel rendering: Add devicepixel based computation to BorderEdge class. 2014-02-23 08:17:38 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn jonlee kondapallykalyan simon.fraser oldest_to_newest 983663 0 zalan 2014-02-22 20:47:04 -0800 To produce correct width (and type) results, BorderEdge class needs to take device pixel ratio into account. 983668 1 224993 zalan 2014-02-22 21:14:45 -0800 Created attachment 224993 Patch 983697 2 224993 commit-queue 2014-02-23 08:17:35 -0800 Comment on attachment 224993 Patch Clearing flags on attachment: 224993 Committed r164555: <http://trac.webkit.org/changeset/164555> 983698 3 commit-queue 2014-02-23 08:17:38 -0800 All reviewed patches have been landed. Closing bug. 224993 2014-02-22 21:14:45 -0800 2014-02-23 08:17:35 -0800 Patch bug-129224-20140222211447.patch text/plain 6209 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWU3M2MwM2MzNTQ4Nzlh MzdhMDBmZjg5ZGE2ZWJhZTc2Y2EzM2M1ZC4uZWZhYWI0NDY3OTEzYjgwNWNkOWJmMDFiZmFkMzBj ODMwNThhNGI2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTAyLTIyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3VicGl4ZWwgcmVuZGVyaW5n OiBBZGQgZGV2aWNlcGl4ZWwgYmFzZWQgY29tcHV0YXRpb24gdG8gQm9yZGVyRWRnZSBjbGFzcy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTIyNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvIHByb2R1 Y2UgY29ycmVjdCB3aWR0aCAoYW5kIHR5cGUpIHJlc3VsdHMsIEJvcmRlckVkZ2UgY2xhc3MgbmVl ZHMgdG8gdGFrZSBkZXZpY2UgcGl4ZWwgcmF0aW8gaW50byBhY2NvdW50LgorCisgICAgICAgIEN1 cnJlbnRseSBub3QgdGVzdGFibGUuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94TW9k ZWxPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Qm9yZGVyRWRnZTo6Qm9yZGVyRWRnZSk6 CisgICAgICAgIChXZWJDb3JlOjpCb3JkZXJFZGdlOjpvYnNjdXJlc0JhY2tncm91bmRFZGdlKToK KyAgICAgICAgKFdlYkNvcmU6OkJvcmRlckVkZ2U6OmdldERvdWJsZUJvcmRlclN0cmlwZVdpZHRo cyk6IHRoaXMgZG9lcyBub3QgYWx3YXlzIHByb2R1Y2UgdGhlIHNhbWUKKyAgICAgICAgcmVzdWx0 IGFzIGJlZm9yZSwgYnV0IHRoZSBzdW0gb2YgaW5uZXIgYW5kIG91dGVyIGlzIG5vdCBkaWZmZXJl bnQuCisgICAgICAgIChXZWJDb3JlOjpCb3JkZXJFZGdlOjpib3JkZXJXaWR0aEluRGV2aWNlUGl4 ZWwpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6OmdldEJvcmRlckVk Z2VJbmZvKToKKwogMjAxNC0wMi0yMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbW92ZSBzb21lIHVucmVhY2hhYmxlIGNvZGUgKC1XdW5yZWFjaGFi bGUtY29kZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hN b2RlbE9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxP YmplY3QuY3BwCmluZGV4IGY0ZGIxYzc1OWYzNDA2MmI5ZmU0NDQ1Yzk4ODI3Y2Q1NjBiM2VlNDAu LjhmYjE2N2UzZjdhZjAyYTYxOGUxNjdkNDBkZDM2M2ZmZjE3N2YxOTUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcApAQCAtMTM5Niwy MiArMTM5NiwyNCBAQCBib29sIFJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWludE5pbmVQaWVjZUlt YWdlKEdyYXBoaWNzQ29udGV4dCogZ3JhcGhpY3NDb250ZXh0LAogCiBjbGFzcyBCb3JkZXJFZGdl IHsKIHB1YmxpYzoKLSAgICBCb3JkZXJFZGdlKExheW91dFVuaXQgZWRnZVdpZHRoLCBjb25zdCBD b2xvciYgZWRnZUNvbG9yLCBFQm9yZGVyU3R5bGUgZWRnZVN0eWxlLCBib29sIGVkZ2VJc1RyYW5z cGFyZW50LCBib29sIGVkZ2VJc1ByZXNlbnQgPSB0cnVlKQorICAgIEJvcmRlckVkZ2UoTGF5b3V0 VW5pdCBlZGdlV2lkdGgsIGNvbnN0IENvbG9yJiBlZGdlQ29sb3IsIEVCb3JkZXJTdHlsZSBlZGdl U3R5bGUsIGJvb2wgZWRnZUlzVHJhbnNwYXJlbnQsIGJvb2wgZWRnZUlzUHJlc2VudCwgZmxvYXQg ZGV2aWNlUGl4ZWxSYXRpbykKICAgICAgICAgOiB3aWR0aChlZGdlV2lkdGgpCiAgICAgICAgICwg Y29sb3IoZWRnZUNvbG9yKQogICAgICAgICAsIHN0eWxlKGVkZ2VTdHlsZSkKICAgICAgICAgLCBp c1RyYW5zcGFyZW50KGVkZ2VJc1RyYW5zcGFyZW50KQogICAgICAgICAsIGlzUHJlc2VudChlZGdl SXNQcmVzZW50KQorICAgICAgICAsIGRldmljZVBpeGVsUmF0aW8oZGV2aWNlUGl4ZWxSYXRpbykK ICAgICB7Ci0gICAgICAgIGlmIChzdHlsZSA9PSBET1VCTEUgJiYgZWRnZVdpZHRoIDwgMykKKyAg ICAgICAgaWYgKHN0eWxlID09IERPVUJMRSAmJiB3aWR0aCAgPCBib3JkZXJXaWR0aEluRGV2aWNl UGl4ZWwoMykpCiAgICAgICAgICAgICBzdHlsZSA9IFNPTElEOwogICAgIH0KICAgICAKICAgICBC b3JkZXJFZGdlKCkKLSAgICAgICAgOiB3aWR0aCgwKQorICAgICAgICA6IHdpZHRoKExheW91dFVu aXQ6OmZyb21QaXhlbCgwKSkKICAgICAgICAgLCBzdHlsZShCSElEREVOKQogICAgICAgICAsIGlz VHJhbnNwYXJlbnQoZmFsc2UpCiAgICAgICAgICwgaXNQcmVzZW50KGZhbHNlKQorICAgICAgICAs IGRldmljZVBpeGVsUmF0aW8oMSkKICAgICB7CiAgICAgfQogICAgIApAQCAtMTQyMCwxNCArMTQy MiwxNCBAQCBwdWJsaWM6CiAgICAgYm9vbCBwcmVzZW50QnV0SW52aXNpYmxlKCkgY29uc3QgeyBy ZXR1cm4gdXNlZFdpZHRoKCkgJiYgIWhhc1Zpc2libGVDb2xvckFuZFN0eWxlKCk7IH0KICAgICBi b29sIG9ic2N1cmVzQmFja2dyb3VuZEVkZ2UoZmxvYXQgc2NhbGUpIGNvbnN0CiAgICAgewotICAg ICAgICBpZiAoIWlzUHJlc2VudCB8fCBpc1RyYW5zcGFyZW50IHx8ICh3aWR0aCAqIHNjYWxlKSA8 IDIgfHwgY29sb3IuaGFzQWxwaGEoKSB8fCBzdHlsZSA9PSBCSElEREVOKQorICAgICAgICBpZiAo IWlzUHJlc2VudCB8fCBpc1RyYW5zcGFyZW50IHx8ICh3aWR0aCAqIHNjYWxlKSA8IGJvcmRlcldp ZHRoSW5EZXZpY2VQaXhlbCgyKSB8fCBjb2xvci5oYXNBbHBoYSgpIHx8IHN0eWxlID09IEJISURE RU4pCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAgICAgaWYgKHN0eWxlID09IERP VFRFRCB8fCBzdHlsZSA9PSBEQVNIRUQpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAg ICAgICAgaWYgKHN0eWxlID09IERPVUJMRSkKLSAgICAgICAgICAgIHJldHVybiB3aWR0aCA+PSA1 ICogc2NhbGU7IC8vIFRoZSBvdXRlciBiYW5kIG5lZWRzIHRvIGJlID49IDJweCB3aWRlIGF0IHVu aXQgc2NhbGUuCisgICAgICAgICAgICByZXR1cm4gd2lkdGggPj0gc2NhbGUgKiBib3JkZXJXaWR0 aEluRGV2aWNlUGl4ZWwoNSk7IC8vIFRoZSBvdXRlciBiYW5kIG5lZWRzIHRvIGJlID49IDJweCB3 aWRlIGF0IHVuaXQgc2NhbGUuCiAKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQpAQCAtMTQ0 NiwxNiArMTQ0OCw5IEBAIHB1YmxpYzoKICAgICAKICAgICB2b2lkIGdldERvdWJsZUJvcmRlclN0 cmlwZVdpZHRocyhMYXlvdXRVbml0JiBvdXRlcldpZHRoLCBMYXlvdXRVbml0JiBpbm5lcldpZHRo KSBjb25zdAogICAgIHsKLSAgICAgICAgaW50IGZ1bGxXaWR0aCA9IHVzZWRXaWR0aCgpOwotICAg ICAgICBvdXRlcldpZHRoID0gZnVsbFdpZHRoIC8gMzsKLSAgICAgICAgaW5uZXJXaWR0aCA9IGZ1 bGxXaWR0aCAqIDIgLyAzOwotCi0gICAgICAgIC8vIFdlIG5lZWQgY2VydGFpbiBpbnRlZ2VyIHJv dW5kaW5nIHJlc3VsdHMKLSAgICAgICAgaWYgKGZ1bGxXaWR0aCAlIDMgPT0gMikKLSAgICAgICAg ICAgIG91dGVyV2lkdGggKz0gMTsKLQotICAgICAgICBpZiAoZnVsbFdpZHRoICUgMyA9PSAxKQot ICAgICAgICAgICAgaW5uZXJXaWR0aCArPSAxOworICAgICAgICBMYXlvdXRVbml0IGZ1bGxXaWR0 aCA9IHVzZWRXaWR0aCgpOworICAgICAgICBpbm5lcldpZHRoID0gY2VpbFRvRGV2aWNlUGl4ZWwo ZnVsbFdpZHRoICogMiAvIDMsIGRldmljZVBpeGVsUmF0aW8pOworICAgICAgICBvdXRlcldpZHRo ID0gZmxvb3JUb0RldmljZVBpeGVsKGZ1bGxXaWR0aCAvIDMsIGRldmljZVBpeGVsUmF0aW8pOwog ICAgIH0KICAgICAKICAgICBMYXlvdXRVbml0IHdpZHRoOwpAQCAtMTQ2Myw2ICsxNDU4LDEwIEBA IHB1YmxpYzoKICAgICBFQm9yZGVyU3R5bGUgc3R5bGU7CiAgICAgYm9vbCBpc1RyYW5zcGFyZW50 OwogICAgIGJvb2wgaXNQcmVzZW50OworICAgIGZsb2F0IGRldmljZVBpeGVsUmF0aW87CisKK3By aXZhdGU6CisgICAgZmxvYXQgYm9yZGVyV2lkdGhJbkRldmljZVBpeGVsKGludCBsb2dpY2FsUGl4 ZWxzKSBjb25zdCB7IHJldHVybiBMYXlvdXRVbml0KGxvZ2ljYWxQaXhlbHMgLyBkZXZpY2VQaXhl bFJhdGlvKS50b0Zsb2F0KCk7IH0KIH07CiAKIHN0YXRpYyBib29sIGFsbENvcm5lcnNDbGlwcGVk T3V0KGNvbnN0IFJvdW5kZWRSZWN0JiBib3JkZXIsIGNvbnN0IExheW91dFJlY3QmIGNsaXBSZWN0 KQpAQCAtMjM1MywzMCArMjM1MiwzNSBAQCB2b2lkIFJlbmRlckJveE1vZGVsT2JqZWN0OjpjbGlw Qm9yZGVyU2lkZUZvckNvbXBsZXhJbm5lclBhdGgoR3JhcGhpY3NDb250ZXh0KiBncgogdm9pZCBS ZW5kZXJCb3hNb2RlbE9iamVjdDo6Z2V0Qm9yZGVyRWRnZUluZm8oQm9yZGVyRWRnZSBlZGdlc1td LCBjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUsIGJvb2wgaW5jbHVkZUxvZ2ljYWxMZWZ0RWRnZSwg Ym9vbCBpbmNsdWRlTG9naWNhbFJpZ2h0RWRnZSkgY29uc3QKIHsKICAgICBib29sIGhvcml6b250 YWwgPSBzdHlsZS0+aXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKTsKKyAgICBmbG9hdCBkZXZpY2VT Y2FsZUZhY3RvciA9IGRvY3VtZW50KCkuZGV2aWNlU2NhbGVGYWN0b3IoKTsKIAogICAgIGVkZ2Vz W0JTVG9wXSA9IEJvcmRlckVkZ2Uoc3R5bGUtPmJvcmRlclRvcFdpZHRoKCksCiAgICAgICAgIHN0 eWxlLT52aXNpdGVkRGVwZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlCb3JkZXJUb3BDb2xvciksCiAg ICAgICAgIHN0eWxlLT5ib3JkZXJUb3BTdHlsZSgpLAogICAgICAgICBzdHlsZS0+Ym9yZGVyVG9w SXNUcmFuc3BhcmVudCgpLAotICAgICAgICBob3Jpem9udGFsIHx8IGluY2x1ZGVMb2dpY2FsTGVm dEVkZ2UpOworICAgICAgICBob3Jpem9udGFsIHx8IGluY2x1ZGVMb2dpY2FsTGVmdEVkZ2UsCisg ICAgICAgIGRldmljZVNjYWxlRmFjdG9yKTsKIAogICAgIGVkZ2VzW0JTUmlnaHRdID0gQm9yZGVy RWRnZShzdHlsZS0+Ym9yZGVyUmlnaHRXaWR0aCgpLAogICAgICAgICBzdHlsZS0+dmlzaXRlZERl cGVuZGVudENvbG9yKENTU1Byb3BlcnR5Qm9yZGVyUmlnaHRDb2xvciksCiAgICAgICAgIHN0eWxl LT5ib3JkZXJSaWdodFN0eWxlKCksCiAgICAgICAgIHN0eWxlLT5ib3JkZXJSaWdodElzVHJhbnNw YXJlbnQoKSwKLSAgICAgICAgIWhvcml6b250YWwgfHwgaW5jbHVkZUxvZ2ljYWxSaWdodEVkZ2Up OworICAgICAgICAhaG9yaXpvbnRhbCB8fCBpbmNsdWRlTG9naWNhbFJpZ2h0RWRnZSwKKyAgICAg ICAgZGV2aWNlU2NhbGVGYWN0b3IpOwogCiAgICAgZWRnZXNbQlNCb3R0b21dID0gQm9yZGVyRWRn ZShzdHlsZS0+Ym9yZGVyQm90dG9tV2lkdGgoKSwKICAgICAgICAgc3R5bGUtPnZpc2l0ZWREZXBl bmRlbnRDb2xvcihDU1NQcm9wZXJ0eUJvcmRlckJvdHRvbUNvbG9yKSwKICAgICAgICAgc3R5bGUt PmJvcmRlckJvdHRvbVN0eWxlKCksCiAgICAgICAgIHN0eWxlLT5ib3JkZXJCb3R0b21Jc1RyYW5z cGFyZW50KCksCi0gICAgICAgIGhvcml6b250YWwgfHwgaW5jbHVkZUxvZ2ljYWxSaWdodEVkZ2Up OworICAgICAgICBob3Jpem9udGFsIHx8IGluY2x1ZGVMb2dpY2FsUmlnaHRFZGdlLAorICAgICAg ICBkZXZpY2VTY2FsZUZhY3Rvcik7CiAKICAgICBlZGdlc1tCU0xlZnRdID0gQm9yZGVyRWRnZShz dHlsZS0+Ym9yZGVyTGVmdFdpZHRoKCksCiAgICAgICAgIHN0eWxlLT52aXNpdGVkRGVwZW5kZW50 Q29sb3IoQ1NTUHJvcGVydHlCb3JkZXJMZWZ0Q29sb3IpLAogICAgICAgICBzdHlsZS0+Ym9yZGVy TGVmdFN0eWxlKCksCiAgICAgICAgIHN0eWxlLT5ib3JkZXJMZWZ0SXNUcmFuc3BhcmVudCgpLAot ICAgICAgICAhaG9yaXpvbnRhbCB8fCBpbmNsdWRlTG9naWNhbExlZnRFZGdlKTsKKyAgICAgICAg IWhvcml6b250YWwgfHwgaW5jbHVkZUxvZ2ljYWxMZWZ0RWRnZSwKKyAgICAgICAgZGV2aWNlU2Nh bGVGYWN0b3IpOwogfQogCiBib29sIFJlbmRlckJveE1vZGVsT2JqZWN0Ojpib3JkZXJPYnNjdXJl c0JhY2tncm91bmRFZGdlKGNvbnN0IEZsb2F0U2l6ZSYgY29udGV4dFNjYWxlKSBjb25zdAo=