129220 2014-02-22 16:51:22 -0800 Remove some unreachable code (-Wunreachable-code) 2014-02-22 17:32:48 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned alecflett allan.jensen commit-queue dino eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble jsbell kondapallykalyan macpherson menard philipj roger_fong sam sergio oldest_to_newest 983650 0 joepeck 2014-02-22 16:51:22 -0800 Remove some straightforward cases of unreachable code. I believe these are all break statements that have a return, goto, or another break immediately preceding them. It may not be possible to enable -Wunreachable-code by default. There are many places where we have code after CRASH() / NO_RETURN functions, return values after switches that return for all possible values, code that compiles differently on 32/64bit that statically eliminate branches (if sizeof(...)), debug only code enabled/disabled by static booleans that are false, and more. I did file some bugs on real cases of unreachable code that this caught; nothing significant. 983651 1 224985 joepeck 2014-02-22 16:53:52 -0800 Created attachment 224985 [PATCH] Proposed Fix 983653 2 224985 commit-queue 2014-02-22 17:32:45 -0800 Comment on attachment 224985 [PATCH] Proposed Fix Clearing flags on attachment: 224985 Committed r164553: <http://trac.webkit.org/changeset/164553> 983654 3 commit-queue 2014-02-22 17:32:48 -0800 All reviewed patches have been landed. Closing bug. 224985 2014-02-22 16:53:52 -0800 2014-02-22 17:32:45 -0800 [PATCH] Proposed Fix unreachable.patch text/plain 9870 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLmMKaW5kZXggYzYxM2FjYy4u YzBjMTNkOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0 YXBpLmMKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLmMKQEAg LTU3MCw3ICs1NzAsNiBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBFdmlsRXhjZXB0aW9uT2JqZWN0X2Nv bnZlcnRUb1R5cGUoSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2JqZQogICAgICAgICBicmVhazsK ICAgICBkZWZhdWx0OgogICAgICAgICByZXR1cm4gSlNWYWx1ZU1ha2VOdWxsKGNvbnRleHQpOwot ICAgICAgICBicmVhazsKICAgICB9CiAgICAgCiAgICAgSlNWYWx1ZVJlZiBmdW5jID0gSlNPYmpl Y3RHZXRQcm9wZXJ0eShjb250ZXh0LCBvYmplY3QsIGZ1bmNOYW1lLCBleGNlcHRpb24pOwpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggNWRkZWUwNi4uMzA0ODI1ZSAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDItMjIgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgc29tZSB1bnJlYWNoYWJsZSBj b2RlICgtV3VucmVhY2hhYmxlLWNvZGUpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjkyMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIEFQSS90ZXN0cy90ZXN0YXBpLmM6CisgICAgICAgIChFdmlsRXhj ZXB0aW9uT2JqZWN0X2NvbnZlcnRUb1R5cGUpOgorICAgICAgICAqIGRpc2Fzc2VtYmxlci91ZGlz ODYvdWRpczg2X2RlY29kZS5jOgorICAgICAgICAoZGVjb2RlX29wZXJhbmQpOgorCiAyMDE0LTAy LTIxICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogSlNDb250ZXh0IGluc3BlY3Rpb24gc2hvdWxkIHJlcG9ydCBleGNlcHRpb25z IGluIHRoZSBjb25zb2xlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNz ZW1ibGVyL3VkaXM4Ni91ZGlzODZfZGVjb2RlLmMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlz YXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfZGVjb2RlLmMKaW5kZXggYjdkYTBmMC4uNTc5OTAzNiAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvdWRp czg2X2RlY29kZS5jCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRp czg2L3VkaXM4Nl9kZWNvZGUuYwpAQCAtNjUyLDcgKzY1Miw2IEBAIGRlY29kZV9vcGVyYW5kKHN0 cnVjdCB1ZCAgICAgICAgICAgKnUsCiAgICAgY2FzZSBPUF9FOgogICAgICAgZGVjb2RlX21vZHJt X3JtKHUsIG9wZXJhbmQsIFRfR1BSLCBzaXplKTsKICAgICAgIGJyZWFrOwotICAgICAgYnJlYWs7 CiAgICAgY2FzZSBPUF9HOgogICAgICAgZGVjb2RlX21vZHJtX3JlZyh1LCBvcGVyYW5kLCBUX0dQ Uiwgc2l6ZSk7CiAgICAgICBicmVhazsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlNDJhMWQwLi4wZTA3M2JmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEgQEAKKzIwMTQtMDItMjIgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgc29tZSB1bnJlYWNoYWJsZSBj b2RlICgtV3VucmVhY2hhYmxlLWNvZGUpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjkyMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NDaGFyYWN0ZXJCdWZmZXIpOgor ICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjpwcm9jZXNzRW5kVGFnKToKKyAgICAg ICAgVGhlIG9ubHkgdHJpY2t5IGNhc2UuIEhlcmUgdGhlcmUgd2FzIGEgYnJlYWsgaW5zaWRlIHRo ZQorICAgICAgICAjaWYsIGJ1dCBub3QgdGhlICNlbHNlLCBhbmQgYSBicmVhayBhZnRlciB0aGUg I2VuZGlmLgorICAgICAgICBSZW1vdmUgdGhlIGJyZWFrIGluc2lkZSB0aGUgI2lmLCBhbmQgYWx3 YXlzIHVzZSB0aGUKKyAgICAgICAgYnJlYWsgYWZ0ZXIgdGhlICNlbmRpZi4KKworICAgICAgICAq IE1vZHVsZXMvaW5kZXhlZGRiL0lEQlRyYW5zYWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OklEQlRyYW5zYWN0aW9uOjptb2RlVG9TdHJpbmcpOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pT VHJhY2tDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6dG9KUyk6CisgICAgICAgICogYmlu ZGluZ3MvanMvSlNXZWJHTFJlbmRlcmluZ0NvbnRleHRDdXN0b20uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6ZnVuY3Rpb25Gb3JVbmlmb3JtKToKKyAgICAgICAgKiBjc3MvU2VsZWN0b3JDaGVja2Vy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tPbmUpOgorICAg ICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1M TWVkaWFFbGVtZW50OjpwYXJzZUF0dHJpYnV0ZSk6CisgICAgICAgICogcGFnZS9DYXB0aW9uVXNl clByZWZlcmVuY2VzTWVkaWFBRi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYXB0aW9uVXNlclBy ZWZlcmVuY2VzTWVkaWFBRjo6Y2FwdGlvbkRpc3BsYXlNb2RlKToKKwogMjAxNC0wMi0yMSAgTXls ZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIEFmdGVyIGNv cHkgYW5kIHBhc3RlLCBjdXJzb3IgbWF5IGFwcGVhciB0byBiZSBhYm92ZSB0aGUgYm90dG9tIG9m IGNvbnRlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lE QlRyYW5zYWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQlRy YW5zYWN0aW9uLmNwcAppbmRleCAyZTQ4MWE3Li5hZTU2Yzg1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJUcmFuc2FjdGlvbi5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCVHJhbnNhY3Rpb24uY3BwCkBAIC0zNDgsMTUg KzM0OCwxMiBAQCBjb25zdCBBdG9taWNTdHJpbmcmIElEQlRyYW5zYWN0aW9uOjptb2RlVG9TdHJp bmcoSW5kZXhlZERCOjpUcmFuc2FjdGlvbk1vZGUgbW9kZQogICAgIHN3aXRjaCAobW9kZSkgewog ICAgIGNhc2UgSW5kZXhlZERCOjpUcmFuc2FjdGlvbk1vZGU6OlJlYWRPbmx5OgogICAgICAgICBy ZXR1cm4gSURCVHJhbnNhY3Rpb246Om1vZGVSZWFkT25seSgpOwotICAgICAgICBicmVhazsKIAog ICAgIGNhc2UgSW5kZXhlZERCOjpUcmFuc2FjdGlvbk1vZGU6OlJlYWRXcml0ZToKICAgICAgICAg cmV0dXJuIElEQlRyYW5zYWN0aW9uOjptb2RlUmVhZFdyaXRlKCk7Ci0gICAgICAgIGJyZWFrOwog CiAgICAgY2FzZSBJbmRleGVkREI6OlRyYW5zYWN0aW9uTW9kZTo6VmVyc2lvbkNoYW5nZToKICAg ICAgICAgcmV0dXJuIElEQlRyYW5zYWN0aW9uOjptb2RlVmVyc2lvbkNoYW5nZSgpOwotICAgICAg ICBicmVhazsKICAgICB9CiAKICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTVHJhY2tDdXN0b20uY3BwIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNUcmFja0N1c3RvbS5jcHAKaW5kZXggMGFkMjMzNi4uNDY1NDFj MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNUcmFja0N1c3RvbS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNUcmFja0N1c3RvbS5jcHAKQEAg LTY5LDE1ICs2OSwxMiBAQCBKU0M6OkpTVmFsdWUgdG9KUyhKU0M6OkV4ZWNTdGF0ZSogZXhlYywg SlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgVHJhY2tCYQogICAgICAgICAKICAgICBj YXNlIFRyYWNrQmFzZTo6QXVkaW9UcmFjazoKICAgICAgICAgcmV0dXJuIENSRUFURV9ET01fV1JB UFBFUihleGVjLCBnbG9iYWxPYmplY3QsIEF1ZGlvVHJhY2ssIHRyYWNrKTsKLSAgICAgICAgYnJl YWs7CiAKICAgICBjYXNlIFRyYWNrQmFzZTo6VmlkZW9UcmFjazoKICAgICAgICAgcmV0dXJuIENS RUFURV9ET01fV1JBUFBFUihleGVjLCBnbG9iYWxPYmplY3QsIFZpZGVvVHJhY2ssIHRyYWNrKTsK LSAgICAgICAgYnJlYWs7CiAKICAgICBjYXNlIFRyYWNrQmFzZTo6VGV4dFRyYWNrOgogICAgICAg ICByZXR1cm4gQ1JFQVRFX0RPTV9XUkFQUEVSKGV4ZWMsIGdsb2JhbE9iamVjdCwgVGV4dFRyYWNr LCB0cmFjayk7Ci0gICAgICAgIGJyZWFrOwogICAgIH0KICAgICAKICAgICByZXR1cm4ganNOdWxs KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1dlYkdMUmVuZGVy aW5nQ29udGV4dEN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1dlYkdM UmVuZGVyaW5nQ29udGV4dEN1c3RvbS5jcHAKaW5kZXggYjY0MzdmYi4uYTE5MzE4NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNXZWJHTFJlbmRlcmluZ0NvbnRleHRD dXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTV2ViR0xSZW5kZXJp bmdDb250ZXh0Q3VzdG9tLmNwcApAQCAtNDY1LDcgKzQ2NSw2IEBAIHN0YXRpYyBib29sIGZ1bmN0 aW9uRm9yVW5pZm9ybShEYXRhRnVuY3Rpb25Ub0NhbGwgZikKICAgICBjYXNlIGZfdW5pZm9ybTN2 OgogICAgIGNhc2UgZl91bmlmb3JtNHY6CiAgICAgICAgIHJldHVybiB0cnVlOwotICAgICAgICBi cmVhazsKICAgICBkZWZhdWx0OiBicmVhazsKICAgICB9CiAgICAgcmV0dXJuIGZhbHNlOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVja2VyLmNwcAppbmRleCBlYWI5YWQwLi42NWJhMTQyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVja2VyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVja2VyLmNwcApAQCAtNjM2LDcgKzYzNiw2IEBA IGJvb2wgU2VsZWN0b3JDaGVja2VyOjpjaGVja09uZShjb25zdCBTZWxlY3RvckNoZWNraW5nQ29u dGV4dCYgY29udGV4dCkgY29uc3QKICAgICAgICAgICAgIHJldHVybiBpc0VuYWJsZWQoZWxlbWVu dCk7CiAgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb0Z1bGxQYWdlTWVkaWE6CiAgICAg ICAgICAgICByZXR1cm4gZWxlbWVudC0+ZG9jdW1lbnQoKS5pc01lZGlhRG9jdW1lbnQoKTsKLSAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9EZWZhdWx0 OgogICAgICAgICAgICAgcmV0dXJuIGlzRGVmYXVsdEJ1dHRvbkZvckZvcm0oZWxlbWVudCk7CiAg ICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb0Rpc2FibGVkOgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggNWRkNTVkZi4uOTM1MTY4YSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC0yNjQ3LDEzICsyNjQ3LDEwIEBA IFN0cmluZyBIVE1MTWVkaWFFbGVtZW50OjpwcmVsb2FkKCkgY29uc3QKICAgICBzd2l0Y2ggKG1f cHJlbG9hZCkgewogICAgIGNhc2UgTWVkaWFQbGF5ZXI6Ok5vbmU6CiAgICAgICAgIHJldHVybiBB U0NJSUxpdGVyYWwoIm5vbmUiKTsKLSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBNZWRpYVBsYXll cjo6TWV0YURhdGE6CiAgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIm1ldGFkYXRhIik7Ci0g ICAgICAgIGJyZWFrOwogICAgIGNhc2UgTWVkaWFQbGF5ZXI6OkF1dG86CiAgICAgICAgIHJldHVy biBBU0NJSUxpdGVyYWwoImF1dG8iKTsKLSAgICAgICAgYnJlYWs7CiAgICAgfQogCiAgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNl ci9IVE1MVHJlZUJ1aWxkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRy ZWVCdWlsZGVyLmNwcAppbmRleCA4MTQ1YzFkLi40ZGYxZmYwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAKQEAgLTIyOTcsOCArMjI5Nyw2IEBA IHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpwcm9jZXNzRW5kVGFnKEF0b21pY0hUTUxUb2tlbiogdG9r ZW4pCiAgICAgICAgICAgICBwcm9jZXNzVGVtcGxhdGVFbmRUYWcodG9rZW4pOwogICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICB9Ci0KLSAgICAgICAgYnJlYWs7CiAjZWxzZQogICAgICAgICBB U1NFUlRfTk9UX1JFQUNIRUQoKTsKICNlbmRpZgpAQCAtMjU1Miw3ICsyNTUwLDYgQEAgUmVwcm9j ZXNzQnVmZmVyOgogICAgICAgICAvLyBGSVhNRTogcGFyc2UgZXJyb3IKICAgICAgICAgc2V0SW5z ZXJ0aW9uTW9kZShJbnNlcnRpb25Nb2RlOjpJbkJvZHkpOwogICAgICAgICBnb3RvIFJlcHJvY2Vz c0J1ZmZlcjsKLSAgICAgICAgYnJlYWs7CiAgICAgfQogICAgIGNhc2UgSW5zZXJ0aW9uTW9kZTo6 VGV4dDogewogICAgICAgICBBU1NFUlQoaW5zZXJ0aW9uTW9kZSgpID09IEluc2VydGlvbk1vZGU6 OlRleHQpOwpAQCAtMjU2OCw3ICsyNTY1LDYgQEAgUmVwcm9jZXNzQnVmZmVyOgogICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICBkZWZhdWx0Rm9ySW5IZWFkTm9zY3JpcHQoKTsKICAgICAgICAg Z290byBSZXByb2Nlc3NCdWZmZXI7Ci0gICAgICAgIGJyZWFrOwogICAgIH0KICAgICBjYXNlIElu c2VydGlvbk1vZGU6OkluRnJhbWVzZXQ6CiAgICAgY2FzZSBJbnNlcnRpb25Nb2RlOjpBZnRlckZy YW1lc2V0OiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NhcHRpb25Vc2VyUHJl ZmVyZW5jZXNNZWRpYUFGLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2FwdGlvblVzZXJQcmVm ZXJlbmNlc01lZGlhQUYuY3BwCmluZGV4IGYwOWQyNzcuLjA0MjBjZTEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvQ2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUYuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUYuY3BwCkBA IC0xNjUsMTUgKzE2NSwxMiBAQCBDYXB0aW9uVXNlclByZWZlcmVuY2VzOjpDYXB0aW9uRGlzcGxh eU1vZGUgQ2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUY6OmNhcHRpbwogICAgIHN3aXRjaCAo ZGlzcGxheVR5cGUpIHsKICAgICBjYXNlIGtNQUNhcHRpb25BcHBlYXJhbmNlRGlzcGxheVR5cGVG b3JjZWRPbmx5OgogICAgICAgICByZXR1cm4gRm9yY2VkT25seTsKLSAgICAgICAgYnJlYWs7CiAK ICAgICBjYXNlIGtNQUNhcHRpb25BcHBlYXJhbmNlRGlzcGxheVR5cGVBdXRvbWF0aWM6CiAgICAg ICAgIHJldHVybiBBdXRvbWF0aWM7Ci0gICAgICAgIGJyZWFrOwogCiAgICAgY2FzZSBrTUFDYXB0 aW9uQXBwZWFyYW5jZURpc3BsYXlUeXBlQWx3YXlzT246CiAgICAgICAgIHJldHVybiBBbHdheXNP bjsKLSAgICAgICAgYnJlYWs7CiAgICAgfQogCiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cKaW5kZXggMDQ5N2FmNi4uNDczZGJkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTAyLTIyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAg ICAgICAgUmVtb3ZlIHNvbWUgdW5yZWFjaGFibGUgY29kZSAoLVd1bnJlYWNoYWJsZS1jb2RlKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MjIwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlQVBJQ2FzdC5oOgorICAgICAgICAoV2Vi S2l0Ojp0b0FQSSk6CisKIDIwMTQtMDItMjEgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KIAogICAgICAgICBNYWRlIFdLV2ViVmlldyBpbXBsZW1lbnQgYWxsIFdLQ29udGVudFZpZXdE ZWxlZ2F0ZSBtZXRob2RzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9J bmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZUFQSUNhc3QuaCBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVBUElDYXN0LmgKaW5kZXggMTVh YzE1OC4uZTYzNTQwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Jbmpl Y3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZUFQSUNhc3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlQVBJQ2FzdC5oCkBAIC03Nywx MyArNzcsMTAgQEAgaW5saW5lIFdLSW5zZXJ0QWN0aW9uVHlwZSB0b0FQSShXZWJDb3JlOjpFZGl0 b3JJbnNlcnRBY3Rpb24gYWN0aW9uKQogICAgIHN3aXRjaCAoYWN0aW9uKSB7CiAgICAgY2FzZSBX ZWJDb3JlOjpFZGl0b3JJbnNlcnRBY3Rpb25UeXBlZDoKICAgICAgICAgcmV0dXJuIGtXS0luc2Vy dEFjdGlvblR5cGVkOwotICAgICAgICBicmVhazsKICAgICBjYXNlIFdlYkNvcmU6OkVkaXRvcklu c2VydEFjdGlvblBhc3RlZDoKICAgICAgICAgcmV0dXJuIGtXS0luc2VydEFjdGlvblBhc3RlZDsK LSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBXZWJDb3JlOjpFZGl0b3JJbnNlcnRBY3Rpb25Ecm9w cGVkOgogICAgICAgICByZXR1cm4ga1dLSW5zZXJ0QWN0aW9uRHJvcHBlZDsKLSAgICAgICAgYnJl YWs7CiAgICAgfQogICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIHJldHVybiBrV0tJbnNl cnRBY3Rpb25UeXBlZDsKQEAgLTk0LDEwICs5MSw4IEBAIGlubGluZSBXS0FmZmluaXR5VHlwZSB0 b0FQSShXZWJDb3JlOjpFQWZmaW5pdHkgYWZmaW5pdHkpCiAgICAgc3dpdGNoIChhZmZpbml0eSkg ewogICAgIGNhc2UgV2ViQ29yZTo6VVBTVFJFQU06CiAgICAgICAgIHJldHVybiBrV0tBZmZpbml0 eVVwc3RyZWFtOwotICAgICAgICBicmVhazsKICAgICBjYXNlIFdlYkNvcmU6OkRPV05TVFJFQU06 CiAgICAgICAgIHJldHVybiBrV0tBZmZpbml0eURvd25zdHJlYW07Ci0gICAgICAgIGJyZWFrOwog ICAgIH0KICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICByZXR1cm4ga1dLQWZmaW5pdHlV cHN0cmVhbTsK