129195 2014-02-21 21:22:51 -0800 REGRESSION(r164412): Pixel cracks when zooming in to any web content. 2014-02-21 23:19:27 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser thorton webkit-bug-importer oldest_to_newest 983503 0 zalan 2014-02-21 21:22:51 -0800 1. Load any web page. 2. Pinch-zoom in. 3. 1 pixel width tile grid shows up. 983504 1 zalan 2014-02-21 21:23:38 -0800 <rdar://problem/16131028> 983508 2 224946 zalan 2014-02-21 21:40:05 -0800 Created attachment 224946 Patch 983512 3 224946 simon.fraser 2014-02-21 22:18:04 -0800 Comment on attachment 224946 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224946&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:2243 > + LayoutRect dirtyRect(enclosingIntRect(clip)); > IntRect pixelSnappedRectForIntegralPositionedItems = pixelSnappedIntRect(dirtyRect); Odd that you call pixelSnappedIntRect() on the result of enclosingIntRect(). Should it be an IntRect? 983513 4 zalan 2014-02-21 22:23:10 -0800 (In reply to comment #3) > (From update of attachment 224946 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=224946&action=review > > > Source/WebCore/rendering/RenderLayerBacking.cpp:2243 > > + LayoutRect dirtyRect(enclosingIntRect(clip)); > > IntRect pixelSnappedRectForIntegralPositionedItems = pixelSnappedIntRect(dirtyRect); > > Odd that you call pixelSnappedIntRect() on the result of enclosingIntRect(). Should it be an IntRect? Yes, it looks odd, but I left it there so that when I clean up the paint rect clipping all I need to change back is the dirtyRect and the pixelSnappedRectForIntegralPositionedItems can stay as it is. 983514 5 zalan 2014-02-21 22:26:24 -0800 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 224946 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=224946&action=review > > > > > Source/WebCore/rendering/RenderLayerBacking.cpp:2243 > > > + LayoutRect dirtyRect(enclosingIntRect(clip)); > > > IntRect pixelSnappedRectForIntegralPositionedItems = pixelSnappedIntRect(dirtyRect); > > > > Odd that you call pixelSnappedIntRect() on the result of enclosingIntRect(). Should it be an IntRect? > Yes, it looks odd, but I left it there so that when I clean up the paint rect clipping all I need to change back is the dirtyRect and the pixelSnappedRectForIntegralPositionedItems can stay as it is. I guess I should remove it to not to cause any confusion. (as it might take a few days to get to the clipping cleanup) 983515 6 simon.fraser 2014-02-21 22:29:57 -0800 Just add a comment if you plan to come back to it. 983517 7 224948 zalan 2014-02-21 22:38:24 -0800 Created attachment 224948 Patch 983518 8 224948 zalan 2014-02-21 22:38:52 -0800 Comment on attachment 224948 Patch EWSing. 983519 9 zalan 2014-02-21 22:40:17 -0800 (In reply to comment #6) > Just add a comment if you plan to come back to it. I prefer what you suggested first. It's more explicit that way. Thanks for the review. 983524 10 224948 commit-queue 2014-02-21 23:19:24 -0800 Comment on attachment 224948 Patch Clearing flags on attachment: 224948 Committed r164532: <http://trac.webkit.org/changeset/164532> 983525 11 commit-queue 2014-02-21 23:19:27 -0800 All reviewed patches have been landed. Closing bug. 224946 2014-02-21 21:40:05 -0800 2014-02-21 22:38:21 -0800 Patch bug-129195-20140221214005.patch text/plain 3103 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzUxNDI4Zjg1YjRiN2Nm ZWYxZTA5ZDI3Zjg2NzdlMTdmZWRhN2QzNi4uZDIyN2VlOTE0NWEzYzQ4MzljMDk0MWMzZThhYTRj MzgyYzcyNzcwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAyLTIxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTY0NDEy KTogUGl4ZWwgY3JhY2tzIHdoZW4gem9vbWluZyBpbiB0byBhbnkgd2ViIGNvbnRlbnQuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjkxOTUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnRlZ3JhbCBjbGlw cGluZyBvZiB0aGUgcmVwYWludCByZWN0IHdhcyBwcmVtYXR1cmVseSByZW1vdmVkIGluIFJlbmRl ckxheWVyQmFja2luZzo6cGFpbnRDb250ZW50cygpLgorICAgICAgICBSZXBhaW50IHJlY3RzIG5l ZWRzIGEgdW5pZm9ybSwgZGV2aWNlIHBpeGVsIHByZWNpc2UgY2xpcHBpbmcgYWNyb3NzIHRoZSBw YWludGluZyBmbG93IGluY2x1ZGluZyBSZW5kZXJMYXllciwKKyAgICAgICAgUmVuZGVyVmlldyBh bmQgVGlsZUNvbnRyb2xsZXIuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNr aW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6cGFpbnRDb250 ZW50cyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OmNvbXBvc2l0ZWRC b3VuZHNJbmNsdWRpbmdNYXJnaW4pOgorCiAyMDE0LTAyLTIxICBSeW9zdWtlIE5pd2EgIDxybml3 YUB3ZWJraXQub3JnPgogCiAgICAgICAgIElubmVyIHRleHQgZWxlbWVudCBzaG91bGQgbm90IHVz ZSAtd2Via2l0LXVzZXItbW9kaWZ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllckJhY2tpbmcuY3BwCmluZGV4IDBmNGIyYmFiYjEwNjBiNjMxZGZkYjIzNjljYjIwMmM0 ZWE2ZThmZDUuLjk1ZjczYTcxZTBmYjVjNjJhMDBlZDg5NDJmODdmYzMzYmNjMjUyZmEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC0y MjM5LDcgKzIyMzksNyBAQCB2b2lkIFJlbmRlckxheWVyQmFja2luZzo6cGFpbnRDb250ZW50cyhj b25zdCBHcmFwaGljc0xheWVyKiBncmFwaGljc0xheWVyLCBHcmFwaAogI2VuZGlmCiAKICAgICAv LyBUaGUgZGlydHlSZWN0IGlzIGluIHRoZSBjb29yZHMgb2YgdGhlIHBhaW50aW5nIHJvb3QuCi0g ICAgTGF5b3V0UmVjdCBkaXJ0eVJlY3QoY2xpcCk7CisgICAgTGF5b3V0UmVjdCBkaXJ0eVJlY3Qo ZW5jbG9zaW5nSW50UmVjdChjbGlwKSk7CiAgICAgSW50UmVjdCBwaXhlbFNuYXBwZWRSZWN0Rm9y SW50ZWdyYWxQb3NpdGlvbmVkSXRlbXMgPSBwaXhlbFNuYXBwZWRJbnRSZWN0KGRpcnR5UmVjdCk7 CiAKICAgICBpZiAoZ3JhcGhpY3NMYXllciA9PSBtX2dyYXBoaWNzTGF5ZXIuZ2V0KCkKQEAgLTIy NTAsNyArMjI1MCw3IEBAIHZvaWQgUmVuZGVyTGF5ZXJCYWNraW5nOjpwYWludENvbnRlbnRzKGNv bnN0IEdyYXBoaWNzTGF5ZXIqIGdyYXBoaWNzTGF5ZXIsIEdyYXBoCiAgICAgICAgIEluc3BlY3Rv ckluc3RydW1lbnRhdGlvbjo6d2lsbFBhaW50KCZyZW5kZXJlcigpKTsKIAogICAgICAgICBpZiAo IShwYWludGluZ1BoYXNlICYgR3JhcGhpY3NMYXllclBhaW50T3ZlcmZsb3dDb250ZW50cykpCi0g ICAgICAgICAgICBkaXJ0eVJlY3QuaW50ZXJzZWN0KGVuY2xvc2luZ0ludFJlY3QoY29tcG9zaXRl ZEJvdW5kc0luY2x1ZGluZ01hcmdpbigpKSk7CisgICAgICAgICAgICBkaXJ0eVJlY3QuaW50ZXJz ZWN0KGNvbXBvc2l0ZWRCb3VuZHNJbmNsdWRpbmdNYXJnaW4oKSk7CiAKICAgICAgICAgLy8gV2Ug aGF2ZSB0byB1c2UgdGhlIHNhbWUgcm9vdCBhcyBmb3IgaGl0IHRlc3RpbmcsIGJlY2F1c2UgYm90 aCBtZXRob2RzIGNhbiBjb21wdXRlIGFuZCBjYWNoZSBjbGlwUmVjdHMuCiAgICAgICAgIHBhaW50 SW50b0xheWVyKGdyYXBoaWNzTGF5ZXIsICZjb250ZXh0LCBkaXJ0eVJlY3QsIFBhaW50QmVoYXZp b3JOb3JtYWwsIHBhaW50aW5nUGhhc2UpOwpAQCAtMjUzNyw4ICsyNTM3LDggQEAgTGF5b3V0UmVj dCBSZW5kZXJMYXllckJhY2tpbmc6OmNvbXBvc2l0ZWRCb3VuZHNJbmNsdWRpbmdNYXJnaW4oKSBj b25zdAogICAgIExheW91dFVuaXQgbGVmdE1hcmdpbldpZHRoID0gdGlsZWRCYWNraW5nLT5sZWZ0 TWFyZ2luV2lkdGgoKTsKICAgICBMYXlvdXRVbml0IHRvcE1hcmdpbkhlaWdodCA9IHRpbGVkQmFj a2luZy0+dG9wTWFyZ2luSGVpZ2h0KCk7CiAKLSAgICBib3VuZHNJbmNsdWRpbmdNYXJnaW4ubW92 ZUJ5KEludFBvaW50KC1sZWZ0TWFyZ2luV2lkdGgsIC10b3BNYXJnaW5IZWlnaHQpKTsKLSAgICBi b3VuZHNJbmNsdWRpbmdNYXJnaW4uZXhwYW5kKGxlZnRNYXJnaW5XaWR0aCArIChMYXlvdXRVbml0 KXRpbGVkQmFja2luZy0+cmlnaHRNYXJnaW5XaWR0aCgpLCB0b3BNYXJnaW5IZWlnaHQgKyAoTGF5 b3V0VW5pdCl0aWxlZEJhY2tpbmctPmJvdHRvbU1hcmdpbkhlaWdodCgpKTsKKyAgICBib3VuZHNJ bmNsdWRpbmdNYXJnaW4ubW92ZUJ5KExheW91dFBvaW50KC1sZWZ0TWFyZ2luV2lkdGgsIC10b3BN YXJnaW5IZWlnaHQpKTsKKyAgICBib3VuZHNJbmNsdWRpbmdNYXJnaW4uZXhwYW5kKGxlZnRNYXJn aW5XaWR0aCArIHRpbGVkQmFja2luZy0+cmlnaHRNYXJnaW5XaWR0aCgpLCB0b3BNYXJnaW5IZWln aHQgKyB0aWxlZEJhY2tpbmctPmJvdHRvbU1hcmdpbkhlaWdodCgpKTsKIAogICAgIHJldHVybiBi b3VuZHNJbmNsdWRpbmdNYXJnaW47CiB9Cg== 224948 2014-02-21 22:38:24 -0800 2014-02-21 23:19:24 -0800 Patch bug-129195-20140221223823.patch text/plain 4984 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzUxNDI4Zjg1YjRiN2Nm ZWYxZTA5ZDI3Zjg2NzdlMTdmZWRhN2QzNi4uMjc1MjMyZDBhZDZmOTc3ZTIwNjEyODdiOTkyNzBi MjE3OThmYTQ3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAyLTIxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTY0NDEy KTogUGl4ZWwgY3JhY2tzIHdoZW4gem9vbWluZyBpbiB0byBhbnkgd2ViIGNvbnRlbnQuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjkxOTUKKworICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgSW50ZWdyYWwgY2xpcHBp bmcgb2YgdGhlIHJlcGFpbnQgcmVjdCB3YXMgcHJlbWF0dXJlbHkgcmVtb3ZlZCBpbiBSZW5kZXJM YXllckJhY2tpbmc6OnBhaW50Q29udGVudHMoKS4KKyAgICAgICAgUmVwYWludCByZWN0cyBuZWVk cyBhIHVuaWZvcm0sIGRldmljZSBwaXhlbCBwcmVjaXNlIGNsaXBwaW5nIGFjcm9zcyB0aGUgcGFp bnRpbmcgZmxvdyBpbmNsdWRpbmcgUmVuZGVyTGF5ZXIsCisgICAgICAgIFJlbmRlclZpZXcgYW5k IFRpbGVDb250cm9sbGVyLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2lu Zy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OnBhaW50Q29udGVu dHMpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjpjb21wb3NpdGVkQm91 bmRzSW5jbHVkaW5nTWFyZ2luKToKKwogMjAxNC0wMi0yMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBJbm5lciB0ZXh0IGVsZW1lbnQgc2hvdWxkIG5vdCB1c2Ug LXdlYmtpdC11c2VyLW1vZGlmeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQmFja2luZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJCYWNraW5nLmNwcAppbmRleCAwZjRiMmJhYmIxMDYwYjYzMWRmZGIyMzY5Y2IyMDJjNGVh NmU4ZmQ1Li4wMDc1NTI0Y2EwYjJjOTcxODUyNjczOWNjMzQxZTcwNGQ2YTc1NWVmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcApAQCAtMjE3 Miw3ICsyMTcyLDcgQEAgdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnNldENvbnRlbnRzTmVlZERp c3BsYXlJblJlY3QoY29uc3QgTGF5b3V0UmVjdCYgciwgR3JhcGgKIH0KIAogdm9pZCBSZW5kZXJM YXllckJhY2tpbmc6OnBhaW50SW50b0xheWVyKGNvbnN0IEdyYXBoaWNzTGF5ZXIqIGdyYXBoaWNz TGF5ZXIsIEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwKLSAgICBjb25zdCBMYXlvdXRSZWN0JiBw YWludERpcnR5UmVjdCwgLy8gSW4gdGhlIGNvb3JkcyBvZiByb290TGF5ZXIuCisgICAgY29uc3Qg SW50UmVjdCYgcGFpbnREaXJ0eVJlY3QsIC8vIEluIHRoZSBjb29yZHMgb2Ygcm9vdExheWVyLgog ICAgIFBhaW50QmVoYXZpb3IgcGFpbnRCZWhhdmlvciwgR3JhcGhpY3NMYXllclBhaW50aW5nUGhh c2UgcGFpbnRpbmdQaGFzZSkKIHsKICAgICBpZiAocGFpbnRzSW50b1dpbmRvdygpIHx8IHBhaW50 c0ludG9Db21wb3NpdGVkQW5jZXN0b3IoKSkgewpAQCAtMjIzOSw4ICsyMjM5LDcgQEAgdm9pZCBS ZW5kZXJMYXllckJhY2tpbmc6OnBhaW50Q29udGVudHMoY29uc3QgR3JhcGhpY3NMYXllciogZ3Jh cGhpY3NMYXllciwgR3JhcGgKICNlbmRpZgogCiAgICAgLy8gVGhlIGRpcnR5UmVjdCBpcyBpbiB0 aGUgY29vcmRzIG9mIHRoZSBwYWludGluZyByb290LgotICAgIExheW91dFJlY3QgZGlydHlSZWN0 KGNsaXApOwotICAgIEludFJlY3QgcGl4ZWxTbmFwcGVkUmVjdEZvckludGVncmFsUG9zaXRpb25l ZEl0ZW1zID0gcGl4ZWxTbmFwcGVkSW50UmVjdChkaXJ0eVJlY3QpOworICAgIEludFJlY3QgZGly dHlSZWN0ID0gZW5jbG9zaW5nSW50UmVjdChjbGlwKTsKIAogICAgIGlmIChncmFwaGljc0xheWVy ID09IG1fZ3JhcGhpY3NMYXllci5nZXQoKQogICAgICAgICB8fCBncmFwaGljc0xheWVyID09IG1f Zm9yZWdyb3VuZExheWVyLmdldCgpCkBAIC0yMjU3LDkgKzIyNTYsOSBAQCB2b2lkIFJlbmRlckxh eWVyQmFja2luZzo6cGFpbnRDb250ZW50cyhjb25zdCBHcmFwaGljc0xheWVyKiBncmFwaGljc0xh eWVyLCBHcmFwaAogCiAgICAgICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZGlkUGFpbnQo JnJlbmRlcmVyKCksICZjb250ZXh0LCBkaXJ0eVJlY3QpOwogICAgIH0gZWxzZSBpZiAoZ3JhcGhp Y3NMYXllciA9PSBsYXllckZvckhvcml6b250YWxTY3JvbGxiYXIoKSkgewotICAgICAgICBwYWlu dFNjcm9sbGJhcihtX293bmluZ0xheWVyLmhvcml6b250YWxTY3JvbGxiYXIoKSwgY29udGV4dCwg cGl4ZWxTbmFwcGVkUmVjdEZvckludGVncmFsUG9zaXRpb25lZEl0ZW1zKTsKKyAgICAgICAgcGFp bnRTY3JvbGxiYXIobV9vd25pbmdMYXllci5ob3Jpem9udGFsU2Nyb2xsYmFyKCksIGNvbnRleHQs IGRpcnR5UmVjdCk7CiAgICAgfSBlbHNlIGlmIChncmFwaGljc0xheWVyID09IGxheWVyRm9yVmVy dGljYWxTY3JvbGxiYXIoKSkgewotICAgICAgICBwYWludFNjcm9sbGJhcihtX293bmluZ0xheWVy LnZlcnRpY2FsU2Nyb2xsYmFyKCksIGNvbnRleHQsIHBpeGVsU25hcHBlZFJlY3RGb3JJbnRlZ3Jh bFBvc2l0aW9uZWRJdGVtcyk7CisgICAgICAgIHBhaW50U2Nyb2xsYmFyKG1fb3duaW5nTGF5ZXIu dmVydGljYWxTY3JvbGxiYXIoKSwgY29udGV4dCwgZGlydHlSZWN0KTsKICAgICB9IGVsc2UgaWYg KGdyYXBoaWNzTGF5ZXIgPT0gbGF5ZXJGb3JTY3JvbGxDb3JuZXIoKSkgewogICAgICAgICBjb25z dCBMYXlvdXRSZWN0JiBzY3JvbGxDb3JuZXJBbmRSZXNpemVyID0gbV9vd25pbmdMYXllci5zY3Jv bGxDb3JuZXJBbmRSZXNpemVyUmVjdCgpOwogICAgICAgICBjb250ZXh0LnNhdmUoKTsKQEAgLTI1 MzcsOCArMjUzNiw4IEBAIExheW91dFJlY3QgUmVuZGVyTGF5ZXJCYWNraW5nOjpjb21wb3NpdGVk Qm91bmRzSW5jbHVkaW5nTWFyZ2luKCkgY29uc3QKICAgICBMYXlvdXRVbml0IGxlZnRNYXJnaW5X aWR0aCA9IHRpbGVkQmFja2luZy0+bGVmdE1hcmdpbldpZHRoKCk7CiAgICAgTGF5b3V0VW5pdCB0 b3BNYXJnaW5IZWlnaHQgPSB0aWxlZEJhY2tpbmctPnRvcE1hcmdpbkhlaWdodCgpOwogCi0gICAg Ym91bmRzSW5jbHVkaW5nTWFyZ2luLm1vdmVCeShJbnRQb2ludCgtbGVmdE1hcmdpbldpZHRoLCAt dG9wTWFyZ2luSGVpZ2h0KSk7Ci0gICAgYm91bmRzSW5jbHVkaW5nTWFyZ2luLmV4cGFuZChsZWZ0 TWFyZ2luV2lkdGggKyAoTGF5b3V0VW5pdCl0aWxlZEJhY2tpbmctPnJpZ2h0TWFyZ2luV2lkdGgo KSwgdG9wTWFyZ2luSGVpZ2h0ICsgKExheW91dFVuaXQpdGlsZWRCYWNraW5nLT5ib3R0b21NYXJn aW5IZWlnaHQoKSk7CisgICAgYm91bmRzSW5jbHVkaW5nTWFyZ2luLm1vdmVCeShMYXlvdXRQb2lu dCgtbGVmdE1hcmdpbldpZHRoLCAtdG9wTWFyZ2luSGVpZ2h0KSk7CisgICAgYm91bmRzSW5jbHVk aW5nTWFyZ2luLmV4cGFuZChsZWZ0TWFyZ2luV2lkdGggKyB0aWxlZEJhY2tpbmctPnJpZ2h0TWFy Z2luV2lkdGgoKSwgdG9wTWFyZ2luSGVpZ2h0ICsgdGlsZWRCYWNraW5nLT5ib3R0b21NYXJnaW5I ZWlnaHQoKSk7CiAKICAgICByZXR1cm4gYm91bmRzSW5jbHVkaW5nTWFyZ2luOwogfQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5oIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5oCmluZGV4IGFhMDM1ZDdh YTNkNjBhMjFhZTZiNDNhOTcwMmU4MGJkYzg3ODg3YjEuLmNhNjE3NWFhYWIyNGU2YjUyMDg0ZDAw OGEyZjRjMDljODc0NzBhMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllckJhY2tpbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJCYWNraW5nLmgKQEAgLTI4Myw3ICsyODMsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgaGFz VGlsZWRCYWNraW5nRmxhdHRlbmluZ0xheWVyKCkgY29uc3QgeyByZXR1cm4gKG1fY2hpbGRDb250 YWlubWVudExheWVyICYmIG1fdXNpbmdUaWxlZENhY2hlTGF5ZXIpOyB9CiAgICAgR3JhcGhpY3NM YXllciogdGlsZUNhY2hlRmxhdHRlbmluZ0xheWVyKCkgY29uc3QgeyByZXR1cm4gbV91c2luZ1Rp bGVkQ2FjaGVMYXllciA/IG1fY2hpbGRDb250YWlubWVudExheWVyLmdldCgpIDogMDsgfQogCi0g ICAgdm9pZCBwYWludEludG9MYXllcihjb25zdCBHcmFwaGljc0xheWVyKiwgR3JhcGhpY3NDb250 ZXh0KiwgY29uc3QgTGF5b3V0UmVjdCYgcGFpbnREaXJ0eVJlY3QsIFBhaW50QmVoYXZpb3IsIEdy YXBoaWNzTGF5ZXJQYWludGluZ1BoYXNlKTsKKyAgICB2b2lkIHBhaW50SW50b0xheWVyKGNvbnN0 IEdyYXBoaWNzTGF5ZXIqLCBHcmFwaGljc0NvbnRleHQqLCBjb25zdCBJbnRSZWN0JiBwYWludERp cnR5UmVjdCwgUGFpbnRCZWhhdmlvciwgR3JhcGhpY3NMYXllclBhaW50aW5nUGhhc2UpOwogCiAg ICAgLy8gSGVscGVyIGZ1bmN0aW9uIGZvciB1cGRhdGVHcmFwaGljc0xheWVyR2VvbWV0cnkuCiAg ICAgdm9pZCBhZGp1c3RBbmNlc3RvckNvbXBvc2l0aW5nQm91bmRzRm9yRmxvd1RocmVhZChMYXlv dXRSZWN0JiBhbmNlc3RvckNvbXBvc2l0aW5nQm91bmRzLCBjb25zdCBSZW5kZXJMYXllciogY29t cG9zaXRpbmdBbmNlc3RvcikgY29uc3Q7Cg==