129170 2014-02-21 14:23:16 -0800 Add extra space to op_call and related opcodes 2014-02-22 13:26:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver fpizlo oldest_to_newest 983359 0 oliver 2014-02-21 14:23:16 -0800 Add extra space to op_call and related opcodes 983361 1 224908 oliver 2014-02-21 14:25:16 -0800 Created attachment 224908 Patch 983365 2 224908 mark.lam 2014-02-21 14:28:26 -0800 Comment on attachment 224908 Patch r=me 983366 3 224908 dbates 2014-02-21 14:29:31 -0800 Comment on attachment 224908 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224908&action=review > Source/JavaScriptCore/ChangeLog:9 > + slot to the op_call instructions, and refactoring to make simlar Nit: simlar => similar 983367 4 224908 dbates 2014-02-21 14:30:06 -0800 Comment on attachment 224908 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224908&action=review > Source/JavaScriptCore/ChangeLog:10 > + changes easier in future. Nit: "in future" => "in the future" 983368 5 oliver 2014-02-21 14:32:19 -0800 Committed r164503: <http://trac.webkit.org/changeset/164503> 983474 6 fpizlo 2014-02-21 18:12:16 -0800 Why? Did you test performance? Inlining is based on bytecode size, and you just made everything larger. 983494 7 oliver 2014-02-21 20:26:11 -0800 (In reply to comment #6) > Why? > > Did you test performance? Inlining is based on bytecode size, and you just made everything larger. Because call_var_args needs an extra argument, i didn't think about the performance impact because i forgot that inlining was based on # of operands rather than # of opcodes. I'll see if i can fix this, or alternatively just remove the requirement that call_var_args be the same size as all the other calls. 983501 8 fpizlo 2014-02-21 21:12:09 -0800 (In reply to comment #7) > (In reply to comment #6) > > Why? > > > > Did you test performance? Inlining is based on bytecode size, and you just made everything larger. > > Because call_var_args needs an extra argument, i didn't think about the performance impact because i forgot that inlining was based on # of operands rather than # of opcodes. > > I'll see if i can fix this, or alternatively just remove the requirement that call_var_args be the same size as all the other calls. I think it's enough to just measure it and make sure that nothing broke 983507 9 oliver 2014-02-21 21:38:59 -0800 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Why? > > > > > > Did you test performance? Inlining is based on bytecode size, and you just made everything larger. > > > > Because call_var_args needs an extra argument, i didn't think about the performance impact because i forgot that inlining was based on # of operands rather than # of opcodes. > > > > I'll see if i can fix this, or alternatively just remove the requirement that call_var_args be the same size as all the other calls. > > I think it's enough to just measure it and make sure that nothing broke kk 983628 10 oliver 2014-02-22 13:26:39 -0800 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Why? > > > > > > Did you test performance? Inlining is based on bytecode size, and you just made everything larger. > > > > Because call_var_args needs an extra argument, i didn't think about the performance impact because i forgot that inlining was based on # of operands rather than # of opcodes. > > > > I'll see if i can fix this, or alternatively just remove the requirement that call_var_args be the same size as all the other calls. > > I think it's enough to just measure it and make sure that nothing broke I don't see a regression under jsc on my MBP. Just about to run the DRT hosted version. 224908 2014-02-21 14:25:16 -0800 2014-02-21 14:30:06 -0800 Patch bug-129170-20140221142514.patch text/plain 10562 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh YzkyZDk4MTUyMzkxMmQ0OTJiYmE1NmMxYTY2MWQzZThmY2YzMmY5Li42Zjk0YzNmMGRkMjgzNGE0 OWE0NjFkNTYwYmE5MDQ0NTQ1Mjg5ODg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMiBAQAorMjAxNC0wMi0yMSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIEFkZCBleHRyYSBzcGFjZSB0byBvcF9jYWxsIGFuZCByZWxhdGVkIG9wY29kZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTE3MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5n ZSBpbiBiZWhhdmlvdXIsIGp1c3Qgc29tZSByZWZhY3RvcmluZyB0byBhZGQgYW4gZXh0cmEKKyAg ICAgICAgc2xvdCB0byB0aGUgb3BfY2FsbCBpbnN0cnVjdGlvbnMsIGFuZCByZWZhY3RvcmluZyB0 byBtYWtlIHNpbWxhcgorICAgICAgICBjaGFuZ2VzIGVhc2llciBpbiBmdXR1cmUuCisKKyAgICAg ICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OnBy aW50Q2FsbE9wKToKKyAgICAgICAgKiBieXRlY29kZS9PcGNvZGUuaDoKKyAgICAgICAgKEpTQzo6 cGFkT3Bjb2RlTmFtZSk6CisgICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9y LmNwcDoKKyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OmVtaXRDYWxsKToKKyAgICAg ICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OmVtaXRDYWxsVmFyYXJncyk6CisgICAgICAgIChK U0M6OkJ5dGVjb2RlR2VuZXJhdG9yOjplbWl0Q29uc3RydWN0KToKKyAgICAgICAgKiBkZmcvREZH Qnl0ZUNvZGVQYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVDb2RlUGFyc2VyOjpo YW5kbGVJbnRyaW5zaWMpOgorICAgICAgICAqIGppdC9KSVRDYWxsLmNwcDoKKyAgICAgICAgKEpT Qzo6SklUOjpjb21waWxlT3BDYWxsKToKKyAgICAgICAgKiBqaXQvSklUQ2FsbDMyXzY0LmNwcDoK KyAgICAgICAgKEpTQzo6SklUOjpjb21waWxlT3BDYWxsKToKKyAgICAgICAgKiBsbGludC9Mb3dM ZXZlbEludGVycHJldGVyLmFzbToKKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVy MzJfNjQuYXNtOgorICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc206CisK IDIwMTQtMDItMjEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBE Rkcgd3JpdGUgYmFycmllcnMgc2hvdWxkIGRvIG1vcmUgc3BlY3VsYXRpb25zCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCmluZGV4IGNkZDY2OGEyYzkxNWIw MjgyN2QwMzk5M2M5YjEwNWQ1MmVjZTQ4NmYuLmEzOTYzOTYyOGZmZDhiZDNlNTllNGM1MTU0YWRm MzhjYTYyN2Q4OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9D b2RlQmxvY2suY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxv Y2suY3BwCkBAIC00NDIsNiArNDQyLDcgQEAgdm9pZCBDb2RlQmxvY2s6OnByaW50Q2FsbE9wKFBy aW50U3RyZWFtJiBvdXQsIEV4ZWNTdGF0ZSogZXhlYywgaW50IGxvY2F0aW9uLCBjb24KICNlbmRp ZgogICAgIH0KICAgICArK2l0OworICAgICsraXQ7CiAgICAgZHVtcEFycmF5UHJvZmlsaW5nKG91 dCwgaXQsIGhhc1ByaW50ZWRQcm9maWxpbmcpOwogICAgIGR1bXBWYWx1ZVByb2ZpbGluZyhvdXQs IGl0LCBoYXNQcmludGVkUHJvZmlsaW5nKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29k ZS9PcGNvZGUuaAppbmRleCAzNTI2ZDhlZTc5ZTBlOTlhZDZhZGZiZDc0YzA1Y2IwM2E5NDQxMDUz Li5jOTgyYWMwOGEyNzM0NjI4ODE5MWNkNzc1MmVlNDU1NzViMTdiNDljIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5oCkBAIC0xNDQsMTUgKzE0NCwxNSBAQCBuYW1lc3Bh Y2UgSlNDIHsKICAgICBtYWNybyhvcF9uZXdfZnVuYywgNCkgXAogICAgIG1hY3JvKG9wX25ld19j YXB0dXJlZF9mdW5jLCA0KSBcCiAgICAgbWFjcm8ob3BfbmV3X2Z1bmNfZXhwLCAzKSBcCi0gICAg bWFjcm8ob3BfY2FsbCwgOCkgLyogaGFzIHZhbHVlIHByb2ZpbGluZyAqLyBcCi0gICAgbWFjcm8o b3BfY2FsbF9ldmFsLCA4KSAvKiBoYXMgdmFsdWUgcHJvZmlsaW5nICovIFwKLSAgICBtYWNybyhv cF9jYWxsX3ZhcmFyZ3MsIDgpIC8qIGhhcyB2YWx1ZSBwcm9maWxpbmcgKi8gXAorICAgIG1hY3Jv KG9wX2NhbGwsIDkpIC8qIGhhcyB2YWx1ZSBwcm9maWxpbmcgKi8gXAorICAgIG1hY3JvKG9wX2Nh bGxfZXZhbCwgOSkgLyogaGFzIHZhbHVlIHByb2ZpbGluZyAqLyBcCisgICAgbWFjcm8ob3BfY2Fs bF92YXJhcmdzLCA5KSAvKiBoYXMgdmFsdWUgcHJvZmlsaW5nICovIFwKICAgICBtYWNybyhvcF90 ZWFyX29mZl9hY3RpdmF0aW9uLCAyKSBcCiAgICAgbWFjcm8ob3BfdGVhcl9vZmZfYXJndW1lbnRz LCAzKSBcCiAgICAgbWFjcm8ob3BfcmV0LCAyKSBcCiAgICAgbWFjcm8ob3BfcmV0X29iamVjdF9v cl90aGlzLCAzKSBcCiAgICAgXAotICAgIG1hY3JvKG9wX2NvbnN0cnVjdCwgOCkgXAorICAgIG1h Y3JvKG9wX2NvbnN0cnVjdCwgOSkgXAogICAgIG1hY3JvKG9wX3N0cmNhdCwgNCkgXAogICAgIG1h Y3JvKG9wX3RvX3ByaW1pdGl2ZSwgMykgXAogICAgIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAKaW5kZXggYWMy ZmJjYjVkNzY5OWIxNmFmYmY4NjI1NjczOTIyYTZjM2QzYzc2Mi4uZDcwOWNmMTJlYTUzYzgzM2E5 NWNiNTIxNDlhMWY4MjgzYjU3MmZmNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAKQEAgLTE3NjYsNiArMTc2 Niw3IEBAIFJlZ2lzdGVySUQqIEJ5dGVjb2RlR2VuZXJhdG9yOjplbWl0Q2FsbChPcGNvZGVJRCBv cGNvZGVJRCwgUmVnaXN0ZXJJRCogZHN0LCBSZWdpCiAjZWxzZQogICAgIGluc3RydWN0aW9ucygp LmFwcGVuZCgwKTsKICNlbmRpZgorICAgIGluc3RydWN0aW9ucygpLmFwcGVuZCgwKTsKICAgICBp bnN0cnVjdGlvbnMoKS5hcHBlbmQoYXJyYXlQcm9maWxlKTsKICAgICBpbnN0cnVjdGlvbnMoKS5h cHBlbmQocHJvZmlsZSk7CiAgICAgCkBAIC0xNzk5LDYgKzE4MDAsNyBAQCBSZWdpc3RlcklEKiBC eXRlY29kZUdlbmVyYXRvcjo6ZW1pdENhbGxWYXJhcmdzKFJlZ2lzdGVySUQqIGRzdCwgUmVnaXN0 ZXJJRCogZnVuYwogICAgIGluc3RydWN0aW9ucygpLmFwcGVuZCh0aGlzUmVnaXN0ZXItPmluZGV4 KCkpOwogICAgIGluc3RydWN0aW9ucygpLmFwcGVuZChhcmd1bWVudHMtPmluZGV4KCkpOwogICAg IGluc3RydWN0aW9ucygpLmFwcGVuZChmaXJzdEZyZWVSZWdpc3Rlci0+aW5kZXgoKSk7CisgICAg aW5zdHJ1Y3Rpb25zKCkuYXBwZW5kKDApOwogICAgIGluc3RydWN0aW9ucygpLmFwcGVuZChhcnJh eVByb2ZpbGUpOwogICAgIGluc3RydWN0aW9ucygpLmFwcGVuZChwcm9maWxlKTsKICAgICBpZiAo bV9zaG91bGRFbWl0UHJvZmlsZUhvb2tzKSB7CkBAIC0xODgxLDYgKzE4ODMsNyBAQCBSZWdpc3Rl cklEKiBCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdENvbnN0cnVjdChSZWdpc3RlcklEKiBkc3QsIFJl Z2lzdGVySUQqIGZ1bmMsCiAgICAgaW5zdHJ1Y3Rpb25zKCkuYXBwZW5kKDApOwogI2VuZGlmCiAg ICAgaW5zdHJ1Y3Rpb25zKCkuYXBwZW5kKDApOworICAgIGluc3RydWN0aW9ucygpLmFwcGVuZCgw KTsKICAgICBpbnN0cnVjdGlvbnMoKS5hcHBlbmQocHJvZmlsZSk7CiAKICAgICBpZiAoZXhwZWN0 ZWRGdW5jdGlvbiAhPSBOb0V4cGVjdGVkRnVuY3Rpb24pCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCmluZGV4IGU2ODk3NDVjMjIxYmYzMDhkYjQ0 OTRmNmM3YzVlOTFiMGY5MjY1YjUuLjE0YTNhZWIwZWI4OWYzMGM0NWZjODFmZjFhMmFmOTQzOWY2 NWRjMjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQ YXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJz ZXIuY3BwCkBAIC0xNTY3LDcgKzE1NjcsNyBAQCBib29sIEJ5dGVDb2RlUGFyc2VyOjpoYW5kbGVJ bnRyaW5zaWMoaW50IHJlc3VsdE9wZXJhbmQsIEludHJpbnNpYyBpbnRyaW5zaWMsIGludAogICAg ICAgICBpZiAoYXJndW1lbnRDb3VudEluY2x1ZGluZ1RoaXMgIT0gMikKICAgICAgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICAgICAgCi0gICAgICAgIEFycmF5TW9kZSBhcnJheU1vZGUgPSBnZXRB cnJheU1vZGUobV9jdXJyZW50SW5zdHJ1Y3Rpb25bNl0udS5hcnJheVByb2ZpbGUpOworICAgICAg ICBBcnJheU1vZGUgYXJyYXlNb2RlID0gZ2V0QXJyYXlNb2RlKG1fY3VycmVudEluc3RydWN0aW9u W09QQ09ERV9MRU5HVEgob3BfY2FsbCkgLSAyXS51LmFycmF5UHJvZmlsZSk7CiAgICAgICAgIGlm ICghYXJyYXlNb2RlLmlzSlNBcnJheSgpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAg ICAgICBzd2l0Y2ggKGFycmF5TW9kZS50eXBlKCkpIHsKQEAgLTE1OTEsNyArMTU5MSw3IEBAIGJv b2wgQnl0ZUNvZGVQYXJzZXI6OmhhbmRsZUludHJpbnNpYyhpbnQgcmVzdWx0T3BlcmFuZCwgSW50 cmluc2ljIGludHJpbnNpYywgaW50CiAgICAgICAgIGlmIChhcmd1bWVudENvdW50SW5jbHVkaW5n VGhpcyAhPSAxKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAKLSAgICAgICAg QXJyYXlNb2RlIGFycmF5TW9kZSA9IGdldEFycmF5TW9kZShtX2N1cnJlbnRJbnN0cnVjdGlvbls2 XS51LmFycmF5UHJvZmlsZSk7CisgICAgICAgIEFycmF5TW9kZSBhcnJheU1vZGUgPSBnZXRBcnJh eU1vZGUobV9jdXJyZW50SW5zdHJ1Y3Rpb25bT1BDT0RFX0xFTkdUSChvcF9jYWxsKSAtIDJdLnUu YXJyYXlQcm9maWxlKTsKICAgICAgICAgaWYgKCFhcnJheU1vZGUuaXNKU0FycmF5KCkpCiAgICAg ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIHN3aXRjaCAoYXJyYXlNb2RlLnR5cGUoKSkg ewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRDYWxsLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQ2FsbC5jcHAKaW5kZXggMDE5ZjIxYzRlYjdjZDU3 NGUwNWQ4YTJlNTQxZjdkZmRmMzYzOTI5Yi4uMjU5ZDk3YzY3NjBlODlmOTVjZGVjMDg5MWQ5MzIz ZDdjY2ZlZjU1YSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRDYWxs LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVENhbGwuY3BwCkBAIC0xNzQs NyArMTc0LDggQEAgdm9pZCBKSVQ6OmNvbXBpbGVPcENhbGwoT3Bjb2RlSUQgb3Bjb2RlSUQsIElu c3RydWN0aW9uKiBpbnN0cnVjdGlvbiwgdW5zaWduZWQgY2EKICAgICAgICAgLSBDYWxsZXIgaW5p dGlhbGl6ZXMgU2NvcGVDaGFpbjsgUmV0dXJuUEM7IENvZGVCbG9jay4KICAgICAgICAgLSBDYWxs ZXIgcmVzdG9yZXMgY2FsbEZyYW1lUmVnaXN0ZXIgYWZ0ZXIgcmV0dXJuLgogICAgICovCi0KKyAg ICBDT01QSUxFX0FTU0VSVChPUENPREVfTEVOR1RIKG9wX2NhbGwpID09IE9QQ09ERV9MRU5HVEgo b3BfY29uc3RydWN0KSwgY2FsbF9hbmRfY29uc3RydWN0X29wY29kZXNfbXVzdF9iZV9zYW1lX2xl bmd0aCk7CisgICAgQ09NUElMRV9BU1NFUlQoT1BDT0RFX0xFTkdUSChvcF9jYWxsKSA9PSBPUENP REVfTEVOR1RIKG9wX2NhbGxfdmFyYXJncyksIGNhbGxfYW5kX2NhbGxfdmFyYXJnc19vcGNvZGVz X211c3RfYmVfc2FtZV9sZW5ndGgpOwogICAgIGlmIChvcGNvZGVJRCA9PSBvcF9jYWxsX3ZhcmFy Z3MpCiAgICAgICAgIGNvbXBpbGVMb2FkVmFyYXJncyhpbnN0cnVjdGlvbik7CiAgICAgZWxzZSB7 CkBAIC0xODUsNyArMTg2LDcgQEAgdm9pZCBKSVQ6OmNvbXBpbGVPcENhbGwoT3Bjb2RlSUQgb3Bj b2RlSUQsIEluc3RydWN0aW9uKiBpbnN0cnVjdGlvbiwgdW5zaWduZWQgY2EKICAgICAgICAgICAg IGVtaXRHZXRWaXJ0dWFsUmVnaXN0ZXIocmVnaXN0ZXJPZmZzZXQgKyBDYWxsRnJhbWU6OmFyZ3Vt ZW50T2Zmc2V0SW5jbHVkaW5nVGhpcygwKSwgcmVnVDApOwogICAgICAgICAgICAgSnVtcCBkb25l ID0gZW1pdEp1bXBJZk5vdEpTQ2VsbChyZWdUMCk7CiAgICAgICAgICAgICBsb2FkUHRyKEFkZHJl c3MocmVnVDAsIEpTQ2VsbDo6c3RydWN0dXJlT2Zmc2V0KCkpLCByZWdUMCk7Ci0gICAgICAgICAg ICBzdG9yZVB0cihyZWdUMCwgaW5zdHJ1Y3Rpb25bNl0udS5hcnJheVByb2ZpbGUtPmFkZHJlc3NP Zkxhc3RTZWVuU3RydWN0dXJlKCkpOworICAgICAgICAgICAgc3RvcmVQdHIocmVnVDAsIGluc3Ry dWN0aW9uW09QQ09ERV9MRU5HVEgob3BfY2FsbCkgLSAyXS51LmFycmF5UHJvZmlsZS0+YWRkcmVz c09mTGFzdFNlZW5TdHJ1Y3R1cmUoKSk7CiAgICAgICAgICAgICBkb25lLmxpbmsodGhpcyk7CiAg ICAgICAgIH0KICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU Q2FsbDMyXzY0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQ2FsbDMyXzY0LmNw cAppbmRleCA4YTBhYzQ1YmViNWY5MDNmODBkMDQyODRiMmNkNGRhZjNjMTRkOGI1Li43ZDY3ZWYx YzNhYjE2MDM0NTgwNGY0NWFjMWQ4MTg3MjRhNDVlOWMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0pJVENhbGwzMl82NC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRDYWxsMzJfNjQuY3BwCkBAIC0yNjQsNyArMjY0LDcgQEAgdm9pZCBKSVQ6OmNv bXBpbGVPcENhbGwoT3Bjb2RlSUQgb3Bjb2RlSUQsIEluc3RydWN0aW9uKiBpbnN0cnVjdGlvbiwg dW5zaWduZWQgY2EKICAgICAgICAgICAgIGVtaXRMb2FkKHJlZ2lzdGVyT2Zmc2V0ICsgQ2FsbEZy YW1lOjphcmd1bWVudE9mZnNldEluY2x1ZGluZ1RoaXMoMCksIHJlZ1QwLCByZWdUMSk7CiAgICAg ICAgICAgICBKdW1wIGRvbmUgPSBicmFuY2gzMihOb3RFcXVhbCwgcmVnVDAsIFRydXN0ZWRJbW0z MihKU1ZhbHVlOjpDZWxsVGFnKSk7CiAgICAgICAgICAgICBsb2FkUHRyKEFkZHJlc3MocmVnVDEs IEpTQ2VsbDo6c3RydWN0dXJlT2Zmc2V0KCkpLCByZWdUMSk7Ci0gICAgICAgICAgICBzdG9yZVB0 cihyZWdUMSwgaW5zdHJ1Y3Rpb25bNl0udS5hcnJheVByb2ZpbGUtPmFkZHJlc3NPZkxhc3RTZWVu U3RydWN0dXJlKCkpOworICAgICAgICAgICAgc3RvcmVQdHIocmVnVDEsIGluc3RydWN0aW9uW09Q Q09ERV9MRU5HVEgob3BfY2FsbCkgLSAyXS51LmFycmF5UHJvZmlsZS0+YWRkcmVzc09mTGFzdFNl ZW5TdHJ1Y3R1cmUoKSk7CiAgICAgICAgICAgICBkb25lLmxpbmsodGhpcyk7CiAgICAgICAgIH0K ICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbElu dGVycHJldGVyLmFzbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVy cHJldGVyLmFzbQppbmRleCAzMzY4YzBmY2NkMTA3MzhkNWJhZWY2YTk1ZGI2YjdkOWQzYWE1M2Jj Li5mMDk2MjhmMTgzNGU2NDUzOGY3ZDM3ZTU5MjRmZGNlNjczZDBjZjdjIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCkBAIC03 NCw2ICs3NCw4IEBAIGNvbnN0IERlbGV0ZWRWYWx1ZVRhZyA9IC03CiBjb25zdCBMb3dlc3RUYWcg PSBEZWxldGVkVmFsdWVUYWcKIGVuZAogCitjb25zdCBDYWxsT3BDb2RlU2l6ZSA9IDkKKwogaWYg WDg2XzY0IG9yIEFSTTY0IG9yIENfTE9PUAogY29uc3QgbWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0 aENhbGwgPSAwCiBlbHNpZiBBUk0gb3IgQVJNdjdfVFJBRElUSU9OQUwgb3IgQVJNdjcgb3IgU0g0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnBy ZXRlcjMyXzY0LmFzbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVy cHJldGVyMzJfNjQuYXNtCmluZGV4IGJiZWE2YjlkMzIzYTg1NmY0MGUzNTU5MWNhMzA3MmRlMzRl NmU5OTkuLjU0MzllNGU5ZGE4MGMzYjM3MDU4MDY5OWMzNjFiZWYxOWZmYjk3M2IgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQu YXNtCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVy MzJfNjQuYXNtCkBAIC05Miw4ICs5Miw4IEBAIG1hY3JvIGRpc3BhdGNoQWZ0ZXJDYWxsKCkKICAg ICBsb2FkaSA0W1BDXSwgdDIKICAgICBzdG9yZWkgdDEsIFRhZ09mZnNldFtjZnIsIHQyLCA4XQog ICAgIHN0b3JlaSB0MCwgUGF5bG9hZE9mZnNldFtjZnIsIHQyLCA4XQotICAgIHZhbHVlUHJvZmls ZSh0MSwgdDAsIDI4LCB0MykKLSAgICBkaXNwYXRjaCg4KQorICAgIHZhbHVlUHJvZmlsZSh0MSwg dDAsIDQgKiAoQ2FsbE9wQ29kZVNpemUgLSAxKSwgdDMpCisgICAgZGlzcGF0Y2goQ2FsbE9wQ29k ZVNpemUpCiBlbmQKIAogbWFjcm8gY0NhbGwyKGZ1bmN0aW9uLCBhcmcxLCBhcmcyKQpAQCAtMTk2 Miw3ICsxOTYyLDcgQEAgbWFjcm8gYXJyYXlQcm9maWxlRm9yQ2FsbCgpCiAgICAgYmluZXEgVGhp c0FyZ3VtZW50T2Zmc2V0ICsgVGFnT2Zmc2V0W2NmciwgdDMsIDhdLCBDZWxsVGFnLCAuZG9uZQog ICAgIGxvYWRpIFRoaXNBcmd1bWVudE9mZnNldCArIFBheWxvYWRPZmZzZXRbY2ZyLCB0MywgOF0s IHQwCiAgICAgbG9hZHAgSlNDZWxsOjptX3N0cnVjdHVyZVt0MF0sIHQwCi0gICAgbG9hZHAgMjRb UENdLCB0MQorICAgIGxvYWRwRnJvbUluc3RydWN0aW9uKENhbGxPcENvZGVTaXplIC0gMiwgdDEp CiAgICAgc3RvcmVwIHQwLCBBcnJheVByb2ZpbGU6Om1fbGFzdFNlZW5TdHJ1Y3R1cmVbdDFdCiAu ZG9uZToKIGVuZApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXI2NC5hc20gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2 ZWxJbnRlcnByZXRlcjY0LmFzbQppbmRleCA5YjAyNjVkOThlMTM1NDkxM2VjODM2NjFlNDhkNDM1 MGIzYzBlNzY5Li4xZjAyMjVjNzcyYjcyYTczOWNlZDhjMzJmOTU1NTkwOTIxYTk1YWVhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0 LmFzbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRl cjY0LmFzbQpAQCAtNDcsOCArNDcsOCBAQCBtYWNybyBkaXNwYXRjaEFmdGVyQ2FsbCgpCiAgICAg bG9hZHAgQ29kZUJsb2NrOjptX2luc3RydWN0aW9uc1tQQl0sIFBCCiAgICAgbG9hZGlzRnJvbUlu c3RydWN0aW9uKDEsIHQxKQogICAgIHN0b3JlcSB0MCwgW2NmciwgdDEsIDhdCi0gICAgdmFsdWVQ cm9maWxlKHQwLCA3LCB0MikKLSAgICBkaXNwYXRjaCg4KQorICAgIHZhbHVlUHJvZmlsZSh0MCwg KENhbGxPcENvZGVTaXplIC0gMSksIHQyKQorICAgIGRpc3BhdGNoKENhbGxPcENvZGVTaXplKQog ZW5kCiAKIG1hY3JvIGNDYWxsMihmdW5jdGlvbiwgYXJnMSwgYXJnMikKQEAgLTE3NzMsNyArMTc3 Myw3IEBAIG1hY3JvIGFycmF5UHJvZmlsZUZvckNhbGwoKQogICAgIGxvYWRxIFRoaXNBcmd1bWVu dE9mZnNldFtjZnIsIHQzLCA4XSwgdDAKICAgICBidHFueiB0MCwgdGFnTWFzaywgLmRvbmUKICAg ICBsb2FkcCBKU0NlbGw6Om1fc3RydWN0dXJlW3QwXSwgdDAKLSAgICBsb2FkcEZyb21JbnN0cnVj dGlvbig2LCB0MSkKKyAgICBsb2FkcEZyb21JbnN0cnVjdGlvbigoQ2FsbE9wQ29kZVNpemUgLSAy KSwgdDEpCiAgICAgc3RvcmVwIHQwLCBBcnJheVByb2ZpbGU6Om1fbGFzdFNlZW5TdHJ1Y3R1cmVb dDFdCiAuZG9uZToKIGVuZAo=