129159 2014-02-21 11:39:09 -0800 Revive SABI (aka shouldAlwaysBeInlined) 2014-02-21 11:43:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg mmirman msaboff nrotem oliver sam oldest_to_newest 983268 0 fpizlo 2014-02-21 11:39:09 -0800 JSC has some cleverness for rapidly identifying functions that will always be inlined and so do not need to be separately optimized. We broke this when we got rid of the baseline JIT inline caches and replaced them with the DFG ones. 983269 1 224886 fpizlo 2014-02-21 11:40:57 -0800 Created attachment 224886 the patch 983270 2 224886 mhahnenberg 2014-02-21 11:42:04 -0800 Comment on attachment 224886 the patch r=me 983271 3 fpizlo 2014-02-21 11:43:17 -0800 Landed in http://trac.webkit.org/changeset/164490 224886 2014-02-21 11:40:57 -0800 2014-02-21 11:42:04 -0800 the patch blah.patch text/plain 1610 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0NDg5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTAyLTIxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UmV2aXZlIFNBQkkgKGFrYSBzaG91bGRBbHdheXNCZUlubGluZWQpCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjkxNTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoaXMgaXMgYSBzbWFsbCBP Y3RhbmUgc3BlZWQtdXAuCisKKyAgICAgICAgKiBqaXQvUmVwYXRjaC5jcHA6CisgICAgICAgIChK U0M6OmxpbmtGb3IpOiBUaGlzIGNvZGUgd2FzIGFzc3VtaW5nIHRoYXQgaWYgaXQncyBpbnZva2Vk IHRoZW4gdGhlIGNhbGxlciBpcyBhIERGRyBjb2RlIGJsb2NrLiBUaGF0J3Mgd3JvbmcsIHNpbmNl IGl0J3Mgbm93IHVzZWQgYnkgYWxsIG9mIHRoZSBKSVRzLgorCiAyMDE0LTAyLTIxICBKb3NlcGgg UGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog SlNDb250ZXh0IGluc3BlY3Rpb24gc2hvdWxkIHJlcG9ydCBleGNlcHRpb25zIGluIHRoZSBjb25z b2xlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0Y2guY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVwYXRjaC5jcHAJKHJldmlzaW9uIDE2 NDQ2NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVwYXRjaC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTE0MjMsMTEgKzE0MjMsMTIgQEAgdm9pZCBsaW5rRm9yKAogewogICAgIEFTU0VS VCghY2FsbExpbmtJbmZvLnN0dWIpOwogICAgIAorICAgIENvZGVCbG9jayogY2FsbGVyQ29kZUJs b2NrID0gZXhlYy0+Y2FsbGVyRnJhbWUoKS0+Y29kZUJsb2NrKCk7CisKICAgICAvLyBJZiB5b3Un cmUgYmVpbmcgY2FsbC1saW5rZWQgZnJvbSBhIERGRyBjYWxsZXIgdGhlbiB5b3Ugb2J2aW91c2x5 IGRpZG4ndCBnZXQgaW5saW5lZC4KLSAgICBpZiAoY2FsbGVlQ29kZUJsb2NrKQorICAgIGlmIChj YWxsZWVDb2RlQmxvY2sgJiYgSklUQ29kZTo6aXNPcHRpbWl6aW5nSklUKGNhbGxlckNvZGVCbG9j ay0+aml0VHlwZSgpKSkKICAgICAgICAgY2FsbGVlQ29kZUJsb2NrLT5tX3Nob3VsZEFsd2F5c0Jl SW5saW5lZCA9IGZhbHNlOwogICAgIAotICAgIENvZGVCbG9jayogY2FsbGVyQ29kZUJsb2NrID0g ZXhlYy0+Y2FsbGVyRnJhbWUoKS0+Y29kZUJsb2NrKCk7CiAgICAgVk0qIHZtID0gY2FsbGVyQ29k ZUJsb2NrLT52bSgpOwogICAgIAogICAgIFJlcGF0Y2hCdWZmZXIgcmVwYXRjaEJ1ZmZlcihjYWxs ZXJDb2RlQmxvY2spOwo=