129155 2014-02-21 09:43:01 -0800 [Win][LLINT] Many JSC stress test failures. 2014-02-24 14:54:53 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned bfulgham commit-queue mark.lam msaboff ossy oldest_to_newest 983235 0 peavo 2014-02-21 09:43:01 -0800 When running the stress tests on Windows with LLINT enabled, about 25% of the tests fail. 983238 1 224879 peavo 2014-02-21 09:52:34 -0800 Created attachment 224879 Patch 983249 2 224879 msaboff 2014-02-21 10:28:34 -0800 Comment on attachment 224879 Patch r=me 983250 3 peavo 2014-02-21 10:33:23 -0800 (In reply to comment #2) > (From update of attachment 224879 [details]) > r=me Thanks for reviewing :) 983251 4 peavo 2014-02-21 10:35:26 -0800 With this patch, I get the following results from the stress tests: ** The following JSC stress test failures have been introduced: mozilla-tests.yaml/ecma/FunctionObjects/15.3.1.1-3.js.mozilla mozilla-tests.yaml/ecma/FunctionObjects/15.3.1.1-3.js.mozilla-llint mozilla-tests.yaml/ecma/FunctionObjects/15.3.1.1-3.js.mozilla-baseline mozilla-tests.yaml/ecma/FunctionObjects/15.3.1.1-3.js.mozilla-dfg-eager-no-cjit-validate-phases mozilla-tests.yaml/ecma/FunctionObjects/15.3.2.1-3.js.mozilla mozilla-tests.yaml/ecma/FunctionObjects/15.3.2.1-3.js.mozilla-llint mozilla-tests.yaml/ecma/FunctionObjects/15.3.2.1-3.js.mozilla-baseline mozilla-tests.yaml/ecma/FunctionObjects/15.3.2.1-3.js.mozilla-dfg-eager-no-cjit-validate-phases mozilla-tests.yaml/ecma/FunctionObjects/15.3.5-1.js.mozilla mozilla-tests.yaml/ecma/FunctionObjects/15.3.5-1.js.mozilla-llint mozilla-tests.yaml/ecma/FunctionObjects/15.3.5-1.js.mozilla-baseline mozilla-tests.yaml/ecma/FunctionObjects/15.3.5-1.js.mozilla-dfg-eager-no-cjit-validate-phases mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-llint mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-baseline mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-dfg-eager-no-cjit-validate-phases mozilla-tests.yaml/ecma/Array/15.4.5.2-2.js.mozilla mozilla-tests.yaml/ecma/Array/15.4.5.2-2.js.mozilla-llint mozilla-tests.yaml/ecma/Array/15.4.5.2-2.js.mozilla-baseline mozilla-tests.yaml/ecma/Array/15.4.5.2-2.js.mozilla-dfg-eager-no-cjit-validate-phases mozilla-tests.yaml/js1_5/Regress/regress-191633.js.mozilla mozilla-tests.yaml/js1_5/Regress/regress-191633.js.mozilla-llint mozilla-tests.yaml/js1_5/Regress/regress-191633.js.mozilla-baseline mozilla-tests.yaml/js1_5/Regress/regress-191633.js.mozilla-dfg-eager-no-cjit-validate-phases mozilla-tests.yaml/js1_5/Regress/regress-192414.js.mozilla mozilla-tests.yaml/js1_5/Regress/regress-192414.js.mozilla-llint mozilla-tests.yaml/js1_5/Regress/regress-192414.js.mozilla-baseline mozilla-tests.yaml/js1_5/Regress/regress-192414.js.mozilla-dfg-eager-no-cjit-validate-phases mozilla-tests.yaml/js1_5/String/regress-179068.js.mozilla mozilla-tests.yaml/js1_5/String/regress-179068.js.mozilla-llint mozilla-tests.yaml/js1_5/String/regress-179068.js.mozilla-baseline mozilla-tests.yaml/js1_5/String/regress-179068.js.mozilla-dfg-eager-no-cjit-validate-phases stress/ftl-arithcos.js.default stress/ftl-arithcos.js.no-llint stress/ftl-arithcos.js.always-trigger-copy-phase stress/ftl-arithcos.js.no-cjit-validate-phases stress/ftl-arithcos.js.dfg-eager stress/ftl-arithcos.js.dfg-eager-no-cjit-validate jsc-layout-tests.yaml/js/script-tests/basic-map.js.layout jsc-layout-tests.yaml/js/script-tests/basic-map.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/excessive-comma-usage.js.layout jsc-layout-tests.yaml/js/script-tests/excessive-comma-usage.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/excessive-comma-usage.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/function-apply-many-args.js.layout jsc-layout-tests.yaml/js/script-tests/function-apply-many-args.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/function-apply-many-args.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/function-apply-many-args.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/function-apply.js.layout jsc-layout-tests.yaml/js/script-tests/function-apply.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/function-apply.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/function-apply.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/reentrant-caching.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/reentrant-caching.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-dfg-eager-no-cjit Results for JSC stress tests: 57 failures found. 983275 5 peavo 2014-02-21 11:54:24 -0800 When running with the C Loop LLINT, I get these results: ** The following JSC stress test failures have been introduced: mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-llint mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-baseline mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-dfg-eager-no-cjit-validate-phases stress/ftl-arithcos.js.default stress/ftl-arithcos.js.no-llint stress/ftl-arithcos.js.always-trigger-copy-phase stress/ftl-arithcos.js.no-cjit-validate-phases stress/ftl-arithcos.js.dfg-eager stress/ftl-arithcos.js.dfg-eager-no-cjit-validate jsc-layout-tests.yaml/js/script-tests/basic-map.js.layout jsc-layout-tests.yaml/js/script-tests/basic-map.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/basic-map.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/basic-map.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-dfg-eager-no-cjit Results for JSC stress tests: 18 failures found. So there seems to be some regressions when using the x86 backend compared to the C Loop backend, I will look into those next. 983276 6 mark.lam 2014-02-21 11:59:41 -0800 (In reply to comment #5) > Results for JSC stress tests: > 18 failures found. > > So there seems to be some regressions when using the x86 backend compared to the C Loop backend, I will look into those next. Beware of https://bugs.webkit.org/show_bug.cgi?id=129099 which may contribute some failures. Note: some stress tests will turn on the DFG even if you don’t have it on by default. The only way it doesn’t get turned on is if the DFG is not built in. The C loop LLINT build benefits from that. 983277 7 peavo 2014-02-21 12:03:37 -0800 (In reply to comment #6) > (In reply to comment #5) > > Results for JSC stress tests: > > 18 failures found. > > > > So there seems to be some regressions when using the x86 backend compared to the C Loop backend, I will look into those next. > > Beware of https://bugs.webkit.org/show_bug.cgi?id=129099 which may contribute some failures. Note: some stress tests will turn on the DFG even if you don’t have it on by default. The only way it doesn’t get turned on is if the DFG is not built in. The C loop LLINT build benefits from that. Ok, so maybe I should run a test with DFG and LLINT enabled? 983281 8 mark.lam 2014-02-21 12:13:24 -0800 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > Results for JSC stress tests: > > > 18 failures found. > > > > > > So there seems to be some regressions when using the x86 backend compared to the C Loop backend, I will look into those next. > > > > Beware of https://bugs.webkit.org/show_bug.cgi?id=129099 which may contribute some failures. Note: some stress tests will turn on the DFG even if you don’t have it on by default. The only way it doesn’t get turned on is if the DFG is not built in. The C loop LLINT build benefits from that. > > Ok, so maybe I should run a test with DFG and LLINT enabled? Just to clarify: the LLINT is always enabled. It’s either the C loop LLINT or the ASM LLINT. The DFG can be disabled at runtime, but some jsc stress tests will turn it back on because that is the purpose of those tests i.e. to test the DFG. If you run them with the DFG not built in the binary (like the C loop build), then the DFG won’t come into play. To remove the effects of the DFG, don’t build the DFG into the code. 983286 9 peavo 2014-02-21 12:16:38 -0800 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > (In reply to comment #5) > > > > Results for JSC stress tests: > > > > 18 failures found. > > > > > > > > So there seems to be some regressions when using the x86 backend compared to the C Loop backend, I will look into those next. > > > > > > Beware of https://bugs.webkit.org/show_bug.cgi?id=129099 which may contribute some failures. Note: some stress tests will turn on the DFG even if you don’t have it on by default. The only way it doesn’t get turned on is if the DFG is not built in. The C loop LLINT build benefits from that. > > > > Ok, so maybe I should run a test with DFG and LLINT enabled? > > Just to clarify: the LLINT is always enabled. It’s either the C loop LLINT or the ASM LLINT. > > The DFG can be disabled at runtime, but some jsc stress tests will turn it back on because that is the purpose of those tests i.e. to test the DFG. If you run them with the DFG not built in the binary (like the C loop build), then the DFG won’t come into play. > > To remove the effects of the DFG, don’t build the DFG into the code. Ok, I haven't been building with DFG, only LLINT (x86 backend). 983299 10 peavo 2014-02-21 12:45:37 -0800 Not a committer, cq+? :) 983318 11 224879 commit-queue 2014-02-21 13:21:33 -0800 Comment on attachment 224879 Patch Clearing flags on attachment: 224879 Committed r164494: <http://trac.webkit.org/changeset/164494> 983319 12 commit-queue 2014-02-21 13:21:36 -0800 All reviewed patches have been landed. Closing bug. 983915 13 ossy 2014-02-24 08:30:53 -0800 (In reply to comment #11) > (From update of attachment 224879 [details]) > Clearing flags on attachment: 224879 > > Committed r164494: <http://trac.webkit.org/changeset/164494> It broke zillion tests on 32 bit platforms. :-/ Here is the log from the GTK bot: http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/41425 But you can easily reproduce the failures on Mac too. 984027 14 peavo 2014-02-24 13:19:58 -0800 (In reply to comment #13) > (In reply to comment #11) > > (From update of attachment 224879 [details] [details]) > > Clearing flags on attachment: 224879 > > > > Committed r164494: <http://trac.webkit.org/changeset/164494> > > It broke zillion tests on 32 bit platforms. :-/ > > Here is the log from the GTK bot: > http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/41425 > > But you can easily reproduce the failures on Mac too. Sorry for this, I will look into it, and create a new patch soon. 984030 15 mark.lam 2014-02-24 13:21:55 -0800 (In reply to comment #14) > (In reply to comment #13) > > (In reply to comment #11) > > > (From update of attachment 224879 [details] [details] [details]) > > > Clearing flags on attachment: 224879 > > > > > > Committed r164494: <http://trac.webkit.org/changeset/164494> > > > > It broke zillion tests on 32 bit platforms. :-/ > > > > Here is the log from the GTK bot: > > http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/41425 > > > > But you can easily reproduce the failures on Mac too. > > Sorry for this, I will look into it, and create a new patch soon. peavo, if you think it will take longer than 1 hour to find the fix, we should roll out this change first until you can fix it. Please advise. 984041 16 peavo 2014-02-24 13:35:33 -0800 (In reply to comment #15) > (In reply to comment #14) > > (In reply to comment #13) > > > (In reply to comment #11) > > > > (From update of attachment 224879 [details] [details] [details] [details]) > > > > Clearing flags on attachment: 224879 > > > > > > > > Committed r164494: <http://trac.webkit.org/changeset/164494> > > > > > > It broke zillion tests on 32 bit platforms. :-/ > > > > > > Here is the log from the GTK bot: > > > http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/41425 > > > > > > But you can easily reproduce the failures on Mac too. > > > > Sorry for this, I will look into it, and create a new patch soon. > > peavo, if you think it will take longer than 1 hour to find the fix, we should roll out this change first until you can fix it. Please advise. I think I can post a fix within one hour. 984082 17 mark.lam 2014-02-24 14:54:53 -0800 FYI, the fix for the regression was address in https://bugs.webkit.org/show_bug.cgi?id=129272. Fix landed in r164612: <http://trac.webkit.org/changeset/164612> 224879 2014-02-21 09:52:34 -0800 2014-02-21 13:21:33 -0800 Patch bug-129155-20140221185216.patch text/plain 2132 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0NDg1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAyLTIxICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisg ICAgICAgIFtXaW5dW0xMSU5UXSBNYW55IEpTQyBzdHJlc3MgdGVzdCBmYWlsdXJlcy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTE1NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEludGVsIHN5bnRheCBo YXMgcmV2ZXJzZWQgb3BlcmFuZCBvcmRlciBjb21wYXJlZCB0byBBVCZUIHN5bnRheCwgc28gd2Ug bmVlZCB0byBzd2FwIHRoZSBvcGVyYW5kIG9yZGVyLCBpbiB0aGlzIGNhc2Ugb24gZmxvYXRpbmcg cG9pbnQgb3BlcmF0aW9ucy4KKyAgICAgICAgQWxzbyBhdm9pZCB1c2luZyB0aGUgcmV2ZXJzZSBv cGNvZGUgKGUuZy4gZmRpdnIpLCBhcyB0aGlzIHB1dHMgdGhlIHJlc3VsdCBhdCB0aGUgd3Jvbmcg cG9zaXRpb24gaW4gdGhlIGZsb2F0aW5nIHBvaW50IHN0YWNrLgorICAgICAgICBFLmcuICJkaXZk IGZ0MCwgZnQxIiB3b3VsZCB0cmFuc2xhdGUgdG8gZmRpdnIgc3QsIHN0KDEpIChJbnRlbCBzeW50 YXgpIG9uIFdpbmRvd3MsIGJ1dCB0aGlzIHB1dHMgdGhlIHJlc3VsdCBpbiBzdCwgd2hlbiBpdCBz aG91bGQgYmUgaW4gc3QoMSkuCisKKyAgICAgICAgKiBvZmZsaW5lYXNtL3g4Ni5yYjogU3dhcCBv cGVyYW5kIG9yZGVyIG9uIFdpbmRvd3MuCisKIDIwMTQtMDItMjAgIEFuZGVycyBDYXJsc3NvbiAg PGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBNb2Rlcm5pemUgSlNHbG9iYWxMb2NrIGFu ZCBKU0xvY2tIb2xkZXIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3g4 Ni5yYgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94ODYu cmIJKHJldmlzaW9uIDE2NDQ3NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNt L3g4Ni5yYgkod29ya2luZyBjb3B5KQpAQCAtODA2LDEyICs4MDYsMTIgQEAgY2xhc3MgSW5zdHJ1 Y3Rpb24KIAogICAgIGRlZiBoYW5kbGVYODdCaW5PcChvcGNvZGUsIG9wY29kZXJldmVyc2UpCiAg ICAgICAgIGlmIChvcGVyYW5kc1sxXS54ODdEZWZhdWx0U3RhY2tQb3NpdGlvbiA9PSAwKQotICAg ICAgICAgICAgJGFzbS5wdXRzICIje29wY29kZX0gI3tvcGVyYW5kc1swXS54ODdPcGVyYW5kKDAp fSwgI3tyZWdpc3Rlcigic3QiKX0iCisgICAgICAgICAgICAkYXNtLnB1dHMgIiN7b3Bjb2RlfSAj e29yZGVyT3BlcmFuZHMob3BlcmFuZHNbMF0ueDg3T3BlcmFuZCgwKSwgcmVnaXN0ZXIoInN0Iikp fSIKICAgICAgICAgZWxzaWYgKG9wZXJhbmRzWzBdLng4N0RlZmF1bHRTdGFja1Bvc2l0aW9uID09 IDApCi0gICAgICAgICAgICAkYXNtLnB1dHMgIiN7b3Bjb2RlcmV2ZXJzZX0gI3tyZWdpc3Rlcigi c3QiKX0sICN7b3BlcmFuZHNbMV0ueDg3T3BlcmFuZCgwKX0iCisgICAgICAgICAgICAkYXNtLnB1 dHMgIiN7b3Bjb2RlfSAje29yZGVyT3BlcmFuZHMocmVnaXN0ZXIoInN0IiksIG9wZXJhbmRzWzFd Lng4N09wZXJhbmQoMCkpfSIKICAgICAgICAgZWxzZQogICAgICAgICAgICAgJGFzbS5wdXRzICJm bGQgI3tvcGVyYW5kc1swXS54ODdPcGVyYW5kKDApfSIKLSAgICAgICAgICAgICRhc20ucHV0cyAi I3tvcGNvZGVyZXZlcnNlfXAgI3tyZWdpc3Rlcigic3QiKX0sICN7b3BlcmFuZHNbMV0ueDg3T3Bl cmFuZCgxKX0iCisgICAgICAgICAgICAkYXNtLnB1dHMgIiN7b3Bjb2RlcmV2ZXJzZX1wICN7b3Jk ZXJPcGVyYW5kcyhyZWdpc3Rlcigic3QiKSwgb3BlcmFuZHNbMV0ueDg3T3BlcmFuZCgxKSl9Igog ICAgICAgICBlbmQKICAgICBlbmQKIAo=