129152 2014-02-21 08:12:46 -0800 [CMake] Get rid of "FIXME: The Blackberry port ..." from WebCore/CmakeLists.txt 2014-02-24 07:41:54 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mtiborinf webkit-unassigned bunhere commit-queue gyuyoung.kim ossy rakuco sergio oldest_to_newest 983207 0 mtiborinf 2014-02-21 08:12:46 -0800 Get rid of "FIXME: The Blackberry port ..." from WebCore/CmakeLists.txt 983209 1 224867 mtiborinf 2014-02-21 08:19:31 -0800 Created attachment 224867 Patch The explicitly demarcated SVG IDL files (from WebCore_SVG_IDL_FILES) are added to WebCore_IDL_FILES. 983227 2 224867 rakuco 2014-02-21 09:00:26 -0800 Comment on attachment 224867 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224867&action=review > Source/WebCore/CMakeLists.txt:578 > +svg/SVGAElement.idl Nit: wrong indentation? 983548 3 224867 gyuyoung.kim 2014-02-22 02:04:42 -0800 Comment on attachment 224867 Patch Please land after fixing the nit. 983887 4 225062 mtiborinf 2014-02-24 06:57:31 -0800 Created attachment 225062 patch for landing 983907 5 225062 commit-queue 2014-02-24 07:41:51 -0800 Comment on attachment 225062 patch for landing Clearing flags on attachment: 225062 Committed r164586: <http://trac.webkit.org/changeset/164586> 983908 6 commit-queue 2014-02-24 07:41:54 -0800 All reviewed patches have been landed. Closing bug. 224867 2014-02-21 08:19:31 -0800 2014-02-24 06:57:21 -0800 Patch blackberry.patch text/plain 2803 mtiborinf ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNv cmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNWZiM2M2YS4uNjg0NDkyYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKQEAgLTU3NSwzMyArNTc1LDcgQEAgc2V0KFdlYkNvcmVfSURMX0ZJTEVTCiAgICAgc3Rv cmFnZS9TdG9yYWdlLmlkbAogICAgIHN0b3JhZ2UvU3RvcmFnZUV2ZW50LmlkbAogCi0gICAgd29y a2Vycy9BYnN0cmFjdFdvcmtlci5pZGwKLSAgICB3b3JrZXJzL0RlZGljYXRlZFdvcmtlckdsb2Jh bFNjb3BlLmlkbAotICAgIHdvcmtlcnMvU2hhcmVkV29ya2VyLmlkbAotICAgIHdvcmtlcnMvU2hh cmVkV29ya2VyR2xvYmFsU2NvcGUuaWRsCi0gICAgd29ya2Vycy9Xb3JrZXIuaWRsCi0gICAgd29y a2Vycy9Xb3JrZXJHbG9iYWxTY29wZS5pZGwKLSAgICB3b3JrZXJzL1dvcmtlckxvY2F0aW9uLmlk bAotCi0gICAgeG1sL0RPTVBhcnNlci5pZGwKLSAgICB4bWwvWE1MSHR0cFJlcXVlc3QuaWRsCi0g ICAgeG1sL1hNTEh0dHBSZXF1ZXN0RXhjZXB0aW9uLmlkbAotICAgIHhtbC9YTUxIdHRwUmVxdWVz dFByb2dyZXNzRXZlbnQuaWRsCi0gICAgeG1sL1hNTEh0dHBSZXF1ZXN0VXBsb2FkLmlkbAotICAg IHhtbC9YTUxTZXJpYWxpemVyLmlkbAotICAgIHhtbC9YUGF0aEV2YWx1YXRvci5pZGwKLSAgICB4 bWwvWFBhdGhFeGNlcHRpb24uaWRsCi0gICAgeG1sL1hQYXRoRXhwcmVzc2lvbi5pZGwKLSAgICB4 bWwvWFBhdGhOU1Jlc29sdmVyLmlkbAotICAgIHhtbC9YUGF0aFJlc3VsdC5pZGwKLSAgICB4bWwv WFNMVFByb2Nlc3Nvci5pZGwKLSkKLQotIyBGSVhNRTogVGhlIEJsYWNrQmVycnkgcG9ydCBkb2Vz bid0IHN1cHBvcnQgZ2VuZXJhdGluZyBET00gYmluZGluZ3MgZnJvbSB0aGUgU1ZHIElETCBmaWxl cy4KLSMgRm9yIG5vdywgd2UgZXhwbGljaXRseSBkZW1hcmNhdGUgdGhlIFNWRyBJREwgZmlsZXMg c28gdGhhdCB0aGUgQmxhY2tCZXJyeSBwb3J0IGNhbiBza2lwIHRoZW0KLSMgZHVyaW5nIERPTSBi aW5kaW5nIGdlbmVyYXRpb24uIFNlZSA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTcyNzczPi4KLXNldChXZWJDb3JlX1NWR19JRExfRklMRVMKLSAgICBzdmcvU1ZHQUVs ZW1lbnQuaWRsCitzdmcvU1ZHQUVsZW1lbnQuaWRsCiAgICAgc3ZnL1NWR0FsdEdseXBoRGVmRWxl bWVudC5pZGwKICAgICBzdmcvU1ZHQWx0R2x5cGhFbGVtZW50LmlkbAogICAgIHN2Zy9TVkdBbHRH bHlwaEl0ZW1FbGVtZW50LmlkbApAQCAtNzUwLDEwICs3MjQsMjcgQEAgc2V0KFdlYkNvcmVfU1ZH X0lETF9GSUxFUwogICAgIHN2Zy9TVkdWaWV3U3BlYy5pZGwKICAgICBzdmcvU1ZHWm9vbUFuZFBh bi5pZGwKICAgICBzdmcvU1ZHWm9vbUV2ZW50LmlkbAotKQogCi1saXN0KEFQUEVORCBXZWJDb3Jl X0lETF9GSUxFUwotICAgICR7V2ViQ29yZV9TVkdfSURMX0ZJTEVTfQorICAgIHdvcmtlcnMvQWJz dHJhY3RXb3JrZXIuaWRsCisgICAgd29ya2Vycy9EZWRpY2F0ZWRXb3JrZXJHbG9iYWxTY29wZS5p ZGwKKyAgICB3b3JrZXJzL1NoYXJlZFdvcmtlci5pZGwKKyAgICB3b3JrZXJzL1NoYXJlZFdvcmtl ckdsb2JhbFNjb3BlLmlkbAorICAgIHdvcmtlcnMvV29ya2VyLmlkbAorICAgIHdvcmtlcnMvV29y a2VyR2xvYmFsU2NvcGUuaWRsCisgICAgd29ya2Vycy9Xb3JrZXJMb2NhdGlvbi5pZGwKKworICAg IHhtbC9ET01QYXJzZXIuaWRsCisgICAgeG1sL1hNTEh0dHBSZXF1ZXN0LmlkbAorICAgIHhtbC9Y TUxIdHRwUmVxdWVzdEV4Y2VwdGlvbi5pZGwKKyAgICB4bWwvWE1MSHR0cFJlcXVlc3RQcm9ncmVz c0V2ZW50LmlkbAorICAgIHhtbC9YTUxIdHRwUmVxdWVzdFVwbG9hZC5pZGwKKyAgICB4bWwvWE1M U2VyaWFsaXplci5pZGwKKyAgICB4bWwvWFBhdGhFdmFsdWF0b3IuaWRsCisgICAgeG1sL1hQYXRo RXhjZXB0aW9uLmlkbAorICAgIHhtbC9YUGF0aEV4cHJlc3Npb24uaWRsCisgICAgeG1sL1hQYXRo TlNSZXNvbHZlci5pZGwKKyAgICB4bWwvWFBhdGhSZXN1bHQuaWRsCisgICAgeG1sL1hTTFRQcm9j ZXNzb3IuaWRsCiApCiAKIHNldChXZWJDb3JlX0lOU1BFQ1RPUl9TQ1JJUFRTX0RJUiAiJHtKQVZB U0NSSVBUQ09SRV9ESVJ9L2luc3BlY3Rvci9zY3JpcHRzIikKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ODdlMTU3 Li44ZjM3Nzk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDItMTkgIFRpYm9y IE1lc3phcm9zICA8dG1lc3phcm9zLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAg ICAgICAgW0NNYWtlXSBHZXQgcmlkIG9mICJGSVhNRTogVGhlIEJsYWNrYmVycnkgcG9ydCAuLi4i IGZyb20gV2ViQ29yZS9DbWFrZUxpc3RzLnR4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MTUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxNC0wMi0xNyAgTWFu dWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJlZ29AaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ1NTIEdy aWQgTGF5b3V0XSBGaXggbWlzc2luZyBsYXlvdXQgaW4gZmxleGlibGUgYW5kIGNvbnRlbnQgc2l6 ZWQgY29sdW1ucw== 225062 2014-02-24 06:57:31 -0800 2014-02-24 07:41:51 -0800 patch for landing bug-129152-20140224155736.patch text/plain 3144 mtiborinf U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjUyMGE3MWViNDI5YTZj NGFmYWI1NDdhZDlhZDAxZGY2Y2U5NTU1MC4uZjI5MzM2YWUwYjQyMzg3YTNmMDA2OGJlNjQwMjQ3 OWRlMjlkMDNkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAyLTI0ICBUaWJv ciBNZXN6YXJvcyAgPHRtZXN6YXJvcy51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgorCisg ICAgICAgIFtDTWFrZV0gR2V0IHJpZCBvZiAiRklYTUU6IFRoZSBCbGFja2JlcnJ5IHBvcnQgLi4u IiBmcm9tIFdlYkNvcmUvQ21ha2VMaXN0cy50eHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTE1MgorCisgICAgICAgIFJldmlld2VkIGJ5IEd5dXlv dW5nIEtpbS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE0LTAyLTI0ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHJlZHVuZGFu dCBzZXR0aW5nIGluIEZlYXR1cmVEZWZpbmVzLnhjY29uZmlnCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0Cmlu ZGV4IGQwYmUwMDJjYTE1YzY5NDJhOGE1NTMyYzFjNTkyOWY2OTM4OTg2YzUuLmY3YTVhOGU5MmRl OWI1OTA2NDNhODhiZmI3ZWZkMjQ3MjgxODNjNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC01 NzUsMzIgKzU3NSw2IEBAIHNldChXZWJDb3JlX0lETF9GSUxFUwogICAgIHN0b3JhZ2UvU3RvcmFn ZS5pZGwKICAgICBzdG9yYWdlL1N0b3JhZ2VFdmVudC5pZGwKIAotICAgIHdvcmtlcnMvQWJzdHJh Y3RXb3JrZXIuaWRsCi0gICAgd29ya2Vycy9EZWRpY2F0ZWRXb3JrZXJHbG9iYWxTY29wZS5pZGwK LSAgICB3b3JrZXJzL1NoYXJlZFdvcmtlci5pZGwKLSAgICB3b3JrZXJzL1NoYXJlZFdvcmtlckds b2JhbFNjb3BlLmlkbAotICAgIHdvcmtlcnMvV29ya2VyLmlkbAotICAgIHdvcmtlcnMvV29ya2Vy R2xvYmFsU2NvcGUuaWRsCi0gICAgd29ya2Vycy9Xb3JrZXJMb2NhdGlvbi5pZGwKLQotICAgIHht bC9ET01QYXJzZXIuaWRsCi0gICAgeG1sL1hNTEh0dHBSZXF1ZXN0LmlkbAotICAgIHhtbC9YTUxI dHRwUmVxdWVzdEV4Y2VwdGlvbi5pZGwKLSAgICB4bWwvWE1MSHR0cFJlcXVlc3RQcm9ncmVzc0V2 ZW50LmlkbAotICAgIHhtbC9YTUxIdHRwUmVxdWVzdFVwbG9hZC5pZGwKLSAgICB4bWwvWE1MU2Vy aWFsaXplci5pZGwKLSAgICB4bWwvWFBhdGhFdmFsdWF0b3IuaWRsCi0gICAgeG1sL1hQYXRoRXhj ZXB0aW9uLmlkbAotICAgIHhtbC9YUGF0aEV4cHJlc3Npb24uaWRsCi0gICAgeG1sL1hQYXRoTlNS ZXNvbHZlci5pZGwKLSAgICB4bWwvWFBhdGhSZXN1bHQuaWRsCi0gICAgeG1sL1hTTFRQcm9jZXNz b3IuaWRsCi0pCi0KLSMgRklYTUU6IFRoZSBCbGFja0JlcnJ5IHBvcnQgZG9lc24ndCBzdXBwb3J0 IGdlbmVyYXRpbmcgRE9NIGJpbmRpbmdzIGZyb20gdGhlIFNWRyBJREwgZmlsZXMuCi0jIEZvciBu b3csIHdlIGV4cGxpY2l0bHkgZGVtYXJjYXRlIHRoZSBTVkcgSURMIGZpbGVzIHNvIHRoYXQgdGhl IEJsYWNrQmVycnkgcG9ydCBjYW4gc2tpcCB0aGVtCi0jIGR1cmluZyBET00gYmluZGluZyBnZW5l cmF0aW9uLiBTZWUgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Mjc3 Mz4uCi1zZXQoV2ViQ29yZV9TVkdfSURMX0ZJTEVTCiAgICAgc3ZnL1NWR0FFbGVtZW50LmlkbAog ICAgIHN2Zy9TVkdBbHRHbHlwaERlZkVsZW1lbnQuaWRsCiAgICAgc3ZnL1NWR0FsdEdseXBoRWxl bWVudC5pZGwKQEAgLTc1MCwxMCArNzI0LDI3IEBAIHNldChXZWJDb3JlX1NWR19JRExfRklMRVMK ICAgICBzdmcvU1ZHVmlld1NwZWMuaWRsCiAgICAgc3ZnL1NWR1pvb21BbmRQYW4uaWRsCiAgICAg c3ZnL1NWR1pvb21FdmVudC5pZGwKLSkKIAotbGlzdChBUFBFTkQgV2ViQ29yZV9JRExfRklMRVMK LSAgICAke1dlYkNvcmVfU1ZHX0lETF9GSUxFU30KKyAgICB3b3JrZXJzL0Fic3RyYWN0V29ya2Vy LmlkbAorICAgIHdvcmtlcnMvRGVkaWNhdGVkV29ya2VyR2xvYmFsU2NvcGUuaWRsCisgICAgd29y a2Vycy9TaGFyZWRXb3JrZXIuaWRsCisgICAgd29ya2Vycy9TaGFyZWRXb3JrZXJHbG9iYWxTY29w ZS5pZGwKKyAgICB3b3JrZXJzL1dvcmtlci5pZGwKKyAgICB3b3JrZXJzL1dvcmtlckdsb2JhbFNj b3BlLmlkbAorICAgIHdvcmtlcnMvV29ya2VyTG9jYXRpb24uaWRsCisKKyAgICB4bWwvRE9NUGFy c2VyLmlkbAorICAgIHhtbC9YTUxIdHRwUmVxdWVzdC5pZGwKKyAgICB4bWwvWE1MSHR0cFJlcXVl c3RFeGNlcHRpb24uaWRsCisgICAgeG1sL1hNTEh0dHBSZXF1ZXN0UHJvZ3Jlc3NFdmVudC5pZGwK KyAgICB4bWwvWE1MSHR0cFJlcXVlc3RVcGxvYWQuaWRsCisgICAgeG1sL1hNTFNlcmlhbGl6ZXIu aWRsCisgICAgeG1sL1hQYXRoRXZhbHVhdG9yLmlkbAorICAgIHhtbC9YUGF0aEV4Y2VwdGlvbi5p ZGwKKyAgICB4bWwvWFBhdGhFeHByZXNzaW9uLmlkbAorICAgIHhtbC9YUGF0aE5TUmVzb2x2ZXIu aWRsCisgICAgeG1sL1hQYXRoUmVzdWx0LmlkbAorICAgIHhtbC9YU0xUUHJvY2Vzc29yLmlkbAog KQogCiBzZXQoV2ViQ29yZV9JTlNQRUNUT1JfU0NSSVBUU19ESVIgIiR7SkFWQVNDUklQVENPUkVf RElSfS9pbnNwZWN0b3Ivc2NyaXB0cyIpCkBAIC0zMjcwLDQgKzMyNjEsNCBAQCBlbmRpZiAoKQog aWYgKFNIQVJFRF9DT1JFKQogICAgIHNldF90YXJnZXRfcHJvcGVydGllcyhXZWJDb3JlIFBST1BF UlRJRVMgVkVSU0lPTiAke1BST0pFQ1RfVkVSU0lPTn0gU09WRVJTSU9OICR7UFJPSkVDVF9WRVJT SU9OX01BSk9SfSkKICAgICBpbnN0YWxsKFRBUkdFVFMgV2ViQ29yZSBERVNUSU5BVElPTiAiJHtM SUJfSU5TVEFMTF9ESVJ9IikKLWVuZGlmICgpClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQor ZW5kaWYgKCkK