129135 2014-02-20 17:55:35 -0800 ASSERT on touches callbacks after r164409 on iOS 2017-06-22 18:49:48 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=173745 P2 Normal --- 1 enrica enrica andersca ap oldest_to_newest 983056 0 enrica 2014-02-20 17:55:35 -0800 http://trac.webkit.org/changeset/164409 caused a number of ASSERT to fire on iOS. true was used in the call to m_performCallbackWithReturnValue (instead of false) and false in invalidate (instead of true). This change also reintroduced the use of isMainThread on WebKit2 which doesn't work on iOS and should replaced with RunLoop::isMain(). 983058 1 224814 enrica 2014-02-20 17:58:28 -0800 Created attachment 224814 Patch 983063 2 enrica 2014-02-20 18:08:55 -0800 Committed revision 164462. 224814 2014-02-20 17:58:28 -0800 2014-02-20 18:03:57 -0800 Patch fixassert.txt text/plain 2911 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDQ2MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE0LTAyLTIwICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUIG9uIHRvdWNoZXMg Y2FsbGJhY2tzIGFmdGVyIHIxNjQ0MDkgb24gaU9TLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNoYW5nZSB1c2VkIGluY29ycmVjbHkgdHJ1ZSBh bmQgZmFsc2UgaW4gVG91Y2hlc0NhbGxiYWNrcyBhbmQKKyAgICAgICAgSW1hZ2VDYWxsYmFjay4g SXQgYWxzbyByZWludHJvZHVjZWQgaXNNYWluVGhyZWFkKCkgd2hpY2ggZG9lc24ndCB3b3JrCisg ICAgICAgIGZvciBpT1MuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvR2VuZXJpY0NhbGxiYWNrLmg6 CisgICAgICAgIChXZWJLaXQ6OkNhbGxiYWNrQmFzZTo6Z2VuZXJhdGVDYWxsYmFja0lEKToKKyAg ICAgICAgKFdlYktpdDo6SW1hZ2VDYWxsYmFjazo6cGVyZm9ybUNhbGxiYWNrV2l0aFJldHVyblZh bHVlKToKKyAgICAgICAgKFdlYktpdDo6SW1hZ2VDYWxsYmFjazo6aW52YWxpZGF0ZSk6CisgICAg ICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oOgorICAgICAgICAoV2ViS2l0OjpUb3VjaGVz Q2FsbGJhY2s6OnBlcmZvcm1DYWxsYmFja1dpdGhSZXR1cm5WYWx1ZSk6CisgICAgICAgIChXZWJL aXQ6OlRvdWNoZXNDYWxsYmFjazo6aW52YWxpZGF0ZSk6CisKIDIwMTQtMDItMjAgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBXZSBuZWVkIHNvbWV0aGlu ZyBsaWtlIFdLUGFnZVVJQ2xpZW50IGluIHRoZSBPYmotQyBBUEkKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9HZW5lcmljQ2FsbGJhY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvR2VuZXJpY0NhbGxiYWNrLmgJKHJldmlzaW9uIDE2NDQ1NikKKysrIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9HZW5lcmljQ2FsbGJhY2suaAkod29ya2luZyBjb3B5KQpA QCAtMzEsOSArMzEsOSBAQAogI2luY2x1ZGUgIldLQVBJQ2FzdC5oIgogI2luY2x1ZGUgPGZ1bmN0 aW9uYWw+CiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KLSNpbmNsdWRlIDx3dGYvTWFpblRocmVh ZC5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50 ZWQuaD4KKyNpbmNsdWRlIDx3dGYvUnVuTG9vcC5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIApA QCAtNTQsNyArNTQsNyBAQCBwcm90ZWN0ZWQ6CiBwcml2YXRlOgogICAgIHN0YXRpYyB1aW50NjRf dCBnZW5lcmF0ZUNhbGxiYWNrSUQoKQogICAgIHsKLSAgICAgICAgQVNTRVJUKGlzTWFpblRocmVh ZCgpKTsKKyAgICAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKICAgICAgICAgc3RhdGlj IHVpbnQ2NF90IHVuaXF1ZUNhbGxiYWNrSUQgPSAxOwogICAgICAgICByZXR1cm4gdW5pcXVlQ2Fs bGJhY2tJRCsrOwogICAgIH0KQEAgLTIzNSw3ICsyMzUsNyBAQCBwdWJsaWM6CiAgICAgewogICAg ICAgICBBU1NFUlQobV9jYWxsYmFjayk7CiAKLSAgICAgICAgbV9jYWxsYmFjayh0cnVlLCByZXR1 cm5WYWx1ZTEpOworICAgICAgICBtX2NhbGxiYWNrKGZhbHNlLCByZXR1cm5WYWx1ZTEpOwogCiAg ICAgICAgIG1fY2FsbGJhY2sgPSAwOwogICAgIH0KQEAgLTI0Niw3ICsyNDYsNyBAQCBwdWJsaWM6 CiAKICAgICAgICAgUmVmUHRyPEFQSTo6RXJyb3I+IGVycm9yID0gQVBJOjpFcnJvcjo6Y3JlYXRl KCk7CiAgICAgICAgIFNoYXJlYWJsZUJpdG1hcDo6SGFuZGxlIGhhbmRsZTsKLSAgICAgICAgbV9j YWxsYmFjayhmYWxzZSwgaGFuZGxlKTsKKyAgICAgICAgbV9jYWxsYmFjayh0cnVlLCBoYW5kbGUp OwogCiAgICAgICAgIG1fY2FsbGJhY2sgPSAwOwogICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmgJKHJldmlzaW9uIDE2NDQ1NikKKysrIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAtMjg5LDcgKzI4 OSw3IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAgIEFTU0VSVChtX2NhbGxiYWNrKTsKIAotICAg ICAgICBtX2NhbGxiYWNrKHRydWUsIHJldHVyblZhbHVlMSwgcmV0dXJuVmFsdWUyKTsKKyAgICAg ICAgbV9jYWxsYmFjayhmYWxzZSwgcmV0dXJuVmFsdWUxLCByZXR1cm5WYWx1ZTIpOwogCiAgICAg ICAgIG1fY2FsbGJhY2sgPSAwOwogICAgIH0KQEAgLTI5OSw3ICsyOTksNyBAQCBwdWJsaWM6CiAg ICAgICAgIEFTU0VSVChtX2NhbGxiYWNrKTsKIAogICAgICAgICBSZWZQdHI8QVBJOjpFcnJvcj4g ZXJyb3IgPSBBUEk6OkVycm9yOjpjcmVhdGUoKTsKLSAgICAgICAgbV9jYWxsYmFjayhmYWxzZSwg V2ViQ29yZTo6SW50UG9pbnQoKSwgMCk7CisgICAgICAgIG1fY2FsbGJhY2sodHJ1ZSwgV2ViQ29y ZTo6SW50UG9pbnQoKSwgMCk7CiAgICAgICAgIAogICAgICAgICBtX2NhbGxiYWNrID0gMDsKICAg ICB9Cg==