129131 2014-02-20 17:17:22 -0800 DefaultGCActivityCallback::doWork() should reschedule if GC is deferred 2014-02-20 18:48:37 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mhahnenberg mmirman msaboff oliver oldest_to_newest 983047 0 mark.lam 2014-02-20 17:17:22 -0800 Currently, DefaultGCActivityCallback::doWork() does not check if the GC needs to be deferred before commencing. Will fix. ref: <rdar://problem/15447622> 983061 1 224815 mark.lam 2014-02-20 18:02:24 -0800 Created attachment 224815 the patch 983062 2 224815 mhahnenberg 2014-02-20 18:04:43 -0800 Comment on attachment 224815 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=224815&action=review r=me > Source/JavaScriptCore/ChangeLog:12 > + supposed to be deferred and re-schedule if needed. It only commences with reschedules 983066 3 mark.lam 2014-02-20 18:48:37 -0800 Thanks. Landed in r164463: <http://trac.webkit.org/r164463>. 224815 2014-02-20 18:02:24 -0800 2014-02-20 18:04:43 -0800 the patch bug-129131.patch text/plain 1745 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0NDU5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTAyLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBE ZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrOjpkb1dvcmsoKSBzaG91bGQgcmVzY2hlZHVsZSBpZiBH QyBpcyBkZWZlcnJlZC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyOTEzMT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHks IERlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2s6OmRvV29yaygpIGRvZXMgbm90IGNoZWNrIGlmIHRo ZSBHQworICAgICAgICBuZWVkcyB0byBiZSBkZWZlcnJlZCBiZWZvcmUgY29tbWVuY2luZy4gQXMg YSByZXN1bHQsIHRoZSBHQyBtYXkgY3Jhc2gKKyAgICAgICAgYW5kL29yIGNvcnJ1cHQgZGF0YSBi ZWNhdXNlIHRoZSBWTSBpcyBub3QgaW4gdGhlIGNvbnNpc3RlbnQgc3RhdGUgbmVlZGVkCisgICAg ICAgIGZvciB0aGUgR0MgdG8gcnVuLiBXaXRoIHRoaXMgZml4LCBkb1dvcmsoKSBub3cgY2hlY2tz IGlmIHRoZSBHQyBpcworICAgICAgICBzdXBwb3NlZCB0byBiZSBkZWZlcnJlZCBhbmQgcmUtc2No ZWR1bGUgaWYgbmVlZGVkLiBJdCBvbmx5IGNvbW1lbmNlcyB3aXRoCisgICAgICAgIEdDJ2luZyB3 aGVuIGl0J3Mgc2FmZSB0byBkbyBzby4KKworICAgICAgICAqIHJ1bnRpbWUvR0NBY3Rpdml0eUNh bGxiYWNrLmNwcDoKKyAgICAgICAgKEpTQzo6RGVmYXVsdEdDQWN0aXZpdHlDYWxsYmFjazo6ZG9X b3JrKToKKwogMjAxNC0wMi0yMCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAg ICAgICAgIERGRyBzaG91bGQgZG8gaXRzIG93biBzdGF0aWMgZXN0aW1hdGVzIG9mIGV4ZWN1dGlv biBmcmVxdWVuY3kgYmVmb3JlIGl0IHN0YXJ0cyBjcmVhdGluZyBPU1IgZW50cnlwb2ludHMKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0dDQWN0aXZpdHlDYWxsYmFjay5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvR0NBY3Rpdml0eUNh bGxiYWNrLmNwcAkocmV2aXNpb24gMTY0NDU5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvR0NBY3Rpdml0eUNhbGxiYWNrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODcsNiArODcs MTEgQEAgdm9pZCBEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrOjpkb1dvcmsoKQogICAgICAgICBy ZXR1cm47CiAgICAgCiAgICAgQVBJRW50cnlTaGltIHNoaW0obV92bSk7CisgICAgaWYgKGhlYXAt PmlzRGVmZXJyZWQoKSkgeworICAgICAgICBzY2hlZHVsZVRpbWVyKDApOworICAgICAgICByZXR1 cm47CisgICAgfQorCiAjaWYgIVBMQVRGT1JNKElPUykKICAgICBkb3VibGUgc3RhcnRUaW1lID0g V1RGOjptb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKTsKICAgICBpZiAoaGVhcC0+aXNQYWdl ZE91dChzdGFydFRpbWUgKyBwYWdpbmdUaW1lT3V0KSkgewo=