129128 2014-02-20 16:16:55 -0800 WinCairo should use coordinated graphics and tiled backing store 2014-03-03 08:59:30 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 8 RESOLVED INVALID P2 Normal --- 1 alex.christensen webkit-unassigned benjamin bfulgham cmarcelo commit-queue ossy pnormand oldest_to_newest 983029 0 alex.christensen 2014-02-20 16:16:55 -0800 Now that everybody is using accelerated compositing, WinCairo should also be using coordinated graphics and tiled backing store. GStreamer video doesn't show up on the screen without them, and I imagine there are other features that use them, too. On a related note, I got WinCairo compiling and running with FeatureDefines.props. instead of FeatureDefinesCairo.props. The differences between these two files could cause problems, and using the same feature defines would unite the ports more. Do you think this would be worth upstreaming? Specifically ENABLE_3D_RENDERING, ENABLE_CSS_FILTERS, ENABLE_CSS_SHAPE_INSIDE, ENABLE_IFRAME_SEAMLESS, ENABLE_MEDIA_STATISTICS, ENABLE_REQUEST_ANIMATION_FRAME, ENABLE_SUBPIXEL_LAYOUT, ENABLE_TEMPLATE_ELEMENT, and ENABLE_VIEW_MODE_CSS_MEDIA are different. 983082 1 224824 alex.christensen 2014-02-20 20:08:45 -0800 Created attachment 224824 Patch 983146 2 224824 ossy 2014-02-21 01:00:05 -0800 Comment on attachment 224824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224824&action=review > Source/WTF/wtf/Platform.h:864 > +#define WTF_USE_COORDINATED_GRAPHICS 1 But coordinated graphics is WebKit2 only feature, why do you need it for a WebKit1 only port? 983410 3 alex.christensen 2014-02-21 15:47:09 -0800 > But coordinated graphics is WebKit2 only feature, why do you need it for a WebKit1 only port? I don't know, but GStreamer doesn't draw to the screen without it and tiled backing store. Maybe there's an unintentional dependency somewhere, or maybe I should put this in the #if ENABLE(VIDEO) && PLATFORM(WIN_CAIRO) section instead. This hasn't fixed WebGL on WinCairo, but should I need coordinated graphics for WebGL, now that accelerated compositing is mandatory? WebGL on Windows hasn't worked since that big change. 983600 4 pnormand 2014-02-22 09:43:45 -0800 The current GStreamer AC backend doesn't support COORDINATED_GRAPHICS (afaik), and I second Ossy's question. I'm a bit confused here. 986360 5 alex.christensen 2014-03-03 08:59:06 -0800 This was a fluke. Video works fine without this. I'm not sure why it seemed to help. The only reason I can think of was that I was testing at my apartment with a very flaky internet connection. 224824 2014-02-20 20:08:45 -0800 2014-03-03 08:59:30 -0800 Patch bug-129128-20140220210844.patch text/plain 1112 alex.christensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNjQ0NjUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAyLTIwICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVXNlIENvb3JkaW5hdGVkIEdyYXBo aWNzIGFuZCBUaWxlZCBCYWNraW5nIFN0b3JlIG9uIFdpbkNhaXJvLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MTI4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKyAgICAg ICAgQWRkZWQgZGVmaW5pdGlvbnMgdG8gdXNlIENPT1JESU5BVEVEX0dSQVBISUNTIGFuZCBUSUxF RF9CQUNLSU5HX1NUT1JFIGluIFdpbkNhaXJvLgorCiAyMDE0LTAyLTIwICBDc2FiYSBPc3p0cm9n b27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFN0YWNrU3RhdHMgc291cmNl cyB0byBjbWFrZSBhbmQgYXV0b3Rvb2xzIGJ1aWxkIGZpbGVzCkluZGV4OiBTb3VyY2UvV1RGL3d0 Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHJl dmlzaW9uIDE2NDQ1NSkKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29w eSkKQEAgLTg2MSw2ICs4NjEsOCBAQAogCiAjaWYgUExBVEZPUk0oV0lOX0NBSVJPKQogI2RlZmlu ZSBXVEZfVVNFX1RFWFRVUkVfTUFQUEVSIDEKKyNkZWZpbmUgV1RGX1VTRV9DT09SRElOQVRFRF9H UkFQSElDUyAxCisjZGVmaW5lIFdURl9VU0VfVElMRURfQkFDS0lOR19TVE9SRSAxCiAjZW5kaWYK IAogI2lmIFVTRShURVhUVVJFX01BUFBFUikgJiYgVVNFKDNEX0dSQVBISUNTKSAmJiAhZGVmaW5l ZChXVEZfVVNFX1RFWFRVUkVfTUFQUEVSX0dMKQo=