129126 2014-02-20 15:56:08 -0800 Move the image controls setting to Settings.in 2014-02-20 17:09:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson beidson commit-queue thorton oldest_to_newest 983024 0 beidson 2014-02-20 15:56:08 -0800 Move the image controls setting to Settings.in 983025 1 224807 beidson 2014-02-20 15:57:21 -0800 Created attachment 224807 Patch v1 983028 2 224807 thorton 2014-02-20 16:08:33 -0800 Comment on attachment 224807 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=224807&action=review > Source/WebCore/page/Settings.h:-242 > - bool imageControlsEnabled() { return m_imageControlsEnabled; } do you still need the member and its initializer? I don't see them for other Settings.in settings... 983031 3 224808 beidson 2014-02-20 16:32:50 -0800 Created attachment 224808 Patch for landing. 983041 4 224808 commit-queue 2014-02-20 17:09:17 -0800 Comment on attachment 224808 Patch for landing. Clearing flags on attachment: 224808 Committed r164458: <http://trac.webkit.org/changeset/164458> 983042 5 commit-queue 2014-02-20 17:09:19 -0800 All reviewed patches have been landed. Closing bug. 224807 2014-02-20 15:57:21 -0800 2014-02-20 16:32:50 -0800 Patch v1 patch text/plain 2335 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1Yzg2MzNiLi4yNGM5OWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDItMjAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE1vdmUgdGhlIGltYWdlIGNvbnRyb2xzIHNldHRpbmcgdG8gU2V0dGluZ3MuaW4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTEyNgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9TZXR0aW5n cy5jcHA6CisgICAgICAgICogcGFnZS9TZXR0aW5ncy5oOgorICAgICAgICAqIHBhZ2UvU2V0dGlu Z3MuaW46CisKIDIwMTQtMDItMjAgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAg ICAgICAgIEFuIHVucmVzb2x2ZWQgV2ViR0wgQ29udGV4dCBzaG91bGQgb3BlcmF0ZSBub3JtYWxs eSB1bnRpbCB1c2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCmluZGV4IDAyOTgzZDQuLjY2YmRi ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCkBAIC02MzgsMTMgKzYzOCw2IEBAIHZvaWQg U2V0dGluZ3M6OnNldEFnZ3Jlc3NpdmVUaWxlUmV0ZW50aW9uRW5hYmxlZChib29sIGVuYWJsZWQp CiAgICAgbV9hZ2dyZXNzaXZlVGlsZVJldGVudGlvbkVuYWJsZWQgPSBlbmFibGVkOwogfQogCi0j aWYgRU5BQkxFKElNQUdFX0NPTlRST0xTKQotdm9pZCBTZXR0aW5nczo6c2V0SW1hZ2VDb250cm9s c0VuYWJsZWQoYm9vbCBlbmFibGVkKQotewotICAgIG1faW1hZ2VDb250cm9sc0VuYWJsZWQgPSBl bmFibGVkOwotfQotI2VuZGlmCi0KIHZvaWQgU2V0dGluZ3M6OnNldE1vY2tTY3JvbGxiYXJzRW5h YmxlZChib29sIGZsYWcpCiB7CiAgICAgZ01vY2tTY3JvbGxiYXJzRW5hYmxlZCA9IGZsYWc7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmggYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1NldHRpbmdzLmgKaW5kZXggZmM5YWI4My4uYWE5NTMzNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0 dGluZ3MuaApAQCAtMjM3LDExICsyMzcsNiBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRBZ2dyZXNz aXZlVGlsZVJldGVudGlvbkVuYWJsZWQoYm9vbCk7CiAgICAgYm9vbCBhZ2dyZXNzaXZlVGlsZVJl dGVudGlvbkVuYWJsZWQoKSB7IHJldHVybiBtX2FnZ3Jlc3NpdmVUaWxlUmV0ZW50aW9uRW5hYmxl ZDsgfQogCi0jaWYgRU5BQkxFKElNQUdFX0NPTlRST0xTKQotICAgIHZvaWQgc2V0SW1hZ2VDb250 cm9sc0VuYWJsZWQoYm9vbCk7Ci0gICAgYm9vbCBpbWFnZUNvbnRyb2xzRW5hYmxlZCgpIHsgcmV0 dXJuIG1faW1hZ2VDb250cm9sc0VuYWJsZWQ7IH0KLSNlbmRpZgotCiAgICAgc3RhdGljIHZvaWQg c2V0U2hvdWxkUmVzcGVjdFByaW9yaXR5SW5DU1NBdHRyaWJ1dGVTZXR0ZXJzKGJvb2wpOwogICAg IHN0YXRpYyBib29sIHNob3VsZFJlc3BlY3RQcmlvcml0eUluQ1NTQXR0cmlidXRlU2V0dGVycygp OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmluIGIvU291cmNl L1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5pbgppbmRleCBjM2UyZjVkLi5kZDAzYTBiNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5pbgorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1NldHRpbmdzLmluCkBAIC0yMTQsNiArMjE0LDcgQEAgbWVkaWFEYXRhTG9hZHNBdXRv bWF0aWNhbGx5IGluaXRpYWw9ZmFsc2UKIHNob3VsZFRyYW5zZm9ybXNBZmZlY3RPdmVyZmxvdyBp bml0aWFsPXRydWUKIHNob3VsZERpc3BhdGNoSmF2YVNjcmlwdFdpbmRvd09uRXJyb3JFdmVudHMg aW5pdGlhbD1mYWxzZQogYWx3YXlzVXNlQWNjZWxlcmF0ZWRPdmVyZmxvd1Njcm9sbCBpbml0aWFs PWZhbHNlCitpbWFnZUNvbnRyb2xzRW5hYmxlZCBpbml0aWFsPWZhbHNlLCBjb25kaXRpb25hbD1J TUFHRV9DT05UUk9MUwogCiAjIEZJWE1FOiBUaGlzIGlzIHVubmVlZGVkIGFuZCBzaG91bGQgYmUg cmVtb3ZlZC4KIGFsd2F5c1VzZUJhc2VsaW5lT2ZQcmltYXJ5Rm9udCBpbml0aWFsPWZhbHNlCg== 224808 2014-02-20 16:32:50 -0800 2014-02-20 17:09:17 -0800 Patch for landing. patch text/plain 3066 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1Yzg2MzNiLi5hMzNiMmUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMDItMjAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE1vdmUgdGhlIGltYWdlIGNvbnRyb2xzIHNldHRpbmcgdG8gU2V0dGluZ3MuaW4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTEyNgorCisgICAg ICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0b24uCisKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpTZXR0aW5ncyk6CisgICAgICAgICogcGFn ZS9TZXR0aW5ncy5oOgorICAgICAgICAqIHBhZ2UvU2V0dGluZ3MuaW46CisKIDIwMTQtMDItMjAg IERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIEFuIHVucmVzb2x2ZWQg V2ViR0wgQ29udGV4dCBzaG91bGQgb3BlcmF0ZSBub3JtYWxseSB1bnRpbCB1c2VkCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvU2V0dGluZ3MuY3BwCmluZGV4IDAyOTgzZDQuLmFmMjUyNmIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0 dGluZ3MuY3BwCkBAIC0xODYsOSArMTg2LDYgQEAgU2V0dGluZ3M6OlNldHRpbmdzKFBhZ2UqIHBh Z2UpCiAjZW5kaWYKICAgICAsIG1fc2Nyb2xsaW5nUGVyZm9ybWFuY2VMb2dnaW5nRW5hYmxlZChm YWxzZSkKICAgICAsIG1fYWdncmVzc2l2ZVRpbGVSZXRlbnRpb25FbmFibGVkKGZhbHNlKQotI2lm IEVOQUJMRShJTUFHRV9DT05UUk9MUykKLSAgICAsIG1faW1hZ2VDb250cm9sc0VuYWJsZWQoZmFs c2UpCi0jZW5kaWYKICAgICAsIG1fdGltZVdpdGhvdXRNb3VzZU1vdmVtZW50QmVmb3JlSGlkaW5n Q29udHJvbHMoMykKICAgICAsIG1fc2V0SW1hZ2VMb2FkaW5nU2V0dGluZ3NUaW1lcih0aGlzLCAm U2V0dGluZ3M6OmltYWdlTG9hZGluZ1NldHRpbmdzVGltZXJGaXJlZCkKICNpZiBFTkFCTEUoSElE REVOX1BBR0VfRE9NX1RJTUVSX1RIUk9UVExJTkcpCkBAIC02MzgsMTMgKzYzNSw2IEBAIHZvaWQg U2V0dGluZ3M6OnNldEFnZ3Jlc3NpdmVUaWxlUmV0ZW50aW9uRW5hYmxlZChib29sIGVuYWJsZWQp CiAgICAgbV9hZ2dyZXNzaXZlVGlsZVJldGVudGlvbkVuYWJsZWQgPSBlbmFibGVkOwogfQogCi0j aWYgRU5BQkxFKElNQUdFX0NPTlRST0xTKQotdm9pZCBTZXR0aW5nczo6c2V0SW1hZ2VDb250cm9s c0VuYWJsZWQoYm9vbCBlbmFibGVkKQotewotICAgIG1faW1hZ2VDb250cm9sc0VuYWJsZWQgPSBl bmFibGVkOwotfQotI2VuZGlmCi0KIHZvaWQgU2V0dGluZ3M6OnNldE1vY2tTY3JvbGxiYXJzRW5h YmxlZChib29sIGZsYWcpCiB7CiAgICAgZ01vY2tTY3JvbGxiYXJzRW5hYmxlZCA9IGZsYWc7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmggYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1NldHRpbmdzLmgKaW5kZXggZmM5YWI4My4uMTQzZjk5MCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0 dGluZ3MuaApAQCAtMjM3LDExICsyMzcsNiBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRBZ2dyZXNz aXZlVGlsZVJldGVudGlvbkVuYWJsZWQoYm9vbCk7CiAgICAgYm9vbCBhZ2dyZXNzaXZlVGlsZVJl dGVudGlvbkVuYWJsZWQoKSB7IHJldHVybiBtX2FnZ3Jlc3NpdmVUaWxlUmV0ZW50aW9uRW5hYmxl ZDsgfQogCi0jaWYgRU5BQkxFKElNQUdFX0NPTlRST0xTKQotICAgIHZvaWQgc2V0SW1hZ2VDb250 cm9sc0VuYWJsZWQoYm9vbCk7Ci0gICAgYm9vbCBpbWFnZUNvbnRyb2xzRW5hYmxlZCgpIHsgcmV0 dXJuIG1faW1hZ2VDb250cm9sc0VuYWJsZWQ7IH0KLSNlbmRpZgotCiAgICAgc3RhdGljIHZvaWQg c2V0U2hvdWxkUmVzcGVjdFByaW9yaXR5SW5DU1NBdHRyaWJ1dGVTZXR0ZXJzKGJvb2wpOwogICAg IHN0YXRpYyBib29sIHNob3VsZFJlc3BlY3RQcmlvcml0eUluQ1NTQXR0cmlidXRlU2V0dGVycygp OwogCkBAIC0zMjAsOSArMzE1LDYgQEAgcHJpdmF0ZToKICNlbmRpZgogICAgIGJvb2wgbV9zY3Jv bGxpbmdQZXJmb3JtYW5jZUxvZ2dpbmdFbmFibGVkIDogMTsKICAgICBib29sIG1fYWdncmVzc2l2 ZVRpbGVSZXRlbnRpb25FbmFibGVkIDogMTsKLSNpZiBFTkFCTEUoSU1BR0VfQ09OVFJPTFMpCi0g ICAgYm9vbCBtX2ltYWdlQ29udHJvbHNFbmFibGVkIDogMTsKLSNlbmRpZgogCiAgICAgZG91Ymxl IG1fdGltZVdpdGhvdXRNb3VzZU1vdmVtZW50QmVmb3JlSGlkaW5nQ29udHJvbHM7CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaW4gYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL1NldHRpbmdzLmluCmluZGV4IGMzZTJmNWQuLmRkMDNhMGI3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmluCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0 dGluZ3MuaW4KQEAgLTIxNCw2ICsyMTQsNyBAQCBtZWRpYURhdGFMb2Fkc0F1dG9tYXRpY2FsbHkg aW5pdGlhbD1mYWxzZQogc2hvdWxkVHJhbnNmb3Jtc0FmZmVjdE92ZXJmbG93IGluaXRpYWw9dHJ1 ZQogc2hvdWxkRGlzcGF0Y2hKYXZhU2NyaXB0V2luZG93T25FcnJvckV2ZW50cyBpbml0aWFsPWZh bHNlCiBhbHdheXNVc2VBY2NlbGVyYXRlZE92ZXJmbG93U2Nyb2xsIGluaXRpYWw9ZmFsc2UKK2lt YWdlQ29udHJvbHNFbmFibGVkIGluaXRpYWw9ZmFsc2UsIGNvbmRpdGlvbmFsPUlNQUdFX0NPTlRS T0xTCiAKICMgRklYTUU6IFRoaXMgaXMgdW5uZWVkZWQgYW5kIHNob3VsZCBiZSByZW1vdmVkLgog YWx3YXlzVXNlQmFzZWxpbmVPZlByaW1hcnlGb250IGluaXRpYWw9ZmFsc2UK