12912 2007-02-27 11:34:36 -0800 Variable scoping rules incorrectly evaluated 2007-07-11 21:22:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Critical --- 1 waylonis webkit-unassigned ap zwarich oldest_to_newest 21102 0 waylonis 2007-02-27 11:34:36 -0800 On both Safari 10.4.8 and TOT WebKit, the JavaScript code is incorrectly evaluated. 21103 1 13405 waylonis 2007-02-27 11:35:48 -0800 Created attachment 13405 HTML page that illustrates the evaluation failure. 20931 2 ap 2007-02-27 22:26:33 -0800 See also: bug 7751, bug 11399 (duplicates?) 5048 3 zwarich 2007-07-10 17:19:22 -0700 This bug seems to be fixed in TOT, as the test case runs correctly. 5030 4 ddkilzer 2007-07-10 22:27:42 -0700 (In reply to comment #3) > This bug seems to be fixed in TOT, as the test case runs correctly. (In reply to comment #2) > See also: bug 7751, bug 11399 (duplicates?) Attachment 13405 runs correctly with a local debug build of WebKit r24147 with Safari 3.0 (522.12) on Mac OS X 10.4.10 (8R218). However, the tests for Bug 7751 and Bug 11399 are still broken. 5021 5 ap 2007-07-11 05:07:58 -0700 That's interesting! I think we need to research when this was fixed and whether a test case was landed with the fix. 5002 6 zwarich 2007-07-11 13:32:52 -0700 The bug is still in the r21388 nightly, but is fixed by the r21420 nightly. The revision that fixes it is 21409, which only changes one source code file, nodes2string.cpp. The specific change that fixes the bug is the first in the diff <http://trac.webkit.org/projects/webkit/changeset/21409>. Since the patch is so small and specific, I think the regression tests from that revision adequately cover this bug. Bug 7751 is probably not a bug, as I noted there, and bug 11399, according to Geoff Garen's comment, is due to a choice (deliberate or not) regarding the behaviour of inner windows. 4981 7 ap 2007-07-11 21:22:24 -0700 Marking as fixed per the above comment. 13405 2007-02-27 11:35:48 -0800 2007-02-27 11:35:48 -0800 HTML page that illustrates the evaluation failure. ScopeFailure.html text/html 1916 waylonis PGh0bWw+Cjx0aXRsZT5TY29waW5nIFRlc3Q8L3RpdGxlPgo8c2NyaXB0IHR5cGU9InRleHQvamF2 YXNjcmlwdCI+Ci8qIEEgdGVzdCB0byBzaG93IHRoYXQgc2NvcGluZyBydWxlcyBjYW4gYmUgY29u ZnVzZWQgKi8KCmZ1bmN0aW9uIEFwcGVuZFN0cihkaXZOYW1lLCBzdHIpIHsgCiAgdmFyIGRpdiA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKGRpdk5hbWUpOwogIGRpdi5hcHBlbmRDaGlsZChkb2N1 bWVudC5jcmVhdGVUZXh0Tm9kZShzdHIpKTsKICBkaXYuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgiYnIiKSk7Cn0KCmZ1bmN0aW9uIExvZyhzdHIpIHsgQXBwZW5kU3RyKCJMb2ci LCBzdHIpOyB9CmZ1bmN0aW9uIE91dHB1dChzdHIpIHsgQXBwZW5kU3RyKCJPdXRwdXQiLCBzdHIp OyB9CgpmdW5jdGlvbiB0ZXN0MCgpIHsgT3V0cHV0KCJ0ZXN0MCIpOyByZXR1cm4gdHJ1ZTsgfQpm dW5jdGlvbiB0ZXN0MSgpIHsgT3V0cHV0KCJ0ZXN0MSIpOyByZXR1cm4gdHJ1ZTsgfQpmdW5jdGlv biB0ZXN0MigpIHsgT3V0cHV0KCJ0ZXN0MiIpOyByZXR1cm4gdHJ1ZTsgfQpmdW5jdGlvbiB0ZXN0 MygpIHsgT3V0cHV0KCJ0ZXN0MyIpOyByZXR1cm4gdHJ1ZTsgfQpmdW5jdGlvbiB0ZXN0NCgpIHsg T3V0cHV0KCJ0ZXN0NCIpOyByZXR1cm4gdHJ1ZTsgfQpmdW5jdGlvbiB0ZXN0NSgpIHsgT3V0cHV0 KCJ0ZXN0NSIpOyByZXR1cm4gdHJ1ZTsgfQoKdmFyIHJlcGVhdGVyQ291bnQgPSAwOwpmdW5jdGlv biB0ZXN0TG9vcCgpIHsKICBpZiAoKytyZXBlYXRlckNvdW50ID4gMSkgewogICAgTG9nKCIqKiB0 ZXN0TG9vcCBjYWxsZWQgd2hlbiBpdCBzaG91bGRuJ3QgaGF2ZSBiZWVuIGNhbGxlZCAqKiIpOwog ICAgcmV0dXJuIGZhbHNlOwogIH0KICBPdXRwdXQoInRlc3RMb29wIik7CiAgZm9yICh2YXIgaSA9 IDA7IGkgPCAzOyArK2kpIHsKICAgIE91dHB1dCgiXHRMb29wOiAiICsgaSk7CiAgfQoKICByZXR1 cm4gdHJ1ZTsKfQoKZnVuY3Rpb24gcnVuVGVzdHMoKSB7CiAgdmFyIHRlc3RzID0gW3Rlc3QwLCB0 ZXN0MSwgdGVzdDIsIHRlc3QzLCB0ZXN0NCwgdGVzdDUsIHRlc3RMb29wXTsKCiAgZnVuY3Rpb24g cnVuT25lVGVzdCh0ZXN0Qm9keSkgewogICAgdmFyIHN0cmluZ1RvRXZhbCA9ICd7IHZhciBuZXh0 VGVzdCA9ICcgKyB0ZXN0Qm9keSArICc7IG5leHRUZXN0KCk7IH0nOwoJcmV0dXJuIGV2YWwoc3Ry aW5nVG9FdmFsKTsKICB9CgogIGZvciAodmFyIGkgPSAwOyBpIDwgdGVzdHMubGVuZ3RoOyArK2kp IHsKICAgIHZhciB0ZXN0Qm9keSA9IFN0cmluZyh0ZXN0c1tpXSk7CiAgICB2YXIgcmVzdWx0ID0g cnVuT25lVGVzdCh0ZXN0Qm9keSk7CglMb2coIlRlc3RbIiArIGkgKyAiXTogIiArIHJlc3VsdCk7 CiAgfQp9Cgo8L3NjcmlwdD4KPGJvZHk+ClRoaXMgaWxsdXN0cmF0ZXMgdGhhdCB0aGUgc2NvcGlu ZyBydWxlcyBmb3IgZXZhbHVhdGVkIEpTIGNvZGUgY2FuIGJlIGNvbmZ1c2VkLgpPbiBzaGlwcGlu ZyBTYWZhcmkgYW5kIFRPVCBXZWJLaXQsIHlvdSdsbCBzZWUgYSBsaW5lICIqKiB0ZXN0TG9vcCAu Li4iIHdoaWNoCmluZGljYXRlcyB0aGF0IGEgbG9jYWwgdmFyaWFibGUgaW4gdGhlIHRlc3RMb29w IGZ1bmN0aW9uIGhhcyByZXBsYWNlIHRoZSB2YWx1ZQpvZiBhIHZhcmlhYmxlIGluIHRoZSBydW5U ZXN0cygpIGZ1bmN0aW9uLgpUaGlzIGVycm9yIGRvZXMgbm90IG9jY3VyIGluIEZpcmVmb3ggZm9y IE1hYy9MaW51eCBvciBvbiBJRSBmb3IgV2luZG93cy4KPHA+CjxiPk91dHB1dDo8L2I+CjxwcmU+ PGRpdiBpZD0iT3V0cHV0Ij48L2Rpdj48L3ByZT4KPGJyPgo8Yj5Mb2c6PC9iPgo8cHJlPjxkaXYg aWQ9IkxvZyI+PC9kaXY+PC9wcmU+CjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KcnVu VGVzdHMoKTsKPC9zY3JpcHQ+CjwvYm9keT4KPC9odG1sPgo=