129108 2014-02-20 10:07:52 -0800 Dynamically generated JSExport protocols added to a class results in a crash 2014-02-20 11:34:48 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 982867 0 mhahnenberg 2014-02-20 10:07:52 -0800 We're not getting any information from the runtime about the types of the methods on these protocols because they didn't exist at compile time. We should handle this gracefully. 982868 1 mhahnenberg 2014-02-20 10:08:16 -0800 <rdar://problem/15184814> 982871 2 224767 mhahnenberg 2014-02-20 10:10:32 -0800 Created attachment 224767 Patch 982910 3 224767 commit-queue 2014-02-20 11:34:47 -0800 Comment on attachment 224767 Patch Clearing flags on attachment: 224767 Committed r164439: <http://trac.webkit.org/changeset/164439> 982911 4 commit-queue 2014-02-20 11:34:48 -0800 All reviewed patches have been landed. Closing bug. 224767 2014-02-20 10:10:32 -0800 2014-02-20 11:34:47 -0800 Patch bug-129108-20140220101029.patch text/plain 4031 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0NDMzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTAyLTIwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgRHluYW1pY2FsbHkgZ2VuZXJhdGVkIEpTRXhwb3J0IHByb3RvY29scyBhZGRlZCB0 byBhIGNsYXNzIHJlc3VsdHMgaW4gYSBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MTA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2UncmUgbm90IGdldHRpbmcgYW55IGluZm9ybWF0aW9uIGZy b20gdGhlIHJ1bnRpbWUgYWJvdXQgdGhlIHR5cGVzIG9mIHRoZSBtZXRob2RzIG9uIAorICAgICAg ICB0aGVzZSBwcm90b2NvbHMgYmVjYXVzZSB0aGV5IGRpZG4ndCBleGlzdCBhdCBjb21waWxlIHRp bWUuIFdlIHNob3VsZCBoYW5kbGUgdGhpcyBncmFjZWZ1bGx5LgorCisgICAgICAgICogQVBJL09i akNDYWxsYmFja0Z1bmN0aW9uLm1tOgorICAgICAgICAob2JqQ0NhbGxiYWNrRnVuY3Rpb25Gb3JJ bnZvY2F0aW9uKToKKyAgICAgICAgKiBBUEkvdGVzdHMvSlNFeHBvcnRUZXN0cy5tbToKKyAgICAg ICAgKCtbSlNFeHBvcnRUZXN0cyBleHBvcnREeW5hbWljYWxseUdlbmVyYXRlZFByb3RvY29sVGVz dF0pOgorICAgICAgICAocnVuSlNFeHBvcnRUZXN0cyk6CisKIDIwMTQtMDItMjAgIEdhYm9yIFJh cGNzYW55aSAgPHJnYWJvckB3ZWJraXQub3JnPgogCiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6 IGlzVUludDE2KCkgb24gQVJNdjcgYWZ0ZXIgcjExMzI1My4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9BUEkvT2JqQ0NhbGxiYWNrRnVuY3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL0FQSS9PYmpDQ2FsbGJhY2tGdW5jdGlvbi5tbQkocmV2aXNpb24gMTY0 NDMxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9PYmpDQ2FsbGJhY2tGdW5jdGlvbi5t bQkod29ya2luZyBjb3B5KQpAQCAtNjMyLDYgKzYzMiw5IEBAIGlubGluZSBib29sIHNraXBOdW1i ZXIoY29uc3QgY2hhciomIHBvc2kKIAogc3RhdGljIEpTT2JqZWN0UmVmIG9iakNDYWxsYmFja0Z1 bmN0aW9uRm9ySW52b2NhdGlvbihKU0NvbnRleHQgKmNvbnRleHQsIE5TSW52b2NhdGlvbiAqaW52 b2NhdGlvbiwgQ2FsbGJhY2tUeXBlIHR5cGUsIENsYXNzIGluc3RhbmNlQ2xhc3MsIGNvbnN0IGNo YXIqIHNpZ25hdHVyZVdpdGhPYmpjQ2xhc3NlcykKIHsKKyAgICBpZiAoIXNpZ25hdHVyZVdpdGhP YmpjQ2xhc3NlcykKKyAgICAgICAgcmV0dXJuIG5pbDsKKwogICAgIGNvbnN0IGNoYXIqIHBvc2l0 aW9uID0gc2lnbmF0dXJlV2l0aE9iamNDbGFzc2VzOwogCiAgICAgT3duUHRyPENhbGxiYWNrUmVz dWx0PiByZXN1bHQgPSBhZG9wdFB0cihwYXJzZU9iakNUeXBlPFJlc3VsdFR5cGVEZWxlZ2F0ZT4o cG9zaXRpb24pKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvSlNFeHBv cnRUZXN0cy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3Rz L0pTRXhwb3J0VGVzdHMubW0JKHJldmlzaW9uIDE2NDQzMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9BUEkvdGVzdHMvSlNFeHBvcnRUZXN0cy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjUsNiAr MjUsOSBAQAogCiAjaW1wb3J0ICJKU0V4cG9ydFRlc3RzLmgiCiAKKyNpbXBvcnQgPG9iamMvcnVu dGltZS5oPgorI2ltcG9ydCA8b2JqYy9vYmpjLmg+CisKICNpZiBKU0NfT0JKQ19BUElfRU5BQkxF RAogCiBleHRlcm4gIkMiIHZvaWQgY2hlY2tSZXN1bHQoTlNTdHJpbmcgKmRlc2NyaXB0aW9uLCBi b29sIHBhc3NlZCk7CkBAIC0zMiw2ICszNSw3IEBAIGV4dGVybiAiQyIgdm9pZCBjaGVja1Jlc3Vs dChOU1N0cmluZyAqZGUKIEBpbnRlcmZhY2UgSlNFeHBvcnRUZXN0cyA6IE5TT2JqZWN0CiArICh2 b2lkKSBleHBvcnRJbnN0YW5jZU1ldGhvZFdpdGhJZFByb3RvY29sVGVzdDsKICsgKHZvaWQpIGV4 cG9ydEluc3RhbmNlTWV0aG9kV2l0aENsYXNzUHJvdG9jb2xUZXN0OworKyAodm9pZCkgZXhwb3J0 RHluYW1pY2FsbHlHZW5lcmF0ZWRQcm90b2NvbFRlc3Q7CiBAZW5kCiAKIEBwcm90b2NvbCBUcnV0 aFRlbGxlcgpAQCAtMTAwLDYgKzEwNCwyNSBAQCArICh2b2lkKSBleHBvcnRJbnN0YW5jZU1ldGhv ZFdpdGhDbGFzc1ByCiAgICAgW2NvbnRleHQgZXZhbHVhdGVTY3JpcHQ6QCJtYWtlVGVzdE9iamVj dCgpLm1ldGhvZFdpdGhDbGFzc1Byb3RvY29sKG9wYXF1ZU9iamVjdCk7Il07CiAgICAgY2hlY2tS ZXN1bHQoQCJTdWNjZXNzZnVsbHkgZXhwb3J0ZWQgaW5zdGFuY2UgbWV0aG9kIiwgIWNvbnRleHQu ZXhjZXB0aW9uKTsKIH0KKworKyAodm9pZCkgZXhwb3J0RHluYW1pY2FsbHlHZW5lcmF0ZWRQcm90 b2NvbFRlc3QKK3sKKyAgICBKU0NvbnRleHQgKmNvbnRleHQgPSBbW0pTQ29udGV4dCBhbGxvY10g aW5pdF07CisgICAgUHJvdG9jb2wgKmR5blByb3RvY29sID0gb2JqY19hbGxvY2F0ZVByb3RvY29s KCJOU1N0cmluZ0pTRXhwb3J0Iik7CisgICAgUHJvdG9jb2wgKmpzRXhwb3J0UHJvdG9jb2wgPSBA cHJvdG9jb2woSlNFeHBvcnQpOworICAgIHByb3RvY29sX2FkZFByb3RvY29sKGR5blByb3RvY29s LCBqc0V4cG9ydFByb3RvY29sKTsKKyAgICBNZXRob2QgbWV0aG9kID0gY2xhc3NfZ2V0SW5zdGFu Y2VNZXRob2QoW05TU3RyaW5nIGNsYXNzXSwgQHNlbGVjdG9yKGJvb2xWYWx1ZSkpOworICAgIHBy b3RvY29sX2FkZE1ldGhvZERlc2NyaXB0aW9uKGR5blByb3RvY29sLCBAc2VsZWN0b3IoYm9vbFZh bHVlKSwgbWV0aG9kX2dldFR5cGVFbmNvZGluZyhtZXRob2QpLCBZRVMsIFlFUyk7CisgICAgTlNM b2coQCJ0eXBlIGVuY29kaW5nID0gJXMiLCBtZXRob2RfZ2V0VHlwZUVuY29kaW5nKG1ldGhvZCkp OworICAgIHByb3RvY29sX2FkZE1ldGhvZERlc2NyaXB0aW9uKGR5blByb3RvY29sLCBAc2VsZWN0 b3IoYm9vbFZhbHVlKSwgIkJAOiIsIFlFUywgWUVTKTsKKyAgICBvYmpjX3JlZ2lzdGVyUHJvdG9j b2woZHluUHJvdG9jb2wpOworICAgIGNsYXNzX2FkZFByb3RvY29sKFtOU1N0cmluZyBjbGFzc10s IGR5blByb3RvY29sKTsKKyAgICAKKyAgICBjb250ZXh0W0AiTlNTdHJpbmciXSA9IFtOU1N0cmlu ZyBjbGFzc107CisgICAgY29udGV4dFtAIm15U3RyaW5nIl0gPSBAIllFUyI7CisgICAgSlNWYWx1 ZSAqdmFsdWUgPSBbY29udGV4dCBldmFsdWF0ZVNjcmlwdDpAIm15U3RyaW5nLmJvb2xWYWx1ZSgp Il07CisgICAgY2hlY2tSZXN1bHQoQCJEeW5hbWljYWxseSBnZW5lcmF0ZWQgSlNFeHBvcnQtZWQg cHJvdG9jb2xzIGFyZSBpZ25vcmVkIiwgW3ZhbHVlIGlzVW5kZWZpbmVkXSAmJiAhIWNvbnRleHQu ZXhjZXB0aW9uKTsKK30KIEBlbmQKIAogdm9pZCBydW5KU0V4cG9ydFRlc3RzKCkKQEAgLTEwNyw2 ICsxMzAsNyBAQCB2b2lkIHJ1bkpTRXhwb3J0VGVzdHMoKQogICAgIEBhdXRvcmVsZWFzZXBvb2wg ewogICAgICAgICBbSlNFeHBvcnRUZXN0cyBleHBvcnRJbnN0YW5jZU1ldGhvZFdpdGhJZFByb3Rv Y29sVGVzdF07CiAgICAgICAgIFtKU0V4cG9ydFRlc3RzIGV4cG9ydEluc3RhbmNlTWV0aG9kV2l0 aENsYXNzUHJvdG9jb2xUZXN0XTsKKyAgICAgICAgW0pTRXhwb3J0VGVzdHMgZXhwb3J0RHluYW1p Y2FsbHlHZW5lcmF0ZWRQcm90b2NvbFRlc3RdOwogICAgIH0KIH0KIAo=