129093 2014-02-20 02:31:41 -0800 Web Inspector: clicking on a color swatch in the Computed styles tab shouldn't show the color editing popover 2014-02-20 08:38:19 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 982756 0 graouts 2014-02-20 02:31:41 -0800 It makes no sense to change the computed value for a color. 982757 1 webkit-bug-importer 2014-02-20 02:32:01 -0800 <rdar://problem/16119891> 982777 2 224744 graouts 2014-02-20 03:58:54 -0800 Created attachment 224744 Patch 982834 3 224744 commit-queue 2014-02-20 08:38:17 -0800 Comment on attachment 224744 Patch Clearing flags on attachment: 224744 Committed r164429: <http://trac.webkit.org/changeset/164429> 982835 4 commit-queue 2014-02-20 08:38:19 -0800 All reviewed patches have been landed. Closing bug. 224744 2014-02-20 03:58:54 -0800 2014-02-20 08:38:17 -0800 Patch bug-129093-20140220125854.patch text/plain 1711 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 Mzg0YmQ1MzliYzUzMDI0NTQ0NTkzNmMyMDAwNGI2MmQxZDM0NDkyLi43MjQ4MTdlNTY0Mjc5MGQ4 MDI4MmI2MDJjOTM2ZDM4NTBkZmU4YjcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMi0yMCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9y Zz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBjbGlja2luZyBvbiBhIGNvbG9yIHN3YXRjaCBp biB0aGUgQ29tcHV0ZWQgc3R5bGVzIHRhYiBzaG91bGRuJ3Qgc2hvdyB0aGUgY29sb3IgZWRpdGlu ZyBwb3BvdmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjkwOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJZiB0aGUgY3VycmVudCBlZGl0b3IgaXMgcmVhZC1vbmx5LCBvbmx5IGFsbG93IGN5Y2xpbmcg YmV0d2VlbiBjb2xvciB0eXBlcyBzaW5jZSBpdCB3b3VsZG4ndCBtYWtlIHNlbnNlIHRvIGVkaXQK KyAgICAgICAgc3VjaCBjb2xvcnMuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NTU1N0eWxl RGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzOgorCiAyMDE0LTAyLTE4ICBKYW1lcyBDcmFpZyAgPGpj cmFpZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQVg6IG1vcmUgcHJvcGVy dGllczogZXhpc3RzLCByZXF1aXJlZCwgYW5kIGludmFsaWQgKGV4aXN0cyB3YXMgcHJldmlvdXNs eSBjb21iaW5lZCB3aXRoIGlnbm9yZWQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRp dG9yLmpzCmluZGV4IDU5MTJjMzZhZDE5NDY2MTBmYmFlNzRjNTQwNDM0Njk1NzMzNjkxOTYuLjE5 NGI4NDYyYWIzNzRmNzAzOWU3MjZmYWI2M2EwYTliZGMyOTVjM2YgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRp dG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NTU1N0eWxl RGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzCkBAIC02NzksNyArNjc5LDcgQEAgV2ViSW5zcGVjdG9y LkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAg IHRoaXMuX2NvZGVNaXJyb3Iub3BlcmF0aW9uKHVwZGF0ZS5iaW5kKHRoaXMpKTsKICAgICAgICAg fQogCi0gICAgICAgIGlmIChldmVudC5zaGlmdEtleSkgeworICAgICAgICBpZiAoZXZlbnQuc2hp ZnRLZXkgfHwgdGhpcy5fY29kZU1pcnJvci5nZXRPcHRpb24oInJlYWRPbmx5IikpIHsKICAgICAg ICAgICAgIHZhciBuZXh0Rm9ybWF0ID0gY29sb3IubmV4dEZvcm1hdCgpOwogICAgICAgICAgICAg Y29uc29sZS5hc3NlcnQobmV4dEZvcm1hdCk7CiAgICAgICAgICAgICBpZiAoIW5leHRGb3JtYXQp Cg==