129081 2014-02-19 21:36:58 -0800 ASSERT in FrameLoader::shouldInterruptLoadForXFrameOptions 2014-02-20 10:18:38 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psolanki psolanki ap beidson commit-queue eric.carlson japhet psolanki oldest_to_newest 982662 0 psolanki 2014-02-19 21:36:58 -0800 Malformed servers that don't pass a value in X-Frame-Options can trigger this assert. e.g. on <http://mweb.cbssports.com/ncaab/eye-on-college-basketball/24436548/night-court-marcus-foster-stars-xavier-and-iowa-get-key-wins> there's a load of <https://vine.co/v/MWmZ7L31emm/card> in an iframe. The headers for that URL are $ curl -I https://vine.co/v/MWmZ7L31emm/card HTTP/1.1 200 OK Cache-Control: max-age=1800 Content-Type: text/html; charset=utf-8 Date: Thu, 20 Feb 2014 05:36:30 GMT Strict-Transport-Security: max-age=631138519 X-Content-Type-Options: nosniff X-Frame-Options: X-XSS-Protection: 1; mode=block Connection: keep-alive The empty X-Frame-Options triggers the assert. 982665 1 psolanki 2014-02-19 21:37:15 -0800 <rdar://problem/16026440> 982668 2 224705 psolanki 2014-02-19 21:41:13 -0800 Created attachment 224705 Patch 982696 3 224705 ap 2014-02-19 23:03:57 -0800 Comment on attachment 224705 Patch This breaks gcc build. I think that we need an ASSERT_NOT_REACHED() and return at the end. /mnt/eflews/webkit/WebKit/Source/WebCore/loader/FrameLoader.cpp: In member function 'bool WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions(const WTF::String&, const WebCore::URL&, long unsigned int)': /mnt/eflews/webkit/WebKit/Source/WebCore/loader/FrameLoader.cpp:3074:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors 982872 4 psolanki 2014-02-20 10:16:47 -0800 (In reply to comment #3) > (From update of attachment 224705 [details]) > This breaks gcc build. I think that we need an ASSERT_NOT_REACHED() and return at the end. Ok. Will add that and land the patch. Thanks for the review. 982874 5 psolanki 2014-02-20 10:18:38 -0800 Committed r164435: <http://trac.webkit.org/changeset/164435> 224705 2014-02-19 21:41:13 -0800 2014-02-19 23:03:57 -0800 Patch bug-129081-20140219214112.patch text/plain 1644 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGRjYWQ4MTA1ZDk0ZjMy MmIzZGJlOTlhYjg0YWVkOTMyZjA0Zjc1NS4uMjQyZWRmYjE3NDIzMGI4MGExMDI1ODVkYzY2MWNk MzJmZWIyYjhiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAyLTE5ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBBU1NFUlQgaW4gRnJh bWVMb2FkZXI6OnNob3VsZEludGVycnVwdExvYWRGb3JYRnJhbWVPcHRpb25zCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjkwODEKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzE2MDI2NDQwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERvIG5vdCBhc3NlcnQgaWYgdGhlIHNlcnZlciBzZW5kcyB1cyBhIG1h bGZvcm1lZCBYLUZyYW1lLU9wdGlvbnMgaGVhZGVyLgorCisgICAgICAgICogbG9hZGVyL0ZyYW1l TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpzaG91bGRJbnRlcnJ1 cHRMb2FkRm9yWEZyYW1lT3B0aW9ucyk6CisKIDIwMTQtMDItMTggIERhbiBCZXJuc3RlaW4gIDxt aXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBQTEFURk9STShNQUMpIGlzIHRydWUgd2hlbiBidWls ZGluZyBmb3IgaU9TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2Fk ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCA4MTgz MGYwODQ5Yzc5YzYzNzkyYzlmYWJhMDY3OTEwNGRiZjFiMTZhLi43OGYwMzQ2ZGEzNmZhMzg2ZmQ5 YTkyODA2Zjg3NzM5YjhlMTdmNTZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv RnJhbWVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5j cHAKQEAgLTMwNjgsOCArMzA2OCw3IEBAIGJvb2wgRnJhbWVMb2FkZXI6OnNob3VsZEludGVycnVw dExvYWRGb3JYRnJhbWVPcHRpb25zKGNvbnN0IFN0cmluZyYgY29udGVudCwgY29uCiAgICAgY2Fz ZSBYRnJhbWVPcHRpb25zSW52YWxpZDoKICAgICAgICAgbV9mcmFtZS5kb2N1bWVudCgpLT5hZGRD b25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNlOjpKUywgTWVzc2FnZUxldmVsOjpFcnJvciwgIklu dmFsaWQgJ1gtRnJhbWUtT3B0aW9ucycgaGVhZGVyIGVuY291bnRlcmVkIHdoZW4gbG9hZGluZyAn IiArIHVybC5zdHJpbmdDZW50ZXJFbGxpcHNpemVkVG9MZW5ndGgoKSArICInOiAnIiArIGNvbnRl bnQgKyAiJyBpcyBub3QgYSByZWNvZ25pemVkIGRpcmVjdGl2ZS4gVGhlIGhlYWRlciB3aWxsIGJl IGlnbm9yZWQuIiwgcmVxdWVzdElkZW50aWZpZXIpOwogICAgICAgICByZXR1cm4gZmFsc2U7Ci0g ICAgZGVmYXVsdDoKLSAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgY2FzZSBYRnJh bWVPcHRpb25zTm9uZToKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIH0K