12908 2007-02-27 05:33:25 -0800 crash in http/tests/incremental/frame-focus-before-load.html 2007-02-27 06:23:10 -0800 1 1 1 Unclassified WebKit WebKit Misc. 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED Regression P1 Major --- 1 darin darin oldest_to_newest 21165 0 darin 2007-02-27 05:33:25 -0800 http://trac.webkit.org/projects/webkit/changeset/19879 caused a crash in this test. I have a patch. 21167 1 13394 darin 2007-02-27 05:35:44 -0800 Created attachment 13394 add the missing null checks 21154 2 13394 mitz 2007-02-27 05:43:45 -0800 Comment on attachment 13394 add the missing null checks Okay, but according to the style guidelines you need to use braces for the outer ifs. r=me 21158 3 darin 2007-02-27 06:23:10 -0800 Committed revision 19884. 13394 2007-02-27 05:35:44 -0800 2007-02-27 05:43:45 -0800 add the missing null checks EventHandlerNullCheckPatch.txt text/plain 1496 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxOTg4MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDctMDItMjcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTA4CisgICAgICAgICAg Y3Jhc2ggaW4gaHR0cC90ZXN0cy9pbmNyZW1lbnRhbC9mcmFtZS1mb2N1cy1iZWZvcmUtbG9hZC5o dG1sCisKKyAgICAgICAgKiBwYWdlL21hYy9FdmVudEhhbmRsZXJNYWMubW06IChXZWJDb3JlOjpF dmVudEhhbmRsZXI6OmZvY3VzRG9jdW1lbnRWaWV3KToKKyAgICAgICAgQWRkIG51bGwgY2hlY2tz LgorCiAyMDA3LTAyLTI3ICBSb2IgQnVpcyAgPGJ1aXNAa2RlLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBNYWNpZWouCkluZGV4OiBXZWJDb3JlL3BhZ2UvbWFjL0V2ZW50SGFuZGxlck1hYy5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvbWFjL0V2ZW50SGFuZGxlck1hYy5tbQkocmV2 aXNpb24gMTk4ODApCisrKyBXZWJDb3JlL3BhZ2UvbWFjL0V2ZW50SGFuZGxlck1hYy5tbQkod29y a2luZyBjb3B5KQpAQCAtMTUxLDkgKzE1MSwxMCBAQCBib29sIEV2ZW50SGFuZGxlcjo6a2V5RXZl bnQoTlNFdmVudCAqZXZlCiB2b2lkIEV2ZW50SGFuZGxlcjo6Zm9jdXNEb2N1bWVudFZpZXcoKQog ewogICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKLSAgICBOU1ZpZXcgKnZpZXcgPSBt X2ZyYW1lLT52aWV3KCktPmdldERvY3VtZW50VmlldygpOwotICAgIGlmIChbbV9mcmFtZS0+YnJp ZGdlKCkgZmlyc3RSZXNwb25kZXJdICE9IHZpZXcpCi0gICAgICAgIFttX2ZyYW1lLT5icmlkZ2Uo KSBtYWtlRmlyc3RSZXNwb25kZXI6dmlld107CisgICAgaWYgKEZyYW1lVmlldyogZnJhbWVWaWV3 ID0gbV9mcmFtZS0+dmlldygpKQorICAgICAgICBpZiAoTlNWaWV3ICpkb2N1bWVudFZpZXcgPSBm cmFtZVZpZXctPmdldERvY3VtZW50VmlldygpKQorICAgICAgICAgICAgaWYgKFttX2ZyYW1lLT5i cmlkZ2UoKSBmaXJzdFJlc3BvbmRlcl0gIT0gZG9jdW1lbnRWaWV3KQorICAgICAgICAgICAgICAg IFttX2ZyYW1lLT5icmlkZ2UoKSBtYWtlRmlyc3RSZXNwb25kZXI6ZG9jdW1lbnRWaWV3XTsKICAg ICBFTkRfQkxPQ0tfT0JKQ19FWENFUFRJT05TOwogICAgIGlmIChQYWdlKiBwYWdlID0gbV9mcmFt ZS0+cGFnZSgpKQogICAgICAgICBwYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+c2V0Rm9jdXNlZEZy YW1lKG1fZnJhbWUpOwo=