129068 2014-02-19 15:31:05 -0800 fieldset:disabled > legend:first-child legend input should not be disabled 2014-02-19 17:02:06 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 129035 1 rniwa rniwa ap benjamin darin kling sam oldest_to_newest 982582 0 rniwa 2014-02-19 15:31:05 -0800 Input elements inside the first legend element of a disabled fieldset should not be disabled even if it's inside another legend element as long as the input element itself is not disabled. 982591 1 224688 rniwa 2014-02-19 15:46:07 -0800 Created attachment 224688 Fixes the bug 982595 2 224688 kling 2014-02-19 16:07:19 -0800 Comment on attachment 224688 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=224688&action=review r=me > Source/WebCore/ChangeLog:9 > + An input element inside a disabled fieldset element is ordinarily disabled unless it's inside > + a legend element that is the first of its kind to appear in the fieldset's child node list. It would be interesting to note what other engines do in this scenario. > Source/WebCore/ChangeLog:11 > + Prior to this pach, an input element inside such a legend element was erroneously disabled if patch > Source/WebCore/html/HTMLFormControlElement.cpp:104 > + Element* previousAncestor = 0; nullptr > Source/WebCore/html/HTMLFormControlElement.cpp:106 > if (ancestor->hasTagName(fieldsetTag)) { isHTMLFieldSetElement(ancestor) > Source/WebCore/html/HTMLFormControlElement.cpp:107 > + HTMLFieldSetElement* fieldSetAncestor = toHTMLFieldSetElement(ancestor); I would make this a reference. > Source/WebCore/html/HTMLFormControlElement.cpp:108 > + bool isInFirstLegend = previousAncestor && previousAncestor->hasTagName(legendTag) && previousAncestor == fieldSetAncestor->legend(); isHTMLLegendElement(previousAncestor) 982616 3 rniwa 2014-02-19 17:02:06 -0800 Committed r164403: <http://trac.webkit.org/changeset/164403> 224688 2014-02-19 15:46:07 -0800 2014-02-19 16:07:19 -0800 Fixes the bug bug-129068-20140219154632.patch text/plain 6873 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDM5NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTAyLTE5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGZpZWxkc2V0OmRpc2FibGVkID4g bGVnZW5kOmZpcnN0LWNoaWxkIGxlZ2VuZCBpbnB1dCBzaG91bGQgbm90IGJlIGRpc2FibGVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjkwNjgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbiBpbnB1dCBl bGVtZW50IGluc2lkZSBhIGRpc2FibGVkIGZpZWxkc2V0IGVsZW1lbnQgaXMgb3JkaW5hcmlseSBk aXNhYmxlZCB1bmxlc3MgaXQncyBpbnNpZGUKKyAgICAgICAgYSBsZWdlbmQgZWxlbWVudCB0aGF0 IGlzIHRoZSBmaXJzdCBvZiBpdHMga2luZCB0byBhcHBlYXIgaW4gdGhlIGZpZWxkc2V0J3MgY2hp bGQgbm9kZSBsaXN0LgorCisgICAgICAgIFByaW9yIHRvIHRoaXMgcGFjaCwgYW4gaW5wdXQgZWxl bWVudCBpbnNpZGUgc3VjaCBhIGxlZ2VuZCBlbGVtZW50IHdhcyBlcnJvbmVvdXNseSBkaXNhYmxl ZCBpZgorICAgICAgICBpdCBoYXBwZW5lZCB0byBiZSBpbnNpZGUgYW5vdGhlciBsZWdlbmQgKGUu Zy4gPGZpZWxkc2V0IGRpc2FibGVkPjxsZWdlbmQ+PGxlZ2VuZD48aW5wdXQ+KS4KKworICAgICAg ICBGaXhlZCB0aGUgYnVnIGJ5IGNvcnJlY3RpbmcgdGhlIGFsZ29yaXRobSBpbiB1cGRhdGVBbmNl c3RvckRpc2FibGVkU3RhdGUuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9maWVsZHNldC9m aWVsZHNldC1kaXNhYmxlZC0yLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1Db250cm9s RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50Ojp1 cGRhdGVBbmNlc3RvckRpc2FibGVkU3RhdGUpOgorCiAyMDE0LTAyLTE5ICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIFdURl9NQUtFX0ZBU1RfQUxM T0NBVEVEIHRvIG1vcmUgY2xhc3NlcwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9y bUNvbnRyb2xFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwCShyZXZpc2lvbiAxNjQzODgpCisrKyBTb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x MDEsMTcgKzEwMSwxNyBAQCBib29sIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmZvcm1Ob1ZhbGlk CiAKIHZvaWQgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6dXBkYXRlQW5jZXN0b3JEaXNhYmxlZFN0 YXRlKCkgY29uc3QKIHsKLSAgICBIVE1MRmllbGRTZXRFbGVtZW50KiBmaWVsZFNldEFuY2VzdG9y ID0gMDsKLSAgICBDb250YWluZXJOb2RlKiBsZWdlbmRBbmNlc3RvciA9IDA7Ci0gICAgZm9yIChD b250YWluZXJOb2RlKiBhbmNlc3RvciA9IHBhcmVudE5vZGUoKTsgYW5jZXN0b3I7IGFuY2VzdG9y ID0gYW5jZXN0b3ItPnBhcmVudE5vZGUoKSkgewotICAgICAgICBpZiAoIWxlZ2VuZEFuY2VzdG9y ICYmIGFuY2VzdG9yLT5oYXNUYWdOYW1lKGxlZ2VuZFRhZykpCi0gICAgICAgICAgICBsZWdlbmRB bmNlc3RvciA9IGFuY2VzdG9yOworICAgIEVsZW1lbnQqIHByZXZpb3VzQW5jZXN0b3IgPSAwOwor ICAgIGZvciAoRWxlbWVudCogYW5jZXN0b3IgPSBwYXJlbnRFbGVtZW50KCk7IGFuY2VzdG9yOyBh bmNlc3RvciA9IGFuY2VzdG9yLT5wYXJlbnRFbGVtZW50KCkpIHsKICAgICAgICAgaWYgKGFuY2Vz dG9yLT5oYXNUYWdOYW1lKGZpZWxkc2V0VGFnKSkgewotICAgICAgICAgICAgZmllbGRTZXRBbmNl c3RvciA9IHRvSFRNTEZpZWxkU2V0RWxlbWVudChhbmNlc3Rvcik7Ci0gICAgICAgICAgICBicmVh azsKKyAgICAgICAgICAgIEhUTUxGaWVsZFNldEVsZW1lbnQqIGZpZWxkU2V0QW5jZXN0b3IgPSB0 b0hUTUxGaWVsZFNldEVsZW1lbnQoYW5jZXN0b3IpOworICAgICAgICAgICAgYm9vbCBpc0luRmly c3RMZWdlbmQgPSBwcmV2aW91c0FuY2VzdG9yICYmIHByZXZpb3VzQW5jZXN0b3ItPmhhc1RhZ05h bWUobGVnZW5kVGFnKSAmJiBwcmV2aW91c0FuY2VzdG9yID09IGZpZWxkU2V0QW5jZXN0b3ItPmxl Z2VuZCgpOworICAgICAgICAgICAgbV9hbmNlc3RvckRpc2FibGVkU3RhdGUgPSAhZmllbGRTZXRB bmNlc3Rvci0+aXNEaXNhYmxlZEZvcm1Db250cm9sKCkgfHwgaXNJbkZpcnN0TGVnZW5kID8gQW5j ZXN0b3JEaXNhYmxlZFN0YXRlRW5hYmxlZCA6IEFuY2VzdG9yRGlzYWJsZWRTdGF0ZURpc2FibGVk OworICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CisgICAgICAgIHByZXZpb3VzQW5jZXN0 b3IgPSBhbmNlc3RvcjsKICAgICB9Ci0gICAgbV9hbmNlc3RvckRpc2FibGVkU3RhdGUgPSAoZmll bGRTZXRBbmNlc3RvciAmJiBmaWVsZFNldEFuY2VzdG9yLT5pc0Rpc2FibGVkRm9ybUNvbnRyb2wo KSAmJiAhKGxlZ2VuZEFuY2VzdG9yICYmIGxlZ2VuZEFuY2VzdG9yID09IGZpZWxkU2V0QW5jZXN0 b3ItPmxlZ2VuZCgpKSkgPyBBbmNlc3RvckRpc2FibGVkU3RhdGVEaXNhYmxlZCA6IEFuY2VzdG9y RGlzYWJsZWRTdGF0ZUVuYWJsZWQ7CisgICAgbV9hbmNlc3RvckRpc2FibGVkU3RhdGUgPSBBbmNl c3RvckRpc2FibGVkU3RhdGVFbmFibGVkOwogfQogCiB2b2lkIEhUTUxGb3JtQ29udHJvbEVsZW1l bnQ6OmFuY2VzdG9yRGlzYWJsZWRTdGF0ZVdhc0NoYW5nZWQoKQpJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g MTY0Mzk2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTQtMDItMTkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgZmllbGRzZXQ6ZGlzYWJsZWQgPiBsZWdlbmQ6Zmlyc3QtY2hpbGQgbGVnZW5kIGlu cHV0IHNob3VsZCBub3QgYmUgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyOTA2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZGVkIGEgbmV3IHJlZ3Jlc3Npb24gdGVzdC4KKworICAgICAg ICAqIGZhc3QvZm9ybXMvZmllbGRzZXQvZmllbGRzZXQtZGlzYWJsZWQtMi1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvZmllbGRzZXQvZmllbGRzZXQtZGlzYWJsZWQt Mi5odG1sOiBBZGRlZC4KKwogMjAxNC0wMi0xOSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBBbm90aGVyIFdpbmRvd3MgdXBkYXRlIHRvIHF1aWV0IHRoZSBi b3RzLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWVsZHNldC9maWVsZHNldC1kaXNh YmxlZC0yLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L2ZpZWxkc2V0L2ZpZWxkc2V0LWRpc2FibGVkLTItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQor KysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWVsZHNldC9maWVsZHNldC1kaXNhYmxlZC0yLWV4 cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE5IEBACitBZGRpdGlvbmFsIHRl c3RzIGZvciBmaWVsZHNldCBlbGVtZW50IGRpc2FibGluZyBkZXNjZW5kZW50IGlucHV0IGVsZW1l bnRzCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2Fn ZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGlzSW5wdXREaXNhYmxl ZEJ5SWQoImlucHV0T3V0c2lkZUxlZ2VuZCIpIGlzIHRydWUKK1BBU1MgaXNJbnB1dERpc2FibGVk QnlJZCgiaW5wdXRJbnNpZGVGaXJzdExlZ2VuZCIpIGlzIGZhbHNlCitQQVNTIGlzSW5wdXREaXNh YmxlZEJ5SWQoImlucHV0SW5zaWRlU2Vjb25kTGVnZW5kIikgaXMgdHJ1ZQorUEFTUyBpc0lucHV0 RGlzYWJsZWRCeUlkKCJpbnB1dEluc2lkZU5lc3RlZEZpcnN0TGVnZW5kIikgaXMgZmFsc2UKKwor c2V0RGlzYWJsZWRPbkFsbEZpZWxkc2V0cyhmYWxzZSkKK1BBU1MgaXNJbnB1dERpc2FibGVkQnlJ ZCgiaW5wdXRPdXRzaWRlTGVnZW5kIikgaXMgZmFsc2UKK1BBU1MgaXNJbnB1dERpc2FibGVkQnlJ ZCgiaW5wdXRJbnNpZGVGaXJzdExlZ2VuZCIpIGlzIGZhbHNlCitQQVNTIGlzSW5wdXREaXNhYmxl ZEJ5SWQoImlucHV0SW5zaWRlU2Vjb25kTGVnZW5kIikgaXMgZmFsc2UKK1BBU1MgaXNJbnB1dERp c2FibGVkQnlJZCgiaW5wdXRJbnNpZGVOZXN0ZWRGaXJzdExlZ2VuZCIpIGlzIGZhbHNlCitQQVNT IHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWVsZHNldC9maWVsZHNldC1kaXNhYmxlZC0yLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWVsZHNldC9maWVsZHNldC1kaXNh YmxlZC0yLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ZpZWxk c2V0L2ZpZWxkc2V0LWRpc2FibGVkLTIuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDQ4 IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vLi4v Li4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzdHlsZSB0eXBlPSJ0ZXh0 L2NzcyI+CitpbnB1dDplbmFibGVkIHsgY29sb3I6ICMwMDA7IH0KK2lucHV0OmRpc2FibGVkIHsg Y29sb3I6ICM2NjY7IH0KKzwvc3R5bGU+Cis8ZGl2IGlkPSJjb250YWluZXIiPgorPGlucHV0IGlk PSJyYW5kb21JbnB1dCI+Cis8ZmllbGRzZXQgZGlzYWJsZWQ+PGlucHV0IGlkPSJpbnB1dE91dHNp ZGVMZWdlbmQiPjwvZmllbGRzZXQ+Cis8ZmllbGRzZXQgZGlzYWJsZWQ+PGxlZ2VuZD48aW5wdXQg aWQ9ImlucHV0SW5zaWRlRmlyc3RMZWdlbmQiPjwvbGVnZW5kPjwvZmllbGRzZXQ+Cis8ZmllbGRz ZXQgZGlzYWJsZWQ+PGxlZ2VuZD48L2xlZ2VuZD48bGVnZW5kPjxpbnB1dCBpZD0iaW5wdXRJbnNp ZGVTZWNvbmRMZWdlbmQiPjwvbGVnZW5kPjwvZmllbGRzZXQ+Cis8ZmllbGRzZXQgZGlzYWJsZWQ+ PGxlZ2VuZD48bGVnZW5kPjxpbnB1dCBpZD0iaW5wdXRJbnNpZGVOZXN0ZWRGaXJzdExlZ2VuZCI+ PC9sZWdlbmQ+PC9sZWdlbmQ+PC9maWVsZHNldD4KKzwvZGl2PgorPHNjcmlwdD4KKworZGVzY3Jp cHRpb24oIkFkZGl0aW9uYWwgdGVzdHMgZm9yIGZpZWxkc2V0IGVsZW1lbnQgZGlzYWJsaW5nIGRl c2NlbmRlbnQgaW5wdXQgZWxlbWVudHMiKTsKKworZnVuY3Rpb24gaXNJbnB1dERpc2FibGVkQnlJ ZChpZCkgeworICAgIHZhciBpbnB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKGlkKTsKKyAg ICByZXR1cm4gZ2V0Q29tcHV0ZWRTdHlsZShpbnB1dCkuY29sb3IgPT0gJ3JnYigxMDIsIDEwMiwg MTAyKSc7Cit9CisKK3Nob3VsZEJlVHJ1ZSgnaXNJbnB1dERpc2FibGVkQnlJZCgiaW5wdXRPdXRz aWRlTGVnZW5kIiknKTsKK3Nob3VsZEJlRmFsc2UoJ2lzSW5wdXREaXNhYmxlZEJ5SWQoImlucHV0 SW5zaWRlRmlyc3RMZWdlbmQiKScpOworc2hvdWxkQmVUcnVlKCdpc0lucHV0RGlzYWJsZWRCeUlk KCJpbnB1dEluc2lkZVNlY29uZExlZ2VuZCIpJyk7CitzaG91bGRCZUZhbHNlKCdpc0lucHV0RGlz YWJsZWRCeUlkKCJpbnB1dEluc2lkZU5lc3RlZEZpcnN0TGVnZW5kIiknKTsKKworZnVuY3Rpb24g c2V0RGlzYWJsZWRPbkFsbEZpZWxkc2V0cyh2YWx1ZSkgeworICAgIHZhciBmaWVsZHNldHMgPSBk b2N1bWVudC5xdWVyeVNlbGVjdG9yQWxsKCdmaWVsZHNldCcpOworICAgIGZvciAodmFyIGkgPSAw OyBpIDwgZmllbGRzZXRzLmxlbmd0aDsgaSsrKQorICAgICAgICBmaWVsZHNldHNbaV0uZGlzYWJs ZWQgPSB2YWx1ZTsKK30KKworZGVidWcoJycpOworZXZhbEFuZExvZygnc2V0RGlzYWJsZWRPbkFs bEZpZWxkc2V0cyhmYWxzZSknKTsKK3Nob3VsZEJlRmFsc2UoJ2lzSW5wdXREaXNhYmxlZEJ5SWQo ImlucHV0T3V0c2lkZUxlZ2VuZCIpJyk7CitzaG91bGRCZUZhbHNlKCdpc0lucHV0RGlzYWJsZWRC eUlkKCJpbnB1dEluc2lkZUZpcnN0TGVnZW5kIiknKTsKK3Nob3VsZEJlRmFsc2UoJ2lzSW5wdXRE aXNhYmxlZEJ5SWQoImlucHV0SW5zaWRlU2Vjb25kTGVnZW5kIiknKTsKK3Nob3VsZEJlRmFsc2Uo J2lzSW5wdXREaXNhYmxlZEJ5SWQoImlucHV0SW5zaWRlTmVzdGVkRmlyc3RMZWdlbmQiKScpOwor Citkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29udGFpbmVyJykuc3R5bGUuZGlzcGxheSA9ICdu b25lJzsKKworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRl c3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+CisK