12906 2007-02-27 04:54:04 -0800 REGRESSION: Canvas is pixelated when the page is opened in a background tab 2007-02-27 10:13:40 -0800 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://www.cocoablogs.com/ Regression P1 Normal --- 1 mitz webkit-unassigned oldest_to_newest 21176 0 mitz 2007-02-27 04:54:04 -0800 To reproduce: Create a new tab and open the URL in that (foreground) tab. In Safari Preferences > Tabs, deselect "select new tabs as they are created", then open the URL in a background tab. After the page is finished loading in the background tab, switch to it. Expected results: The clock should render at 1:1 resolution in the background tab, just like in the foreground tab. Actual results: The clock is pixelated in the tab that loaded in the background (looks like 2:1). Regression: Yes, shipping WebKit renders at full resolution in both tabs. 21164 1 13393 mitz 2007-02-27 05:27:46 -0800 Created attachment 13393 Reduction 21156 2 13396 mitz 2007-02-27 05:59:01 -0800 Created attachment 13396 Fall back on the main screen's scale factor if the view is not in a window The main screen's scale factor is just a better guess than the undefined result of sending a message to nil. Since canvas does not seem to support dynamic changes to this parameter (as might be necessary when the view moves from one window to another?), you're stuck with the guessed value. 21159 3 13396 darin 2007-02-27 06:29:09 -0800 Comment on attachment 13396 Fall back on the main screen's scale factor if the view is not in a window Looks like the right thing to do. r=me 21113 4 ap 2007-02-27 10:13:40 -0800 Committed revision 19887. 13393 2007-02-27 05:27:46 -0800 2007-02-27 05:27:46 -0800 Reduction lo-res-canvas.html text/html 449 mitz PGh0bWw+CjxoZWFkPgoJPHRpdGxlPjwvdGl0bGU+CQogICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2ph dmFzY3JpcHQiPgogICAgICAgIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgIHsKICAgICAgICAgICAg dmFyIGNvbnRleHQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY2FudmFzIikuZ2V0Q29udGV4 dCgiMmQiKTsKICAgICAgICAgICAgCiAgICAgICAgICAgIGNvbnRleHQuc2NhbGUoMC41LCAwLjUp OwogICAgICAgICAgICBjb250ZXh0LmFyYygxMDAsIDEwMCwgMTAwLCAwLCAyKk1hdGguUEksIGZh bHNlKTsKICAgICAgICAgICAgY29udGV4dC5maWxsKCk7CiAgICAgICAgfQogICAgPC9zY3JpcHQ+ CjwvaGVhZD4KPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgogICAgPGNhbnZhcyBpZD0iY2FudmFzIiB3 aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCI+PC9jYW52YXM+CjwvYm9keT4KPC9odG1sPgo= 13396 2007-02-27 05:59:01 -0800 2007-02-27 06:29:09 -0800 Fall back on the main screen's scale factor if the view is not in a window 12906_r1.patch text/plain 1265 mitz SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTk4NzcpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMDctMDItMjcgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gaHR0cDov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MDYKKyAgICAgICAgICBSRUdSRVNT SU9OOiBDYW52YXMgaXMgcGl4ZWxhdGVkIHdoZW4gdGhlIHBhZ2UgaXMgb3BlbmVkIGluIGEgYmFj a2dyb3VuZCB0YWIKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5t bToKKyAgICAgICAgKFdlYkNocm9tZUNsaWVudDo6c2NhbGVGYWN0b3IpOiBJZiB0aGUgdmlldyBp cyBub3QgaW4gYSB3aW5kb3csIHVzZSB0aGUgbWFpbgorICAgICAgICBzY3JlZW4ncyBzY2FsZSBm YWN0b3IgYXMgYSBiZXN0IGd1ZXNzLgorCiAyMDA3LTAyLTI2ICBKb2huIFN1bGxpdmFuICA8c3Vs bGl2YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIGFuZCBHZW9mZgpJ bmRleDogV2ViS2l0L1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50Lm1tCShyZXZpc2lvbiAx OTg3NykKKysrIFdlYktpdC9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQubW0JKHdvcmtp bmcgY29weSkKQEAgLTg2LDcgKzg2LDkgQEAgRmxvYXRSZWN0IFdlYkNocm9tZUNsaWVudDo6cGFn ZVJlY3QoKQogCiBmbG9hdCBXZWJDaHJvbWVDbGllbnQ6OnNjYWxlRmFjdG9yKCkKIHsKLSAgICBy ZXR1cm4gW1ttX3dlYlZpZXcgd2luZG93XSB1c2VyU3BhY2VTY2FsZUZhY3Rvcl07CisgICAgaWYg KE5TV2luZG93ICp3aW5kb3cgPSBbbV93ZWJWaWV3IHdpbmRvd10pCisgICAgICAgIHJldHVybiBb d2luZG93ICB1c2VyU3BhY2VTY2FsZUZhY3Rvcl07CisgICAgcmV0dXJuIFtbTlNTY3JlZW4gbWFp blNjcmVlbl0gdXNlclNwYWNlU2NhbGVGYWN0b3JdOwogfQogCiB2b2lkIFdlYkNocm9tZUNsaWVu dDo6Zm9jdXMoKQo=