129045 2014-02-19 09:08:24 -0800 [Win][LLINT] Incorrect stack alignment. 2014-02-19 12:18:49 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned bfulgham commit-queue ggaren mark.lam msaboff oldest_to_newest 982362 0 peavo 2014-02-19 09:08:24 -0800 LLINT expects the stack to be aligned on 16 byte boundaries, but MSVC only aligns the stack on 4 byte boundaries, it seems. 982372 1 224637 peavo 2014-02-19 09:26:35 -0800 Created attachment 224637 Patch 982400 2 224637 bfulgham 2014-02-19 10:16:21 -0800 Comment on attachment 224637 Patch Looks good to me! I think Mark should do the full review. 982402 3 224637 msaboff 2014-02-19 10:21:24 -0800 Comment on attachment 224637 Patch Looks great. r=me. 982404 4 peavo 2014-02-19 10:26:02 -0800 (In reply to comment #3) > (From update of attachment 224637 [details]) > Looks great. r=me. Thanks for looking into this, guys :) 982415 5 ggaren 2014-02-19 10:37:23 -0800 Windows is not the only platform on which the incoming stack is unaligned. For example, the same is true on ARM32. Can we share some of this code? It seems like aligning the stack is a generic action in the LLInt. We need to avoid adding too much Windows-specific cruft to the LLInt. 982416 6 224637 mark.lam 2014-02-19 10:38:13 -0800 Comment on attachment 224637 Patch I don’t see the code to turn this code on in the build. It looks like it will still be using the C loop LLINT. Will you create another patch to turn this on? Thanks. 982428 7 peavo 2014-02-19 10:49:06 -0800 (In reply to comment #6) > (From update of attachment 224637 [details]) > I don’t see the code to turn this code on in the build. It looks like it will still be using the C loop LLINT. Will you create another patch to turn this on? Thanks. Yes you're right, it's still not turned on. Things seem to be running fine now with "normal" browsing, I'm not getting the stack alignment asserts, and the crashes I had was related to the double floating point type operations, which is fixed in this patch. However, there are alot of failures on the JSC stress tests. Should we look into those first, or should I post a patch to enable it, and look into the stress tests afterwards? 982429 8 mark.lam 2014-02-19 10:50:45 -0800 (In reply to comment #7) > However, there are alot of failures on the JSC stress tests. > Should we look into those first, or should I post a patch to enable it, and look into the stress tests afterwards? Do those tests fail with the C Loop LLINT? If turning on the ASM LLINT and JIT does not introduce regressions, then yes, let’s turn it on. 982437 9 224637 commit-queue 2014-02-19 10:55:42 -0800 Comment on attachment 224637 Patch Clearing flags on attachment: 224637 Committed r164374: <http://trac.webkit.org/changeset/164374> 982438 10 commit-queue 2014-02-19 10:55:44 -0800 All reviewed patches have been landed. Closing bug. 982440 11 peavo 2014-02-19 10:57:39 -0800 (In reply to comment #8) > (In reply to comment #7) > > However, there are alot of failures on the JSC stress tests. > > Should we look into those first, or should I post a patch to enable it, and look into the stress tests afterwards? > > Do those tests fail with the C Loop LLINT? If turning on the ASM LLINT and JIT does not introduce regressions, then yes, let’s turn it on. Ok, sounds good, I will test that, and create a new patch if there are no regressions. 982442 12 peavo 2014-02-19 10:58:51 -0800 (In reply to comment #5) > Windows is not the only platform on which the incoming stack is unaligned. For example, the same is true on ARM32. Can we share some of this code? It seems like aligning the stack is a generic action in the LLInt. We need to avoid adding too much Windows-specific cruft to the LLInt. Is this something that could be done with a macro? 982445 13 mark.lam 2014-02-19 11:01:52 -0800 (In reply to comment #11) > (In reply to comment #8) > > (In reply to comment #7) > > > However, there are alot of failures on the JSC stress tests. > > > Should we look into those first, or should I post a patch to enable it, and look into the stress tests afterwards? > > > > Do those tests fail with the C Loop LLINT? If turning on the ASM LLINT and JIT does not introduce regressions, then yes, let’s turn it on. > > Ok, sounds good, I will test that, and create a new patch if there are no regressions. Please also take note of what the failures are. If I remember correctly, most of them should be only timeouts. Turning on the baselineJIT and DFGJIT should help with that. I think there are also some 32-bit x86 failures still, but am not certain. Let’s make a record of what the failures are and whether they are regressions, and then, we can make an informed decision based on that. 982495 14 ggaren 2014-02-19 12:18:49 -0800 > > Windows is not the only platform on which the incoming stack is unaligned. For example, the same is true on ARM32. Can we share some of this code? It seems like aligning the stack is a generic action in the LLInt. We need to avoid adding too much Windows-specific cruft to the LLInt. > > Is this something that could be done with a macro? Possibly. What we want, ideally, is a cross-platform idiom like this: if (!incomingStackIsAligned()) alignStack(); 'incomingStackIsAligned()' would return false on Windows and ARM32, and true on some other platforms. alignStack() might have a shared implementation on all platforms based on our abstract fp and sp registers -- or it might need a specific implementation on some platforms. 224637 2014-02-19 09:26:35 -0800 2014-02-19 10:55:42 -0800 Patch bug-129045-20140219182623.patch text/plain 11957 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0MzY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTAyLTE5ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisg ICAgICAgIFtXaW5dW0xMSU5UXSBJbmNvcnJlY3Qgc3RhY2sgYWxpZ25tZW50LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MDQ1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTExJTlQgZXhwZWN0cyB0aGUg c3RhY2sgdG8gYmUgMTYgYnl0ZSBhbGlnbmVkLCBidXQgd2l0aCBNU1ZDIGl0IGlzIG5vdC4KKyAg ICAgICAgVG8gYWxpZ24gdGhlIHN0YWNrLCBhIG5ldyBiYWNrZW5kLCBYODZfV0lOLCBpcyBjcmVh dGVkLgorCisgICAgICAgICogbGxpbnQvTExJbnRPZmZsaW5lQXNtQ29uZmlnLmg6IFVzZSBYODZf V0lOIGJhY2tlbmQgb24gV2luZG93cy4KKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJl dGVyLmFzbTogQWxpZ24gc3RhY2sgdG8gMTYgYnl0ZSBib3VuZGFyaWVzLiBPdGhlcndpc2UsIHVz ZSBzYW1lIGltcGxlbWVudGF0aW9uIGZvciBYODZfV0lOIGFzIGZvciBYODYuCisgICAgICAgICog bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbTogQWRqdXN0IHN0YWNrIG9mZnNldCB0 byByZXRyaWV2ZSBmdW5jdGlvbiBwYXJhbWV0ZXJzIG5vdyB0aGF0IHRoZSBzdGFjayBpcyBhbGln bmVkLgorICAgICAgICAqIG9mZmxpbmVhc20vYmFja2VuZHMucmI6IEFkZGVkIFg4Nl9XSU4gYmFj a2VuZC4KKyAgICAgICAgKiBvZmZsaW5lYXNtL3g4Ni5yYjogRml4IGNyYXNoIGNhdXNlZCBieSBp bmNvcnJlY3QgYXNzZW1ibHkgY29kZSBmb3IgZG91YmxlIHR5cGVzLgorCiAyMDE0LTAyLTE5ICBE YW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgU2ltcGxpZnkgUExBVEZP Uk0oTUFDKSAmJiAhUExBVEZPUk0oSU9TKSBhbmQgc2ltaWxhciBleHByZXNzaW9ucwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50T2ZmbGluZUFzbUNvbmZpZy5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludE9mZmxpbmVBc21Db25m aWcuaAkocmV2aXNpb24gMTY0MzYzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xM SW50T2ZmbGluZUFzbUNvbmZpZy5oCSh3b3JraW5nIGNvcHkpCkBAIC00OCwxMiArNDgsMTggQEAK IAogI2RlZmluZSBPRkZMSU5FX0FTTV9DX0xPT1AgMAogCi0jaWYgQ1BVKFg4NikKKyNpZiBDUFUo WDg2KSAmJiAhUExBVEZPUk0oV0lOKQogI2RlZmluZSBPRkZMSU5FX0FTTV9YODYgMQogI2Vsc2UK ICNkZWZpbmUgT0ZGTElORV9BU01fWDg2IDAKICNlbmRpZgogCisjaWYgQ1BVKFg4NikgJiYgUExB VEZPUk0oV0lOKQorI2RlZmluZSBPRkZMSU5FX0FTTV9YODZfV0lOIDEKKyNlbHNlCisjZGVmaW5l IE9GRkxJTkVfQVNNX1g4Nl9XSU4gMAorI2VuZGlmCisKICNpZmRlZiBfX0FSTV9BUkNIXzdTX18K ICNkZWZpbmUgT0ZGTElORV9BU01fQVJNdjdzIDEKICNlbHNlCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFz bQkocmV2aXNpb24gMTY0MzYzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXIzMl82NC5hc20JKHdvcmtpbmcgY29weSkKQEAgLTEwMSw3ICsxMDEsNyBA QCBtYWNybyBjQ2FsbDIoZnVuY3Rpb24sIGFyZzEsIGFyZzIpCiAgICAgICAgIG1vdmUgYXJnMSwg YTAKICAgICAgICAgbW92ZSBhcmcyLCBhMQogICAgICAgICBjYWxsIGZ1bmN0aW9uCi0gICAgZWxz aWYgWDg2CisgICAgZWxzaWYgWDg2IG9yIFg4Nl9XSU4KICAgICAgICAgc3VicCA4LCBzcAogICAg ICAgICBwdXNoIGFyZzIKICAgICAgICAgcHVzaCBhcmcxCkBAIC0xMzMsNyArMTMzLDcgQEAgbWFj cm8gY0NhbGw0KGZ1bmN0aW9uLCBhcmcxLCBhcmcyLCBhcmczLAogICAgICAgICBtb3ZlIGFyZzMs IGEyCiAgICAgICAgIG1vdmUgYXJnNCwgYTMKICAgICAgICAgY2FsbCBmdW5jdGlvbgotICAgIGVs c2lmIFg4NgorICAgIGVsc2lmIFg4NiBvciBYODZfV0lOCiAgICAgICAgIHB1c2ggYXJnNAogICAg ICAgICBwdXNoIGFyZzMKICAgICAgICAgcHVzaCBhcmcyCkBAIC0xNTYsNyArMTU2LDcgQEAgbWFj cm8gY2FsbFNsb3dQYXRoKHNsb3dQYXRoKQogZW5kCiAKIG1hY3JvIGRvQ2FsbFRvSmF2YVNjcmlw dChtYWtlQ2FsbCkKLSAgICBpZiBYODYKKyAgICBpZiBYODYgb3IgWDg2X1dJTgogICAgICAgICBj b25zdCBlbnRyeSA9IHQ0CiAgICAgICAgIGNvbnN0IHZtID0gdDMKICAgICAgICAgY29uc3QgcHJv dG9DYWxsRnJhbWUgPSB0NQpAQCAtMjA5LDYgKzIwOSw5IEBAIG1hY3JvIGRvQ2FsbFRvSmF2YVNj cmlwdChtYWtlQ2FsbCkKICAgICBpZiBYODYKICAgICAgICAgbG9hZHAgMzZbc3BdLCB2bQogICAg ICAgICBsb2FkcCAzMltzcF0sIGVudHJ5CisgICAgZWxzaWYgWDg2X1dJTgorICAgICAgICBsb2Fk cCA0MFtzcCwgdGVtcDNdLCB2bQorICAgICAgICBsb2FkcCAzNltzcCwgdGVtcDNdLCBlbnRyeQog ICAgIGVsc2UKICAgICAgICAgbW92ZSBjZnIsIHByZXZpb3VzQ0ZSCiAgICAgZW5kCkBAIC0yMjgs MTIgKzIzMSwxNyBAQCBtYWNybyBkb0NhbGxUb0phdmFTY3JpcHQobWFrZUNhbGwpCiAgICAgaWYg WDg2CiAgICAgICAgIGxvYWRwIDI4W3NwXSwgcHJldmlvdXNQQwogICAgICAgICBsb2FkcCAyNFtz cF0sIHByZXZpb3VzQ0ZSCisgICAgZWxzaWYgWDg2X1dJTgorICAgICAgICBsb2FkcCAzMltzcCwg dGVtcDNdLCBwcmV2aW91c1BDCisgICAgICAgIGxvYWRwIDI4W3NwLCB0ZW1wM10sIHByZXZpb3Vz Q0ZSCiAgICAgZW5kCiAgICAgc3RvcmVwIHByZXZpb3VzUEMsIFJldHVyblBDW2Nmcl0KICAgICBz dG9yZXAgcHJldmlvdXNDRlIsIENhbGxlckZyYW1lW2Nmcl0KIAogICAgIGlmIFg4NgogICAgICAg ICBsb2FkcCA0MFtzcF0sIHByb3RvQ2FsbEZyYW1lCisgICAgZWxzaWYgWDg2X1dJTgorICAgICAg ICBsb2FkcCA0NFtzcCwgdGVtcDNdLCBwcm90b0NhbGxGcmFtZQogICAgIGVuZAogCiAgICAgbG9h ZGkgUHJvdG9DYWxsRnJhbWU6OnBhZGRlZEFyZ0NvdW50W3Byb3RvQ2FsbEZyYW1lXSwgdGVtcDIK QEAgLTM0NCw3ICszNTIsNyBAQCBtYWNybyBtYWtlSG9zdEZ1bmN0aW9uQ2FsbChlbnRyeSwgdGVt cDEsCiAgICAgICAgIHN0b3JlcCBsciwgUHRyU2l6ZVtzcF0KICAgICAgICAgY2xvb3BDYWxsTmF0 aXZlIHRlbXAxCiAgICAgZWxzZQotICAgICAgICBpZiBYODYKKyAgICAgICAgaWYgWDg2IG9yIFg4 Nl9XSU4KICAgICAgICAgICAgICMgUHV0IGNhbGxlZSBmcmFtZSBwb2ludGVyIG9uIHN0YWNrIGFz IGFyZzAsIGFsc28gcHV0IGl0IGluIGVjeCBmb3IgImZhc3RjYWxsIiB0YXJnZXRzCiAgICAgICAg ICAgICBtb3ZlIDAsIHRlbXAyCiAgICAgICAgICAgICBtb3ZlIHRlbXAyLCA0W3NwXSAjIHB1dCAw IGluIFJldHVyblBDCkBAIC0zNTcsNyArMzY1LDcgQEAgbWFjcm8gbWFrZUhvc3RGdW5jdGlvbkNh bGwoZW50cnksIHRlbXAxLAogICAgICAgICAgICAgYWRkcCBDYWxsZXJGcmFtZUFuZFBDU2l6ZSwg c3AKICAgICAgICAgZW5kCiAgICAgICAgIGNhbGwgdGVtcDEKLSAgICAgICAgaWYgWDg2CisgICAg ICAgIGlmIFg4NiBvciBYODZfV0lOCiAgICAgICAgICAgICBhZGRwIDgsIHNwCiAgICAgICAgIGVs c2UKICAgICAgICAgICAgIHN1YnAgQ2FsbGVyRnJhbWVBbmRQQ1NpemUsIHNwCkBAIC0yMTc4LDcg KzIxODYsNyBAQCBtYWNybyBuYXRpdmVDYWxsVHJhbXBvbGluZShleGVjdXRhYmxlT2ZmCiAgICAg bG9hZGkgU2NvcGVDaGFpbiArIFBheWxvYWRPZmZzZXRbdDBdLCB0MQogICAgIHN0b3JlaSBDZWxs VGFnLCBTY29wZUNoYWluICsgVGFnT2Zmc2V0W2Nmcl0KICAgICBzdG9yZWkgdDEsIFNjb3BlQ2hh aW4gKyBQYXlsb2FkT2Zmc2V0W2Nmcl0KLSAgICBpZiBYODYKKyAgICBpZiBYODYgb3IgWDg2X1dJ TgogICAgICAgICBzdWJwIDgsIHNwICMgYWxpZ24gc3RhY2sgcG9pbnRlcgogICAgICAgICBhbmRw IE1hcmtlZEJsb2NrTWFzaywgdDEKICAgICAgICAgbG9hZHAgTWFya2VkQmxvY2s6Om1fd2Vha1Nl dCArIFdlYWtTZXQ6Om1fdm1bdDFdLCB0MwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xs aW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQkocmV2aXNpb24gMTY0MzYzKQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCSh3 b3JraW5nIGNvcHkpCkBAIC03OCw3ICs3OCw3IEBAIGlmIFg4Nl82NCBvciBBUk02NCBvciBDX0xP T1AKIGNvbnN0IG1heEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsID0gMAogZWxzaWYgQVJNIG9y IEFSTXY3X1RSQURJVElPTkFMIG9yIEFSTXY3IG9yIFNINAogY29uc3QgbWF4RnJhbWVFeHRlbnRG b3JTbG93UGF0aENhbGwgPSAyNAotZWxzaWYgWDg2CitlbHNpZiBYODYgb3IgWDg2X1dJTgogY29u c3QgbWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwgPSA0MAogZWxzaWYgTUlQUwogY29uc3Qg bWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwgPSA0MApAQCAtMjQ1LDcgKzI0NSw3IEBAIG1h Y3JvIHByZXNlcnZlQ2FsbGVyUENBbmRDRlIoKQogICAgIGlmIENfTE9PUCBvciBBUk0gb3IgQVJN djcgb3IgQVJNdjdfVFJBRElUSU9OQUwgb3IgTUlQUyBvciBTSDQKICAgICAgICAgcHVzaCBscgog ICAgICAgICBwdXNoIGNmcgotICAgIGVsc2lmIFg4NiBvciBYODZfNjQKKyAgICBlbHNpZiBYODYg b3IgWDg2X1dJTiBvciBYODZfNjQKICAgICAgICAgcHVzaCBjZnIKICAgICBlbHNpZiBBUk02NAog ICAgICAgICBwdXNoTFJBbmRGUApAQCAtMjYwLDcgKzI2MCw3IEBAIG1hY3JvIHJlc3RvcmVDYWxs ZXJQQ0FuZENGUigpCiAgICAgaWYgQ19MT09QIG9yIEFSTSBvciBBUk12NyBvciBBUk12N19UUkFE SVRJT05BTCBvciBNSVBTIG9yIFNINAogICAgICAgICBwb3AgY2ZyCiAgICAgICAgIHBvcCBscgot ICAgIGVsc2lmIFg4NiBvciBYODZfNjQKKyAgICBlbHNpZiBYODYgb3IgWDg2X1dJTiBvciBYODZf NjQKICAgICAgICAgcG9wIGNmcgogICAgIGVsc2lmIEFSTTY0CiAgICAgICAgIHBvcExSQW5kRlAK QEAgLTI3MSw3ICsyNzEsNyBAQCBtYWNybyBwcmVzZXJ2ZVJldHVybkFkZHJlc3NBZnRlckNhbGwo ZGVzCiAgICAgaWYgQ19MT09QIG9yIEFSTSBvciBBUk12NyBvciBBUk12N19UUkFESVRJT05BTCBv ciBBUk02NCBvciBNSVBTIG9yIFNINAogICAgICAgICAjIEluIENfTE9PUCBjYXNlLCB3ZSdyZSBv bmx5IHByZXNlcnZpbmcgdGhlIGJ5dGVjb2RlIHZQQy4KICAgICAgICAgbW92ZSBsciwgZGVzdGlu YXRpb25SZWdpc3RlcgotICAgIGVsc2lmIFg4NiBvciBYODZfNjQKKyAgICBlbHNpZiBYODYgb3Ig WDg2X1dJTiBvciBYODZfNjQKICAgICAgICAgcG9wIGRlc3RpbmF0aW9uUmVnaXN0ZXIKICAgICBl bHNlCiAgICAgICAgIGVycm9yCkBAIC0yODIsNyArMjgyLDcgQEAgbWFjcm8gcmVzdG9yZVJldHVy bkFkZHJlc3NCZWZvcmVSZXR1cm4ocwogICAgIGlmIENfTE9PUCBvciBBUk0gb3IgQVJNdjcgb3Ig QVJNdjdfVFJBRElUSU9OQUwgb3IgQVJNNjQgb3IgTUlQUyBvciBTSDQKICAgICAgICAgIyBJbiBD X0xPT1AgY2FzZSwgd2UncmUgb25seSByZXN0b3JpbmcgdGhlIGJ5dGVjb2RlIHZQQy4KICAgICAg ICAgbW92ZSBzb3VyY2VSZWdpc3RlciwgbHIKLSAgICBlbHNpZiBYODYgb3IgWDg2XzY0CisgICAg ZWxzaWYgWDg2IG9yIFg4Nl9XSU4gb3IgWDg2XzY0CiAgICAgICAgIHB1c2ggc291cmNlUmVnaXN0 ZXIKICAgICBlbHNlCiAgICAgICAgIGVycm9yCkBAIC0yOTAsNyArMjkwLDcgQEAgbWFjcm8gcmVz dG9yZVJldHVybkFkZHJlc3NCZWZvcmVSZXR1cm4ocwogZW5kCiAKIG1hY3JvIGZ1bmN0aW9uUHJv bG9ndWUoKQotICAgIGlmIFg4NiBvciBYODZfNjQKKyAgICBpZiBYODYgb3IgWDg2X1dJTiBvciBY ODZfNjQKICAgICAgICAgcHVzaCBjZnIKICAgICBlbHNpZiBBUk02NAogICAgICAgICBwdXNoTFJB bmRGUApAQCAtMzAyLDcgKzMwMiw3IEBAIG1hY3JvIGZ1bmN0aW9uUHJvbG9ndWUoKQogZW5kCiAK IG1hY3JvIGZ1bmN0aW9uRXBpbG9ndWUoKQotICAgIGlmIFg4NiBvciBYODZfNjQKKyAgICBpZiBY ODYgb3IgWDg2X1dJTiBvciBYODZfNjQKICAgICAgICAgcG9wIGNmcgogICAgIGVsc2lmIEFSTTY0 CiAgICAgICAgIHBvcExSQW5kRlAKQEAgLTMxNiw3ICszMTYsNyBAQCBtYWNybyBjYWxsVG9KYXZh U2NyaXB0UHJvbG9ndWUoKQogICAgIGlmIFg4Nl82NAogICAgICAgICBwdXNoIGNmcgogICAgICAg ICBwdXNoIHQwCi0gICAgZWxzaWYgWDg2CisgICAgZWxzaWYgWDg2IG9yIFg4Nl9XSU4KICAgICAg ICAgcHVzaCBjZnIKICAgICBlbHNpZiBBUk02NAogICAgICAgICBwdXNoTFJBbmRGUApAQCAtMzI3 LDYgKzMyNywxNSBAQCBtYWNybyBjYWxsVG9KYXZhU2NyaXB0UHJvbG9ndWUoKQogICAgIHB1c2hD YWxsZWVTYXZlcwogICAgIGlmIFg4NgogICAgICAgICBzdWJwIDEyLCBzcAorICAgIGVsc2lmIFg4 Nl9XSU4KKyAgICAgICAgc3VicCAxNiwgc3AKKyAgICAgICAgbW92ZSBzcCwgdDQKKyAgICAgICAg bW92ZSB0NCwgdDAKKyAgICAgICAgbW92ZSB0NCwgdDIKKyAgICAgICAgYW5kcCAweGYsIHQyCisg ICAgICAgIGFuZHAgMHhmZmZmZmZmMCwgdDAKKyAgICAgICAgbW92ZSB0MCwgc3AKKyAgICAgICAg c3RvcmVwIHQ0LCBbc3BdCiAgICAgZWxzaWYgQVJNIG9yIEFSTXY3IG9yIEFSTXY3X1RSQURJVElP TkFMCiAgICAgICAgIHN1YnAgNCwgc3AKICAgICAgICAgbW92ZSBzcCwgdDQKQEAgLTM0OCw2ICsz NTcsMTAgQEAgbWFjcm8gY2FsbFRvSmF2YVNjcmlwdEVwaWxvZ3VlKCkKIAogICAgIGlmIFg4Ngog ICAgICAgICBhZGRwIDEyLCBzcAorICAgIGVsc2lmIFg4Nl9XSU4KKyAgICAgICAgcG9wIHQ0Cisg ICAgICAgIG1vdmUgdDQsIHNwCisgICAgICAgIGFkZHAgMTYsIHNwCiAgICAgZWxzaWYgQVJNIG9y IEFSTXY3IG9yIEFSTXY3X1RSQURJVElPTkFMCiAgICAgICAgIHBvcCB0NAogICAgICAgICBtb3Zl IHQ0LCBzcApAQCAtMzU4LDcgKzM3MSw3IEBAIG1hY3JvIGNhbGxUb0phdmFTY3JpcHRFcGlsb2d1 ZSgpCiAgICAgaWYgWDg2XzY0CiAgICAgICAgIHBvcCB0MgogICAgICAgICBwb3AgY2ZyCi0gICAg ZWxzaWYgWDg2CisgICAgZWxzaWYgWDg2IG9yIFg4Nl9XSU4KICAgICAgICAgcG9wIGNmcgogICAg IGVsc2lmIEFSTTY0CiAgICAgICAgIHBvcExSQW5kRlAKQEAgLTYxOCw4ICs2MzEsNiBAQCBlbmQK ICMgc3R1YiB0byBjYWxsIGludG8gSmF2YVNjcmlwdCBvciBOYXRpdmUgZnVuY3Rpb25zCiAjIEVu Y29kZWRKU1ZhbHVlIGNhbGxUb0phdmFTY3JpcHQodm9pZCogY29kZSwgRXhlY1N0YXRlKiogdm1U b3BDYWxsRnJhbWUsIFByb3RvQ2FsbEZyYW1lKiBwcm90b0ZyYW1lKQogIyBFbmNvZGVkSlNWYWx1 ZSBjYWxsVG9OYXRpdmVGdW5jdGlvbih2b2lkKiBjb2RlLCBFeGVjU3RhdGUqKiB2bVRvcENhbGxG cmFtZSwgUHJvdG9DYWxsRnJhbWUqIHByb3RvRnJhbWUpCi0jIE5vdGUsIGlmIHRoZXNlIHN0dWJz IG9yIG9uZSBvZiB0aGVpciByZWxhdGVkIG1hY3JvcyBhcmUgY2hhbmdlZCwgbWFrZSB0aGUKLSMg ZXF1aXZhbGVudCBjaGFuZ2VzIGluIGppdC9KSVRTdHVic1g4Ni5oIGFuZC9vciBqaXQvSklUU3R1 YnNNU1ZDNjQuYXNtCiAKIGlmIENfTE9PUAogX2xsaW50X2NhbGxfdG9famF2YXNjcmlwdDoKQEAg LTY0NSw3ICs2NTYsNyBAQCBfc2FuaXRpemVTdGFja0ZvclZNSW1wbDoKICAgICAgICAgY29uc3Qg dm0gPSB0NAogICAgICAgICBjb25zdCBhZGRyZXNzID0gdDEKICAgICAgICAgY29uc3QgemVyb1Zh bHVlID0gdDAKLSAgICBlbHNpZiBYODYKKyAgICBlbHNpZiBYODYgb3IgWDg2X1dJTgogICAgICAg ICBjb25zdCB2bSA9IHQyCiAgICAgICAgIGNvbnN0IGFkZHJlc3MgPSB0MQogICAgICAgICBjb25z dCB6ZXJvVmFsdWUgPSB0MApAQCAtNjU1LDcgKzY2Niw3IEBAIF9zYW5pdGl6ZVN0YWNrRm9yVk1J bXBsOgogICAgICAgICBjb25zdCB6ZXJvVmFsdWUgPSB0MgogICAgIGVuZAogCi0gICAgaWYgWDg2 CisgICAgaWYgWDg2IG9yIFg4Nl9XSU4KICAgICAgICAgbG9hZHAgNFtzcF0sIHZtCiAgICAgZW5k CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2JhY2tlbmRzLnJiCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2JhY2tlbmRzLnJi CShyZXZpc2lvbiAxNjQzNjMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9i YWNrZW5kcy5yYgkod29ya2luZyBjb3B5KQpAQCAtMzMsNiArMzMsNyBAQCByZXF1aXJlICJjbG9v cCIKIEJBQ0tFTkRTID0KICAgICBbCiAgICAgICJYODYiLAorICAgICAiWDg2X1dJTiIsCiAgICAg ICJYODZfNjQiLAogICAgICAiQVJNIiwKICAgICAgIkFSTXY3IiwKQEAgLTUxLDYgKzUyLDcgQEAg QkFDS0VORFMgPQogV09SS0lOR19CQUNLRU5EUyA9CiAgICAgWwogICAgICAiWDg2IiwKKyAgICAg Ilg4Nl9XSU4iLAogICAgICAiWDg2XzY0IiwKICAgICAgIkFSTSIsCiAgICAgICJBUk12NyIsCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94ODYucmIKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20veDg2LnJiCShyZXZpc2lvbiAxNjQz NjMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94ODYucmIJKHdvcmtpbmcg Y29weSkKQEAgLTI4LDYgKzI4LDggQEAgZGVmIGlzWDY0CiAgICAgY2FzZSAkYWN0aXZlQmFja2Vu ZAogICAgIHdoZW4gIlg4NiIKICAgICAgICAgZmFsc2UKKyAgICB3aGVuICJYODZfV0lOIgorICAg ICAgICBmYWxzZQogICAgIHdoZW4gIlg4Nl82NCIKICAgICAgICAgdHJ1ZQogICAgIGVsc2UKQEAg LTM5LDYgKzQxLDggQEAgZGVmIHVzZVg4NwogICAgIGNhc2UgJGFjdGl2ZUJhY2tlbmQKICAgICB3 aGVuICJYODYiCiAgICAgICAgIHRydWUKKyAgICB3aGVuICJYODZfV0lOIgorICAgICAgICB0cnVl CiAgICAgd2hlbiAiWDg2XzY0IgogICAgICAgICBmYWxzZQogICAgIGVsc2UKQEAgLTk3LDYgKzEw MSw4IEBAIGRlZiBnZXRTaXplU3RyaW5nKGtpbmQpCiAgICAgICAgIHNpemUgPSAiZHdvcmQiCiAg ICAgd2hlbiA6cHRyCiAgICAgICAgIHNpemUgPSAiZHdvcmQiCisgICAgd2hlbiA6ZG91YmxlCisg ICAgICAgIHNpemUgPSAicXdvcmQiCiAgICAgZWxzZQogICAgICAgICByYWlzZQogICAgIGVuZApA QCAtNDA4LDcgKzQxNCwxMSBAQCBjbGFzcyBCYXNlSW5kZXgKICAgICBlbmQKICAgICAKICAgICBk ZWYgeDg2T3BlcmFuZChraW5kKQotICAgICAgICB4ODZBZGRyZXNzT3BlcmFuZCg6cHRyKQorICAg ICAgICBpZiAhaXNJbnRlbFN5bnRheCB8fCBraW5kICE9IDpkb3VibGUKKyAgICAgICAgICAgIHg4 NkFkZHJlc3NPcGVyYW5kKDpwdHIpCisgICAgICAgIGVsc2UKKyAgICAgICAgICAgICIje2dldFNp emVTdHJpbmcoa2luZCl9WyN7b2Zmc2V0LnZhbHVlfSArICN7YmFzZS54ODZPcGVyYW5kKDpwdHIp fSArICN7aW5kZXgueDg2T3BlcmFuZCg6cHRyKX0gKiAje3NjYWxlfV0iCisgICAgICAgIGVuZAog ICAgIGVuZAogCiAgICAgZGVmIHg4NkNhbGxPcGVyYW5kKGtpbmQpCkBAIC04MDksNiArODE5LDEx IEBAIGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgIHJhaXNlIHVubGVzcyAkYWN0aXZlQmFja2Vu ZCA9PSAiWDg2IgogICAgICAgICBsb3dlclg4NkNvbW1vbgogICAgIGVuZAorCisgICAgZGVmIGxv d2VyWDg2X1dJTgorICAgICAgICByYWlzZSB1bmxlc3MgJGFjdGl2ZUJhY2tlbmQgPT0gIlg4Nl9X SU4iIAorICAgICAgICBsb3dlclg4NkNvbW1vbgorICAgIGVuZAogICAgIAogICAgIGRlZiBsb3dl clg4Nl82NAogICAgICAgICByYWlzZSB1bmxlc3MgJGFjdGl2ZUJhY2tlbmQgPT0gIlg4Nl82NCIK QEAgLTE0MzAsNyArMTQ0NSw3IEBAIGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgICAgICAgICAg c3AgPSBSZWdpc3RlcklELm5ldyhuaWwsICJzcCIpCiAgICAgICAgICAgICAgICAgJGFzbS5wdXRz ICJtb3Yje3g4NlN1ZmZpeCg6aW50KX0gI3tvcmRlck9wZXJhbmRzKG9wZXJhbmRzWzBdLng4Nk9w ZXJhbmQoOmludCksIG9mZnNldFJlZ2lzdGVyKC04LCBzcC54ODZPcGVyYW5kKDpwdHIpKSl9Igog ICAgICAgICAgICAgICAgICRhc20ucHV0cyAibW92I3t4ODZTdWZmaXgoOmludCl9ICN7b3JkZXJP cGVyYW5kcyhvcGVyYW5kc1sxXS54ODZPcGVyYW5kKDppbnQpLCBvZmZzZXRSZWdpc3RlcigtNCwg c3AueDg2T3BlcmFuZCg6cHRyKSkpfSIKLSAgICAgICAgICAgICAgICAkYXNtLnB1dHMgImZsZCN7 eDg2U3VmZml4KDpwdHIpfSAje2dldFNpemVTdHJpbmcoOnB0cil9I3tvZmZzZXRSZWdpc3Rlcigt OCwgc3AueDg2T3BlcmFuZCg6cHRyKSl9IgorICAgICAgICAgICAgICAgICRhc20ucHV0cyAiZmxk I3t4ODZTdWZmaXgoOnB0cil9ICN7Z2V0U2l6ZVN0cmluZyg6ZG91YmxlKX0je29mZnNldFJlZ2lz dGVyKC04LCBzcC54ODZPcGVyYW5kKDpwdHIpKX0iCiAgICAgICAgICAgICAgICAgJGFzbS5wdXRz ICJmc3RwICN7b3BlcmFuZHNbMl0ueDg3T3BlcmFuZCgxKX0iCiAgICAgICAgICAgICBlbHNlCiAg ICAgICAgICAgICAgICAgJGFzbS5wdXRzICJtb3ZkICN7b3BlcmFuZHNbMF0ueDg2T3BlcmFuZCg6 aW50KX0sICN7b3BlcmFuZHNbMl0ueDg2T3BlcmFuZCg6ZG91YmxlKX0iCkBAIC0xNDQyLDcgKzE0 NTcsNyBAQCBjbGFzcyBJbnN0cnVjdGlvbgogICAgICAgICAgICAgaWYgdXNlWDg3CiAgICAgICAg ICAgICAgICAgc3AgPSBSZWdpc3RlcklELm5ldyhuaWwsICJzcCIpCiAgICAgICAgICAgICAgICAg aWYgKG9wZXJhbmRzWzBdLng4N0RlZmF1bHRTdGFja1Bvc2l0aW9uID09IDApCi0gICAgICAgICAg ICAgICAgICAgICRhc20ucHV0cyAiZnN0I3t4ODZTdWZmaXgoOnB0cil9ICN7Z2V0U2l6ZVN0cmlu Zyg6cHRyKX0je29mZnNldFJlZ2lzdGVyKC04LCBzcC54ODZPcGVyYW5kKDpwdHIpKX0iCisgICAg ICAgICAgICAgICAgICAgICRhc20ucHV0cyAiZnN0I3t4ODZTdWZmaXgoOnB0cil9ICN7Z2V0U2l6 ZVN0cmluZyg6ZG91YmxlKX0je29mZnNldFJlZ2lzdGVyKC04LCBzcC54ODZPcGVyYW5kKDpwdHIp KX0iCiAgICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICAkYXNtLnB1dHMg ImZsZCAje29wZXJhbmRzWzBdLng4N09wZXJhbmQoMCl9IgogICAgICAgICAgICAgICAgICAgICAk YXNtLnB1dHMgImZzdHBsIC04KCN7c3AueDg2T3BlcmFuZCg6cHRyKX0pIgo=