129036 2014-02-19 01:39:23 -0800 [CSSRegions] Add helper method for region clipping flow content 2014-02-20 01:05:37 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mihnea webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser WebkitBugTracker oldest_to_newest 982289 0 mihnea 2014-02-19 01:39:23 -0800 Use a helper method throughout the code instead of same code block. 982296 1 224613 mihnea 2014-02-19 01:44:50 -0800 Created attachment 224613 Patch 982320 2 224613 abucur 2014-02-19 05:00:58 -0800 Comment on attachment 224613 Patch r=me 982723 3 224613 commit-queue 2014-02-20 01:05:34 -0800 Comment on attachment 224613 Patch Clearing flags on attachment: 224613 Committed r164419: <http://trac.webkit.org/changeset/164419> 982724 4 commit-queue 2014-02-20 01:05:37 -0800 All reviewed patches have been landed. Closing bug. 224613 2014-02-19 01:44:50 -0800 2014-02-20 01:05:34 -0800 Patch 129036.patch text/plain 5394 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YjUzMDNkLi45YjNmYjE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTQtMDItMTkgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTU1JlZ2lvbnNdIEFkZCBoZWxwZXIgbWV0aG9kIGZvciByZWdpb24gY2xpcHBpbmcg ZmxvdyBjb250ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjkwMzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGQgaGVscGVyIG1ldGhvZCB0byB0ZXN0IHdoZXRoZXIgYSByZWdpb24gc2hvdWxkIGNs aXAgdGhlIGZsb3cgdGhyZWFkIGNvbnRlbnQKKyAgICAgICAgYW5kIHVzZSBpdCB0aG91Z2hvdXQg dGhlIGNvZGUuCisgICAgICAgIENvZGUgcmVmYWN0b3JpbmcsIG5vIGZ1bmN0aW9uYWxpdHkgY2hh bmdlLCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmNhbGN1bGF0ZUNsaXBSZWN0cyk6Cisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJSZWdpb246Om92ZXJmbG93UmVjdEZvckZsb3dUaHJlYWRQb3J0aW9uKToKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclJlZ2lvbjo6c2hvdWxkQ2xpcEZsb3dUaHJlYWRDb250ZW50KToKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlclJlZ2lvbjo6cmVjdEZsb3dQb3J0aW9uRm9yQm94KToKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmg6CisKIDIwMTQtMDItMTkgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBTaW1wbGlmeSBQTEFURk9STShNQUMp ICYmICFQTEFURk9STShJT1MpIGFuZCBzaW1pbGFyIGV4cHJlc3Npb25zCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCA2Y2IyZTdhLi5mNDAxMTg1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTY3ODIsOCArNjc4Miw3IEBA IHZvaWQgUmVuZGVyTGF5ZXI6OnBhaW50Rmxvd1RocmVhZElmUmVnaW9uKEdyYXBoaWNzQ29udGV4 dCogY29udGV4dCwgY29uc3QgTGF5ZXJQCiAgICAgQ2xpcFJlY3QgcmVnaW9uQ2xpcFJlY3Q7CiAg ICAgUmVuZGVyTmFtZWRGbG93VGhyZWFkKiBmbG93VGhyZWFkID0gZmxvd0ZyYWdtZW50LT5uYW1l ZEZsb3dUaHJlYWQoKTsKICAgICBSZW5kZXJMYXllciogZmxvd1RocmVhZExheWVyID0gZmxvd1Ro cmVhZC0+bGF5ZXIoKTsKLSAgICBib29sIGlzTGFzdFJlZ2lvbldpdGhSZWdpb25GcmFnbWVudEJy ZWFrID0gKGZsb3dGcmFnbWVudC0+aXNMYXN0UmVnaW9uKCkgJiYgZmxvd0ZyYWdtZW50LT5zdHls ZSgpLnJlZ2lvbkZyYWdtZW50KCkgPT0gQnJlYWtSZWdpb25GcmFnbWVudCk7Ci0gICAgaWYgKGZs b3dGcmFnbWVudC0+aGFzT3ZlcmZsb3dDbGlwKCkgfHwgaXNMYXN0UmVnaW9uV2l0aFJlZ2lvbkZy YWdtZW50QnJlYWspIHsKKyAgICBpZiAoZmxvd0ZyYWdtZW50LT5zaG91bGRDbGlwRmxvd1RocmVh ZENvbnRlbnQoKSkgewogICAgICAgICByZWdpb25DbGlwUmVjdCA9IHJlbmRlck5hbWVkRmxvd0Zy YWdtZW50Q29udGFpbmVyLT5wYWRkaW5nQm94UmVjdCgpOwogCiAgICAgICAgIC8vIFdoZW4gdGhl IGxheWVyIG9mIHRoZSBmbG93IGZyYWdtZW50J3MgY29udGFpbmVyIGlzIGNvbXBvc2l0ZWQsIHRo ZSBmbG93IGZyYWdtZW50IGNvbnRhaW5lciByZWNlaXZlcyBhCkBAIC02ODA3LDEyICs2ODA2LDEz IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnBhaW50Rmxvd1RocmVhZElmUmVnaW9uKEdyYXBoaWNzQ29u dGV4dCogY29udGV4dCwgY29uc3QgTGF5ZXJQCiAgICAgfQogCiAgICAgLy8gT3B0aW1pemUgY2xp cHBpbmcgZm9yIHRoZSBzaW5nbGUgZnJhZ21lbnQgY2FzZS4KLSAgICBpZiAoIXJlZ2lvbkNsaXBS ZWN0LmlzRW1wdHkoKSAmJiByZWdpb25DbGlwUmVjdCAhPSBMYXlvdXRSZWN0OjppbmZpbml0ZVJl Y3QoKSkKKyAgICBib29sIHNob3VsZENsaXAgPSAhcmVnaW9uQ2xpcFJlY3QuaXNFbXB0eSgpICYm IHJlZ2lvbkNsaXBSZWN0ICE9IExheW91dFJlY3Q6OmluZmluaXRlUmVjdCgpOworICAgIGlmIChz aG91bGRDbGlwKQogICAgICAgICBjbGlwVG9SZWN0KHBhaW50aW5nSW5mby5yb290TGF5ZXIsIGNv bnRleHQsIHBhaW50aW5nSW5mby5wYWludERpcnR5UmVjdCwgcmVnaW9uQ2xpcFJlY3QpOwogCiAg ICAgZmxvd1RocmVhZExheWVyLT5wYWludE5hbWVkRmxvd1RocmVhZEluc2lkZVJlZ2lvbihjb250 ZXh0LCBmbG93RnJhZ21lbnQsIHBhaW50aW5nSW5mby5wYWludERpcnR5UmVjdCwgcGFpbnRPZmZz ZXQsIHBhaW50aW5nSW5mby5wYWludEJlaGF2aW9yLCBwYWludEZsYWdzKTsKIAotICAgIGlmICgh cmVnaW9uQ2xpcFJlY3QuaXNFbXB0eSgpICYmIHJlZ2lvbkNsaXBSZWN0ICE9IExheW91dFJlY3Q6 OmluZmluaXRlUmVjdCgpKQorICAgIGlmIChzaG91bGRDbGlwKQogICAgICAgICByZXN0b3JlQ2xp cChjb250ZXh0LCBwYWludGluZ0luZm8ucGFpbnREaXJ0eVJlY3QsIHJlZ2lvbkNsaXBSZWN0KTsK IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmNwcAppbmRleCA2Yjc1 OWYyLi41ZDFkYjNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy UmVnaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmNw cApAQCAtMTU0LDggKzE1NCw3IEBAIExheW91dFJlY3QgUmVuZGVyUmVnaW9uOjpvdmVyZmxvd1Jl Y3RGb3JGbG93VGhyZWFkUG9ydGlvbihjb25zdCBMYXlvdXRSZWN0JiBmbG93CiB7CiAgICAgQVNT RVJUKGlzVmFsaWQoKSk7CiAKLSAgICBib29sIGlzTGFzdFJlZ2lvbldpdGhSZWdpb25GcmFnbWVu dEJyZWFrID0gKGlzTGFzdFBvcnRpb24gJiYgKHN0eWxlKCkucmVnaW9uRnJhZ21lbnQoKSA9PSBC cmVha1JlZ2lvbkZyYWdtZW50KSk7Ci0gICAgaWYgKGhhc092ZXJmbG93Q2xpcCgpIHx8IGlzTGFz dFJlZ2lvbldpdGhSZWdpb25GcmFnbWVudEJyZWFrKQorICAgIGlmIChzaG91bGRDbGlwRmxvd1Ro cmVhZENvbnRlbnQoKSkKICAgICAgICAgcmV0dXJuIGZsb3dUaHJlYWRQb3J0aW9uUmVjdDsKIAog ICAgIExheW91dFJlY3QgZmxvd1RocmVhZE92ZXJmbG93ID0gb3ZlcmZsb3dUeXBlID09IFZpc3Vh bE92ZXJmbG93ID8gdmlzdWFsT3ZlcmZsb3dSZWN0Rm9yQm94KG1fZmxvd1RocmVhZCkgOiBsYXlv dXRPdmVyZmxvd1JlY3RGb3JCb3gobV9mbG93VGhyZWFkKTsKQEAgLTIxNyw3ICsyMTYsMTYgQEAg Ym9vbCBSZW5kZXJSZWdpb246OmlzTGFzdFJlZ2lvbigpIGNvbnN0CiAKICAgICByZXR1cm4gbV9m bG93VGhyZWFkLT5sYXN0UmVnaW9uKCkgPT0gdGhpczsKIH0KLSAgICAKKworYm9vbCBSZW5kZXJS ZWdpb246OnNob3VsZENsaXBGbG93VGhyZWFkQ29udGVudCgpIGNvbnN0Cit7CisgICAgaWYgKGhh c092ZXJmbG93Q2xpcCgpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIC8vIHJlZ2lvbkZy YWdtZW50IGlzIENTU1JlZ2lvbnMgc3BlY2lmaWMgdGhlcmVmb3JlIHdlIHRha2UgaXQgaW50byBh Y2NvdW50IG9ubHkgaW4gdGhlc2UgY2FzZXMuCisgICAgcmV0dXJuIGlzUmVuZGVyTmFtZWRGbG93 RnJhZ21lbnQoKSA/IGlzTGFzdFJlZ2lvbigpICYmIHN0eWxlKCkucmVnaW9uRnJhZ21lbnQoKSA9 PSBCcmVha1JlZ2lvbkZyYWdtZW50IDogZmFsc2U7Cit9CisKIHZvaWQgUmVuZGVyUmVnaW9uOjpz dHlsZURpZENoYW5nZShTdHlsZURpZmZlcmVuY2UgZGlmZiwgY29uc3QgUmVuZGVyU3R5bGUqIG9s ZFN0eWxlKQogewogICAgIFJlbmRlckJsb2NrRmxvdzo6c3R5bGVEaWRDaGFuZ2UoZGlmZiwgb2xk U3R5bGUpOwpAQCAtNTA5LDggKzUxNyw3IEBAIExheW91dFJlY3QgUmVuZGVyUmVnaW9uOjpyZWN0 Rmxvd1BvcnRpb25Gb3JCb3goY29uc3QgUmVuZGVyQm94KiBib3gsIGNvbnN0IExheW91CiAgICAg ICAgICAgICBtYXBwZWRSZWN0LnNldFdpZHRoKHN0ZDo6bWF4PExheW91dFVuaXQ+KDAsIHN0ZDo6 bWluPExheW91dFVuaXQ+KGxvZ2ljYWxCb3R0b21Gb3JGbG93VGhyZWFkQ29udGVudCgpIC0gbWFw cGVkUmVjdC54KCksIG1hcHBlZFJlY3Qud2lkdGgoKSkpKTsKICAgICB9CiAKLSAgICBib29sIGlz TGFzdFJlZ2lvbldpdGhSZWdpb25GcmFnbWVudEJyZWFrID0gKGlzTGFzdFJlZ2lvbigpICYmIChz dHlsZSgpLnJlZ2lvbkZyYWdtZW50KCkgPT0gQnJlYWtSZWdpb25GcmFnbWVudCkpOwotICAgIGlm IChoYXNPdmVyZmxvd0NsaXAoKSB8fCBpc0xhc3RSZWdpb25XaXRoUmVnaW9uRnJhZ21lbnRCcmVh aykgeworICAgIGlmIChzaG91bGRDbGlwRmxvd1RocmVhZENvbnRlbnQoKSkgewogICAgICAgICBM YXlvdXRSZWN0IHBvcnRpb25SZWN0OwogICAgICAgICBpZiAoaXNSZW5kZXJOYW1lZEZsb3dGcmFn bWVudCgpKQogICAgICAgICAgICAgcG9ydGlvblJlY3QgPSB0b1JlbmRlck5hbWVkRmxvd0ZyYWdt ZW50KHRoaXMpLT5mbG93VGhyZWFkUG9ydGlvblJlY3RGb3JDbGlwcGluZyh0aGlzID09IHN0YXJ0 UmVnaW9uLCB0aGlzID09IGVuZFJlZ2lvbik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy UmVnaW9uLmgKaW5kZXggZDdhMzllMC4uZjY4OTQ1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJSZWdpb24uaApAQCAtNzcsNiArNzcsNyBAQCBwdWJsaWM6CiAKICAgICBib29sIGlz Rmlyc3RSZWdpb24oKSBjb25zdDsKICAgICBib29sIGlzTGFzdFJlZ2lvbigpIGNvbnN0OworICAg IGJvb2wgc2hvdWxkQ2xpcEZsb3dUaHJlYWRDb250ZW50KCkgY29uc3Q7CiAKICAgICBSZWdpb25P dmVyc2V0U3RhdGUgcmVnaW9uT3ZlcnNldFN0YXRlKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRSZWdp b25PdmVyc2V0U3RhdGUoUmVnaW9uT3ZlcnNldFN0YXRlKTsK