12902 2007-02-26 15:33:15 -0800 Pressing return key doesn't move caret to next line after applying a font color in GMail 2007-02-27 00:57:23 -0800 1 1 1 Unclassified WebKit WebCore Misc. 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 adele adele darin oldest_to_newest 21313 0 adele 2007-02-26 15:33:15 -0800 * STEPS TO REPRODUCE 1. With TOT, login to your gmail account 2. Create a rich text message 3. Choose a new font color from the tool palette. 4. Start type text in the message. With the caret at the end of this line, press the return key 5. Instead of a new line being created, the caret still remains at the current line * RESULTS The caret should move to the new line but doesn't 21303 1 adele 2007-02-26 15:33:58 -0800 <rdar://problem/5012679> REGRESSION: Pressing return key doesn't move caret to next line after applying a font color in GMail I broke this with my recent event handling change 21304 2 adele 2007-02-26 15:36:11 -0800 Looks like after using the Font popup menu, the main frame is focused and the key event for the return key isn't sent to the editable subframe. But the keys are still inserted because of code in Editor::insertText which calls selectionForEvent. selectionForEvent is returning the selection for the page, not the frame. Which I'm not sure is right. But it seems like focus really should be getting set back to the iframe. I'm not sure where that should happen though. 21296 3 13388 adele 2007-02-26 18:23:41 -0800 Created attachment 13388 test case 21241 4 13390 adele 2007-02-27 00:48:21 -0800 Created attachment 13390 patch 21192 5 adele 2007-02-27 00:57:23 -0800 Committed revision 19879. 13388 2007-02-26 18:23:41 -0800 2007-02-26 18:23:41 -0800 test case iframe.html text/html 535 adele PGh0bWw+CjxoZWFkPgogICAgPHNjcmlwdD4KICAgIGZ1bmN0aW9uIHNldEVkaXQoKSB7CiAgICAg ICAgdmFyIGlmcmFtZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdpZicpOwogICAgICAgIGlm cmFtZS5jb250ZW50RG9jdW1lbnQuZGVzaWduTW9kZSA9ICJvbiI7CiAgICAgICAgaWZyYW1lLmZv Y3VzKCk7CiAgICB9CiAgICBmdW5jdGlvbiBkb1N0dWZmKCkgewogICAgICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdpZicpLmNvbnRlbnRXaW5kb3cuZm9jdXMoKTsKICAgIH0KICAgIDwvc2Ny aXB0Pgo8L2hlYWQ+Cjxib2R5IG9ubG9hZD0ic2V0RWRpdCgpIj4KICAgIDxkaXYgb25jbGljaz0i ZG9TdHVmZigpIiBpZD0iZHYiIHN0eWxlPSJib3JkZXI6IHNvbGlkIHRoaW4gYmxhY2siPmNsaWNr IGhlcmUgYW5kIHRoZW4gdHlwZSBhbmQgaGl0IGVudGVyPC9kaXY+CiAgICA8aWZyYW1lIHNyYz0i YWJvdXQ6YmxhbmsiIGlkPSJpZiIgc3R5bGU9ImJvcmRlcjogc29saWQgdGhpbiBibGFjayI+PC9p ZnJhbWU+CjwvYm9keT4KPC9odG1sPg== 13390 2007-02-27 00:48:21 -0800 2007-02-27 00:54:13 -0800 patch 2_27_gmail.txt text/plain 6190 adele SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxOTg3OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDctMDItMjYgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MDIKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzUwMTI2Nzk+IFJFR1JFU1NJT046IFByZXNzaW5nIHJldHVybiBr ZXkgZG9lc24ndCAKKyAgICAgICAgbW92ZSBjYXJldCB0byBuZXh0IGxpbmUgYWZ0ZXIgYXBwbHlp bmcgYSBmb250IGNvbG9yIGluIEdNYWlsCisKKyAgICAgICAgVGVzdDogZmFzdC9mcmFtZXMvaWZy YW1lLXdpbmRvdy1mb2N1cy0yLmh0bWwKKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmg6 IE1ha2UgZm9jdXNEb2N1bWVudFZpZXcgcHVibGljLgorICAgICAgICAqIHBhZ2UvRnJhbWUuY3Bw OiAoV2ViQ29yZTo6RnJhbWU6OmZvY3VzV2luZG93KTogSW5zdGVhZCBvZiBqdXN0IHNldHRpbmcg dGhlIGZvY3VzZWQgZnJhbWUsCisgICAgICAgICAgd2Ugc2hvdWxkIHNldCBhbHNvIGZvY3VzIHRo ZSBkb2N1bWVudCB2aWV3LiAgVGhlIGJ1ZyBoZXJlIHdhcyB0aGF0IHNpbmNlIHRoZSBzdWJmcmFt ZSB2aWV3CisgICAgICAgICAgd2Fzbid0IHRoZSBmaXJzdCByZXNwb25kZXIsIHRoZSBrZXkgZG93 biBldmVudCB3YXMgZ29pbmcgdG8gdGhlIHdyb25nIGZyYW1lLgorCiAyMDA3LTAyLTI2ICBNYWNp ZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xp dmVyLgpJbmRleDogV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAkocmV2aXNpb24gMTk4NTIpCisrKyBXZWJDb3JlL3Bh Z2UvRXZlbnRIYW5kbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0MSw2ICsxNDEsOCBAQCBwdWJs aWM6CiAgICAgdm9pZCBkcmFnU291cmNlTW92ZWRUbyhjb25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQm KTsKICAgICB2b2lkIGRyYWdTb3VyY2VFbmRlZEF0KGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYs IERyYWdPcGVyYXRpb24pOwogCisgICAgdm9pZCBmb2N1c0RvY3VtZW50VmlldygpOworCiAjaWYg UExBVEZPUk0oTUFDKQogICAgIFBhc3NSZWZQdHI8S2V5Ym9hcmRFdmVudD4gY3VycmVudEtleWJv YXJkRXZlbnQoKSBjb25zdDsKIApAQCAtMjA4LDggKzIxMCw2IEBAIHByaXZhdGU6CiAKICAgICB2 b2lkIGZyZWVDbGlwYm9hcmQoKTsKIAotICAgIHZvaWQgZm9jdXNEb2N1bWVudFZpZXcoKTsKLQog ICAgIGJvb2wgaGFuZGxlRHJhZyhjb25zdCBNb3VzZUV2ZW50V2l0aEhpdFRlc3RSZXN1bHRzJik7 CiAgICAgYm9vbCBoYW5kbGVNb3VzZVVwKGNvbnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3Vs dHMmKTsKIApJbmRleDogV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3BhZ2UvRnJhbWUuY3BwCShyZXZpc2lvbiAxOTg1MikKKysrIFdlYkNvcmUvcGFnZS9GcmFt ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3NDcsNyArMTc0Nyw3IEBAIHZvaWQgRnJhbWU6OmZv Y3VzV2luZG93KCkKICAgICBpZiAoIXRyZWUoKS0+cGFyZW50KCkpCiAgICAgICAgIHBhZ2UoKS0+ Y2hyb21lKCktPmZvY3VzKCk7CiAKLSAgICBwYWdlKCktPmZvY3VzQ29udHJvbGxlcigpLT5zZXRG b2N1c2VkRnJhbWUodGhpcyk7CisgICAgZXZlbnRIYW5kbGVyKCktPmZvY3VzRG9jdW1lbnRWaWV3 KCk7CiB9CiAKIHZvaWQgRnJhbWU6OnVuZm9jdXNXaW5kb3coKQpJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g MTk4NzgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNCBAQAorMjAwNy0wMi0yNyAgQWRlbGUgUGV0ZXJzb24gIDxhZGVsZUBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlZCB0 ZXN0IGZvciBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjkwMgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNTAxMjY3OT4gUkVHUkVTU0lPTjogUHJlc3NpbmcgcmV0dXJu IGtleSBkb2Vzbid0IAorICAgICAgICBtb3ZlIGNhcmV0IHRvIG5leHQgbGluZSBhZnRlciBhcHBs eWluZyBhIGZvbnQgY29sb3IgaW4gR01haWwKKworICAgICAgICAqIGZhc3QvZnJhbWVzL2lmcmFt ZS13aW5kb3ctZm9jdXMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZnJhbWVzL2lmcmFt ZS13aW5kb3ctZm9jdXMuaHRtbDogVXBkYXRlZCB0ZXN0IHRvIGluY2x1ZGUgaW5zZXJ0aW9uIG9m IG5ld2xpbmVzLgorCiAyMDA3LTAyLTI2ICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9mcmFtZXMvaWZyYW1lLXdpbmRvdy1mb2N1cy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvaWZyYW1lLXdpbmRvdy1mb2N1cy1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDE5ODUyKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvaWZyYW1lLXdpbmRv dy1mb2N1cy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw1IEBACi1UaGlz IHRlc3RzIHRoYXQgZm9jdXNpbmcgYW4gZWRpdGFibGUgaWZyYW1lJ3Mgd2luZG93IHdvcmtzIGNv cnJlY3RseS4KK1RoaXMgdGVzdHMgdGhhdCBmb2N1c2luZyBhbiBlZGl0YWJsZSBpZnJhbWUncyB3 aW5kb3cgd29ya3MgY29ycmVjdGx5IGFuZCBhbGxvd3MgdGV4dCBhbmQgbmV3bGluZXMgdG8gYmUg ZW50ZXJlZC4KIAorVEVTVAogUEFTUwogCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9p ZnJhbWUtd2luZG93LWZvY3VzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9m cmFtZXMvaWZyYW1lLXdpbmRvdy1mb2N1cy5odG1sCShyZXZpc2lvbiAxOTg1MikKKysrIExheW91 dFRlc3RzL2Zhc3QvZnJhbWVzL2lmcmFtZS13aW5kb3ctZm9jdXMuaHRtbAkod29ya2luZyBjb3B5 KQpAQCAtMSwyOCArMSw0NiBAQAotPGh0bWw+PGhlYWQ+Ci08c2NyaXB0PgotaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0 KCk7Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAgICAgIGlm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogCi1mdW5jdGlvbiBpbml0KCkgewotICAgIHZhciBp ZnJhbWUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicnRlIik7Ci0gICAgaWZyYW1lLmNvbnRl bnREb2N1bWVudC5kZXNpZ25Nb2RlID0gIm9uIjsKLSAgICBpZnJhbWUuY29udGVudFdpbmRvdy5m b2N1cygpOwotICAgIAotICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKLSAg ICAgICAgZXZlbnRTZW5kZXIua2V5RG93bigiUCIpOwotICAgICAgICBldmVudFNlbmRlci5rZXlE b3duKCJBIik7Ci0gICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oIlMiKTsKLSAgICAgICAgZXZl bnRTZW5kZXIua2V5RG93bigiUyIpOwotICAgIH0KLSAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgncmVzJykuaW5uZXJIVE1MID0gaWZyYW1lLmNvbnRlbnREb2N1bWVudC5ib2R5LmlubmVyVGV4 dDsKLX0KLQotCi08L3NjcmlwdD4KLTwvaGVhZD4KLTxib2R5IG9ubG9hZD0iaW5pdCgpIj4KLVRo aXMgdGVzdHMgdGhhdCBmb2N1c2luZyBhbiBlZGl0YWJsZSBpZnJhbWUncyB3aW5kb3cgd29ya3Mg Y29ycmVjdGx5Ljxicj4KLTxpZnJhbWUgaWQ9InJ0ZSIgc3R5bGU9ImJvcmRlcjogMXB4IHNvbGlk IGJsYWNrIj48L2lmcmFtZT4KLTxkaXYgaWQ9InJlcyI+PC9kaXY+Ci08L2JvZHk+CisgICAgICAg ICAgICBmdW5jdGlvbiBtb3ZlRm9jdXMoKSB7CisgICAgICAgICAgICAgICAgdmFyIGlmcm0gPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgicnRlIik7CisgICAgICAgICAgICAgICAgaWZybS5jb250 ZW50V2luZG93LmZvY3VzKCk7CisgICAgICAgICAgICB9CisgICAgICAgICAgICAKKyAgICAgICAg ICAgIGZ1bmN0aW9uIGluaXQoKSB7CisgICAgICAgICAgICAgICAgdmFyIGlmcm0gPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgicnRlIik7CisgICAgICAgICAgICAgICAgaWZybS5jb250ZW50RG9j dW1lbnQuZGVzaWduTW9kZSA9ICJvbiI7CisgICAgICAgICAgICAgICAgaWZybS5jb250ZW50V2lu ZG93LmZvY3VzKCk7CisgICAgICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICAgICAgICAgICAgICBldmVudFNlbmRl ci5rZXlEb3duKCdUJyk7CisgICAgICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24o J0UnKTsKKyAgICAgICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIua2V5RG93bignUycpOworICAg ICAgICAgICAgICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCdUJyk7CisgICAgICAgICAgICAg ICAgICAgIAorICAgICAgICAgICAgICAgICAgICAvLyBDbGljayBlbHNld2hlcmUgdG8gbW92ZSB0 aGUgZm9jdXMsIGFuZCB0aGVuIG1vdmUgdGhlIGZvY3VzIGJhY2sKKyAgICAgICAgICAgICAgICAg ICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oMTAsIDEwKTsKKyAgICAgICAgICAgICAgICAgICAg ZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVy Lm1vdXNlVXAoKTsKKyAgICAgICAgICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgICAgIC8v IE5ld2xpbmUgY2hhcmFjdGVyCisgICAgICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLmtleURv d24oU3RyaW5nLmZyb21DaGFyQ29kZSgweDAwMGEpKTsKKyAgICAgICAgICAgICAgICAgICAgCisg ICAgICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oJ1AnKTsKKyAgICAgICAgICAg ICAgICAgICAgZXZlbnRTZW5kZXIua2V5RG93bignQScpOworICAgICAgICAgICAgICAgICAgICBl dmVudFNlbmRlci5rZXlEb3duKCdTJyk7CisgICAgICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVy LmtleURvd24oJ1MnKTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoJ3JlcycpLmlubmVySFRNTCA9IGlmcm0uY29udGVudERvY3VtZW50 LmJvZHkuaW5uZXJIVE1MOworICAgICAgICAgICAgfQorICAgICAgICA8L3NjcmlwdD4KKyAgICA8 L2hlYWQ+CisgICAgPGJvZHkgb25sb2FkPSJpbml0KCkiPgorICAgICAgICA8ZGl2IGlkPSJkdiIg b25jbGljaz0ibW92ZUZvY3VzKCkiPlRoaXMgdGVzdHMgdGhhdCBmb2N1c2luZyBhbiBlZGl0YWJs ZSBpZnJhbWUncyB3aW5kb3cgd29ya3MgY29ycmVjdGx5IGFuZCBhbGxvd3MgdGV4dCBhbmQgbmV3 bGluZXMgdG8gYmUgZW50ZXJlZC48ZGl2PgorICAgICAgICA8aWZyYW1lIGlkPSJydGUiIHN0eWxl PSJib3JkZXI6IDFweCBzb2xpZCBibGFjayI+PC9pZnJhbWU+CisgICAgICAgIDxkaXYgaWQ9InJl cyI+PC9kaXY+CisgICAgPC9ib2R5PgogPC9odG1sPgorCg==