129013 2014-02-18 17:31:01 -0800 Don't call to willBeDeletedFrom(Document&) when destructing document 2014-02-19 09:59:53 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned benjamin cmarcelo commit-queue enrica esprehn+autocc kangil.han oldest_to_newest 982183 0 koivisto 2014-02-18 17:31:01 -0800 it is unsafe 982185 1 224572 koivisto 2014-02-18 17:34:09 -0800 Created attachment 224572 patch 982391 2 koivisto 2014-02-19 09:59:53 -0800 Landed a simpler branch version of this in https://trac.webkit.org/r164369 224572 2014-02-18 17:34:09 -0800 2014-02-18 17:39:06 -0800 patch will-be-deleted.patch text/plain 4605 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDMzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE0LTAyLTE4ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBjYWxsIHRvIHdpbGxC ZURlbGV0ZWRGcm9tKERvY3VtZW50Jikgd2hlbiBkZXN0cnVjdGluZyBkb2N1bWVudAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MDEzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSB0aGUgY2FsbCBm cm9tIENvbnRhaW5lck5vZGUgdG8gcmVsZXZhbnQgc3ViY2xhc3MgZGVzdHJ1Y3RvcnMuCisKKyAg ICAgICAgKiBkb20vQXR0ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdHRyOjp+QXR0cik6Cisg ICAgICAgICogZG9tL0NvbnRhaW5lck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGFp bmVyTm9kZTo6fkNvbnRhaW5lck5vZGUpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudEZyYWdtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50RnJhZ21lbnQ6On5Eb2N1bWVudEZyYWdt ZW50KToKKyAgICAgICAgKiBkb20vRG9jdW1lbnRGcmFnbWVudC5oOgorICAgICAgICAqIGRvbS9F bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6On5FbGVtZW50KToKKyAgICAg ICAgKiBkb20vRW50aXR5UmVmZXJlbmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVudGl0eVJl ZmVyZW5jZTo6fkVudGl0eVJlZmVyZW5jZSk6CisgICAgICAgICogZG9tL0VudGl0eVJlZmVyZW5j ZS5oOgorCiAyMDE0LTAyLTE4ICBKYW1lcyBDcmFpZyAgPGpjcmFpZ0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogQVg6IG1vcmUgcHJvcGVydGllczogZXhpc3RzLCByZXF1aXJl ZCwgYW5kIGludmFsaWQgKGV4aXN0cyB3YXMgcHJldmlvdXNseSBjb21iaW5lZCB3aXRoIGlnbm9y ZWQpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vQXR0ci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvZG9tL0F0dHIuY3BwCShyZXZpc2lvbiAxNjQyNTEpCisrKyBTb3VyY2UvV2Vi Q29yZS9kb20vQXR0ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY5LDYgKzY5LDcgQEAgUGFzc1Jl ZlB0cjxBdHRyPiBBdHRyOjpjcmVhdGUoRG9jdW1lbnQmIAogCiBBdHRyOjp+QXR0cigpCiB7Cisg ICAgd2lsbEJlRGVsZXRlZEZyb20oZG9jdW1lbnQoKSk7CiB9CiAKIHZvaWQgQXR0cjo6Y3JlYXRl VGV4dENoaWxkKCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAJKHJldmlz aW9uIDE2NDI1MSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTUwLDcgKzE1MCw2IEBAIHZvaWQgQ29udGFpbmVyTm9kZTo6dGFrZUFs bENoaWxkcmVuRnJvbSgKIAogQ29udGFpbmVyTm9kZTo6fkNvbnRhaW5lck5vZGUoKQogewotICAg IHdpbGxCZURlbGV0ZWRGcm9tKGRvY3VtZW50KCkpOwogICAgIHJlbW92ZURldGFjaGVkQ2hpbGRy ZW4oKTsKIH0KIApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50RnJhZ21lbnQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudEZyYWdtZW50LmNwcAko cmV2aXNpb24gMTY0MjUxKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50RnJhZ21lbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiwxMSBAQCBEb2N1bWVudEZyYWdtZW50OjpE b2N1bWVudEZyYWdtZW50KERvY3VtCiB7CiB9CiAKK0RvY3VtZW50RnJhZ21lbnQ6On5Eb2N1bWVu dEZyYWdtZW50KCkKK3sKKyAgICB3aWxsQmVEZWxldGVkRnJvbShkb2N1bWVudCgpKTsKK30KKwog UGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBEb2N1bWVudEZyYWdtZW50OjpjcmVhdGUoRG9j dW1lbnQmIGRvY3VtZW50KQogewogICAgIHJldHVybiBhZG9wdFJlZihuZXcgRG9jdW1lbnRGcmFn bWVudChkb2N1bWVudCwgTm9kZTo6Q3JlYXRlRG9jdW1lbnRGcmFnbWVudCkpOwpJbmRleDogU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50RnJhZ21lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnRGcmFnbWVudC5oCShyZXZpc2lvbiAxNjQyNTEpCisrKyBTb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnRGcmFnbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2 ICszNiw4IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50 PiBjcmVhdGUoRG9jdW1lbnQmKTsKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdt ZW50PiBjcmVhdGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYpOwogCisgICAgdmlydHVhbCB+RG9j dW1lbnRGcmFnbWVudCgpOworCiAgICAgdm9pZCBwYXJzZUhUTUwoY29uc3QgU3RyaW5nJiwgRWxl bWVudCogY29udGV4dEVsZW1lbnQsIFBhcnNlckNvbnRlbnRQb2xpY3kgPSBBbGxvd1NjcmlwdGlu Z0NvbnRlbnQpOwogICAgIGJvb2wgcGFyc2VYTUwoY29uc3QgU3RyaW5nJiwgRWxlbWVudCogY29u dGV4dEVsZW1lbnQsIFBhcnNlckNvbnRlbnRQb2xpY3kgPSBBbGxvd1NjcmlwdGluZ0NvbnRlbnQp OwogICAgIApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gMTY0MjUxKQorKysg U291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjYsNiAr MTY2LDggQEAgRWxlbWVudDo6fkVsZW1lbnQoKQogICAgICAgICBkb2N1bWVudCgpLmFjY2Vzc1NW R0V4dGVuc2lvbnMoKS0+cmVtb3ZlRWxlbWVudEZyb21QZW5kaW5nUmVzb3VyY2VzKHRoaXMpOwog ICAgICAgICBBU1NFUlQoIWhhc1BlbmRpbmdSZXNvdXJjZXMoKSk7CiAgICAgfQorCisgICAgd2ls bEJlRGVsZXRlZEZyb20oZG9jdW1lbnQoKSk7CiB9CiAKIGlubGluZSBFbGVtZW50UmFyZURhdGEq IEVsZW1lbnQ6OmVsZW1lbnRSYXJlRGF0YSgpIGNvbnN0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9k b20vRW50aXR5UmVmZXJlbmNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20v RW50aXR5UmVmZXJlbmNlLmNwcAkocmV2aXNpb24gMTY0MjUxKQorKysgU291cmNlL1dlYkNvcmUv ZG9tL0VudGl0eVJlZmVyZW5jZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMxLDExIEBA IGlubGluZSBFbnRpdHlSZWZlcmVuY2U6OkVudGl0eVJlZmVyZW5jZSgKIHsKIH0KIAorRW50aXR5 UmVmZXJlbmNlOjp+RW50aXR5UmVmZXJlbmNlKCkKK3sKKyAgICB3aWxsQmVEZWxldGVkRnJvbShk b2N1bWVudCgpKTsKK30KKwogUGFzc1JlZlB0cjxFbnRpdHlSZWZlcmVuY2U+IEVudGl0eVJlZmVy ZW5jZTo6Y3JlYXRlKERvY3VtZW50JiBkb2N1bWVudCwgY29uc3QgU3RyaW5nJiBlbnRpdHlOYW1l KQogewogICAgIHJldHVybiBhZG9wdFJlZihuZXcgRW50aXR5UmVmZXJlbmNlKGRvY3VtZW50LCBl bnRpdHlOYW1lKSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRW50aXR5UmVmZXJlbmNlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0VudGl0eVJlZmVyZW5jZS5oCShyZXZp c2lvbiAxNjQyNTEpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRW50aXR5UmVmZXJlbmNlLmgJKHdv cmtpbmcgY29weSkKQEAgLTMwLDYgKzMwLDggQEAgY2xhc3MgRW50aXR5UmVmZXJlbmNlIGZpbmFs IDogcHVibGljIENvbgogcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPEVudGl0eVJlZmVy ZW5jZT4gY3JlYXRlKERvY3VtZW50JiwgY29uc3QgU3RyaW5nJiBlbnRpdHlOYW1lKTsKIAorICAg IHZpcnR1YWwgfkVudGl0eVJlZmVyZW5jZSgpOworCiBwcml2YXRlOgogICAgIEVudGl0eVJlZmVy ZW5jZShEb2N1bWVudCYsIGNvbnN0IFN0cmluZyYgZW50aXR5TmFtZSk7CiAK