129009 2014-02-18 16:20:10 -0800 Add more new SPI methods 2014-02-18 16:30:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 982155 0 andersca 2014-02-18 16:20:10 -0800 Add more new SPI methods 982156 1 224563 andersca 2014-02-18 16:21:46 -0800 Created attachment 224563 Patch 982157 2 224564 andersca 2014-02-18 16:22:25 -0800 Created attachment 224564 Patch 982158 3 commit-queue 2014-02-18 16:25:12 -0800 Attachment 224564 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:57: Missing spaces around = [whitespace/operators] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 982159 4 224564 thorton 2014-02-18 16:25:22 -0800 Comment on attachment 224564 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224564&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:510 > + return !applicationName ? nil : (NSString *)applicationName; why not flip this? it reads better that way, imo. also, do you actually need this explicit cast? 982160 5 andersca 2014-02-18 16:30:56 -0800 Committed r164330: <http://trac.webkit.org/changeset/164330> 224563 2014-02-18 16:21:46 -0800 2014-02-18 16:22:23 -0800 Patch bug-129009-20140218162145.patch text/plain 3359 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjg4OGIwNzljMmEwZjNk YWVjZjJhZTVmN2FhOTkwYzE0YWZhNTJhYy4uZGZkZTc0YjVkNGE3NGI4ZmE0YjUyMjc1NTgyODcx YjI3MGI4MjQxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTAyLTE4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIG1vcmUgbmV3 IFNQSSBtZXRob2RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjkwMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dl YlZpZXcgX2NlcnRpZmljYXRlQ2hhaW5dKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9jb21taXR0 ZWRVUkxdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9hcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdl bnRdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9zZXRBcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdl bnQ6XSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmg6 CisKKzIwMTQtMDItMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwog ICAgICAgICBNYWtlIHJlbG9hZCBTUEkgZm9yIG5vdwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MDA3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggNzk2ZWFhYjU0MWMzYWZjZjA1YjJj NWVmNmQyY2NmNTkwNDMzYTAyZS4uNDZmYTI5ZmE3NDBiOGEzY2IwZmUzZmI2ZTAyYjk4N2UwNjU2 ZDI3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dl YlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZp ZXcubW0KQEAgLTQyLDYgKzQyLDcgQEAKICNpbXBvcnQgIldLUHJvY2Vzc0NsYXNzSW50ZXJuYWwu aCIKICNpbXBvcnQgIldLUmVtb3RlT2JqZWN0UmVnaXN0cnlJbnRlcm5hbC5oIgogI2ltcG9ydCAi V0tXZWJWaWV3Q29uZmlndXJhdGlvblByaXZhdGUuaCIKKyNpbXBvcnQgIldlYkNlcnRpZmljYXRl SW5mby5oIgogI2ltcG9ydCAiV2ViQ29udGV4dC5oIgogI2ltcG9ydCAiV2ViQmFja0ZvcndhcmRM aXN0LmgiCiAjaW1wb3J0ICJXZWJQYWdlUHJveHkuaCIKQEAgLTQ1MSw3ICs0NTIsNyBAQAogCiAg ICAgcmV0dXJuIF9yZW1vdGVPYmplY3RSZWdpc3RyeS5nZXQoKTsKIH0KLQorICAgIAogLSAoV0tC cm93c2luZ0NvbnRleHRIYW5kbGUgKilfaGFuZGxlCiB7CiAgICAgcmV0dXJuIFtbW1dLQnJvd3Np bmdDb250ZXh0SGFuZGxlIGFsbG9jXSBfaW5pdFdpdGhQYWdlSUQ6X3BhZ2UtPnBhZ2VJRCgpXSBh dXRvcmVsZWFzZV07CkBAIC00OTAsNiArNDkxLDMwIEBACiAgICAgcmV0dXJuIG5pbDsKIH0KIAor LSAoTlNBcnJheSAqKV9jZXJ0aWZpY2F0ZUNoYWluCit7CisgICAgaWYgKFdlYktpdDo6V2ViRnJh bWVQcm94eSogbWFpbkZyYW1lID0gX3BhZ2UtPm1haW5GcmFtZSgpKQorICAgICAgICByZXR1cm4g bWFpbkZyYW1lLT5jZXJ0aWZpY2F0ZUluZm8oKSA/IChOU0FycmF5ICopbWFpbkZyYW1lLT5jZXJ0 aWZpY2F0ZUluZm8oKS0+Y2VydGlmaWNhdGVJbmZvKCkuY2VydGlmaWNhdGVDaGFpbigpIDogbmls OworCisgICAgcmV0dXJuIG5pbDsKK30KKworLSAoTlNVUkwgKilfY29tbWl0dGVkVVJMCit7Cisg ICAgcmV0dXJuIFtOU1VSTCBfd2ViX1VSTFdpdGhXVEZTdHJpbmc6X3BhZ2UtPnBhZ2VMb2FkU3Rh dGUoKS51cmwoKV07Cit9CisKKy0gKE5TU3RyaW5nICopX2FwcGxpY2F0aW9uTmFtZUZvclVzZXJB Z2VudAoreworICAgIGNvbnN0IFN0cmluZyYgYXBwbGljYXRpb25OYW1lID0gX3BhZ2UtPmFwcGxp Y2F0aW9uTmFtZUZvclVzZXJBZ2VudCgpOworICAgIHJldHVybiAhYXBwbGljYXRpb25OYW1lID8g bmlsIDogKE5TU3RyaW5nICopYXBwbGljYXRpb25OYW1lOworfQorCistICh2b2lkKV9zZXRBcHBs aWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQ6KE5TU3RyaW5nICopYXBwbGljYXRpb25OYW1lRm9yVXNl ckFnZW50Cit7CisgICAgX3BhZ2UtPnNldEFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudChhcHBs aWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQpOworfQorCiBzdGF0aWMgaW5saW5lIFdlYkNvcmU6Okxh eW91dE1pbGVzdG9uZXMgbGF5b3V0TWlsZXN0b25lcyhfV0tSZW5kZXJpbmdQcm9ncmVzc0V2ZW50 cyBldmVudHMpCiB7CiAgICAgV2ViQ29yZTo6TGF5b3V0TWlsZXN0b25lcyBtaWxlc3RvbmVzID0g MDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3UHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZp ZXdQcml2YXRlLmgKaW5kZXggODExMzZhNDIyMTcwMjNiNTM0YjhhOTFmZWIxZmI3NDFhMDg4Yjc2 NC4uOGNlMzZmMGRhNmEzNTEzNDJjOWM5ZDU1MjYzN2FjZThlNDI1NGNmZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgK QEAgLTUxLDYgKzUxLDExIEBAIHR5cGVkZWYgTlNfT1BUSU9OUyhOU1VJbnRlZ2VyLCBfV0tSZW5k ZXJpbmdQcm9ncmVzc0V2ZW50cykgewogCiAtIChXS05hdmlnYXRpb24gKilfcmVsb2FkOwogCitA cHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIE5TQXJyYXkgKl9jZXJ0aWZpY2F0ZUNoYWlu OworQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBOU1VSTCAqX2NvbW1pdHRlZFVSTDsK KworQHByb3BlcnR5IChjb3B5LCBzZXR0ZXI9X3NldEFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2Vu dDopIE5TU3RyaW5nICpfYXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50OworCiAjaWYgVEFSR0VU X09TX0lQSE9ORQogQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0TWluaW11bUxheW91 dFNpemVPdmVycmlkZTopIENHU2l6ZSBfbWluaW11bUxheW91dFNpemVPdmVycmlkZTsKIAo= 224564 2014-02-18 16:22:25 -0800 2014-02-18 16:25:22 -0800 Patch bug-129009-20140218162224.patch text/plain 3151 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjg4OGIwNzljMmEwZjNk YWVjZjJhZTVmN2FhOTkwYzE0YWZhNTJhYy4uZGZkZTc0YjVkNGE3NGI4ZmE0YjUyMjc1NTgyODcx YjI3MGI4MjQxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTAyLTE4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIG1vcmUgbmV3 IFNQSSBtZXRob2RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjkwMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dl YlZpZXcgX2NlcnRpZmljYXRlQ2hhaW5dKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9jb21taXR0 ZWRVUkxdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9hcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdl bnRdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9zZXRBcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdl bnQ6XSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmg6 CisKKzIwMTQtMDItMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwog ICAgICAgICBNYWtlIHJlbG9hZCBTUEkgZm9yIG5vdwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5MDA3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggNzk2ZWFhYjU0MWMzYWZjZjA1YjJj NWVmNmQyY2NmNTkwNDMzYTAyZS4uMzc1OWQ1ZjJhYjI4YjNmZDg5ZWZkZTgxMDY4M2RkNmU4OTYz NTM5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dl YlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZp ZXcubW0KQEAgLTQyLDYgKzQyLDcgQEAKICNpbXBvcnQgIldLUHJvY2Vzc0NsYXNzSW50ZXJuYWwu aCIKICNpbXBvcnQgIldLUmVtb3RlT2JqZWN0UmVnaXN0cnlJbnRlcm5hbC5oIgogI2ltcG9ydCAi V0tXZWJWaWV3Q29uZmlndXJhdGlvblByaXZhdGUuaCIKKyNpbXBvcnQgIldlYkNlcnRpZmljYXRl SW5mby5oIgogI2ltcG9ydCAiV2ViQ29udGV4dC5oIgogI2ltcG9ydCAiV2ViQmFja0ZvcndhcmRM aXN0LmgiCiAjaW1wb3J0ICJXZWJQYWdlUHJveHkuaCIKQEAgLTQ5MCw2ICs0OTEsMzAgQEAKICAg ICByZXR1cm4gbmlsOwogfQogCistIChOU0FycmF5ICopX2NlcnRpZmljYXRlQ2hhaW4KK3sKKyAg ICBpZiAoV2ViS2l0OjpXZWJGcmFtZVByb3h5KiBtYWluRnJhbWUgPSBfcGFnZS0+bWFpbkZyYW1l KCkpCisgICAgICAgIHJldHVybiBtYWluRnJhbWUtPmNlcnRpZmljYXRlSW5mbygpID8gKE5TQXJy YXkgKiltYWluRnJhbWUtPmNlcnRpZmljYXRlSW5mbygpLT5jZXJ0aWZpY2F0ZUluZm8oKS5jZXJ0 aWZpY2F0ZUNoYWluKCkgOiBuaWw7CisKKyAgICByZXR1cm4gbmlsOworfQorCistIChOU1VSTCAq KV9jb21taXR0ZWRVUkwKK3sKKyAgICByZXR1cm4gW05TVVJMIF93ZWJfVVJMV2l0aFdURlN0cmlu ZzpfcGFnZS0+cGFnZUxvYWRTdGF0ZSgpLnVybCgpXTsKK30KKworLSAoTlNTdHJpbmcgKilfYXBw bGljYXRpb25OYW1lRm9yVXNlckFnZW50Cit7CisgICAgY29uc3QgU3RyaW5nJiBhcHBsaWNhdGlv bk5hbWUgPSBfcGFnZS0+YXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50KCk7CisgICAgcmV0dXJu ICFhcHBsaWNhdGlvbk5hbWUgPyBuaWwgOiAoTlNTdHJpbmcgKilhcHBsaWNhdGlvbk5hbWU7Cit9 CisKKy0gKHZvaWQpX3NldEFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudDooTlNTdHJpbmcgKilh cHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQKK3sKKyAgICBfcGFnZS0+c2V0QXBwbGljYXRpb25O YW1lRm9yVXNlckFnZW50KGFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudCk7Cit9CisKIHN0YXRp YyBpbmxpbmUgV2ViQ29yZTo6TGF5b3V0TWlsZXN0b25lcyBsYXlvdXRNaWxlc3RvbmVzKF9XS1Jl bmRlcmluZ1Byb2dyZXNzRXZlbnRzIGV2ZW50cykKIHsKICAgICBXZWJDb3JlOjpMYXlvdXRNaWxl c3RvbmVzIG1pbGVzdG9uZXMgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaAppbmRleCA4MTEzNmE0MjIxNzAyM2I1MzRi OGE5MWZlYjFmYjc0MWEwODhiNzY0Li44Y2UzNmYwZGE2YTM1MTM0MmM5YzlkNTUyNjM3YWNlOGU0 MjU0Y2ZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlld1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlld1ByaXZhdGUuaApAQCAtNTEsNiArNTEsMTEgQEAgdHlwZWRlZiBOU19PUFRJT05T KE5TVUludGVnZXIsIF9XS1JlbmRlcmluZ1Byb2dyZXNzRXZlbnRzKSB7CiAKIC0gKFdLTmF2aWdh dGlvbiAqKV9yZWxvYWQ7CiAKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgTlNBcnJh eSAqX2NlcnRpZmljYXRlQ2hhaW47CitAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIE5T VVJMICpfY29tbWl0dGVkVVJMOworCitAcHJvcGVydHkgKGNvcHksIHNldHRlcj1fc2V0QXBwbGlj YXRpb25OYW1lRm9yVXNlckFnZW50OikgTlNTdHJpbmcgKl9hcHBsaWNhdGlvbk5hbWVGb3JVc2Vy QWdlbnQ7CisKICNpZiBUQVJHRVRfT1NfSVBIT05FCiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0 dGVyPV9zZXRNaW5pbXVtTGF5b3V0U2l6ZU92ZXJyaWRlOikgQ0dTaXplIF9taW5pbXVtTGF5b3V0 U2l6ZU92ZXJyaWRlOwogCg==